| Age | Commit message (Collapse) | Author |
|
`controlsLayout` should not be a direct child of the widget, since it
already has `m_topLayout` as layout.
This fixes the following warning:
QLayout: Attempting to add QLayout "" to PhononWidget "", which already has a layout
|
|
|
|
Reviewers: markg, elvisangelaccio
Reviewed By: markg, elvisangelaccio
Subscribers: chehrlic, rkflx, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10995
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
Reviewers: #dolphin, markg
Reviewed By: markg
Subscribers: elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10995
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
Also use override instead of Q_DECL_OVERRIDE
|
|
Test Plan: compile
Reviewers: #dolphin, broulik
Reviewed By: broulik
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D8637
|
|
|
|
REVIEW: 126771
|
|
KWindowConfig::save/restoreWindowSize with the help of the porting scripts.
REVIEW: 122305
|
|
Conflicts:
dolphin/src/main.cpp
kdepasswd/kcm/kcm_useraccount.desktop
konqueror/settings/ebrowsing/ebrowsing.desktop
konqueror/settings/kio/cache.desktop
konqueror/settings/kio/cookies.desktop
konqueror/settings/kio/netpref.desktop
konqueror/settings/kio/proxy.desktop
konqueror/settings/kio/smb.desktop
konqueror/settings/kio/uasproviders/firefox30oncurrent.desktop
konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop
konqueror/settings/kio/useragent.desktop
lib/konq/konq_operations.cpp
|
|
BUG: 339882
FIXED-IN: 4.14.3
REVIEW: 120776
|
|
Conflicts:
dolphin/src/panels/terminal/terminalpanel.cpp
dolphin/src/panels/terminal/terminalpanel.h
|
|
Patch from ROSA Linux.
BUG: 337107
BUG: 337033
BUG: 334924
CCBUG: 339882
REVIEW: 120745
FIXED-IN: 4.14.3
|
|
REVIEW: 120688
|
|
|
|
REVIEW: 120159
|
|
TerminalPanel connections to konsole part were not converted since there
is no header available that defines these function, we have to keep the
old syntax here.
Additionally the new syntax no longer accepts QPointer arguments, we have
to explicitly call .data() there.
|
|
This does not work properly yet, there are probably quite a few bad signal/
slot connections due to KUrl -> QUrl. However dolphin starts without
crashing.
Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
and I have no idea how it is supposed to be used.
This is the first commit for review 117395
|
|
Thanks to Kai Uwe Broulok and Jekyll Wu for the investigation!
BUG: 309498
FIXED-IN: 4.9.4
|
|
|
|
Show a video widget depending on the video content instead of the mimetype
string: There are container formats which can be either audios or videos.
Besides, the rmvb video files have a mimetype of
"application/vnd.rn-realmedia", and these files can be recognized as videos
correctly now.
The patch has been provided by Hui Ni.
REVIEW: 104988
FIXED-IN: 4.9
|
|
|
|
Most developers seem to prefer
if (ptr) ...
if (!ptr) ...
in comparison to
if (ptr != 0) ...
if (ptr == 0) ...
Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
|
|
|
|
BUG: 196243
svn path=/trunk/KDE/kdebase/apps/; revision=998153
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=969877
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=969874
|
|
information panel
svn path=/trunk/KDE/kdebase/apps/; revision=958762
|
|
pressed.
- Assure that the video player has the same size as the preview widget. Convincing the embedded video player to dynamically resize during playing a video seems to be impossible - I need to check the Phonon::VideoPlayer source code to get the root cause for the currently strange behavior :-(
svn path=/trunk/KDE/kdebase/apps/; revision=958332
|
|
- provide a custom member for the audio media object
svn path=/trunk/KDE/kdebase/apps/; revision=952886
|
|
Phonon is quite cool BTW :-)
svn path=/trunk/KDE/kdebase/apps/; revision=952882
|
|
been pressed. This solves the issue that Dolphin might get blocked during hovering media files. Dolphin still gets blocked when requesting a media object the first time, but for the user this "just" means that after pressing the play-button the first time, that the playing starts a little bit later.
CCMAIL: [email protected]
CCMAIL: [email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=919063
|
|
previewing (similar to the file dialog) to Dolphin's metadata panel. Since Phonon is currently in-process only with the memory/ stability issues that come with this, this might have to be disabled by default - we'll see how it goes. Thanks, Matthias!
CCMAIL:[email protected]
CCMAIL:[email protected]
svn path=/trunk/KDE/kdebase/apps/; revision=917389
|