| Age | Commit message (Collapse) | Author |
|---|
|
Summary:
This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself.
The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior.
BUG: 307747
Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen.
{F3787651}
Test Plan:
1. Drag a folder.
2. Drop it onto itself.
Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure
Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure
Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D6281
|
|
When unmounting a removable media Dolphin checks if there are
some files open on the device before performing the unmount.
If the terminal window in dolphin is open and the to be unmounted path is open,
the unmount process will be blocked.
This patch sets the terminal window current path to the home directory upon unmount request
if the terminal directory is set to the mount path.
The unmount request could came from two sources:
The user could hit right click on the media in the dolphin's places panel and hit unmount.
The user could request an unmount from the indicator applet
This patch was originally written by Arjun AK for the kdelibs4 version
of Dolphin: https://git.reviewboard.kde.org/r/121613/
BUG: 158264
FIXED-IN: 17.11.80
Differential Revision: https://phabricator.kde.org/D7847
|
|
If the QMimeData object created by PlacesItemModel doesn't have any url
set (e.g. when dragging unmounted devices), it is detected by the
resulting DropJob as "drop raw data" because the mimeData has one format set
(the internalMimeType() used for dragging between places items).
This results in a crash because the DropJob schedules a PasteJob, but in
the meantime the QDrag from Dolphin ends and deletes the mimeData object
that was passed to the paste job.
The fix is to prevent the DropJob in the first place. We can introduce a
new internal mimetype that we use to blacklist drops-onto-items (while
still allowing drops-between-items). This way PlacesItemModel can set
the blacklist flag if the mimeData is being created without urls.
BUG: 373005
FIXED-IN: 17.04.3
Test Plan:
Drag and drop an unmounted device to another place item or the DolphinView, doesn't crash anymore.
Dropping the unmounted device between two places item still works.
Differential Revision: https://phabricator.kde.org/D5535
|
|
KUser does quite a lot of stuff under the hood and also calls getpwuid which might block with network login.
Differential Revision: https://phabricator.kde.org/D5049
|
|
Differential Revision: https://phabricator.kde.org/D4498
|
|
This is merge of #128964 and #128942. This will impelement changing the "Date" field to "Modified" and allow a new "Accessed" time field to be available. This also includes changes to update configuration files.
REVIEW: 129077
|
|
This fixes some URLs built from local paths without scheme.
|
|
REVIEW: 126771
|
|
addType("File") will create a invalid query for baloo. Currently seems
there is no replacement for it, so just remove it.
REVIEW: 126109
FIXED-IN: 15.12
BUG: 348902
|
|
because we don't use KBoomark's D-Bus signaling anymore.
REVIEW: 124497
|
|
* folder-txt => folder-text
* folder-video => folder-videos
* folder-image => folder-images
Thanks to andreas_k and Christian Butcher!
BUG: 347257
FIXED-IN: 15.08.0
|
|
REVIEW: 123526
CCBUG: 345174
FIXED-IN: 15.08.0
|
|
present, because KFileMetaDataWidget is in KDELibs4Support)
Reviewed-By: Vishesh Handa
|
|
|
|
|
|
|
|
commit 2a79feaea0088730bbf4fd4b65baa1c4a91b84b9)
|
|
|
|
Adoption of http://commits.kde.org/kdelibs/2b5c6e42fc8114c6854ce490b9cdd4356be683d9
FIXED-IN: 14.12.3
BUG: 343620
BUG: 310080
REVIEW: 122640
|
|
|
|
|
|
fixes being unable to access eg. removable drives
|
|
fixes the determination of the closest item for me.
|
|
REVIEW: 120688
|
|
|
|
|
|
removed unused mirroredDirectory method
REVIEW: 120194
|
|
|
|
|
|
|
|
REVIEW: 120286
BUG: 339204
FIXED-IN: 4.14.2
|
|
REVIEW: 120159
|
|
|
|
In dolphin the Section that leads you to timeline claims
to show "Recently Accessed", which is not true, it shows
"Recently Saved" instead.
BUG: 304854
REVIEW: 119986
|
|
Use a Qt::uniqueConnection so that only one connection exists between the sender and receiver.
REVIEW: 119532
|
|
|
|
|
|
baloo/baloo-widgets path fixes.
|
|
Since the master branch had never been merged into frameworks since the
creation of the frameworks branch, I had to fix a couple of merge
conflicts and make another change in order to make it build - I hope I
did not get anything wrong.
We should probably merge master into frameworks on a regular basis from
now on.
CCMAIL:[email protected]
Conflicts:
dolphin/src/dolphinmainwindow.cpp
dolphin/src/search/dolphinfacetswidget.cpp
dolphin/src/statusbar/dolphinstatusbar.cpp
dolphin/src/views/dolphinview.cpp
|
|
TerminalPanel connections to konsole part were not converted since there
is no header available that defines these function, we have to keep the
old syntax here.
Additionally the new syntax no longer accepts QPointer arguments, we have
to explicitly call .data() there.
|
|
This does not work properly yet, there are probably quite a few bad signal/
slot connections due to KUrl -> QUrl. However dolphin starts without
crashing.
Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
and I have no idea how it is supposed to be used.
This is the first commit for review 117395
|
|
|
|
Nepomuk is being replaced with Baloo
|
|
Since Dolphin 2.0, we have stored the selected items in a QSet<int>,
which is neither space-efficient nor particularly fast when inserting
many items which are in a consecutive range.
This commit replaces the QSet<int> by a new class "KItemSet", which
stores the items in a sorted list of ranges. For each range, we only
store the first index and the length of the range, so we need a lot
less memory for most common selection patterns, and we also save quite
a few CPU cycles in many situations, because adding an item to the
KItemSet will in many cases not need a memory allocation at all, and
it's particularly easy when inserting sorted items into the KItemSet in
a row.
KItemSet contains a minimal subset of QSet's API which makes it
suitable as a drop-in replacement for our needs. It also has iterators,
such that the items can be iterated through easily, also with foreach.
One advantage of KItemSet compared to QSet<int> is that the items are
always iterated through in ascending order.
REVIEW: 113488
|
|
It makes no sense to pin files. Plus the old
PlacesModel from kdelibs had the same behaviour.
REVIEW: 110347
|
|
|
|
Reload the places panel when Nepomuk starts up and shutsdown. This way
the user does not need to restart Dolphin to see the custom searches and
places after Nepomuk switches on.
BUG: 304918
REVIEW: 110323
|
|
Fixes the problem that the "Recently accessed" entries in the Places
Panel might not be shown when using the default setup.
BUG: 310770
FIXED-IN: 4.10 Beta 2
REVIEW: 107464
|
|
|
|
Basically adds a conditional that in case that mtp kioslave is installed
devices with MTP are added to the predicated.
REVIEW: 106651
|
