| Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
TerminalPanel connections to konsole part were not converted since there
is no header available that defines these function, we have to keep the
old syntax here.
Additionally the new syntax no longer accepts QPointer arguments, we have
to explicitly call .data() there.
|
|
This does not work properly yet, there are probably quite a few bad signal/
slot connections due to KUrl -> QUrl. However dolphin starts without
crashing.
Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
and I have no idea how it is supposed to be used.
This is the first commit for review 117395
|
|
BUG: 302037
FIXED-IN: 4.10.3
REVIEW: 110233
|
|
The protection against unwanted execution of "rm -rf" when changing the
directory while entering the command did not work if there was never any
automatic "cd" command sent to the terminal before.
This patch ensures that Terminal Panel's member m_clearTerminal is
false after the initialization of the panel, such that the protection is
effective after that.
BUG: 316300
FIXED-IN: 4.10.2
REVIEW: 109431
|
|
The root cause of the problem was that TerminalPanel's member
m_konsolePartCurrentDirectory, which is used to determine in
TerminalPanel::sendCdToTerminal(QString& dir) if the Konsole part's
directory is aleady 'dir', such that issuing the 'cd' command is not
needed, was updated too late, namely when the part's
currentDirectoryChanged(QString) signal was received, which may be up
to one second after the 'cd' command.
When changing the directory from "dir1" to "dir2" and going back to
the "dir1" in less than one second (either by using the 'Back' action
or by activating a tab which still had "dir1" open), the 'cd dir1'
command was therefore suppressed because the Terminal Panel still
thought that "dir1" was the current directory in the part. However,
the directory of the part was actually "dir2", and when the
currentDirectoryChanged(QString) signal was received from the part, the
view's URL was set to "dir2" as well.
BUG: 306349
BUG: 304838
FIXED-IN: 4.9.2
|
|
|
|
This prevents that these commands, which have not been enetered by the
user, but generated automatically, appear in the shell history, provided
that the shell is configured appropriately.
BUG: 204039
FIXED-IN: 4.9.0
|
|
|
|
See https://git.reviewboard.kde.org/r/105028/
|
|
Thanks to Jekyll Wu for helping to implement this feature!
FEATURE: 156732
FIXED-IN: 4.9.0
|
|
The attached patch sets the main window on the main directory
lister in DolphinView and KIO jobs in DolphinMainWindow to ensure
that login data for remote protocols such as sftp, ftp are cached
properly for the duration of the application. Otherwise, the end
user is going to end up being unnecessarily re-prompted to enter
password login information.
Thanks to Dawit Alemayehu for the patch!
REVIEW: 104614
FIXED-IN: 4.9.0
|
|
Thanks to Jekyll Wu for the analyses.
CCBUG: 286367
|
|
- fix crash when Ctrl-D-ing in the terminal
- don't respond to window manager actions, only when the dock itself is
hidden
Refers to commit 8d789f2626243ddc6c763c84e582e8e20afe7689
|
|
Previous state: When the terminal is hidden, the cwd is not updated
anymore. If it was on a removable device when hiding, the hidden
terminal might prevent unmounting this device.
This patch fixes that bug by changing the cwd to "/" when hiding the panel.
REVIEW: 101387
BUG: 158264
FIXED-IN: 4.7.0
|
|
When navigating in Dolphin it attempts to keep any open Terminal (F4)
in sync by changing the directory in the shell. It does this by
sending a "^C; cd $DIRECTORY" however shells under FreeBSD treat "^C"
as a literal string and not SIGINT. Fix this by sending SIGINT to the
shell instead of "^C".
It appears Linux does not exhibit this behaviour.
Patch originally written by David Naylor, from the KDE-FreeBSD team.
CCMAIL: [email protected]
(cherry picked from commit 5f78219e18073e475ed1f1865a1a2be1fafd60cf)
|
|
Most developers seem to prefer
if (ptr) ...
if (!ptr) ...
in comparison to
if (ptr != 0) ...
if (ptr == 0) ...
Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
|
|
|
|
|
|
|
|
This fixes the issue that the initial size of the Filter Panel is too small.
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1195243
|
|
they accept an URL or not.
svn path=/trunk/KDE/kdebase/apps/; revision=1183480
|
|
and g111 for the hint.
CCBUG: 161637
svn path=/trunk/KDE/kdebase/apps/; revision=1106403
|
|
a cd command.
The terminal interface does not provide an API for this, so as workaround backspaces are send. Not nice, but as the issue can lead to data loss, this solution is better than having nothing.
BUG: 161637
svn path=/trunk/KDE/kdebase/apps/; revision=1103207
|
|
the GUI for a long time
(e.g. when accessing the non-existing sftp://192.168.1.100/home)
and only run this job if the terminal panel is shown (or at the time when it is made visible).
Sorry kdebase users, you get to update kdelibs again.
BUG: 202176
svn path=/trunk/KDE/kdebase/apps/; revision=1030480
|
|
Dario Andres for the analyses!
BUG: 202953
svn path=/trunk/KDE/kdebase/apps/; revision=1011008
|
|
"file:" URL, but is nevertheless local (e.g., "desktop:").
This fix is also applied to the new "Open external Terminal" action
which will be in KDE 4.3.
BUG: 167810
svn path=/trunk/KDE/kdebase/apps/; revision=969265
|
|
Make Dolphin benefit from new TerminalInterfaceV2 functions.
svn path=/trunk/KDE/kdebase/apps/; revision=946382
|
|
check for KUrl::isLocalFile())
svn path=/trunk/KDE/kdebase/apps/; revision=939835
|
|
relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-)
svn path=/trunk/KDE/kdebase/apps/; revision=911089
|