| Age | Commit message (Collapse) | Author |
|---|
|
running a program
Summary:
Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
FEATURE: 304816
FIXED-IN: 19.04.0
Test Plan:
# Open terminal panel
# Run `watch ls`
# Close Dolphin
# Observe confirmation
# Disable confirmation
# Repeat, observe no confirmation
# Enable confirmation in the settings
# Repeat, observe a confirmation
Reviewers: #dolphin, markg, elvisangelaccio, rominf
Reviewed By: #dolphin, elvisangelaccio
Subscribers: kfm-devel, elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D10960
|
|
Summary:
Show a message if Konsole part is not installed
BUG: 371822
FIXED-IN: 18.04.0
{F5749731}
Reviewers: ngraham, progwolff, elvisangelaccio
Reviewed By: ngraham, progwolff, elvisangelaccio
Subscribers: rkflx, ngraham, elvisangelaccio, broulik, progwolff, #dolphin
Differential Revision: https://phabricator.kde.org/D11118
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
GIT_SILENT
|
|
Summary:
BUG: 298467
Set the focus to the active view, after leaving the terminal panel.
This is a fork of the patch at https://git.reviewboard.kde.org/r/116118/ by @emmanuelp which should fix the issue with the original patch reported by Frank Reininghaus.
Test Plan: Works for me.
Reviewers: #dolphin, emmanuelp, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: ngraham, emmanuelp
Differential Revision: https://phabricator.kde.org/D9955
|
|
Also use override instead of Q_DECL_OVERRIDE
|
|
Test Plan: compile
Reviewers: #dolphin, broulik
Reviewed By: broulik
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D8637
|
|
When unmounting a removable media Dolphin checks if there are
some files open on the device before performing the unmount.
If the terminal window in dolphin is open and the to be unmounted path is open,
the unmount process will be blocked.
This patch sets the terminal window current path to the home directory upon unmount request
if the terminal directory is set to the mount path.
The unmount request could came from two sources:
The user could hit right click on the media in the dolphin's places panel and hit unmount.
The user could request an unmount from the indicator applet
This patch was originally written by Arjun AK for the kdelibs4 version
of Dolphin: https://git.reviewboard.kde.org/r/121613/
BUG: 158264
FIXED-IN: 17.11.80
Differential Revision: https://phabricator.kde.org/D7847
|
|
|
|
Conflicts:
dolphin/src/panels/terminal/terminalpanel.cpp
dolphin/src/panels/terminal/terminalpanel.h
|
|
The previous solution could cause problems if the user navigates to a
different URL in one view, and then activates another split view very
quickly: the new active view might be switched to the same URL as the
first view, which is unwanted.
To fix this problem, we record a history of "cd" commands that Dolphin
sends to the Terminal Panel in a queue. If a currentDirectoryChanged
signal is received, and the new terminal directory is "dir", this patch
does the following:
1. If the queue is empty, change the view URL to "dir".
2. Otherwise, take the queue's head, and check if it is equal to
"dir". If that is the case, ignore the signal and return.
3. Go back to step 1.
This ensures that every currentDirectoryChange signal that is caused by
a "cd" that was sent from Dolphin to the terminal is ignored.
BUG: 339009
BUG: 314038
REVIEW: 120768
|
|
REVIEW: 120688
|
|
|
|
This does not work properly yet, there are probably quite a few bad signal/
slot connections due to KUrl -> QUrl. However dolphin starts without
crashing.
Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
and I have no idea how it is supposed to be used.
This is the first commit for review 117395
|
|
Thanks to Jekyll Wu for helping to implement this feature!
FEATURE: 156732
FIXED-IN: 4.9.0
|
|
- fix crash when Ctrl-D-ing in the terminal
- don't respond to window manager actions, only when the dock itself is
hidden
Refers to commit 8d789f2626243ddc6c763c84e582e8e20afe7689
|
|
Previous state: When the terminal is hidden, the cwd is not updated
anymore. If it was on a removable device when hiding, the hidden
terminal might prevent unmounting this device.
This patch fixes that bug by changing the cwd to "/" when hiding the panel.
REVIEW: 101387
BUG: 158264
FIXED-IN: 4.7.0
|
|
|
|
This fixes the issue that the initial size of the Filter Panel is too small.
|
|
they accept an URL or not.
svn path=/trunk/KDE/kdebase/apps/; revision=1183480
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1104133
|
|
a cd command.
The terminal interface does not provide an API for this, so as workaround backspaces are send. Not nice, but as the issue can lead to data loss, this solution is better than having nothing.
BUG: 161637
svn path=/trunk/KDE/kdebase/apps/; revision=1103207
|
|
the GUI for a long time
(e.g. when accessing the non-existing sftp://192.168.1.100/home)
and only run this job if the terminal panel is shown (or at the time when it is made visible).
Sorry kdebase users, you get to update kdelibs again.
BUG: 202176
svn path=/trunk/KDE/kdebase/apps/; revision=1030480
|
|
Make Dolphin benefit from new TerminalInterfaceV2 functions.
svn path=/trunk/KDE/kdebase/apps/; revision=946382
|
|
relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-)
svn path=/trunk/KDE/kdebase/apps/; revision=911089
|
