┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels/terminal
AgeCommit message (Collapse)Author
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2014-12-10Fix Terminal-View navigation sync issueArjun AK
The URL needs to be constructed from 'QUrl::fromLocalFile()' instead of a QString so that the scheme is set properly. REVIEW: 121409 BUG: 341678
2014-11-03Q_DECL_OVERRIDELukáš Tinkl
2014-10-24Merge remote-tracking branch 'origin/master' into frameworksFrank Reininghaus
Conflicts: dolphin/src/panels/terminal/terminalpanel.cpp dolphin/src/panels/terminal/terminalpanel.h
2014-10-24Make the view/Terminal Panel synchronization less error-proneFrank Reininghaus
The previous solution could cause problems if the user navigates to a different URL in one view, and then activates another split view very quickly: the new active view might be switched to the same URL as the first view, which is unwanted. To fix this problem, we record a history of "cd" commands that Dolphin sends to the Terminal Panel in a queue. If a currentDirectoryChanged signal is received, and the new terminal directory is "dir", this patch does the following: 1. If the queue is empty, change the view URL to "dir". 2. Otherwise, take the queue's head, and check if it is equal to "dir". If that is the case, ignore the signal and return. 3. Go back to step 1. This ensures that every currentDirectoryChange signal that is caused by a "cd" that was sent from Dolphin to the terminal is ignored. BUG: 339009 BUG: 314038 REVIEW: 120768
2014-10-23Connect to the currentDirectoryChanged signal after the shell setupFrank Reininghaus
This fixes the problem that the view URL may be reset to the Home URL when opening the Terminal Panel while browsing a remote URL. Moreover, it fixes crashes that can occur when the signal is received during the shell setup if the DolphinMainWindow does not have a valid m_activeViewContainer yet. BUG: 339502 BUG: 340233 REVIEW: 120726 FIXED-IN: 4.14.3
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-10-07kdelibs4support--Montel Laurent
2014-08-24cleanupsDavid Faure
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-05dolphin: convert panels/ and filterbar to qt signal/slot syntaxAlex Richardson
TerminalPanel connections to konsole part were not converted since there is no header available that defines these function, we have to keep the old syntax here. Additionally the new syntax no longer accepts QPointer arguments, we have to explicitly call .data() there.
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2013-05-02Do not change the view URL if it is a symlink to the current directoryFrank Reininghaus
BUG: 302037 FIXED-IN: 4.10.3 REVIEW: 110233
2013-03-15Prevent accidental deletion of home directory in Terminal PanelFrank Reininghaus
The protection against unwanted execution of "rm -rf" when changing the directory while entering the command did not work if there was never any automatic "cd" command sent to the terminal before. This patch ensures that Terminal Panel's member m_clearTerminal is false after the initialization of the panel, such that the protection is effective after that. BUG: 316300 FIXED-IN: 4.10.2 REVIEW: 109431
2012-09-19Prevent unwanted URL changes when using the Terminal PanelFrank Reininghaus
The root cause of the problem was that TerminalPanel's member m_konsolePartCurrentDirectory, which is used to determine in TerminalPanel::sendCdToTerminal(QString& dir) if the Konsole part's directory is aleady 'dir', such that issuing the 'cd' command is not needed, was updated too late, namely when the part's currentDirectoryChanged(QString) signal was received, which may be up to one second after the 'cd' command. When changing the directory from "dir1" to "dir2" and going back to the "dir1" in less than one second (either by using the 'Back' action or by activating a tab which still had "dir1" open), the 'cd dir1' command was therefore suppressed because the Terminal Panel still thought that "dir1" was the current directory in the part. However, the directory of the part was actually "dir2", and when the currentDirectoryChanged(QString) signal was received from the part, the view's URL was set to "dir2" as well. BUG: 306349 BUG: 304838 FIXED-IN: 4.9.2
2012-06-08Krazy fixesPeter Penz
2012-06-03Prepend "cd" and "clear" commands with a space in the Terminal PanelFrank Reininghaus
This prevents that these commands, which have not been enetered by the user, but generated automatically, appear in the shell history, provided that the shell is configured appropriately. BUG: 204039 FIXED-IN: 4.9.0
2012-05-26Minor coding style fixesPeter Penz
2012-05-25Use KService to lookup the library name of konsolepartJekyll Wu
See https://git.reviewboard.kde.org/r/105028/
2012-04-26Update the view when changing the directory using 'cd' in the terminalFrank Reininghaus
Thanks to Jekyll Wu for helping to implement this feature! FEATURE: 156732 FIXED-IN: 4.9.0
2012-04-17Ensure authentication data is cached properlyPeter Penz
The attached patch sets the main window on the main directory lister in DolphinView and KIO jobs in DolphinMainWindow to ensure that login data for remote protocols such as sftp, ftp are cached properly for the duration of the application. Otherwise, the end user is going to end up being unnecessarily re-prompted to enter password login information. Thanks to Dawit Alemayehu for the patch! REVIEW: 104614 FIXED-IN: 4.9.0
2012-01-25Terminal: only consider process IDs > 0Peter Penz
Thanks to Jekyll Wu for the analyses. CCBUG: 286367
2011-06-01Fix problems with commit 8d789f2626243dSebastian Dörner
- fix crash when Ctrl-D-ing in the terminal - don't respond to window manager actions, only when the dock itself is hidden Refers to commit 8d789f2626243ddc6c763c84e582e8e20afe7689
2011-05-25Don't let hidden terminals prevent unmountingSebastian Dörner
Previous state: When the terminal is hidden, the cwd is not updated anymore. If it was on a removable device when hiding, the hidden terminal might prevent unmounting this device. This patch fixes that bug by changing the cwd to "/" when hiding the panel. REVIEW: 101387 BUG: 158264 FIXED-IN: 4.7.0
2011-04-12Fix directory navigation in Dolphin::Terminal.Raphael Kubo da Costa
When navigating in Dolphin it attempts to keep any open Terminal (F4) in sync by changing the directory in the shell. It does this by sending a "^C; cd $DIRECTORY" however shells under FreeBSD treat "^C" as a literal string and not SIGINT. Fix this by sending SIGINT to the shell instead of "^C". It appears Linux does not exhibit this behaviour. Patch originally written by David Naylor, from the KDE-FreeBSD team. CCMAIL: [email protected] (cherry picked from commit 5f78219e18073e475ed1f1865a1a2be1fafd60cf)
2011-02-09Coding style update for pointer comparisonPeter Penz
Most developers seem to prefer if (ptr) ... if (!ptr) ... in comparison to if (ptr != 0) ... if (ptr == 0) ... Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
2011-02-09Use capitalized includes of recently committed kdelibs headersPeter Penz
2011-02-04Update e-mail address from [email protected] to [email protected]Peter Penz
2011-02-04Use capitalized KDE includesPeter Penz
2011-02-02Provide a default size-hint for all panelsPeter Penz
This fixes the issue that the initial size of the Filter Panel is too small.
2010-11-10Cleanup KLibLoader use.Kevin Ottens
svn path=/trunk/KDE/kdebase/apps/; revision=1195243
2010-10-07Internal cleanup for panels: Let the panel-implementations decide whether ↵Peter Penz
they accept an URL or not. svn path=/trunk/KDE/kdebase/apps/; revision=1183480
2010-03-22Send CTRL+C to the terminal instead of of backspaces. Thanks to the FiNeX ↵Peter Penz
and g111 for the hint. CCBUG: 161637 svn path=/trunk/KDE/kdebase/apps/; revision=1106403
2010-03-16-pedanticAndré Wöbbeking
svn path=/trunk/KDE/kdebase/apps/; revision=1104133
2010-03-14Fix issue that the current terminal line does not get cleared before sending ↵Peter Penz
a cd command. The terminal interface does not provide an API for this, so as workaround backspaces are send. Not nice, but as the issue can lead to data loss, this solution is better than having nothing. BUG: 161637 svn path=/trunk/KDE/kdebase/apps/; revision=1103207
2009-10-02Make "most local url" determination asynchronous so that it doesn't block ↵David Faure
the GUI for a long time (e.g. when accessing the non-existing sftp://192.168.1.100/home) and only run this job if the terminal panel is shown (or at the time when it is made visible). Sorry kdebase users, you get to update kdelibs again. BUG: 202176 svn path=/trunk/KDE/kdebase/apps/; revision=1030480
2009-08-13Fix possible crash when opening Dolphin with an enabled Terminal. Thanks to ↵Peter Penz
Dario Andres for the analyses! BUG: 202953 svn path=/trunk/KDE/kdebase/apps/; revision=1011008
2009-05-17Update the directory of the Terminal Panel if the current URL is not aFrank Reininghaus
"file:" URL, but is nevertheless local (e.g., "desktop:"). This fix is also applied to the new "Open external Terminal" action which will be in KDE 4.3. BUG: 167810 svn path=/trunk/KDE/kdebase/apps/; revision=969265
2009-03-29BUG: 164489Rahman Duran
Make Dolphin benefit from new TerminalInterfaceV2 functions. svn path=/trunk/KDE/kdebase/apps/; revision=946382
2009-03-15a lot of more KUrl::path() -> KUrl::toLocalFile() changes (mostly after a ↵Christian Ehrlicher
check for KUrl::isLocalFile()) svn path=/trunk/KDE/kdebase/apps/; revision=939835
2009-01-14Cleanup panel related class names: The terms "sidebar"/"sidebarpage" are ↵Peter Penz
relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-) svn path=/trunk/KDE/kdebase/apps/; revision=911089
2009-01-14Group classes into folders, Dolphin is too big in the meantime for having a ↵Peter Penz
flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later. svn path=/trunk/KDE/kdebase/apps/; revision=911065
generated by cgit v1.3 (git 2.53.0) at 2026-04-21 05:06:42 +0000