┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/panels
AgeCommit message (Collapse)Author
2017-11-21Revert some hunks from previous commitKevin Funk
Changes in folderspanel.cpp in 464b13f3828e5cdd03438d0881c3a62c7cda6333 were unintended.
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2017-11-11Prevent folders from drag and dropping onto themselves in dolphin main viewEmirald Mateli
Summary: This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself. The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior. BUG: 307747 Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen. {F3787651} Test Plan: 1. Drag a folder. 2. Drop it onto itself. Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror Tags: #dolphin Differential Revision: https://phabricator.kde.org/D6281
2017-11-03Use nullptr + add explicit keywordMontel Laurent
Test Plan: compile Reviewers: #dolphin, broulik Reviewed By: broulik Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D8637
2017-10-12Don't block unmounting when terminal panel's cwd is the mountpointMiklos Marton
When unmounting a removable media Dolphin checks if there are some files open on the device before performing the unmount. If the terminal window in dolphin is open and the to be unmounted path is open, the unmount process will be blocked. This patch sets the terminal window current path to the home directory upon unmount request if the terminal directory is set to the mount path. The unmount request could came from two sources: The user could hit right click on the media in the dolphin's places panel and hit unmount. The user could request an unmount from the indicator applet This patch was originally written by Arjun AK for the kdelibs4 version of Dolphin: https://git.reviewboard.kde.org/r/121613/ BUG: 158264 FIXED-IN: 17.11.80 Differential Revision: https://phabricator.kde.org/D7847
2017-09-11Add "Open in New Window to Dolphin's places context menuNathaniel Graham
Summary: BUG: 384352 Add an "Open in New Window" menu item to the context menu for Dolphin's places items. Test Plan: Tested in up-to-date KDE Neon. Works as expected: {F3898707} Reviewers: #dolphin, #kde_applications, dfaure, aacid, elvisangelaccio, emmanuelp, broulik Reviewed By: #dolphin, emmanuelp, broulik Subscribers: alexeymin, emmanuelp, broulik, sefaeyeoglu, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D7690
2017-09-01Limit folder panel to home directory if inside homeRobert Hoffmann
Summary: Added the option to limit the displayed folders in the folder panel (F7) to the tree below the user's home directory if the current URL is inside the home directory. This can be configured in the preferences General/Behaviour tab by checking the corresponding check box. Reviewers: #dolphin, elvisangelaccio, emmanuelp Reviewed By: #dolphin, elvisangelaccio, emmanuelp Subscribers: emmanuelp, elvisangelaccio, #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D7477
2017-08-23Fix typo in udi stringChristoph Feck
Spotted by Chris Holland. BUG: 383182
2017-06-27[Places Panel] Disallow editing devicesKai Uwe Broulik
I introduced this bug when I changed the layout of the menu. While it would be nice if one could edit devices, it is currently not possible and would require significant re-engineering effort in Solid. While the "Edit" menu works just fine, changes are not persisted. Reviewed-By: emmanuelp Differential Revision: https://phabricator.kde.org/D6294
2017-06-11Ignore drops-onto-items from invalid places itemsElvis Angelaccio
If the QMimeData object created by PlacesItemModel doesn't have any url set (e.g. when dragging unmounted devices), it is detected by the resulting DropJob as "drop raw data" because the mimeData has one format set (the internalMimeType() used for dragging between places items). This results in a crash because the DropJob schedules a PasteJob, but in the meantime the QDrag from Dolphin ends and deletes the mimeData object that was passed to the paste job. The fix is to prevent the DropJob in the first place. We can introduce a new internal mimetype that we use to blacklist drops-onto-items (while still allowing drops-between-items). This way PlacesItemModel can set the blacklist flag if the mimeData is being created without urls. BUG: 373005 FIXED-IN: 17.04.3 Test Plan: Drag and drop an unmounted device to another place item or the DolphinView, doesn't crash anymore. Dropping the unmounted device between two places item still works. Differential Revision: https://phabricator.kde.org/D5535
2017-03-15[PlacesItemModel] Use QDir::homePath() instead of KUser().homeDir()Kai Uwe Broulik
KUser does quite a lot of stuff under the hood and also calls getpwuid which might block with network login. Differential Revision: https://phabricator.kde.org/D5049
2017-03-14Cleanup Places Panel context menusKai Uwe Broulik
Differential Revision: https://phabricator.kde.org/D4498
2017-01-21Merge branch 'Applications/16.12'Elvis Angelaccio
2017-01-21informationpanel: don't change color of scrollarea's viewportElvis Angelaccio
This code was added a long time ago in b1c9b5126d, but the commit message doesn't explain why. If we remove it nothing seems to change and we fix the ugly background on the scrollbar when Breeze draws a frame around dockable panels. BUG: 366203 FIXED-IN: 16.12.2 REVIEW: 129861
2017-01-21Change "Date" to "Modified" and allow access to new "Accessed" time fieldDon Nguyen
This is merge of #128964 and #128942. This will impelement changing the "Date" field to "Modified" and allow a new "Accessed" time field to be available. This also includes changes to update configuration files. REVIEW: 129077
2017-01-18Port away from deprecated KIO::Job::ui()Elvis Angelaccio
It's equivalent to KJob::uiDelegate() from kcoreaddons.
2017-01-03Add missing Q_DECL_OVERRIDEMontel Laurent
2016-10-28Merge branch 'Applications/16.08'Kai Uwe Broulik
2016-10-28[Places Item Edit Dialog] Fix accepting dialog with ReturnKai Uwe Broulik
By setting a parent for the QDialogButtonBox we let QDialog handle everything by itself. Also, store the dialog button box as a member rather than just the OK button. This removes the need to set the OK button as default manually (which didn't work anyway) and fixes pressing Return while the input is focused erroneously opening the folder browser rather than accepting the dialog. REVIEW: 129213
2016-08-06Fix some low-hanging warning fruitsMartin T. H. Sandsmark
2016-07-14Give FileMetaDataConfigurationDialog a parentChristoph Feck
REVIEW: 128439
2016-06-25add_definitions(-DQT_NO_URL_CAST_FROM_STRING) + fix compilationDavid Faure
This fixes some URLs built from local paths without scheme.
2016-06-16Fix DnD onto desktop:/ app desktop file.David Faure
We need to resolve from desktop:/ to file:/ so that DropJob can handle application .desktop files. CCBUG: 363991
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-11-19Fix search in places panel.Weng Xuetian
addType("File") will create a invalid query for baloo. Currently seems there is no replacement for it, so just remove it. REVIEW: 126109 FIXED-IN: 15.12 BUG: 348902
2015-08-30Icons: wrong icon usaeg for balloo Review Request #124972andreas kainz
2015-07-31Remove unused KBookmarkManager::bookmarksChanged signal-slot connection, ↵Emmanuel Pescosta
because we don't use KBoomark's D-Bus signaling anymore. REVIEW: 124497
2015-07-27Change the Dolphin places icons:Christian Butcher
* folder-txt => folder-text * folder-video => folder-videos * folder-image => folder-images Thanks to andreas_k and Christian Butcher! BUG: 347257 FIXED-IN: 15.08.0
2015-04-29Use user-places.xbel instead of bookmarks.xml in places model.Emmanuel Pescosta
REVIEW: 123526 CCBUG: 345174 FIXED-IN: 15.08.0
2015-03-31Show kdeconnect devices under "Devices"Kai Uwe Broulik
We probably need a more sophisticated heuristic for identifying devices in the places panel but given we already did that for Bluetooth should do for the foreseeable future. REVIEW: 123189 BUG: 337222
2015-03-30Merge branch 'davidedmundson/highdpi'David Edmundson
REVIEW: 123137
2015-03-25Center align pixmaps in a high DPR friendly wayDavid Edmundson
2015-03-14Make obexftp places group under devicesDavid Rosca
REVIEW: 122935
2015-02-26Port away from KDELibs4Support (we only use KDELibs4Support when baloo isn't ↵Emmanuel Pescosta
present, because KFileMetaDataWidget is in KDELibs4Support) Reviewed-By: Vishesh Handa
2015-02-25Merge branch 'master' into frameworksEmmanuel Pescosta
2015-02-24Replace kDebug/kWarning by categorized logging (org.kde.dolphin)Emmanuel Pescosta
2015-02-24Removed unused KGlobal includes and use KIO/Job instead of KIO/JobClassesEmmanuel Pescosta
2015-02-24include KFileItem instead of KFileItemListEmmanuel Pescosta
2015-02-20Missed a saveBookmarks call in the PlacesItemModel's deconstructor (see ↵Emmanuel Pescosta
commit 2a79feaea0088730bbf4fd4b65baa1c4a91b84b9)
2015-02-19Merge branch 'master' into frameworksEmmanuel Pescosta
2015-02-19Sync bookmark manager only if the change was done by the current processEmmanuel Pescosta
Adoption of http://commits.kde.org/kdelibs/2b5c6e42fc8114c6854ce490b9cdd4356be683d9 FIXED-IN: 14.12.3 BUG: 343620 BUG: 310080 REVIEW: 122640
2015-02-19QUrl porting bug: Added a missing QUrl::fromLocalFile in ↵Emmanuel Pescosta
FoldersPanel::loadTree to make the FoldersPanel work again REVIEW: 122631 BUG: 344204 FIXED-IN: 15.04
2015-02-06kdelibs4support--Montel Laurent
2015-02-04Port away from KGlobal::mainComponent()Emmanuel Pescosta
2015-02-03Ported Dolphin from KDialog to QDialog and save/restoreDialogSize to ↵Emmanuel Pescosta
KWindowConfig::save/restoreWindowSize with the help of the porting scripts. REVIEW: 122305
2015-01-30Port KGlobalSettings::smallestReadableFont() to ↵Emmanuel Pescosta
QFontDatabase::systemFont(QFontDatabase::SmallestReadableFont) REVIEW: 122308
2015-01-28Merge branch 'Applications/14.12' into frameworksEmmanuel Pescosta
Conflicts: dolphin/src/main.cpp kdepasswd/kcm/kcm_useraccount.desktop konqueror/settings/ebrowsing/ebrowsing.desktop konqueror/settings/kio/cache.desktop konqueror/settings/kio/cookies.desktop konqueror/settings/kio/netpref.desktop konqueror/settings/kio/proxy.desktop konqueror/settings/kio/smb.desktop konqueror/settings/kio/uasproviders/firefox30oncurrent.desktop konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop konqueror/settings/kio/useragent.desktop lib/konq/konq_operations.cpp
2015-01-05Dolphin: port from KonqOperations::doDrop to the new KIO::DropJobDavid Faure
REVIEW: 121678
2014-12-14use save() instead of writeConfig()Emmanuel Pescosta
generated by cgit v1.3 (git 2.53.0) at 2026-04-29 11:43:03 +0000