| Age | Commit message (Collapse) | Author |
|
|
|
baloo/baloo-widgets path fixes.
|
|
|
|
Since the master branch had never been merged into frameworks since the
creation of the frameworks branch, I had to fix a couple of merge
conflicts and make another change in order to make it build - I hope I
did not get anything wrong.
We should probably merge master into frameworks on a regular basis from
now on.
CCMAIL:[email protected]
Conflicts:
dolphin/src/dolphinmainwindow.cpp
dolphin/src/search/dolphinfacetswidget.cpp
dolphin/src/statusbar/dolphinstatusbar.cpp
dolphin/src/views/dolphinview.cpp
|
|
|
|
This does not work properly yet, there are probably quite a few bad signal/
slot connections due to KUrl -> QUrl. However dolphin starts without
crashing.
Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
and I have no idea how it is supposed to be used.
This is the first commit for review 117395
|
|
newly opened tab also starts the same search (Because new tab is opened with
the current view url), but the search box is in read-only mode. So you cannot
close the search bar nor edit the search text.
This patch fixes this by parsing the search url. The value of the "search"
parameter is used as search text and the value of the "url" parameter is used
for the search path ("root" folder for the search when "Search from here" mode
is enabled).
In case of Baloo search urls, we use Baloo::Query::fromSearchUrl.
Removed everything related to read only mode in DolphinSearchBox, not needed
anymore.
REVIEW: 111968
BUG: 311950
FIXED-IN: 4.13.0
|
|
They were previously checkboxes. Most files cannot have more than 1 type
considering that the exposed types were "Document", "Image", "Video" and
"Audio".
Also, it is not very simple in baloo to search through ORs for types.
Not through the exposed API anyway.
REVIEW: 117015
|
|
|
|
This required changes in Baloo which require reindexing. Since the
storage location has changed for Beta 3 everyone should be re-indexing
everything, so it won't be a problem.
|
|
DolphinSearchBox::balooUrlForSearching(). REVIEW: 116837 FIXED-IN: 4.13.0
|
|
|
|
Nepomuk is being replaced with Baloo
|
|
Implemented setActive(bool active), isActive() and activated() signal
for DolphinSearchBox - similar to the KUrlNavigator implementation.
BUG: 296970
FIXED-IN: 4.11.2
REVIEW: 112534
|
|
|
|
This way when another read only query is added, the internal state is
changed and the search label gets updated.
REVIEW: 110324
BUG: 315796
FIXED-IN: 4.10.4
|
|
BUG: 318937
FIXED-IN: 4.11.0
|
|
guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port
REVIEW: 106825
|
|
Thanks to André Wöbbeking for noticing that this was unnecessarily
complex!
|
|
This is achieved by adding some descriptive text and by using a more
appropriate icon.
Thanks to Panos Kanavos for the patch!
BUG: 300248
FIXED-IN: 4.10.0
REVIEW: 106325
|
|
|
|
BUG: 270721
BUG: 280377
FIXED-IN: 4.9.0
|
|
The places-entries for searching revealed some serious issues in
combination with the search-panel. Move the filtering away from
QDockWidget and bring it back below the search-bar.
|
|
QFontMetrics::averageCharWidth() is quite slow and does not work
well on fonts with broken characters. In the
usecases required by Dolphin QFontMetrics::height() is a better
and faster alternative to get a font-dependent minimum width.
Thanks go to Christoph Feck for this hint!
|
|
|
|
Thanks to Hugo Pereira Da Costa for the patch.
BUG: 277227
FIXED-IN: 4.7.0
|
|
regular expression in addition to the query created by the query
parser. All it does is majorly slowing down the query execution.
REVIEW: 101462
|
|
Actually HAVE_NEPOMUK should be defined here, but it isn't. This seems
to be some bug in the buildsystem.
CCMAIL: [email protected]
|
|
Use Query::titleFromQueryUrl() to give a hint what kind of information
is shown to the user.
|
|
If the Search Panel is shown outside the context of the "Find" mode it
will be always enabled and does a global search. Only if the user is in
the "Find" mode and the searching is restricted to the current directory
the Search Panel might get disabled if the current directory is not
indexed. This solves the major usability issue that it was not clear
for the users whether a global or restricted search is done.
|
|
When a searching has been triggered externally (e.g. by clicking on a tag) the search-mode settings like "From here"... are ignored and should not be shown at all. The current patch is only a quick workaround until a clean layout will be provided for this case.
|
|
The search panel must get a hint whether clicking on the facets should result in searching everywhere or from the current folder. It is not sufficient to check the search-settings of the "Find:"-box, as when the "Find:"-box is invisible there is no hint for the user what kind of searching is done and the setting must be ignored.
|
|
- Always merge the query from the "Find:"-field with the current facet-query. This assures that the facet-query never gets overwritten if the user changes the "Find:"-field.
- Always trigger a searching if the text of the "Find:"-field has been cleared.
Still a lot of usability issues are left, but this is at least a first step...
|
|
|
|
|
|
In this case the "From Here"/"Everywhere" buttons and the "Filename"/"Content" buttons are useless. Currently they just get disabled but the plan is to provide a better visual indication of the current query and to remove them completely.
|
|
A minor API cleanup in DolphinSearchBox has been done related to the test.
|
|
The clearing of the search-text should only be done when opening the search-box.
|
|
|
|
The filter-panel should be disabled if the current folder is not indexed at all. Also when triggering a "Find" the filter-panel should stay invisible per default when the current folder is not indexed.
CCBUG: 264969
|
|
enabled and not enough width is available for all options.
svn path=/trunk/KDE/kdebase/apps/; revision=1216467
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1216293
|
|
search-result when searching in indexed folders.
CCBUG: 263724
svn path=/trunk/KDE/kdebase/apps/; revision=1215987
|
|
subfolders when Nepomuk/Strigi has been activated.
CCBUG: 262274
svn path=/trunk/KDE/kdebase/apps/; revision=1215428
|
|
the focus and gets focused again by the shortcut (this behavior is consistent to e.g. the behavior in Kate).
CCBUG: 256160
svn path=/trunk/KDE/kdebase/apps/; revision=1207719
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1200741
|
|
also for non-local URLs
svn path=/trunk/KDE/kdebase/apps/; revision=1200307
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1200303
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1199915
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1195688
|