| Age | Commit message (Collapse) | Author |
|
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
|
|
Summary: CCBUG: 420354
Reviewers: ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio
Reviewed By: elvisangelaccio, #dolphin, iasensio
Subscribers: iasensio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D29198
|
|
Summary:
Move from the searchbox to the search results listbox/view using the
down arrow key in addition to the existing methods using the tab key,
return key, or the mouse.
Test Plan:
use ctrl+f to search in a directory tree, press down arrow key
to go to the results
Reviewers: ngraham, #dolphin
Reviewed By: ngraham, #dolphin
Subscribers: meven, elvisangelaccio, ngraham, iasensio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D26362
|
|
Summary:
Extracts the logic that parses `baloosearch:` urls into a new model class. The parser logic itself is kept as is.
The search box UI is later updated using the model fields.
This refactor has been proposed by @bruns in the review of D24422, as it largely simplifies the unit tests and further expansion/improvements.
Test Plan:
No behavior changes.
Test case is added in the follow-up revision: D25258
Reviewers: #dolphin, elvisangelaccio, bruns
Reviewed By: #dolphin, elvisangelaccio, bruns
Subscribers: ngraham, bruns, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D25257
|
|
Summary:
With the new compact search filters (type/date/rating) it makes sense to show these options whenever available, and save some horizontal space on the main bar (specially for verbose languages).
These options will be hidden nevertheless if the search is non-indexed or Baloo is disabled.
For some nicer aesthetics D25029 should be also applied.
CCBUG: 386754
Test Plan:
Current: {F7681182}
After: {F7687380}
Along with D25029: {F7687385}
Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg
Reviewed By: ngraham, #vdg
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D25057
|
|
Summary:
Fix the search box forgetting the location where the user was previously searching into.
To do a search on "All Files" instead of setting the `m_searchPath` to `$HOME`, it checks the button state, so the "From Here" location is not lost.
As an added benefit, selecting "Your Files" when in a non-indexed folder will use the baloo search instead of a fully non-indexed search from $HOME.
This issue is the last remaining one of the series started with D24422, with the purpose of fixing the searchbox parsing and update.
Test Plan:
- Toggle between "From Here/Your Files" and navigate between locations
- The search box remembers the location and keeps a coherent state
{F7575402}
Reviewers: #dolphin, elvisangelaccio
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D24577
|
|
Summary:
Hide the search extra options when they are not available, because the current location is not indexed or Baloo is not enabled.
The button is disabled and shows a tooltip to provide feedback of why it's not available.
Depends on D24478
{F7531893}
CCBUG: 396898
FEATURE: 318580
FEATURE: 408680
FIXED-IN: 19.11.80
Test Plan:
- `Ctrl-F` on a non-indexed location
- `balooctl disable` and `Ctrl-F` on an indexed location
On both cases the extra options are not shown, the button is disabled and the reason is shown in the tooltip
The user selection is remembered between indexed locations.
Reviewers: #dolphin, elvisangelaccio, meven, ngraham
Reviewed By: meven
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D24446
|
|
Summary: Extracts the logic for checking if the current path is indexed to its own method.
Test Plan: No behavior changes
Reviewers: elvisangelaccio, ngraham, meven
Reviewed By: ngraham, meven
Subscribers: meven, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D24478
|
|
Summary:
See https://hig.kde.org/style/writing/placeholder.html
Screenshot:
Old: {F6691712}
New: {F6698685}
Test Plan: Compile and run
Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio
Reviewed By: #dolphin, #vdg, ngraham
Subscribers: GB_2, kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel
Tags: #dolphin, #documentation
Maniphest Tasks: T10258
Differential Revision: https://phabricator.kde.org/D19770
|
|
|
|
Also use override instead of Q_DECL_OVERRIDE
|
|
Summary:
FEATURE: 269332
Make Dolphin's Saved Search feature discoverable by adding a button inside the search field. The button only becomes enabled when there is a valid search term. When pushed, it saves the search to the Places panel, providing a visible-by-default way to do this to complement the existing implementation that is only visible in the context menu.
Also harmonized the label text so that it's consistent no matter how you create a saved search (button or context menu)
Test Plan:
Tested in KDE Neon. Works great:
{F5449508}
Reviewers: #dolphin, broulik, dfaure, markg, emateli, elvisangelaccio
Reviewed By: #dolphin, markg, emateli, elvisangelaccio
Subscribers: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D8454
|
|
Additionally, moves the "More/Fewer options" button from right to left to reduce the mouse travelling distance when the dolphin is maximized on a large screen (see screenshots)
The current location url will be passed to the search tool to set the initial search root directory.
REVIEW: 123883
|
|
REVIEW: 129705
Signed-off-by: Anthony Fieroni <[email protected]>
|
|
Dolphin search"
The natural query parser is too unstable for the release atm, we'll readd the
query parser when the code is mature enough.
This reverts commit e3578ee3b770a1b8f359ed1a3cc6e3ac7f6c700e.
|
|
7ed7cd97d084364d8ee61b35f5ffa3630c5277a4
CCMAIL: [email protected]
|
|
|
|
REVIEW: 120688
|
|
|
|
REVIEW: 112589
|
|
newly opened tab also starts the same search (Because new tab is opened with
the current view url), but the search box is in read-only mode. So you cannot
close the search bar nor edit the search text.
This patch fixes this by parsing the search url. The value of the "search"
parameter is used as search text and the value of the "url" parameter is used
for the search path ("root" folder for the search when "Search from here" mode
is enabled).
In case of Baloo search urls, we use Baloo::Query::fromSearchUrl.
Removed everything related to read only mode in DolphinSearchBox, not needed
anymore.
REVIEW: 111968
BUG: 311950
FIXED-IN: 4.13.0
|
|
Nepomuk is being replaced with Baloo
|
|
Implemented setActive(bool active), isActive() and activated() signal
for DolphinSearchBox - similar to the KUrlNavigator implementation.
BUG: 296970
FIXED-IN: 4.11.2
REVIEW: 112534
|
|
This is achieved by adding some descriptive text and by using a more
appropriate icon.
Thanks to Panos Kanavos for the patch!
BUG: 300248
FIXED-IN: 4.10.0
REVIEW: 106325
|
|
BUG: 270721
BUG: 280377
FIXED-IN: 4.9.0
|
|
The places-entries for searching revealed some serious issues in
combination with the search-panel. Move the filtering away from
QDockWidget and bring it back below the search-bar.
|
|
Thanks to Hugo Pereira Da Costa for the patch.
BUG: 277227
FIXED-IN: 4.7.0
|
|
Use Query::titleFromQueryUrl() to give a hint what kind of information
is shown to the user.
|
|
If the Search Panel is shown outside the context of the "Find" mode it
will be always enabled and does a global search. Only if the user is in
the "Find" mode and the searching is restricted to the current directory
the Search Panel might get disabled if the current directory is not
indexed. This solves the major usability issue that it was not clear
for the users whether a global or restricted search is done.
|
|
In this case the "From Here"/"Everywhere" buttons and the "Filename"/"Content" buttons are useless. Currently they just get disabled but the plan is to provide a better visual indication of the current query and to remove them completely.
|
|
A minor API cleanup in DolphinSearchBox has been done related to the test.
|
|
The clearing of the search-text should only be done when opening the search-box.
|
|
|
|
The filter-panel should be disabled if the current folder is not indexed at all. Also when triggering a "Find" the filter-panel should stay invisible per default when the current folder is not indexed.
CCBUG: 264969
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1216293
|
|
the focus and gets focused again by the shortcut (this behavior is consistent to e.g. the behavior in Kate).
CCBUG: 256160
svn path=/trunk/KDE/kdebase/apps/; revision=1207719
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1200741
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1195671
|
|
- Remove filter-prototypes that conflict with the filterpanel
svn path=/trunk/KDE/kdebase/apps/; revision=1190445
|
|
for at least a second.
svn path=/trunk/KDE/kdebase/apps/; revision=1184510
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1154073
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1148408
|
|
search box.
BUG: 218880
svn path=/trunk/KDE/kdebase/apps/; revision=1080372
|
|
* remember the search options when closing Dolphin, so that the user can adjust his "default search template"
svn path=/trunk/KDE/kdebase/apps/; revision=1052499
|
|
* trigger progress information when starting a search
* let the information panel hide the meta data for the search string
* get the search string from the configurator
svn path=/trunk/KDE/kdebase/apps/; revision=1048721
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1048239
|
|
* Allow the user to manually close the options.
* Added tooltip descriptions.
svn path=/trunk/KDE/kdebase/apps/; revision=1047281
|
|
before than the code was written.
svn path=/trunk/KDE/kdebase/apps/; revision=1041128
|
|
playground/base/nepomuk/search_widgets_test. I adjusted some names of classes and members and also changed some parts of the implementation, but conceptually the concept is 1:1 like provided by Adam in playground.
Currently the UI works quite well, but the creating of the query string has not been integrated yet.
svn path=/trunk/KDE/kdebase/apps/; revision=1039572
|
|
search prototype from playground
svn path=/trunk/KDE/kdebase/apps/; revision=1036776
|