┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/settings/dolphinsettingsdialog.cpp
AgeCommit message (Collapse)Author
2024-10-17Move settings category switcher to the top on mobileFelix Ernst
There is not enough horizontal space to show the full Dolphin settings window on the average phone. This commit saves some horizontal space by moving the category switcher in Dolphin settings from being a list on the left to being tabs on the top.
2024-08-16DolphinSettingsDialog: Move focus to Okay button lastFelix Ernst
This commit changes the Tab order in Dolphin's Configure dialog so that the items which are visually at the end of the dialog are also last in the keyboard focus order when cycling through the interface using the Tab key. Previously, the "Cancel", "Defaults", "Okay", and "Apply" buttons received focus prior to the actual contents of the pages which does not make sense from a workflow perspective. This change should also make navigating this dialog easier when relying on screen readers because reading those buttons out prior to users even having a chance to change any setting did not make any sense.
2023-11-08Adapt to KConfigGroup name officially being a QString typeFriedrich W. H. Kossebau
GIT_SILENT
2023-09-10Merge remote-tracking branch 'origin/master' into kf6Méven Car
2023-09-10Replace qAsConst with std::as_constMéven Car
2023-09-09Add open in split view actionEric Armbruster
This action is shown only if a single folder is selected. The action opens the selected folder in the inactive split view (and opens the split view if necessary). FEATURE: 465500
2023-08-28Clean obsolete ifdefs since dolphin requires KF 5.101+Méven Car
2023-08-18Dolphin settings revampDimosthenis Krallis
It includes a move of the settings in the Navigation and Startup sections to the Interface (formerly Behavior) section. It also includes a new tab in the View (formerly View Mode) section, called General where some settings regarding Display style, Browsing and Miscellaneous settings The Interface section has new tabs named Folders & Tabs and Status & Location bars respectively where most of the Startup and Navigation settings moved. The `dolphin/kcms/kcm_dolphinnavigation` kcm is removed.
2023-07-05Add explicit moc includes to sources for moc-covered headersFriedrich W. H. Kossebau
* speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods
2023-04-02Context menu: allow to show copy to/move to inactive split viewMéven Car
Prevent copying/moving to same folder as origin when copying/moving to inactive split view BUG: 356436
2023-02-05Add clang-format and format code as in FrameworksSerg Podtynnyi
2022-10-15Port away from deprecated KMessageBox Yes/NoFriedrich W. H. Kossebau
GIT_SILENT
2022-06-15Use cmakedefine01Ahmad Samir
This way we get a build time warning if the var isn't defined at all, e.g. a missing check_include_files() CMake call.
2022-06-15Use one config-dolphin.h.cmake configuration fileAhmad Samir
2022-05-02Re-add "Open Terminal Here" featureoioi 555
This is equivalent to the "Open Terminal Here" feature that existed until Version 20.12. If the user has selected folders, replace "Open Terminal" in the context menu with "Open Terminal Here". When more than 5 folders are selected, a modal window will ask the user if they are sure they want to open all 6 or more terminal windows. In Detail View, users can also select a file, which will open a terminal at the location of that file. BUG: 452637 FIXED-IN: 22.08
2021-11-13Dolphin preferences dialog use now for everything colorfull iconsAndreas Kainz
2021-10-20Save size of config dialog in state configAlexander Lohnau
CCBUG: 397602
2021-10-06Change settings window title to "Configure" for consistency sakeFelipe Kinoshita
This commit makes Dolphin's settings window more consistent with other KDE apps.
2021-05-20Add action to places panel context menu trash entry to open trash settingsSaravanan K
BUG: 367583 FIXED-IN: 21.08
2021-05-10DolphinContextMenu: Allow disabling "Open Terminal" actionAlexander Lohnau
BUG: 436323 FIXED-IN: 21.08
2020-12-28Share actions with main window to avoid duplicating icon name and textDuong Do Minh Chau
2020-12-28Add options to hide some context menu entriesDuong Do Minh Chau
This commit add options to hide the following context menu entries: - Add to Places - Copy Location - Duplicate Here - Open in New Tab and Open in New Tabs - Open in New Window - Sort By - View Mode The Services settings page is renamed to Context Menu ShowCopyMoveMenu option is moved from GeneralSettings to ContextMenuSettings BUG: 314594
2020-11-05Add support for KUserFeedbackElvis Angelaccio
This commit introduces KUserFeedback in dolphin with some basic data sources and with a settings page to configure the telemetry values. There are also a couple custom data sources as proof of concept: a bunch of settings and the count of available network shares as listed by Solid. The settings page is shown only if the user feedback framework is enabled, but currently in Plasma we don't have a global kill switch to disable it. At the moment we never show an encouragement message. We need to connect to the `Provider::showEncouragementMessage()` signal, but first we should agree to a common way to show a non-annoying message to the users.
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-10-23Compile without foreachAlexander Lohnau
2020-09-20Exclude trash settings from windowsAlexander Lohnau
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2019-12-09Fix build with Qt 5.14 RCAntonio Rojas
Add needed Qt includes that are no longer pulled transitively. BUG: 414492 Differential Revision: https://phabricator.kde.org/D25783
2019-09-06Use large colorful category icons in Dolphin settingsBjörn Feber
Summary: {F7324074} Ref task T10165 Depends on D23749 Test Plan: Open the Dolphin settings dialog. Reviewers: #dolphin, #vdg, ndavis, ngraham Reviewed By: #dolphin, #vdg, ndavis, ngraham Subscribers: ngraham, ndavis, kfm-devel, #vdg, #dolphin Tags: #dolphin Maniphest Tasks: T10165 Differential Revision: https://phabricator.kde.org/D23750
2019-03-27Fix typo in dolphinsettingsdialog.cppYi-Jyun Pan
Summary: Just remove the useless "have". Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20080
2019-03-26Prompt user to save/discard changes upon closing config dialogAmish Naidu
Summary: When the configuration dialog is closed with unsaved changes, a message box is prompted to save/discard them or cancel the event. BUG: 391206 Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19904
2018-07-05Modernize Settings windowNathaniel Graham
Summary: This patch modernizes the appearance of Dolphin's configuration window by following the KDE HIG as much as possible and following design cues from Plasma and System Settings. Test Plan: Tested all settings to make sure they still work; they do. Startup page, before: {F5825313} Startup page, after: {F5918574} View page (Icons), before: {F5825319} View page (Icons) after: {F5918575} View page (Compact), before: {F5825321} View page (Compact) after: {F5918700} View page (Detailed), before: {F5825323} View page: (Detailed), after: {F5918701} Navigation page: no change Trash page, before: {F5858748} Trash page, after: {F5866656} (Provided by {D12986}) General page (behavior), before: {F5825316} General page (behavior) after: {F5918572} General page (confirmations), before: {F5866885} General page (confirmations), after: {F5918702} General page (status bar): no change Reviewers: #dolphin, #vdg, broulik, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: fabianr, cfeck, medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12571
2018-06-19Move General settings to the topNathaniel Graham
Summary: KDE apps generally (ha ha) have their {nav General} page at the top of the list, so it's the first thing the user sees when they open the {nav Settings} window, but Dolphin is an exception. It puts the {nav General} page //last!// This patch makes Dolphin consistent with other KDE apps by moving the {nav General} page up to the top. Test Plan: {F5918590} Reviewers: #dolphin, #kde_applications, elvisangelaccio, ltoscano Reviewed By: elvisangelaccio, ltoscano Subscribers: kde-doc-english, ltoscano, elvisangelaccio, kfm-devel Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D13595
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2017-02-13Don't add trashSettingsPage to m_pages if nullKai Uwe Broulik
Otherwise we might crash in applySettings() or restoreDefaults()
2017-02-08[Settings Dialog] Show Trash settings only if authorizedKai Uwe Broulik
If this KCM is disabled through KIOSK restriction opening it would result in an error message. Hide the entry altogether in this case. Differential Revision: https://phabricator.kde.org/D4502
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-09-10Change Dolphin Preferences Sidebar Iconsandreas kainz
2015-02-04Port Dolphin away from KApplication, KCmdLineArgs and K4AboutDataMathieu Tarral
2015-02-04Solved TODO: KWindowConfig::saveWindowSize/restoreWindowSize in ↵Emmanuel Pescosta
DolphinSettingsDialog
2014-12-14use save() instead of writeConfig()Emmanuel Pescosta
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-09-12Ported KIcon to QIconEmmanuel Pescosta
REVIEW: 120159
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-06-06Make the settings dialog work in the frameworks branchFrank Reininghaus
The KF5 version of KPageDialog has no virtual slot "slotButtonClicked(int button)". Its kdelibs 4.x counterpart had such a slot, which was connected automatically to the corresponding signal. This slot was overriden by DolphinSettingsDialog::slotButtonClicked(int button) which was responsible for applying the changed setting and restoring the default values if the corresponding button was clicked. The lack of the buttonClicked(int) signal and the corresponding slot caused the problem that clicking a button in the settings dialog had no effect. This patch makes the functions applySettings() and restoreDefaults() functions slots, and connects them directly to the "clicked" signal of the corresponding buttons. BUG: 335709 REVIEW: 118576
2014-05-05dolphin: convert statusbar, settings and search to qt5 signals/slot syntaxAlex Richardson
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
generated by cgit v1.3 (git 2.53.0) at 2026-04-18 07:52:32 +0000