┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/settings/general
AgeCommit message (Collapse)Author
2020-12-09operator+/- is disabled for QFlags in qt6Laurent Montel
2020-12-03DolphinView: set the parent of layout in the ctorAhmad Samir
This silences a runtime warning: QLayout: Attempting to add QLayout "" to DolphinView "", which already has a layout Remove redudant setLayout() calls, passing a parent widget to the Q*BoxLayout ctor sets that layout as the top-level layout for that widget.
2020-10-23Compile without foreachAlexander Lohnau
2020-09-13Improve Touch supportSteffen Hartleib
With this patch dolphin now supports the following touch gestures: * Tap gesture to interact/open with directories, files and so on * TapAndHold and release gesture for access to the context menu (main window, panel folder, places and information) * TapAndHold and moving gesture for drag and drop action (main windows, panel folder and places) * pinch gesture for zoom in main window * kinetic scrolling (QScroller) for main window, panel folder, panel places, panel information, setting preview and service * two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up * two finger tap gesture to toggle item selection, similar to Ctrl and left mouse click FEATURE: 385066 FIXED-IN: 20.11.80 You are currently rebasing branch 'touch' on '85241a924'.
2020-09-08Merge branch 'release/20.08' into masterNate Graham
2020-09-08Fix untranslated spinbox suffix stringsNate Graham
BUG: 426286 FIXED-IN: 20.08.2
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-08-08Fix i18nYuri Chornoivan
2020-08-02Remove MaximumSize entry from kdeglobals when settings the preview file size ↵Antonio Rojas
limit to "No limit" Instead of setting it to 0, which KIO's PreviewJob interprets as "No previews", breaking previews in konsole and Plasma desktop BUG: 424403
2020-07-05Merge branch 'release/20.04'Elvis Angelaccio
2020-07-05Write correct value for "Open in application" script execution settingWolfgang Bauer
KIO actually uses "alwaysAsk", "execute", and "open" as possible values. When reading the setting, map unknown values to "open" like KIO does. That also provides compatibility with older dolphin versions. BUG: 421294 FIXED-IN: 20.04.3
2020-06-09Provide ability to configure size cut-off for local file previewsGastón Haro
Summary: FileWidgets read from kdeglobals the property "MaximumSize" under "PreviewSettings" to decide if a preview will be generated for that file. There is no current GUI to change that file size limit. On the other hand Dolphin ignores it. This patch aims to fix that by adding new configuration options to Dolphin. That is a new spinbox in Dolphin settings under General -> Previews tab. Test Plan: 1 - Set up a local folder with 2 jpg images of less and more than 1 MB respectively. 2 - Go to Dolphin Preferences. General -> Previews and check "JPEG Images" from the list. And set "Skip previews for files above:" to 1MB. 3 - Navigate to the afore mentioned folder. Only the image of size less than 1 MB should show a preview. BUG: 331240 Reviewers: ngraham, #dolphin, meven, elvisangelaccio Reviewed By: ngraham, #dolphin, meven, elvisangelaccio Subscribers: cfeck, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28402
2020-04-06Revert "Port deprecated signal (qt5.15)"Aleix Pol
This reverts commit e545efee73a869aef4276baef0535169f03933de. (Cherry-picked from c01d1b4c0e909af716801e4b82862c50e8def4a4)
2020-03-31Revert "Port deprecated signal (qt5.15)"Aleix Pol
This reverts commit e545efee73a869aef4276baef0535169f03933de.
2020-02-16Port deprecated signal (qt5.15)Laurent Montel
2019-12-26Don't use nullptr/0 as flags (deprecated in qt5.15)Laurent Montel
2019-12-15Don't overload the word "Properties" to mean multiple thingsNate Graham
Summary: Generally "Properties" refers to information about a selected file. However Dolphin also uses the word "Properties" in the phrase "View Properties", which refers to the display style of the view. Since "properties" is a fairly esoteric and technical term to most users, it would probably be wise to avoid using it in multiple contexts. Accordingly, this patch changes "view properties" to "view display style". Test Plan: Look at the settings window, hamburger menu, view menu, and docbook Reviewers: #vdg, #dolphin, ndavis, elvisangelaccio Reviewed By: #vdg, #dolphin, ndavis, elvisangelaccio Subscribers: ndavis, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D25987
2019-12-09Merge branch 'release/19.12'Antonio Rojas
2019-12-09Fix build with Qt 5.14 RCAntonio Rojas
Add needed Qt includes that are no longer pulled transitively. BUG: 414492 Differential Revision: https://phabricator.kde.org/D25783
2019-11-16Use URLs with transport encryptionYuri Chornoivan
2019-09-29Expose full set of script execution options in settings windowNate Graham
Summary: Right now the script execution setting is a checkbox, capable only of handling boolean input. This is not appropriate because there are actually three options available. Accordingly, this patch replaces the checkbox with a combobox (to save space compared to radio buttons) that clearly exposes all three options. BUG: 371837 FIXED-IN: 19.12.0 Test Plan: {F7440559} - All three options do what they say they'll do - All options get saved properly - The combobox displays the correct option when the window is loaded - The {nav Defaults} button resets it to "always ask" as expected Reviewers: elvisangelaccio, #dolphin, #vdg Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T9932 Differential Revision: https://phabricator.kde.org/D24247
2019-08-19Fix a typoNazar Kalinowski
Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23264
2019-05-05Get rid of ugly static_cast usages in connect() callsElvis Angelaccio
2019-03-17Make global view properties the default settingElvis Angelaccio
Summary: Automatic creation of .directory files is one of the most complained about things in dolphin. These days applications are supposed to store application-specific data within $XDG_DATA_HOME. Long-term that's the proper solution for this issue, but for now we can at least flip the default so that we no longer create .directory files out of the box. A tooltip is also added as a kind of warning for the users who want to change the setting. Ideally a proper warning should be shown using a KMessageWidget or KMessageBox, but neither play too well with the setting dialog workflow used by dolphin. CCBUG: 322922 Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19661
2019-03-06Improve wording of split view/pane settingsSimon Depiets
Summary: I found these strings very hard to understand then translate without looking into the code because the use of "view" refers to both "the split view" and "the left pane and the right pane of the split view". This patch attempts to explicitly mention panes when needed. Reviewers: #dolphin, angeloevertonjr, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19579
2019-02-27remove deprecated methodsLaurent Montel
2019-02-16Add option to choose which view to closeAngelo Oliveira Jr
Summary: This Diff make configurable which view will close when toggling off the split view mode, if it's the active one or the inactive one. A new checkbox was added to the Dolphin configuration window, and defaults to the original behavior. FEATURE: 312834 FIXED-IN: 19.03.80 Test Plan: {F6535432} Reviewers: ngraham, #dolphin, elvisangelaccio Reviewed By: ngraham, #dolphin Subscribers: elvisangelaccio, cfeck, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D18040
2019-02-06Merge branch 'Applications/18.12'Kai Uwe Broulik
2019-02-06Sort preview plugins case-insensitivelyKai Uwe Broulik
"eBook thumbnails" would show up all the way at the bottom otherwise Test Plan: 18.12 branch It now shows where it should Differential Revision: https://phabricator.kde.org/D18787
2019-01-28Introduce HAVE_TERMINALElvis Angelaccio
Source code should check for features detected during configure-time, rather than checking for a specific OS. See also commit 87e8d0ba5f.
2019-01-19Ask for confirmation when Closing Dolphin windows with a terminal panel ↵Nate Graham
running a program Summary: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program. FEATURE: 304816 FIXED-IN: 19.04.0 Test Plan: # Open terminal panel # Run `watch ls` # Close Dolphin # Observe confirmation # Disable confirmation # Repeat, observe no confirmation # Enable confirmation in the settings # Repeat, observe a confirmation Reviewers: #dolphin, markg, elvisangelaccio, rominf Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel, elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D10960
2018-10-27Adjust label in the settings page for changed preview behaviourFabian Vogt
Summary: Requested by https://phabricator.kde.org/D15138#318904 Test Plan: Opened the preview settings, label text changed. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ngraham, markg, broulik, kfm-devel, elvisangelaccio Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15216
2018-09-04Merge branch 'Applications/18.08'David Edmundson
2018-09-04Correctly save behaviourOnLaunchDavid Edmundson
Summary: We only wrote out a checkbox value if the checkbox was checked. Unchecking it would not do anything. BUG: 398022 Test Plan: Read KRun's exepcted values Unchecked config option Reloaded dolphin Checkbox remained off Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15147
2018-08-22Restore settings label and prevent warning when Baloo is unavailableHenrik Fehlauer
Summary: As discussed in D14814, 6674c9c387d0 removed the {nav Show tooltips} checkbox in Dolphin's preferences when Baloo is unavailabe at compile time and thus the tooltip would not be functional. The {nav Miscellaneous} label in front of the checkbox was also removed, even though it relates to all options in that group. In addition, after 6674c9c387d0 running Dolphin without Baloo support would print QWidget::insertAction: Attempt to insert null action on startup. Both issues can be fixed with more `#ifdefs`. Test Plan: After building with `-DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON`, the {nav Show tooltips} checkbox is removed, the {nav Miscellaneous} label is still there, and there is no warning printed. Reviewers: elvisangelaccio Reviewed By: elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D14980
2018-08-21Port away from kdelibs4supportElvis Angelaccio
Summary: It was only used as fallback when baloo was not found, but `KFileMetaDataWidget` is useless without nepomuk. The result of this patch is that the information panel and the tooltips won't be available from platforms without baloo (instead of being available but broken). The baloo dependency remains optional. Closes T8720 Test Plan: Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and make sure it doesn't show tooltips or the information panel. Reviewers: #dolphin, broulik, ngraham Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T8720 Differential Revision: https://phabricator.kde.org/D14814
2018-07-05Modernize Settings windowNathaniel Graham
Summary: This patch modernizes the appearance of Dolphin's configuration window by following the KDE HIG as much as possible and following design cues from Plasma and System Settings. Test Plan: Tested all settings to make sure they still work; they do. Startup page, before: {F5825313} Startup page, after: {F5918574} View page (Icons), before: {F5825319} View page (Icons) after: {F5918575} View page (Compact), before: {F5825321} View page (Compact) after: {F5918700} View page (Detailed), before: {F5825323} View page: (Detailed), after: {F5918701} Navigation page: no change Trash page, before: {F5858748} Trash page, after: {F5866656} (Provided by {D12986}) General page (behavior), before: {F5825316} General page (behavior) after: {F5918572} General page (confirmations), before: {F5866885} General page (confirmations), after: {F5918702} General page (status bar): no change Reviewers: #dolphin, #vdg, broulik, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: fabianr, cfeck, medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12571
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Modernize the syntax of shortcutsRoman Inflianskas
Reviewers: #dolphin, markg Reviewed By: markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10986
2018-03-03Add an option to confirm trash emptying into settingsRoman Inflianskas
Summary: Add an option to confirm trash emptying into settings. BUG: 340572 Reviewers: #dolphin, ngraham, markg Reviewed By: #dolphin, ngraham, markg Subscribers: markg, ngraham, rkflx, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D10968
2018-02-03Fix all 'explicit constructor' krazy warningsElvis Angelaccio
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2017-11-16Use KConfig::readEntry()'s default argument properlyNathaniel Graham
Summary: Follow-on patch to D7440 to use KConfig::readEntry()'s default argument properly to reduce some unnecessary code Test Plan: Tested in KDE Neon. no regressions; by default, all plugins are enabled if the key is not set, and if it is set, user changes to the list are remembered Reviewers: #dolphin, elvisangelaccio, dfaure, apol Reviewed By: #dolphin, elvisangelaccio, apol Differential Revision: https://phabricator.kde.org/D8846
2017-11-15Turn on Dolphin icon previews by defaultNathaniel Graham
Summary: BUG: 338492 BUG: 350212 By default, turn on all preview plugins and turn on previews themselves. Depends on D8347 Test Plan: Tested this change in an up-to-date KDE Neon: removed the existing dolphinrc file, deployed Dolphin with the change, and observed that previews are now turned on for all file types for which a plugin exists except for text files, which are in the blacklist because they're mostly useless at nearly all icon sizes (still available in case people want them, though). Here's how Dolphin's main window looks by default now in KDE Neon: {F5441184} (You may notice that there are no previews for the video files; that's because Neon doesn't ship with any plugins for them, so that would be expected at this point) And here is how the Settings > General > Preview window looks like now by default: {F5435391} Reviewers: #dolphin, #vdg, markg, abetts, dfaure, aseigo, elvisangelaccio Reviewed By: #vdg, abetts, dfaure, elvisangelaccio Subscribers: abetts, cfeck, andreaska, emmanuelp, andreask, markg, broulik, anthonyfieroni, davidedmundson, ltoscano, dfaure, elvisangelaccio, #konqueror Tags: #dolphin Differential Revision: https://phabricator.kde.org/D7440
2017-11-03Use nullptr + add explicit keywordMontel Laurent
Test Plan: compile Reviewers: #dolphin, broulik Reviewed By: broulik Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D8637
2017-07-21Fix layout warningElvis Angelaccio
This fixes the following warning: QLayout: Attempting to add QLayout "" to PreviewsSettingsPage "", which already has a layout `topLayout->addLayout(fileSizeBoxLayout)` takes ownership of `fileSizeBoxLayout`, so there is no reason to use `this` as parent.
2016-09-04Use tab for switching active splitMartin T. H. Sandsmark
REVIEW: 128564 REVIEW: 110970 BUGS: 171743
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
generated by cgit v1.3 (git 2.53.0) at 2026-04-22 15:00:04 +0000