┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/settings/services
AgeCommit message (Collapse)Author
2019-05-08services/test: Fix testAlexander Potashev
Reviewers: #dolphin, elvisangelaccio, sitter Reviewed By: sitter Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D21022
2019-03-18fix coverage generation when run through ctestHarald Sitter
path construction is a bit disappointing and doesn't actually work all that well for out-of-tree PWDs. in lieu of an upstream fix let's try our best to get the correct coverage directory set. without this hack no results get recorded unfortunately.
2019-03-18redo service menu ruby helpers from ground up more or lessHarald Sitter
Summary: - apply ruby community style guidelines - full rewrite fixing, among other things: - inefficient/unreadable String#end_with reimplementation - inefficient use of Kernel.system (forked shell to fork a shell) - inefficient/unreadable Dir.glob reimplementation - inefficient File initialization for single chmod - invocation conditions are now actually readable - invocation conditions now also force +x on argless scripts, not just scripts that need arguments - repetitive conditions are now expressed as loops on argument arrays - mime detection now uses xdg-mime instead of file (xdg-mime internally may fall back to mime but will prefer higher level tools such as kmimetypefinder5; giving better results overall) - return values of "backtick forks" are now checked and will produce suitable errors on stderr - fail now takes a log_msg argument which is printed to stderr. this is in addition to the error raised as notification for the user, as that is unfortunately not so useful for diagnostics - overall error handling and logging of problem causes is much improved - add license headers. the original code was actually fairly exhaustive, so this really should have had a header to begin with. the code was originally introduced in svn r1045663 on Nov 6 14:56:35 2009 UTC - add blackbox tests. in the interest of keeping the scripts actually simple scripts (as opposed to a bunch of classes used by even simpler scirpts) they are now also covered by test rigging which runs them as scripts (again, as opposed to individual unit testing of distinct units) - the tests optionally can use simplecov to gather coverage metrics - also wired up to ctest so it actually gets run structurally there is actually a fair amount of overlap between the two scripts, but again, in the interest of keeping things simple I think it's better to live with that instead of refactoring a shared library out of it and then use heavy-duty meta-programming Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19334
2019-03-10port to std::stable_sortLaurent Montel
2018-05-14Remove duplicated entryAntonio Larrosa
Summary: This gave a warning when running the script, and the value was overwritten a few lines below, so just remove the unused value. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12845
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-02-03Fix all 'explicit constructor' krazy warningsElvis Angelaccio
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2017-07-28Use https for knsrc providersDavid Edmundson
CCBUG: 382820
2017-03-14make services GHNS work with store.kde.orgMarco Martin
Summary: point the knsrc providers file to the new kde store, and port the servicemenuinstallation/servicemenudeinstallation scripts to kf5 (they still were based on kde4-config) BUG:376922 Test Plan: downloaded some service menus (send to telegram, convert svg) by the knewstuff ui available in the services page of config dialog they get installed in the proper folder and work, uninstall works Reviewers: #dolphin, emmanuelp Reviewed By: #dolphin, emmanuelp Subscribers: elvisangelaccio Differential Revision: https://phabricator.kde.org/D5035
2016-06-18Look for kfileitemaction plugins in the expected subfolderElvis Angelaccio
For a rationale, see https://git.reviewboard.kde.org/r/128225/
2016-06-08Load KFileItemAction plugins with json metadataElvis Angelaccio
REVIEW: 128088
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2014-11-03Q_DECL_OVERRIDELukáš Tinkl
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-10Clean includes + port to QMenuMontel Laurent
2014-10-07kdelibs4support--Montel Laurent
2014-10-01Ported Dolphin away from KStandardDirsEmmanuel Pescosta
removed unused mirroredDirectory method REVIEW: 120194
2014-09-26Make constants const, avoids unnecessary symbols in the .data section.Volker Krause
2014-09-12Ported KIcon to QIconEmmanuel Pescosta
REVIEW: 120159
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-05dolphin: convert statusbar, settings and search to qt5 signals/slot syntaxAlex Richardson
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2013-06-21Revert "Hide context menu plugins unless enabled by default or by the user"Sune Vuorela
This reverts commit b1aebb44d6863951841d857b84253a782d4138dc. As agreed with Frank on k-c-d.
2013-05-29Hide context menu plugins unless enabled by default or by the userFrank Reininghaus
REVIEW: 110685
2012-04-08Layout improvements for settingsPeter Penz
- Handle 'Context Menu' settings as part of the services - Handle 'Version Control' settings as part of the services - Move the confirmations-settings into own tab - Use combobox for view-property settings - A lot of minor spacing cleanups
2011-03-02Better servicemenu(de)installationJonathan Schmidt-Dominé
2011-02-27Allow to configure thumbnail-pluginsPeter Penz
Adjust the preview-settings to allow users to configure thumbnail-plugins. For consistency also the service-settings have been adjusted to use the ServiceModel and ServiceItemDelegate.
2011-02-04Update e-mail address from [email protected] to [email protected]Peter Penz
2011-02-04Don't use the submodule-path for Qt-includes on application-levelPeter Penz
Also some KDE-includes have been capitalized
2011-02-04Use capitalized KDE includesPeter Penz
2010-11-10Don't try to apply the services-settings, if they have not even been shown. ↵Peter Penz
This fixes the issue that the version-control settings get reset when changing another setting. svn path=/trunk/KDE/kdebase/apps/; revision=1195364
2010-11-03Use a ':' as end of the label instead of a '.', even if the label is ↵Peter Penz
top-aligned. svn path=/trunk/KDE/kdebase/apps/; revision=1192621
2010-10-25- Add support for file item actions (see http://reviewboard.kde.org/r/5659/)Peter Penz
- Internal cleanups of DolphinContextMenu code svn path=/trunk/KDE/kdebase/apps/; revision=1189651
2010-07-24Sourcecode hierarchy cleanup: Move files from khns to settings/services ↵Peter Penz
(step 1/2) svn path=/trunk/KDE/kdebase/apps/; revision=1154135
2010-07-24Sourcecode hierarchy cleanup: Use subfolders inside the "settings" folderPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=1154129