┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/settings/viewmodes
AgeCommit message (Collapse)Author
2023-02-05Add clang-format and format code as in FrameworksSerg Podtynnyi
2022-10-27Change the full row highlight checkbox to radiobuttonsFelix Ernst
This commit changes how the setting to switch between full row highlight and the old way of only having the icons and names be activatable in details mode is presented on the settings page. Before this commit a singular checkbox is used that talks about the highlight effect. But the highlight effect isn't actually what users should be interested in. They mostly care how much of the area can be used to activate an item. To make this clear this commit uses radio buttons instead that give a distinctive choice between activation areas.
2022-10-27Make details view mode's full row activation optionalFelix Ernst
In d3839617193e92463806580699caa595c892b8a6 the details view mode was changed in a way that made the full row of an item the click target instead of only having the item's icon and text be the representative clickable area of an item. This commit makes this new behaviour optional through a setting which can be changed in Dolphin's settings dialog. The explanation for introducing yet another setting in this case is as follows: While the introduced change is an improvement for many typical workflows, there are some workflows for which this new behaviour is problematic. Quite prominently a usage of Dolphin that tries to maximise information density is made worse by the change because now side padding is necessary to click the view's background. While the side padding is and was optional, disabling it made switching the active view in split view mode more difficult among other things. For a more complete discussion about the issues, please check out the bug report(s) and the discussion in Dolphin's gitlab issue with number 34. Co-authored-by: Ivan Čukić <[email protected]> BUG: 453700 FIXED-IN: 22.12
2022-09-26Remove unused includesLaurent Montel
2022-05-31Fix build with Qt6 QFont::setWeight()Ahmad Samir
In Qt5 it takes an int, in Qt6 it takes a QFont::Weight.
2022-05-31Migrate old custom view font config entriesAhmad Samir
2022-05-31Simplify custom font settingsAhmad Samir
Instead of having 3 separate config keys, use the KConfig QFont de/serilaization.
2021-12-13Drop now unneeded QOverload statementsAlexander Lohnau
By defining the KF_DISABLE_DEPRECATED_BEFORE_AND_AT and QT_DISABLE_DEPRECATED_BEFOREvalues, the deprecated overloads are hidden. This way we only have the un-deprecated one visible.
2021-11-03Port ViewModeSettings from macros to std::variantFelix Ernst
Macros should be avoided if possible. Instead this commit replaces the usage of macros with an std::variant of the ViewModeSettings. As part of this cleanup, code that belongs to the VideModeSettings class is moved there. Some parameters are also renamed to be more in line with typical naming conventions.
2021-02-09Build with QT_NO_KEYWORDSNicolas Fella
2020-12-24Details View: display dates as relative Short datesMéven Car
CCBUG: 340982
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-10-23Compile without foreachAlexander Lohnau
2020-08-26Merge branch 'release/20.08' into masterElvis Angelaccio
2020-08-25Fix nullptr crash on WindowsAlexander Lohnau
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-05-08Prevent crash in WindowsMéven Car
Summary: https://phabricator.kde.org/D25335#664304 Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29470
2020-05-04[Details mode] Allow to fill the column size of directories with actual sizeMéven Car
Summary: Allow to compute the recursive size of directories to fill the details view size column. A setting allow to set a limit to the recursive level, allowing the user to have some power over the setting. When sorting by size and the feature is on, we get progressive ordering as the directory size are gathered. KDirectoryContentsCounter uses a cache internally to keep results so that it can display directory size faster, but counts the dir size of directories each time it is asked to count the size a directory nevertheless and when the size has changed, it is updated. KDirectoryContentsCounter uses one worker per instance only, meaning one process per view makes the disk spin. FIXED-IN: 20.08 BUG: 190580 BUG: 158090 Test Plan: With some recursion allowed: {F8267580} Without any recursion allowed (default): {F8267581} Reviewers: elvisangelaccio, ngraham, #dolphin Reviewed By: elvisangelaccio, ngraham, #dolphin Subscribers: feverfew, anthonyfieroni, iasensio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25335
2020-03-31Revert "Port deprecated signal (qt5.15)"Aleix Pol
This reverts commit e545efee73a869aef4276baef0535169f03933de.
2020-02-16Port deprecated signal (qt5.15)Laurent Montel
2020-01-06Don't use nullptr for flag. Just use default argument hereLaurent Montel
2019-05-05Get rid of ugly static_cast usages in connect() callsElvis Angelaccio
2019-02-27remove deprecated methodsLaurent Montel
2018-07-05Modernize Settings windowNathaniel Graham
Summary: This patch modernizes the appearance of Dolphin's configuration window by following the KDE HIG as much as possible and following design cues from Plasma and System Settings. Test Plan: Tested all settings to make sure they still work; they do. Startup page, before: {F5825313} Startup page, after: {F5918574} View page (Icons), before: {F5825319} View page (Icons) after: {F5918575} View page (Compact), before: {F5825321} View page (Compact) after: {F5918700} View page (Detailed), before: {F5825323} View page: (Detailed), after: {F5918701} Navigation page: no change Trash page, before: {F5858748} Trash page, after: {F5866656} (Provided by {D12986}) General page (behavior), before: {F5825316} General page (behavior) after: {F5918572} General page (confirmations), before: {F5866885} General page (confirmations), after: {F5918702} General page (status bar): no change Reviewers: #dolphin, #vdg, broulik, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: fabianr, cfeck, medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12571
2018-06-27Port from KComboBox to QComboBoxNathaniel Graham
Summary: None of Dolphin's current usages of `KComboBox` use any of its additional features beyond `QComboBox`, so let's use `QComboBox` instead. Test Plan: Tested all features that use comboboxes in Dolphin. No visual or functional changes or regressions. Reviewers: #dolphin, elvisangelaccio, broulik Reviewed By: #dolphin, elvisangelaccio Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13749
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-02-13Merge branch 'Applications/17.12'Elvis Angelaccio
2018-02-13Fix resetting "View Modes" preferences to defaultsRobert Hoffmann
Summary: Removed call to settings.readConfig() in ViewSettingsTab::loadSettings(), because it overwrites default settings with user settings even if called from ViewSettingsTab::restoreDefaultSettings(). Test Plan: Settings -> Configure Dolphin -> View Modes: Choose "Custom Font", "Choose...": other font settings than preselected; alter "Icon Size" slider positions; click OK; OK; note modified text font next to icons, icon sizes Settings -> Configure Dolphin -> View Modes: Click "Defaults" check "Font" is reset to "System Font"; check "Icon Size" slider positions are reset to default positions; click OK check text font next to icons, icon sizes are reset to defaults Subscribers: ltoscano, ngraham, elvisangelaccio, michaelh, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D10190
2018-02-03Fix all 'explicit constructor' krazy warningsElvis Angelaccio
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2017-07-21Don't add null widget to layoutElvis Angelaccio
m_expandableFolders is created only in DetailsMode. This fixes a QLayout runtime warning.
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-02-26Port away from KDELibs4Support (we only use KDELibs4Support when baloo isn't ↵Emmanuel Pescosta
present, because KFileMetaDataWidget is in KDELibs4Support) Reviewed-By: Vishesh Handa
2015-02-03Ported Dolphin from KDialog to QDialog and save/restoreDialogSize to ↵Emmanuel Pescosta
KWindowConfig::save/restoreWindowSize with the help of the porting scripts. REVIEW: 122305
2014-12-14use save() instead of writeConfig()Emmanuel Pescosta
2014-12-14port from KTabWidget to QTabWidgetEmmanuel Pescosta
2014-11-03Q_DECL_OVERRIDELukáš Tinkl
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-07kdelibs4support--Montel Laurent
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-05dolphin: convert statusbar, settings and search to qt5 signals/slot syntaxAlex Richardson
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2012-08-13Show icon size as tooltip when adjusting icon sizeJekyll Wu
BUG:292700 FIXED-IN: 4.10.0 REVIEW: 105990
2012-04-14Allow to optionally limit the maximum number of text linesPeter Penz
Showing the whole filename unclipped seems to be a good default, however for users with a lot of files that have extremely long names this might get a problem especially in the icons-view. - Allow to limit the maximum number of lines in the icons-view - Allow to specify a maximum width in the compact-view (No limit is required for the details-view, as the name is shortened automatically to show other columns) BUG: 288596 FIXED-IN: 4.9.0
2012-04-08Layout improvements for settingsPeter Penz
- Handle 'Context Menu' settings as part of the services - Handle 'Version Control' settings as part of the services - Move the confirmations-settings into own tab - Use combobox for view-property settings - A lot of minor spacing cleanups
2012-03-09Provide UI-option for "Expandable folders"Peter Penz
CCBUG: 289090
2012-03-09Details view: Allow to turn off expandable folders like in Dolphin 1.7Peter Penz
The option for turning off expandable folders has been removed with the new view-engine. Due to several requests this option has been readded again. As for 4.8.x no new user-interface strings may be introduced, the line ExpandableFolders=false must be manually added below the section "[DetailsMode]" in the file ~/.kde/share/config/dolphinrc if the expandable-folders feature should be disabled. Thanks to H.H. "cyberbeat" for the initial patch! BUG: 289090 FIXED-IN: 4.8.2
generated by cgit v1.3 (git 2.53.0) at 2026-04-23 10:01:09 +0000