┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/settings/viewpropertiesdialog.cpp
AgeCommit message (Collapse)Author
2018-07-14Modernize View Properties windowNathaniel Graham
Summary: Like D12571, but for the {nav View Properties} Window. Also did a little bit of re-organization. This allows us to use a `QFormLayout` as the top-level layout and simplify the code a lot, including no longer using the now-unnecessary paradigm of putting a layout inside a `QWidget`, and ending the use of `QGridLayout` to make a fake and more complicated form-style layout. Depends on D13749 Test Plan: Window still resizes properly when the Additional Information content is shown or hidden. Global view properties, additional information hidden: {F6035943} Global view properties, additional information shown: {F6035945} Per-folder view properties, additional information hidden: {F6035869} Per-folder view properties, additional information shown: {F6035870} Reviewers: #dolphin, elvisangelaccio, broulik, #vdg Reviewed By: #dolphin, elvisangelaccio Subscribers: abetts, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13768
2018-06-27Port from KComboBox to QComboBoxNathaniel Graham
Summary: None of Dolphin's current usages of `KComboBox` use any of its additional features beyond `QComboBox`, so let's use `QComboBox` instead. Test Plan: Tested all features that use comboboxes in Dolphin. No visual or functional changes or regressions. Reviewers: #dolphin, elvisangelaccio, broulik Reviewed By: #dolphin, elvisangelaccio Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13749
2018-06-26Use collapsible box to configure visible rolesElvis Angelaccio
Summary: A modal dialog that opens another modal dialog is bad UX and should be avoided whenever possible. These days we have `KCollapsibleGroupBox` that can be used to show advanced settings without cluttering the default layout. This change removes the `AdditionalInfoDialog` and uses a collapsible groupbox instead. The `Apply` buttons gets enabled whenever a role gets checked or unchecked, consistently with the existing checkboxes. Test Plan: Change visible roles in the view properties dialog. Reviewers: #dolphin, #vdg Reviewed By: #vdg Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13569
2018-06-13ViewPropertiesDialog: disable Apply button on startupElvis Angelaccio
We call `markAsDirty(false)` at the end of `loadSettings()` but that's not enough, because `m_isDirty` is initialized to false (as it should be). This means `isDirtyChanged` is not emitted and the button is not disabled. By disabling it explicitly, we make it consistent with the Apply button in the settings dialog (which is also initially disabled).
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Modernize the syntax of shortcutsRoman Inflianskas
Reviewers: #dolphin, markg Reviewed By: markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10986
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-01-21Change "Date" to "Modified" and allow access to new "Accessed" time fieldDon Nguyen
This is merge of #128964 and #128942. This will impelement changing the "Date" field to "Modified" and allow a new "Accessed" time field to be available. This also includes changes to update configuration files. REVIEW: 129077
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-09-25Fix layout of ViewPropertiesDialogDavid Rosca
In case of GlobalViewProps, propsBox == this and it already has layout. REVIEW: 125373
2015-02-26Port away from KDELibs4Support (we only use KDELibs4Support when baloo isn't ↵Emmanuel Pescosta
present, because KFileMetaDataWidget is in KDELibs4Support) Reviewed-By: Vishesh Handa
2015-02-03Ported Dolphin from KDialog to QDialog and save/restoreDialogSize to ↵Emmanuel Pescosta
KWindowConfig::save/restoreWindowSize with the help of the porting scripts. REVIEW: 122305
2014-12-14use save() instead of writeConfig()Emmanuel Pescosta
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-01Ported Dolphin away from KStandardDirsEmmanuel Pescosta
removed unused mirroredDirectory method REVIEW: 120194
2014-06-29Remove the automoc noiseChristophe Giboudeaux
2014-05-05dolphin: convert statusbar, settings and search to qt5 signals/slot syntaxAlex Richardson
2014-05-05Allow compiling Dolphin with KF5Alex Richardson
This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395
2014-02-06Port Dolphin to BalooVishesh Handa
Nepomuk is being replaced with Baloo
2012-10-15Port Dolphin from Nepomuk to Nepomuk2 according to the Nepomuk2Port mini ↵Emmanuel Pescosta
guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port REVIEW: 106825
2012-06-08Fix wrong loading of sort-rolePeter Penz
2012-04-21Prepare view-engine for non-KFileItem usecasePeter Penz
Up to now the view-engine only provided a model-implementation that supports file-items. The view-engine always had been designed to be able to work with any kind of model, so now a KStandardItemModel is available. The plan is to convert the places panel to the new view-engine. It should be no problem to fix this until the feature freeze - in the worst case the places-panel code could be reverted while still keeping the KStandardItemModel changes.
2012-03-13Remove RolesInfoAccessorPeter Penz
Now KFileItemModel provides a way to access the available roles including their translations. Note that the 3 roles "comments", "rating" and "tags" have not been implemented yet in KFileItemModel and turning them on does not work currently.
2012-03-11First step to introduce dynamic rolesPeter Penz
Currently Dolphin is only capable of showing a fixed number of roles (e.g. name, size, date, owner, ...). Dolphin 2.1 should support also other roles like rating, tags, comments or other meta-information of images or audio-files. To support this the sorting-type and additional-type from DolphinView has been replaced by a role-type represented as QByteArray.
2011-11-06Show compact-mode icon also in KonquerorPeter Penz
Additionally a broken signal-connection has been fixed.
2011-11-06Delete obsolete class DolphinSettingsPeter Penz
2011-11-06Fix issues with applying wrong view-modePeter Penz
- The view properties dialog mixed the details-view with the compact-view (#285848). - The view properties have been reset when applying a setting from the "Dolphin Preferences" dialog. The rootcause was that the obsolete DolphinSettings class implemented the saving in a wrong way because of the recent refactoring (will remove this class completely now to prevent such issues in future). BUG: 285848 FIXED-IN: 4.8.0
2011-10-15Interface cleanups to prepare the return of "grouped sorting"Peter Penz
- Rename setCategorizedSorting() to setGroupedSorting() - Change the model interface to allow enabling/disabling grouping without the need to declare a role (the sort role will be taken). - Add dummy group role implementation in KFileItemModel The grouping code itself requires some cleanups and might crash at the moment or lead to weird layouts.
2011-09-02Simplified code for the viewmode settingsPeter Penz
2011-07-30Merged very early alpha-version of Dolphin 2.0Peter Penz
Dolphin 2.0 will get a new view-engine with the following improvements: - Better performance - Animated transitions - No clipped filenames due to dynamic item-sizes - Grouping support for all view-modes - Non-rectangular selection areas - Simplified code for better maintenance More details will be provided in a blog-entry during the next days. Please note that the code is in a very early alpha-stage and although the most tricky parts have been implemented already very basic things like drag and drop or selections have not been pushed yet. Those things are rather trivial to implement but this still will take some time.
2011-02-09Coding style update for pointer comparisonPeter Penz
Most developers seem to prefer if (ptr) ... if (!ptr) ... in comparison to if (ptr != 0) ... if (ptr == 0) ... Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
2011-02-04Don't use the submodule-path for Qt-includes on application-levelPeter Penz
Also some KDE-includes have been capitalized
2011-02-04Use capitalized KDE includesPeter Penz
2010-07-24Sourcecode hierarchy cleanup: Move further files from src to src/viewsPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=1154150
2010-07-24Sourcecode hierarchy cleanup: Create folder "views" and move view related ↵Peter Penz
sources to it svn path=/trunk/KDE/kdebase/apps/; revision=1154146
2010-05-14Use the AdditionalInfoAccessor to be flexible for future changes/extensions ↵Peter Penz
in KFileItemDelegate. svn path=/trunk/KDE/kdebase/apps/; revision=1126703
2010-02-05Be more clear that selecting the checkbox means, that the shown view ↵Peter Penz
properties should be used as default (that only "new folders" are affected, is incorrect). BUG: 213354 svn path=/trunk/KDE/kdebase/apps/; revision=1085564
2010-01-20- Fix minor typosDarío Andrés Rodríguez
"sub folders" -> "sub-folders" BUG: 198084 svn path=/trunk/KDE/kdebase/apps/; revision=1077615
2009-05-26fixed krazy issues (see http://www.kdedevelopers.org/node/3919)Peter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=973269
2009-04-20Let the user choose if folders are always shown first in the views ofFrank Reininghaus
Dolphin and Konqueror (the default) or not. This setting can be changed in the View menu: "View->Sort By->Folders First". FEATURE: 62007 svn path=/trunk/KDE/kdebase/apps/; revision=956820
2009-03-03§$%$ revert last commit, this does not compile (sorry!)Peter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=934823
2009-03-03SVN_SILENT: coding style fixPeter Penz
svn path=/trunk/KDE/kdebase/apps/; revision=934820
2009-02-17The tab order of the View Properties Dialog now moves in a logical and ↵Shaun Reich
coherent manner (it no longer skips out of order). svn path=/trunk/KDE/kdebase/apps/; revision=927483
2009-02-16I forgot to change these connection statements to both send and receive ↵Shaun Reich
boolean values in my prior commit(s). Now the View Properties Dialog will enable the apply button when the affected (4) widget values are changed. svn path=/trunk/KDE/kdebase/apps/; revision=926757
2009-02-15The View Properties dialog now correctly disables/enables the Apply button, ↵Shaun Reich
instead of it just being enabled all the time, even after you apply it, so it's similar to the Settings Dialog now. svn path=/trunk/KDE/kdebase/apps/; revision=926562
2009-02-14Changed connections of the signals activated(), to currentIndexChanged() as ↵Shaun Reich
used in 3 QComboBoxes. Remember that activated() is not always triggered when the selected item is changed. svn path=/trunk/KDE/kdebase/apps/; revision=926180
2009-01-14Group classes into folders, Dolphin is too big in the meantime for having a ↵Peter Penz
flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later. svn path=/trunk/KDE/kdebase/apps/; revision=911065