┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/statusbar
AgeCommit message (Collapse)Author
2024-05-30Offer installing Filelight if no disk usage analyzer was foundNicolas Fella
This avoids an empty menu and points the user towards a useful tool BUG: 477739
2024-03-23Avoid wrapping text in the status barEugene Popov
The size of the status bar isn't intended to display multiline text.
2024-03-13Animate most of the barsFelix Ernst
When a bar is toggled visible this usually happens because the user might want to use its functionality now. However, if bars appear without animation or at a location the user is not currently looking at, they might not notice that they have appeared at all. An animation makes it more likely that the user notices the change and can then use the newly made visible component. Another reason for animations for showing or hiding of components is that it can be disorienting for users when panels or bars suddenly appear or disappear without animation. There is no visible movement then, so the user might not know what happened if they didn't concentrate or blink at that moment. The newly appearing or disappearing component might also displace other components which can make it difficult to find what one was just looking at. These bars animate now after this change: - Search panel - Filter bar - Status bar This is implemented by extracting the animation code from SelectionMode::TopBar into a new abstract base class AnimatedHeightWidget. This class is now also used in SelectionMode::BottomBar and the animating code there was removed. These bars are left in Dolphin that stay without animation: - Menu bar (Would probably need to be implemented in KXmlGui) - Tool bar (Would probably need to be implemented in KXmlGui) - Tab bar (Needs a different appraoch because it already inherits QTabBar and therefore can not inherit AnimatedHeightWidget)
2024-01-12Explain free space button usage in tooltipFelix Ernst
This is to make sure that users do not have to guess why they would want to press the button.
2023-12-28Add separator in Dolphin Status BarCarl Schwan
See https://invent.kde.org/plasma/breeze/-/merge_requests/390 for explanation and screenshots
2023-11-24Reduce status bar minimum widthFelix Ernst
This is to make sure that when the window is resized it is less likely that the places panel will be resized only because the status bar doesn't want to become very narrow in width.
2023-11-24Turn free space label into a flat buttonFelix Ernst
The usage of a label to show this space information is problematic because there are features/actions hidden behind clicking the label. A button makes this clear. It also fixes the accessibility of this control because previously this info would never be read out by screen readers as it couldn't get keyboard focus. A side-effect of this change is that the free disk space bar looks more normal with non-Breeze styles. This had been a long-standing issue.
2023-11-10Adapt to frame change in BreezeCarl Schwan
Reduce margins in some places, make the dolphinstatusbar use a QStatusBar style, and mark the kitemlistcontainer as no frame
2023-11-08Port away from KMoreToolsNicolas Fella
The idea behind KMoreTools was to point the user at external tools for a given job. It provides a rather complex framework for that, including suggesting not-yet-installed tools. The UX behind that isn't great though, which somewhat deep menu hierarchies and a somewhat arbitrary list of tools. Most KDE apps have moved away from it, with only Dolphin remaining. Instead provide direct integration with relevant KDE tools (Filelight, KDiskFree, KFind)
2023-10-24Merge branch 'master' into kf6Nicolas Fella
2023-10-18Never show status bar context menu away from status barFelix Ernst
The status bar context menu was hard-coded to always appear at the cursor position. However, context menus can also be triggered by keyboard, for example with the Menu key, in which case it makes no sense to show the context menu at whatever random position the mouse cursor currently is. Instead invoke the context menu in the middle of the status bar when it is opened by keyboard.
2023-07-27Minor code improvementMéven Car
NO_CHANGELOG
2023-07-26Update following removing of KIO::FileSystemFreeSpaceJob::result overloadMéven Car
NO_CHANGELOG
2023-07-05Add explicit moc includes to sources for moc-covered headersFriedrich W. H. Kossebau
* speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods
2023-02-05Add clang-format and format code as in FrameworksSerg Podtynnyi
2022-09-26Remove unused includesLaurent Montel
2022-05-18Add tooltip to free space info widget showing full disk capacityShubham
BUG: 452867 FIXED-IN: 22.08
2022-05-13Drop KNS3 prefix for KMoreTools includesAlexander Lohnau
In KF6 KMoreTools should become it's own library and thus the KNS3 prefix should get removed. Considering that the classes are not in any namespace, having a namespaced include is not needed and only causes noise.
2021-11-29[Status Bar] Don't mess with status bar visibility in extensionsKai Uwe Broulik
"Extensions" is additions to the status bar like free space bar and zoom slider which should hide while loading. The status bar itself should only show/hide based on the global setting. BUG: 443132
2021-04-07Add option to hide entire status barMichael Lang
2021-02-14[Status Bar] Hide zoomLabel also in menu handlerKai Uwe Broulik
2021-02-09Build with QT_NO_KEYWORDSNicolas Fella
2021-01-23Make zoom slider and free space bar a little smaller by defaultNate Graham
This makes more room for the new explanatory label for the zoom slider. The zoom slider in particular was huge, and probably would have stood to be reduced in width anyway even if we didn't add an explanaory label.
2021-01-23Add explanatory label to status bar's icon size sliderNate Graham
Right now the slider has no label. Let's add one so it's clear what it does. BUG: 429255 FIXED-IN: 21.04
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-08-23Fix 'show space' setting not being re-appliedNazar Kalinowski
BUG: 425542
2020-06-08Status bar: Hide the space free bar when size is unknownMéven Car
Summary: BUG: 420027 BUG: 422226 FIXED-IN: 20.08 Test Plan: {F8312398} Reviewers: #dolphin, ngraham, broulik, #vdg, elvisangelaccio Reviewed By: #dolphin, ngraham, #vdg, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29213
2020-05-31[DolphinStatusBar] Fix free space info height with bigger fontsAhmad Samir
When the font height is more than the zoom slider height, use the former to set the fixed height of the free space widget on the status bar. Otherwise the text is cut-off. This works with Breeze, Oxygen and Fusion styles.
2019-11-09Remove unnecessary semicolons after Q_UNUSEDElvis Angelaccio
GIT_SILENT
2019-11-09[Status Bar] Remove file status Timer, add text update delayMéven Car
Summary: Currently when hovering over a file we have its name, mimetype type and size display in the status bar for 1 second, after which the status of the folder is displayed. This patch removes this timer making the status bar behavior more predictable and user friendly. Instead there is a 50ms delay between when the status bar gets new text to display (for instance mouse hovering or keyboard navigation) and when the status bar displayed text is updated. This is to avoid flickering. FIXED-IN: 19.12 BUG: 399267 Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25218
2019-06-23Add "What's This?" to nearly everything in the main windowFelix Ernst
Summary: This commit adds "What's This?" help to nearly everything in the Dolphin main window (panels, views, buttons, ...). It adds the "?" to the title bar so this help can easily be called. For links in those help texts to work the WhatsThisClickedEvents are handled in the main window class. This doesn't work for menus because events from them aren't forwarded to the main window for some reason so EventFilters are installed for the Control button menus. Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter can be installed in the menubar. Therefore help texts without links are provided for the menubar. Test Plan: Check if the event handling might make any problems. Check for any big mistakes in the help messages. Reviewers: #dolphin, elvisangelaccio Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20471
2019-01-15Drop unused includesElvis Angelaccio
GIT_SILENT
2018-10-25Fix minor typosYuri Chornoivan
2018-10-09[MountPointObserverCache] Update mounts less frequentlyKai Uwe Broulik
Even on fastest disks, filling up the disk in 10 seconds is unlikely. Moreover, Plasma's "low disk" warning only polls every minute as well and Dolphin doesn't warn you about the fact that it's full. Reduces needless wake ups of disks and network. CCBUG: 398612 Differential Revision: https://phabricator.kde.org/D15507
2018-09-19Update disk space info on refreshKai Uwe Broulik
When explicitly refreshing the view (e.g. F5) also refresh disk space info. This would also allow us to raise the refresh interval somewhat. CCBUG: 398612 Differential Revision: https://phabricator.kde.org/D15508
2018-06-03Drop obsolete version checksElvis Angelaccio
We already depend on KF5 >= 5.43
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-02-04Fix all krazy #include warningsElvis Angelaccio
- "include own header first line" - "put config.h in angle brackets line" - "do not include QtModule/QtClass line" `QElapsedTimer` was implicitly included by kfileitemmodelsortalgorithm.h, now we need to explicitly include it in kfileitemmodel.cpp. We also need to explicitly link to `Qt5::Concurrent`, otherwise we cannot `#include <QtConcurrentRun>`.
2018-02-03Fix all 'explicit constructor' krazy warningsElvis Angelaccio
2017-11-25Use kSqueezedTextLabel for the label text on the statusbarAhmad Samir
Summary: Following up from D8927; use kSqueezedTextLabel for the label text on the statusbar: - This simplifies the code in updateLabelText() - Remove the eventFilter as it's not needed any more since kSqueezedTextLabel has a resizeEvent function - Specify a stretch factor, 1, for m_label, m_zoomSlider and m_spaceInfo, this prevents the changing of the width of m_label when the label text is updated from changing the widths of the zoomSlider and the spaceInfo widgets as that is a bit too jumpy. (Thanks to the code of konversation statusbar for the hint about using the stretch factor in addWidget()). Reviewers: elvisangelaccio Subscribers: elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D8991
2017-11-21Elide the label text on the statusbar in the middleAhmad Samir
Summary: BUG: 387189 Currently the label text on the statusbar is elided in on the right, but that means that when the text gets elided the size of the file isn't shown. The label text on the statusbar shows the file name, the mime type and the size; the name is already shown in the main window and the mimetype can usually be guessed from the icon or from the extension, so it's usually the size that the user wants to see on the statusbar. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, anthonyfieroni Differential Revision: https://phabricator.kde.org/D8927
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2017-11-07Add more whitespace to the status barDiego Gangl
Summary: This patch gives the status bar a little more vertical whitespace, prevents the status bar from "jumping up and down" when showing a progress bar, and adds a bit of padding on the sides so the labels are more clearly separated when using dual panes. Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio Differential Revision: https://phabricator.kde.org/D8540
2017-07-13Fix knewstuff popup menu position on waylandElvis Angelaccio
On Wayland we need to pass a parent to popup menus. See https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Popup_Menus So we use the new setParentWidget() method from KNewStuff (introduced in Frameworks 5.37).
2017-03-10Show pointing hand cursor when hovering spaceinfo barElvis Angelaccio
Summary: This improves the discoverability of the diskspace menu, a feature otherwise almost impossible to find. Reviewers: gregormi, emmanuelp Differential Revision: https://phabricator.kde.org/D4873
2016-06-25add_definitions(-DQT_NO_URL_CAST_FROM_STRING) + fix compilationDavid Faure
This fixes some URLs built from local paths without scheme.
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
generated by cgit v1.3 (git 2.53.0) at 2026-04-23 03:14:15 +0000