| Age | Commit message (Collapse) | Author |
|
Rather than reloading the view after it is initilised, we just wait
until the view emits its finishedPathLoading() signal. This saves some
time when running the tests (at least on my system).
|
|
This has been committed by accident in 06dd174f.
|
|
Many tests have to wait until this signal is received from the
DolphinView, so it is convenient to have a function that wraps
the QTest::kWaitForSignal() call.
|
|
|
|
This commit changes mainly two things:
1. The functionality related to the handling of temporary files and
folders is moved to a new class TestDir.
2. The setup of a temporary folder and of DolphinView instances is
now done in each unit test function. A benefit of this change is that
there are no unwanted interactions between different unit test functions
any more. Moreover, different test functions could now share a test
folder more easily.
Additionally, the reference arguments of all functions are changed to
pointers for consistency.
|
|
Most developers seem to prefer
if (ptr) ...
if (!ptr) ...
in comparison to
if (ptr != 0) ...
if (ptr == 0) ...
Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
|
|
|
|
|
|
In particular, tests for changing the zoom level and for saving and
restoring the view state.
svn path=/trunk/KDE/kdebase/apps/; revision=1217270
|
|
Up to now, some Columns View tests that need a folder to be displayed
in the view only passed if they were run first: The first test always
passed, and if a test name was passed on the command line, such that
only this test would be run, this test would work as well. In other
cases, the view was empty, not showing the items in the folder.
The problem is worked around by creating a new DolphinView before each
test in the case of the Columns View. Added a TODO comment to make me
remember to look into this again at some point.
svn path=/trunk/KDE/kdebase/apps/; revision=1217260
|
|
The test assumes that the view does not have the keyboard focus
initially. However, this may not be the case if this is the only test
to be executed (i.e., if testKeyboardFocus is passed to the test
executable on the command line). This commit transfers the keyboard
focus explicitly to another widget.
svn path=/trunk/KDE/kdebase/apps/; revision=1217251
|
|
related to the folder view properties.
svn path=/trunk/KDE/kdebase/apps/; revision=1216359
|
|
DolphinView::hasSelection() provides a valid return-value. This looks like an issue in Qt, but I did not have the time yet to provide a Qt-only example for a bug-report :-(
svn path=/trunk/KDE/kdebase/apps/; revision=1213199
|
|
proxy model to DolphinView. By this it will be easier later to replace the traditional QAbstractItemViews by any kind of other implementation (e.g. based on QGraphicsView/QML).
svn path=/trunk/KDE/kdebase/apps/; revision=1213189
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1210710
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1210707
|
|
2. Reduce the time out for the finishedPathLoading signal.
svn path=/trunk/KDE/kdebase/apps/; revision=1202815
|
|
DolphinView. The main testing code is inside an abstract base
class. Three classes inherit this base class and do the actual testing
in one view mode each.
svn path=/trunk/KDE/kdebase/apps/; revision=1202157
|