┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/tests/testbase.cpp
AgeCommit message (Collapse)Author
2011-04-14Improve stability of unit tests when running them with ValgrindFrank Reininghaus
I noticed unexpected unit test failures when running the tests with Valgrind. The reason was that test execution was slowed down a lot, such that that TestBase::waitForFinishedPathLoading() did not receive the view's signal within the default timeout of 2 seconds, and that this failure was not detected in every test -> the tests failed later on because not all expected items had been loaded yet. To fix this, I changed two things: 1. Added an assert in TestBase::waitForFinishedPathLoading() that checks if the signal has been received. Continuing does not make much sense if that is not the case. 2. Increased the default timeout to 20 seconds. The reason why there is a finite timeout at all is that I didn't want to waste too much time on machines where the file kioslave seems to have problems loading a directory (I've seen corresponding test logs at cdash.org). However, with the first change I mentioned above, the waiting time is lost only once (due to the assert) rather than every time a directory is loaded -> I think that the timeout increase does not lead to an increased waste of time on such machines.
2011-04-12Implement a cut/copy/paste unit test for DolphinView.Frank Reininghaus
2011-04-05Add function TestBase::waitForFinishedPathLoading()Frank Reininghaus
Many tests have to wait until this signal is received from the DolphinView, so it is convenient to have a function that wraps the QTest::kWaitForSignal() call.
2011-04-03Dolphin unit test refactoringFrank Reininghaus
This commit changes mainly two things: 1. The functionality related to the handling of temporary files and folders is moved to a new class TestDir. 2. The setup of a temporary folder and of DolphinView instances is now done in each unit test function. A benefit of this change is that there are no unwanted interactions between different unit test functions any more. Moreover, different test functions could now share a test folder more easily. Additionally, the reference arguments of all functions are changed to pointers for consistency.
2011-02-04Use capitalized KDE includesPeter Penz
2011-01-22Add a unit test that checks the DolphinView functionality that isFrank Reininghaus
related to the folder view properties. svn path=/trunk/KDE/kdebase/apps/; revision=1216359
2011-01-09Encapsulate the creation and handling of the directory lister, the model and ↵Peter Penz
proxy model to DolphinView. By this it will be easier later to replace the traditional QAbstractItemViews by any kind of other implementation (e.g. based on QGraphicsView/QML). svn path=/trunk/KDE/kdebase/apps/; revision=1213189
2010-12-021. Also use a time out when waiting for the view's selectionChanged signal.Frank Reininghaus
2. Reduce the time out for the finishedPathLoading signal. svn path=/trunk/KDE/kdebase/apps/; revision=1202815
2010-11-29Use kWaitForSignal to wait until the view has finished reloading. I'veFrank Reininghaus
also added a timeout such that the tests fail rather than hang if the file kioslave dies (which happens sometimes according to some test logs on cdash.org). svn path=/trunk/KDE/kdebase/apps/; revision=1202159
2010-11-091. Add method TestBase::reloadViewAndWait().Frank Reininghaus
2. Remove some debug output from DolphinDetailsViewTest - it seems that the test failure I saw on cdash.org is due to a failing kioslave, which is probably not Dolphin's fault. svn path=/trunk/KDE/kdebase/apps/; revision=1194514
2010-10-29It's easier to put functionality that is used by many unit tests intoFrank Reininghaus
a common base class. I took that idea from Nepomuk's unit tests in kdelibs. svn path=/trunk/KDE/kdebase/apps/; revision=1191051