┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/tests
AgeCommit message (Collapse)Author
2018-10-07[PlacesItemModelTest] More index-related fixesElvis Angelaccio
Again, we cannot assume the Desktop and Downloads places are always around.
2018-10-07[PlacesItemModel] Fix testSystemItems()Elvis Angelaccio
2018-10-07[PlacesItemModelTest] Fix testHideItem()Elvis Angelaccio
2018-10-07[PlacesItemModelTest] Fix testTearDownDevice()Elvis Angelaccio
2018-10-07[PlacesItemModelTest] Fix testDeletePlace()Elvis Angelaccio
If the Desktop or Downloads folder is missing, using 5 as index would be wrong.
2018-10-07[PlacesItemModelTest] Fix testGroups() test caseElvis Angelaccio
The test was also assuming that the Desktop and Downloads folders are always available, which isn't the case.
2018-10-07Follow-up of commit 9760f9607dElvis Angelaccio
Also drop the hardcoded model count all over the place.
2018-10-07[PlacesItemModelTest] Check whether Desktop and Download folders existElvis Angelaccio
KFilePlacesModel creates the Desktop and Downloads bookmarks only if their folder exists. This should hopefully fix the failing test on the CI (actual count = 15, expected count = 17), since the CI runs in docker and probably doesn't have those two folders by default.
2018-10-07Add test cases for enabled status of DolphinNewFileMenuElvis Angelaccio
Summary: Root and Trash test cases are currently failing because of commit e133c4557ecc37ed3f7e1b9418306aa8cc516865. Reviewers: #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16005
2018-06-03Enable test mode in dolphinmainwindowtestElvis Angelaccio
We don't want to use the user configuration files when creating a test instance of DolphinMainWindow.
2018-05-31Fix the test that broke after recent changes to the default Places itemsNathaniel Graham
Test Plan: `ctest`; all tests pass. Reviewers: #dolphin, markg Reviewed By: markg Subscribers: renatoo, kfm-devel, elvisangelaccio, markg Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12464
2018-04-29Bundle dolphinui.rc also in dolphinmainwindowtestElvis Angelaccio
Otherwise the test executable will not be able to find the .rc file while creating a DolphinMainWindow instance. We also need to force the component name to `dolphin`, otherwise kxmlgui will default to the name of the binary (which in this case would be dolphinmainwindowtest rather than dolphin).
2018-04-25DolphinTabPage: deactivate secondary view after closing split viewElvis Angelaccio
We deactivate the previously active view container whenever we change the active split view, but we never do the same when we close the split view. Long term we should probably even delete the secondary view after closing the split view, because it will never be used again and the pointer will be overwritten the next time the user opens the split view.
2018-04-25Merge branch 'Applications/18.04'Elvis Angelaccio
2018-04-25Add failing test case for bug #385111Elvis Angelaccio
Will be fixed by D12446. CCBUG: 385111
2018-04-01Fix detachingElvis Angelaccio
2018-03-11Removed unused variables spotted by clazyElvis Angelaccio
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-02-03Fix -Wunused-result warningsElvis Angelaccio
2018-02-03Port QSignalSpy to new signal syntaxElvis Angelaccio
More compile-time safety. Tests still pass. This also fixes a krazy warning about "normalised signal/slot signatures".
2018-01-26Fix place item edit after creationRenato Araujo Oliveira Filho
Summary: Make sure that the place can be edited after the creation. Depends on D9333 BUG: 389147 Test Plan: Create an item in dolphin places panel, make sure that you can rename it Reviewers: #dolphin, ngraham Reviewed By: ngraham Subscribers: michaelh, elvisangelaccio, lbeltrame, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9985
2018-01-26Make sure that old URLs do not appear duplicated in places modelRenato Araujo Oliveira Filho
Summary: BUG: 389401 KIO model now provides Baloo URLs; we need to remove the old ones created by Dolphin places model BUG: 387888 Depends on D9332 Test Plan: unit test Reviewers: mwolff, #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, broulik, ervin, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9333
2018-01-08Fix PlacesItemModel loading with hidden devicesRenato Araujo Oliveira Filho
Summary: Make sure that hidden devices loaded after module initialization does not appear in the view. Check for item visibility before add it on the model. Test Plan: Unit test created Reviewers: franckarrecot Reviewed By: franckarrecot Subscribers: cfeck, ervin, #dolphin Differential Revision: https://phabricator.kde.org/D9441
2017-12-14Use Kio::KPlacesModel as source model for PlacesItemModelRenato Araujo Oliveira Filho
Summary: Use Kio::KPlacesModel as source model for PlacesItemModel avoiding duplicated code. Depends on D8862 Depends on D8332 Depends on D8434 Depends on D8348 Depends on D8630 Test Plan: Unit test created Reviewers: elvisangelaccio, emmanuelp, mlaurent, mwolff Reviewed By: elvisangelaccio, mlaurent, mwolff Subscribers: mwolff, mlaurent, anthonyfieroni, nicolasfella, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8855
2017-11-27Created unit test for PlacesItemModelRenato Araujo Oliveira Filho
Summary: Make sure that PlacesItemModel is covered by unit test Reviewers: ervin, elvisangelaccio, mwolff Reviewed By: ervin, elvisangelaccio, mwolff Subscribers: mwolff, elvisangelaccio, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8630
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-20Modernize: Use override where possibleKevin Funk
Also use override instead of Q_DECL_OVERRIDE
2017-11-11Prevent folders from drag and dropping onto themselves in dolphin main viewEmirald Mateli
Summary: This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself. The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior. BUG: 307747 Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen. {F3787651} Test Plan: 1. Drag a folder. 2. Drop it onto itself. Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror Tags: #dolphin Differential Revision: https://phabricator.kde.org/D6281
2017-05-27Introduce DolphinMainWindowTestElvis Angelaccio
For now it contains a test case for the crash in bug #379135 CCBUG: 379135 Reviewers: emmanuelp, dfaure Differential Revision: https://phabricator.kde.org/D5936
2017-05-27Move non-exported code to a static libraryElvis Angelaccio
This allows us to speed up the compilation because we don't need to build twice the source files we use in the unit tests. Test Plan: Builds, dolphin works and tests pass. Reviewers: emmanuelp, dfaure Differential Revision: https://phabricator.kde.org/D5935
2017-05-11Port tests from ecm_mark_as_test to ecm_add_testHannah von Reth
Summary: This enables us to run the tests on Windows. Reviewers: elvisangelaccio, kfunk, dfaure Reviewed By: elvisangelaccio Subscribers: #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D5810
2017-05-11Fix kfileitemmodeltestElvis Angelaccio
Commit 6dcbb8127c introduced the isHidden role, update the test accordingly.
2017-05-11Remove define to disable exportsHannah von Reth
As the tests are now correctly linked to dolphinprivate we need the actual export macro.
2017-04-07Fix some compiler warningsKevin Funk
2017-01-21Change "Date" to "Modified" and allow access to new "Accessed" time fieldDon Nguyen
This is merge of #128964 and #128942. This will impelement changing the "Date" field to "Modified" and allow a new "Accessed" time field to be available. This also includes changes to update configuration files. REVIEW: 129077
2017-01-18Remove extra semicolonElvis Angelaccio
GIT_SILENT
2017-01-03Add missing Q_DECL_OVERRIDEMontel Laurent
2017-01-03Add missing Q_OBJECT macrosIlya Bizyaev
REVIEW: 129738
2016-12-03Fix viewpropertiestest when GlobalViewProps is trueElvis Angelaccio
The test was not saving its changes to the global settings, so it was passing on the CI only because the default value of GlobalViewProps is already false. If GlobalViewProps was set to true instead, testAutoSave() would fail because save() was not called and GlobalViewProps was not
2016-12-03Fix 5 clazy warningsSpencer Brown
This bumps the minimum Qt version to 5.5 (because of Q_ENUM usage). REVIEW: 129604
2016-08-06Fix some low-hanging warning fruitsMartin T. H. Sandsmark
2016-04-22Fix exports and linkage, remove sources from tests which are already being ↵Andrius da Costa Ribas
linked. REVIEW: 127709
2015-09-01Pedantic--Montel Laurent
2015-05-07Simplify the KFileItemModel benchmarkFrank Reininghaus
The benchmark inserted KFileItemLists of different sizes in the model. The intention was to verify that an O(N^2) complexity issue was fixed. However, now that this original problem does not exist any more, the benchmark results are much easier to read, and regressions are much easier to spot at first sight, if only a single list size is used.
2015-04-24Remove obsolete benchmark for inserting many child itemsFrank Reininghaus
I added this benchmark quite a long time ago in order to check that the changes in dc6322dc090bcaec40d75522debad1edfb25b27a do not make inserting many child items into the model slower. The test tries to insert child items of different subfolders at the same time, which cannot happen during normal usage because KDirLister only tells us about one subfolder at a time. The code was commented out a long time ago because it is no longer compatible with the (greatly improved) new internal structure of KFileItemModel. I think that it's not worth porting the benchmark because it fulfilled its intended purpose a long time ago. Even if someone decides to make a simplified working new benchmark out of it at some point, it does not make much sense to keep this commented-out code around for years. It can still be found in the git history - after all, that's what version control systems are for.
2015-02-26Use QT_GUILESS_MAINHeiko Becker
REVIEW: 122730
2015-02-26Port away from KDELibs4Support (we only use KDELibs4Support when baloo isn't ↵Emmanuel Pescosta
present, because KFileMetaDataWidget is in KDELibs4Support) Reviewed-By: Vishesh Handa
2015-02-25Move the KVersionControlPlugin2 interface from konqlib to Dolphin and remove ↵Emmanuel Pescosta
the deprecated KVersionControlPlugin interface from konqlib REVIEW: 122687
2015-02-24Fix build on Jenkins (or with BUILD_TESTING=ON)Hrvoje Senjan
2015-02-24Replace kDebug/kWarning by categorized logging (org.kde.dolphin)Emmanuel Pescosta
generated by cgit v1.3 (git 2.53.0) at 2026-04-23 02:22:14 +0000