| Age | Commit message (Collapse) | Author |
|
This has been committed by accident in 06dd174f.
|
|
Many tests have to wait until this signal is received from the
DolphinView, so it is convenient to have a function that wraps
the QTest::kWaitForSignal() call.
|
|
|
|
This commit changes mainly two things:
1. The functionality related to the handling of temporary files and
folders is moved to a new class TestDir.
2. The setup of a temporary folder and of DolphinView instances is
now done in each unit test function. A benefit of this change is that
there are no unwanted interactions between different unit test functions
any more. Moreover, different test functions could now share a test
folder more easily.
Additionally, the reference arguments of all functions are changed to
pointers for consistency.
|
|
|
|
Most developers seem to prefer
if (ptr) ...
if (!ptr) ...
in comparison to
if (ptr != 0) ...
if (ptr == 0) ...
Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
|
|
|
|
|
|
A minor API cleanup in DolphinSearchBox has been done related to the test.
|
|
|
|
In particular, tests for changing the zoom level and for saving and
restoring the view state.
svn path=/trunk/KDE/kdebase/apps/; revision=1217270
|
|
Up to now, some Columns View tests that need a folder to be displayed
in the view only passed if they were run first: The first test always
passed, and if a test name was passed on the command line, such that
only this test would be run, this test would work as well. In other
cases, the view was empty, not showing the items in the folder.
The problem is worked around by creating a new DolphinView before each
test in the case of the Columns View. Added a TODO comment to make me
remember to look into this again at some point.
svn path=/trunk/KDE/kdebase/apps/; revision=1217260
|
|
The test assumes that the view does not have the keyboard focus
initially. However, this may not be the case if this is the only test
to be executed (i.e., if testKeyboardFocus is passed to the test
executable on the command line). This commit transfers the keyboard
focus explicitly to another widget.
svn path=/trunk/KDE/kdebase/apps/; revision=1217251
|
|
related to the folder view properties.
svn path=/trunk/KDE/kdebase/apps/; revision=1216359
|
|
When running the test in the background while using the computer for
other things, it may happen that the test's widgets are not focused,
which led to an infinite loop before this commit. I've removed the
checks that caused this loop because the only thing that is important
for the test is that the view loses the keyboard focus at some point
(see bug 220898).
svn path=/trunk/KDE/kdebase/apps/; revision=1215139
|
|
selection failure after a keyboard focus change in between key press
and key release events)
svn path=/trunk/KDE/kdebase/apps/; revision=1214822
|
|
deletion if Shift+Delete is pressed for some time and the confirmation
dialog is disabled).
svn path=/trunk/KDE/kdebase/apps/; revision=1214651
|
|
when a key is pressed.
svn path=/trunk/KDE/kdebase/apps/; revision=1214565
|
|
DolphinView::hasSelection() provides a valid return-value. This looks like an issue in Qt, but I did not have the time yet to provide a Qt-only example for a bug-report :-(
svn path=/trunk/KDE/kdebase/apps/; revision=1213199
|
|
proxy model to DolphinView. By this it will be easier later to replace the traditional QAbstractItemViews by any kind of other implementation (e.g. based on QGraphicsView/QML).
svn path=/trunk/KDE/kdebase/apps/; revision=1213189
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1210710
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1210707
|
|
URL.
svn path=/trunk/KDE/kdebase/apps/; revision=1205329
|
|
2. Reduce the time out for the finishedPathLoading signal.
svn path=/trunk/KDE/kdebase/apps/; revision=1202815
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1202160
|
|
also added a timeout such that the tests fail rather than hang if the
file kioslave dies (which happens sometimes according to some test
logs on cdash.org).
svn path=/trunk/KDE/kdebase/apps/; revision=1202159
|
|
DolphinView. The main testing code is inside an abstract base
class. Three classes inherit this base class and do the actual testing
in one view mode each.
svn path=/trunk/KDE/kdebase/apps/; revision=1202157
|
|
1. Remove unneeded includes
2. Fix typo
3. Add newline at end of file.
svn path=/trunk/KDE/kdebase/apps/; revision=1200027
|
|
test to init() and cleanup().
svn path=/trunk/KDE/kdebase/apps/; revision=1199721
|
|
bug234600_overlappingIconsWhenZooming() such that it's the standard
value again in the following test. Also verify that the zoom level is
as expected after each call to DolphinView::setZoomLevel(int).
svn path=/trunk/KDE/kdebase/apps/; revision=1199137
|
|
than the "Name" column. Fixes keyboard navigation problems if files
with very wide names are present in the current folder.
Unit test included.
CCBUG: 257401
svn path=/trunk/KDE/kdebase/apps/; revision=1199123
|
|
works as expected.
svn path=/trunk/KDE/kdebase/apps/; revision=1198202
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1194790
|
|
2. Remove some debug output from DolphinDetailsViewTest - it seems
that the test failure I saw on cdash.org is due to a failing kioslave,
which is probably not Dolphin's fault.
svn path=/trunk/KDE/kdebase/apps/; revision=1194514
|
|
To make it work, I had to make DolphinTreeView::indexAt public, but
this method is public in the base class anyway.
svn path=/trunk/KDE/kdebase/apps/; revision=1194511
|
|
a common base class. I took that idea from Nepomuk's unit tests in
kdelibs.
svn path=/trunk/KDE/kdebase/apps/; revision=1191051
|
|
I've seen the test fail due to timeout at
http://my.cdash.org/index.php?project=kdebase&date=
Maybe some debug output helps to find the cause for this.
svn path=/trunk/KDE/kdebase/apps/; revision=1189677
|
|
QT_QTCORE_LIBRARY - KDE4_*_LIBS includes dependencies.
svn path=/trunk/KDE/kdebase/apps/; revision=1188673
|
|
which has been fixed recently). This commit also adds a new class
TestHelper which provides some funtionality that most Dolphin unit
tests will need. I hope that this makes implementing additional tests
as easy as possible :-)
svn path=/trunk/KDE/kdebase/apps/; revision=1188536
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1188148
|
|
of the problems related to Dolphin's modifications to QTreeView works
as it should.
This is only a small start, but I hope that we can cover at least the
basic functionality of DolphinView, the three item views and possibly
a couple of other classes with a rather stable API soon.
svn path=/trunk/KDE/kdebase/apps/; revision=1188049
|
|
implementation. Thanks to David Faure for the hint!
svn path=/trunk/KDE/kdebase/apps/; revision=819137
|
|
that only "Open office" is selected and ".org writer documentation" is handled as extension
BUG: 158228
svn path=/trunk/KDE/kdebase/apps/; revision=778329
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=748476
|
|
KDE4_ADD_TEST_EXECUTABLE is deprecated now use KDE4_ADD_EXECUTABLE(<target> TEST <files>) instead
QT4_ADD_DBUS_INTERFACE_NO_NAMESPACE and QT4_ADD_DBUS_INTERFACES_NO_NAMESPACE are deprecated too
used SET_SOURCE_FILES_PROPERTIES(<files> PROPERTIES NO_NAMESPACE TRUE) QT4_ADD_DBUS_INTERFACES(<srcList> <files>)
set( EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR} ) is put in each CMakeLists.txt where
KDE4_ADD_EXECUTABLE(<target> TEST <files>) and KDE4_ADD_UNIT_TEST were used.
svn path=/trunk/KDE/kdebase/apps/; revision=716149
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=685984
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=676863
|
|
need that feature in the part anyway)
svn path=/trunk/KDE/kdebase/apps/; revision=666229
|
|
> Sounds like the kind of method that would benefit greatly from a unit test :)
OK, committing my first unit test for KDE. Although very minimal it's at least a start ;-) (currently deactivated as I've some problem in CMakeList.txt)
svn path=/trunk/KDE/kdebase/apps/; revision=666162
|