┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views/dolphinview.cpp
AgeCommit message (Collapse)Author
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-10Prevent "Two clicks renaming" if the selected file/folder is not movableAndreas Krutzler
Summary: Two clicks renaming doesn't check if the user is actually allowed to rename a file/folder. With this patch, this get fixed. Depends on D7647 Reviewers: rkflx, #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: elvisangelaccio, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8740
2017-10-27Two clicks on file/folder to renameAndreas Krutzler
Summary: Make renaming of files/folders faster by clicking a second time on the items text to start renaming. BUG: 205157 Test Plan: This feature works as follows: 1. select an item by single-click, or one is already selected 2. wait the "double-click-interval" 3. click on the items text 4. none of the cancellations (see below) happens within the double-click-interval 5. inline-renaming starts Cancellations: * open any file/folder * select different item(s) * start dragging items * Dolphin loses focus This feature is just enabled while "Double-click to open files and folders" in system-settings and "Rename inline" in Dolphin are enabled. Reviewers: #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx Reviewed By: #dolphin, #kde_applications, elvisangelaccio, ngraham, rkflx Subscribers: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham Differential Revision: https://phabricator.kde.org/D7647
2017-09-17Keep renamed file(s) in viewEmirald Mateli
When renaming a file, if its new name causes it to scroll out of view, Dolphin will not scroll to the location of the new file. This patch aims to address that. This affects all view modes. CCBUG: 354330 Test Plan: 1. Have many files in a directory (or several files, just zoom in a lot) 2. Rename a file so that it will move out of view Differential Revision: https://phabricator.kde.org/D6312
2017-07-27Fix drop menu position with urlnavigator dropsElvis Angelaccio
Commit 1e251d2f6a in kio broke drop menus when dropping on the URL navigator (menus show up in the DolphinView rather than the URL bar). This happens because in DolphinView::dropUrls() we set `this` as the widget passed to KJobWidgets::setWindow() (in DragAndDropHelper::dropUrls()). We need to replace `this` with the actual widget that received the QDropEvent and that can mapToGlobal() the relative pos of the drop event. Unfortunately this widget is not KUrlNavigator itself, but one of its KUrlNavigatorButton children (private class, not exported). So unfortunately we need a new API in KIO that exposes this child widget. Differential Revision: https://phabricator.kde.org/D6684
2017-07-13Add missing emit keywordsElvis Angelaccio
GIT_SILENT
2017-05-08Don't ignore tag clicks in the tooltipsElvis Angelaccio
Summary: Now that we can use the metadata widgets in the tooltips, we can also open the tags:// url if the user clicks some tag in a tooltip. The behavior is now consistent with the metadata widget in the information panel. Test Plan: Click a tag when the metadata tooltip shows up. Reviewers: emmanuelp Subscribers: #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D5658
2017-02-18Start an anchored selection when restoring the selected items to make it ↵Emmanuel Pescosta
possible that the selection can be changed after reloading of the current view. Otherwise it is not possible to alter the selection without restarting a new one. Bug found by Martin Tobias Holmedahl Sandsmark See also RR 128563
2017-02-18Remove the preserving of the selected items in reload(), this is already coveredEmmanuel Pescosta
by saveState/restoreState.
2017-02-18Preserve selected items when changing foldersEmmanuel Pescosta
Based on the idea of Martin Tobias Holmedahl Sandsmark
2017-02-18Restore the view state after the URL of the DolphinView has been changed,Emmanuel Pescosta
as stated in the documentation of KUrlNavigator::saveLocationState. The historyChanged signal of the KUrlNavigator is emitted before the urlChanged signal and so the view state restoring happens before the view URL has been changed. This makes it impossible to save and restore the selected URLs, because DolphinView::setUrl clears the list of selected items (which has been restored right before). This changes removes the history changed slot and restores the view state after the setUrl call.
2017-02-06Merge branch 'Applications/16.12'Kai Uwe Broulik
2017-02-06[KStandardItemListWidget] Update icon when palette changesKai Uwe Broulik
We can colorize icons based on the user's palette, so clear the pixmap cache when it changes. Differential Revision: https://phabricator.kde.org/D3937
2017-02-05Port tooltips to KToolTipWidgetElvis Angelaccio
Use the new KToolTipWidget class (introduced by kwidgetsaddons 5.30) as backend of ToolTipManager. FileMetaDataToolTip becomes a simple widget used as content of the tooltip. It is now possible to actually use the metadata widget shown inside the tooltips. Tooltips are now functional on Wayland as well. More information about KToolTipWidget in https://git.reviewboard.kde.org/r/129648/ BUG: 352276 BUG: 371223 FIXED-IN: 17.04.0 Closes T4980 Differential Revision: D4449
2017-01-18Port away from deprecated KIO::Job::ui()Elvis Angelaccio
It's equivalent to KJob::uiDelegate() from kcoreaddons.
2017-01-03[DolphinView] Update view palette on palette changeKai Uwe Broulik
Everything was handling palette change already but for the visual distinction between active and non-active view (in case of split view), a custom palette was set which was then never updated. This could be seen by the label text color changing but not the view background. Differential Revision: https://phabricator.kde.org/D3909
2016-09-04Use tab for switching active splitMartin T. H. Sandsmark
REVIEW: 128564 REVIEW: 110970 BUGS: 171743
2016-08-06Fix some low-hanging warning fruitsMartin T. H. Sandsmark
2016-06-25add_definitions(-DQT_NO_URL_CAST_FROM_STRING) + fix compilationDavid Faure
This fixes some URLs built from local paths without scheme.
2016-06-16Fix DnD onto desktop:/ app desktop file.David Faure
We need to resolve from desktop:/ to file:/ so that DropJob can handle application .desktop files. CCBUG: 363991
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-09-03Merge branch 'Applications/15.08'Frank Reininghaus
2015-09-03Only store modified columns widths after the mouse button was releasedFrank Reininghaus
This prevents that the new widths are written to disk multiple times in quick succession, which can make column resizing quite slow. BUG: 351846 REVIEW: 351846 FIXED-IN: 15.08.1
2015-09-01Pedantic--Montel Laurent
2015-03-19Fix some EBN issuesYuri Chornoivan
2015-02-26Port away from KDELibs4Support (we only use KDELibs4Support when baloo isn't ↵Emmanuel Pescosta
present, because KFileMetaDataWidget is in KDELibs4Support) Reviewed-By: Vishesh Handa
2015-01-05Always connect the drop job result with DolphinView::slotPasteJobResultEmmanuel Pescosta
to receive the error message in case of an error also when the destUrl is not equal to the current url in the view. CCMAIL: [email protected]
2015-01-05Dolphin: port from KonqOperations::doDrop to the new KIO::DropJobDavid Faure
REVIEW: 121678
2014-12-14port away from deprecated KFileItem(mode_t mode, mode_t permissions, const ↵Emmanuel Pescosta
QUrl &url, bool delayedMimeTypes = false);
2014-11-10make use of initializer listsEmmanuel Pescosta
2014-11-02KonqOperations: KIO::pasteMimeData -> KIO::paste, update signal and simplify ↵David Faure
dolphin accordingly.
2014-11-02Port from KonqOperations::doPaste to new job KIO::pasteDavid Faure
Remove KonqOperations::doPaste.
2014-10-21Dolphin: port to KIO::pasteInfoText().David Faure
DolphinContextMenu::createPasteAction used to be precise about destination ("Paste To Folder"), while now it's precise about the source (what to paste). It was decided that this was more useful and consistent anyway. REVIEW: 120695
2014-10-21port Dolphin from KUrl to QUrlLukáš Tinkl
REVIEW: 120688
2014-10-21Merge doPaste and doPasteV2. Remove unused QPoint. Remove unused editMimeType.David Faure
2014-10-21port Konqueror from KUrl to QUrlLukáš Tinkl
REVIEW: 120650
2014-10-18Fix includesMontel Laurent
2014-10-18Fix includesMontel Laurent
2014-10-10Clean includes + port to QMenuMontel Laurent
2014-10-08Fix includes erroneously having slipped into baloo-only sectionsMarko Käning
CCMAIL: [email protected]
2014-10-07kdelibs4support--Montel Laurent
2014-09-22Port away from KonqOperations::renameV2.David Faure
Tested. The if before the connect looks suspicious to me, though.
2014-09-11fixed TODO:Emmanuel Pescosta
Qt5: Replace Qt::XButton1 by Qt::BackButton and Qt::XButton2 by Qt::ForwardButton
2014-08-22Merge branch 'master' into frameworksEmmanuel Pescosta
Conflicts: dolphin/src/dolphinmainwindow.cpp dolphin/src/dolphinmainwindow.h dolphin/src/dolphinrecenttabsmenu.cpp dolphin/src/dolphinviewcontainer.cpp kfind/CMakeLists.txt
2014-08-22Port away from KonqOperations::askDeleteConfirmation and KonqOperations::delDavid Faure
and remove them. Porting docs added to https://community.kde.org/Frameworks/Porting_Notes#libkonq
2014-08-20Save the view states in addition to the view urls and splitter state in ↵Emmanuel Pescosta
DolphinTabPage. Also added version numbers to view and tab state. REVIEW: 119792
2014-08-13Port from KonqMimeData to KIO::isClipboardDataCut/setClipboardDataCutDavid Faure
2014-08-12Always clear DolphinView's m_currentItemUrl member in updateViewState()Frank Reininghaus
Before this patch, we still kept the URL in m_currentItemUrl if the URL was not found in the model. This could cause problems the next time updateViewState() was called, because the current index would then be set to 0, which could cause other issues. For example, all items between the first item in the view and a folder which was expanded in Details View could be selected. In principle, it is possible that updateViewState() is called multiple times if many large files are being pasted in the view, but since the item which should be made the current item (and which the view should be scrolled to) should always be the first pasted item, this change will most likely not cause any other problems. BUG: 329377 REVIEW: 119703 FIXED-IN: 4.14.0
2014-08-01Actually the include was unused, remove itLuca Beltrame
2014-08-01Attempt to fix build (try 2)Luca Beltrame
generated by cgit v1.3 (git 2.53.0) at 2026-04-21 17:29:03 +0000