┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views/dolphinview.cpp
AgeCommit message (Collapse)Author
2019-03-09New tab placed after current tab when middle-clickingDavid Hallas
Summary: New tabs should be placed after the currently active tab when using middle click. Test Plan: Open new tab from the places panel using middle click, verify that the Open new tab from the folders panel using middle click, verify that the tab is opened after the current tab Open new tab by middle clicking on the Back button, verify that the tab is opened after the current tab Open new tab by middle clicking on the Forward button, verify that the tab is opened after the current tab FEATURE: 403690 Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19201
2019-02-27remove deprecated methodsLaurent Montel
2019-02-08Merge branch 'Applications/18.12'Kai Uwe Broulik
2019-02-08[DolphinView] Use correct color groupKai Uwe Broulik
Use the inactive color group when the window is inactive and update when window state changes. CCBUG: 404053 Differential Revision: https://phabricator.kde.org/D18811
2019-02-02Merge branch 'Applications/18.12'Elvis Angelaccio
2019-02-02[versioncontrolobserver] Update working directory on tab activationAnthony Fieroni
Differential Revision: https://phabricator.kde.org/D18605 Signed-off-by: Anthony Fieroni <[email protected]>
2018-12-17Make RenameDialog modal again.Elvis Angelaccio
Summary: The rename dialog used to be modal, but commit 828ba8902ce16819a385832b487e60eab36e54ca changed the behavior without really explaining why. Test Plan: disable inline renaming and rename something. Reviewers: #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17621
2018-11-08Warn user before renaming the file/folder to start with a ' . 'Shubham Jangra
Summary: For normal "casual" linux users, renaming the file/folder starting with dot may get irritating, they will be wondering their file is deleted. Test Plan: 1. Make new file/folder. 2. Rename it to .foo 3. Question dialog appears. Reviewers: elvisangelaccio, ngraham, pino Reviewed By: elvisangelaccio, ngraham Subscribers: cfeck, emateli, elvisangelaccio, pino, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15980
2018-10-27Merge branch 'Applications/18.08'Elvis Angelaccio
2018-10-27Don't enable two-clicks renaming in single-click modeElvis Angelaccio
Summary: This was supposed to be part of commit 5454283008f2, but apparently we didn't notice it was missing. Test Plan: - Enable single-click mode from system settings - Select a file in dolphin - Long-click the selected file and make sure inline renaming doesn't start Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16460
2018-10-18Use QLatin1Char instead of QLatin1StringShubham Jangra
2018-10-07Fix stale commentElvis Angelaccio
GIT_SILENT
2018-10-03Merge branch 'Applications/18.08'Andreas Krutzler
2018-10-03Fix that dragging a file can trigger inline rename.Andreas Krutzler
Summary: Inline renaming is aborted as soon as an item is dragged. Previously, ’m_dragging' was used to determine if an item was being dragged. However, inline renaming is triggered after a certain amount of time, during which time the user may have stopped dragging items. BUG: 398375 FIXED-IN: 18.08.2 Test Plan: When dragging an selected item, inline renaming should never be started, regardless of where you drag it (Places panel, other split-view window, out of the Dolphin window, ...). Reviewers: wbauer, elvisangelaccio, #dolphin, ngraham Reviewed By: wbauer, elvisangelaccio, #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15904
2018-08-21Port away from kdelibs4supportElvis Angelaccio
Summary: It was only used as fallback when baloo was not found, but `KFileMetaDataWidget` is useless without nepomuk. The result of this patch is that the information panel and the tooltips won't be available from platforms without baloo (instead of being available but broken). The baloo dependency remains optional. Closes T8720 Test Plan: Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and make sure it doesn't show tooltips or the information panel. Reviewers: #dolphin, broulik, ngraham Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T8720 Differential Revision: https://phabricator.kde.org/D14814
2018-06-05Fix scrolling to renamed file when using the rename dialogElvis Angelaccio
Summary: The `RenameDialog::slotResult()` slot is currently never called because the dialog is deleted first, due to the usage of the `WA_DeleteOnClose` attribute. This breaks the scroll-to-renamed-file feature when the inline renaming is disabled. Instead of deleting the dialog on close, we can use `deleteLater()` when we are sure the dialog has actually finished its job, which is when the KIO move job emits the `result` signal. Test Plan: - Disable inline renaming - Rename a file so that it goes out of the view - Check whether the view scrolls to the renamed file. Reviewers: #dolphin, emateli Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13304
2018-03-04Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-03-03Remove unused #includeRoman Inflianskas
Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985
2018-01-21Fix renamed file reclaims focusAndreas Krutzler
Summary: After renaming a file and then selecting another file immediately the just selected file stays selected. BUG: 388555 Test Plan: Steps to reproduce: $ mkdir /tmp/test $ cd /tmp/test $ touch a.tmp b.tmp $ dolphin /tmp/test In dolphin: * select a.tmp * <F2> * type aaa * select b.tmp immediately Expected result: * a.tmp renamed to aaa.tmp * b.tmp stays selected, aaa.tmp stays unselected Reviewers: ngraham, michaelh, #dolphin, elvisangelaccio Reviewed By: ngraham, michaelh, #dolphin, elvisangelaccio Subscribers: emateli, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D9711
2017-11-21Modernize: Use nullptr everywhereKevin Funk
2017-11-10Prevent "Two clicks renaming" if the selected file/folder is not movableAndreas Krutzler
Summary: Two clicks renaming doesn't check if the user is actually allowed to rename a file/folder. With this patch, this get fixed. Depends on D7647 Reviewers: rkflx, #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: elvisangelaccio, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8740
2017-10-27Two clicks on file/folder to renameAndreas Krutzler
Summary: Make renaming of files/folders faster by clicking a second time on the items text to start renaming. BUG: 205157 Test Plan: This feature works as follows: 1. select an item by single-click, or one is already selected 2. wait the "double-click-interval" 3. click on the items text 4. none of the cancellations (see below) happens within the double-click-interval 5. inline-renaming starts Cancellations: * open any file/folder * select different item(s) * start dragging items * Dolphin loses focus This feature is just enabled while "Double-click to open files and folders" in system-settings and "Rename inline" in Dolphin are enabled. Reviewers: #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx Reviewed By: #dolphin, #kde_applications, elvisangelaccio, ngraham, rkflx Subscribers: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham Differential Revision: https://phabricator.kde.org/D7647
2017-09-17Keep renamed file(s) in viewEmirald Mateli
When renaming a file, if its new name causes it to scroll out of view, Dolphin will not scroll to the location of the new file. This patch aims to address that. This affects all view modes. CCBUG: 354330 Test Plan: 1. Have many files in a directory (or several files, just zoom in a lot) 2. Rename a file so that it will move out of view Differential Revision: https://phabricator.kde.org/D6312
2017-07-27Fix drop menu position with urlnavigator dropsElvis Angelaccio
Commit 1e251d2f6a in kio broke drop menus when dropping on the URL navigator (menus show up in the DolphinView rather than the URL bar). This happens because in DolphinView::dropUrls() we set `this` as the widget passed to KJobWidgets::setWindow() (in DragAndDropHelper::dropUrls()). We need to replace `this` with the actual widget that received the QDropEvent and that can mapToGlobal() the relative pos of the drop event. Unfortunately this widget is not KUrlNavigator itself, but one of its KUrlNavigatorButton children (private class, not exported). So unfortunately we need a new API in KIO that exposes this child widget. Differential Revision: https://phabricator.kde.org/D6684
2017-07-13Add missing emit keywordsElvis Angelaccio
GIT_SILENT
2017-05-08Don't ignore tag clicks in the tooltipsElvis Angelaccio
Summary: Now that we can use the metadata widgets in the tooltips, we can also open the tags:// url if the user clicks some tag in a tooltip. The behavior is now consistent with the metadata widget in the information panel. Test Plan: Click a tag when the metadata tooltip shows up. Reviewers: emmanuelp Subscribers: #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D5658
2017-02-18Start an anchored selection when restoring the selected items to make it ↵Emmanuel Pescosta
possible that the selection can be changed after reloading of the current view. Otherwise it is not possible to alter the selection without restarting a new one. Bug found by Martin Tobias Holmedahl Sandsmark See also RR 128563
2017-02-18Remove the preserving of the selected items in reload(), this is already coveredEmmanuel Pescosta
by saveState/restoreState.
2017-02-18Preserve selected items when changing foldersEmmanuel Pescosta
Based on the idea of Martin Tobias Holmedahl Sandsmark
2017-02-18Restore the view state after the URL of the DolphinView has been changed,Emmanuel Pescosta
as stated in the documentation of KUrlNavigator::saveLocationState. The historyChanged signal of the KUrlNavigator is emitted before the urlChanged signal and so the view state restoring happens before the view URL has been changed. This makes it impossible to save and restore the selected URLs, because DolphinView::setUrl clears the list of selected items (which has been restored right before). This changes removes the history changed slot and restores the view state after the setUrl call.
2017-02-06Merge branch 'Applications/16.12'Kai Uwe Broulik
2017-02-06[KStandardItemListWidget] Update icon when palette changesKai Uwe Broulik
We can colorize icons based on the user's palette, so clear the pixmap cache when it changes. Differential Revision: https://phabricator.kde.org/D3937
2017-02-05Port tooltips to KToolTipWidgetElvis Angelaccio
Use the new KToolTipWidget class (introduced by kwidgetsaddons 5.30) as backend of ToolTipManager. FileMetaDataToolTip becomes a simple widget used as content of the tooltip. It is now possible to actually use the metadata widget shown inside the tooltips. Tooltips are now functional on Wayland as well. More information about KToolTipWidget in https://git.reviewboard.kde.org/r/129648/ BUG: 352276 BUG: 371223 FIXED-IN: 17.04.0 Closes T4980 Differential Revision: D4449
2017-01-18Port away from deprecated KIO::Job::ui()Elvis Angelaccio
It's equivalent to KJob::uiDelegate() from kcoreaddons.
2017-01-03[DolphinView] Update view palette on palette changeKai Uwe Broulik
Everything was handling palette change already but for the visual distinction between active and non-active view (in case of split view), a custom palette was set which was then never updated. This could be seen by the label text color changing but not the view background. Differential Revision: https://phabricator.kde.org/D3909
2016-09-04Use tab for switching active splitMartin T. H. Sandsmark
REVIEW: 128564 REVIEW: 110970 BUGS: 171743
2016-08-06Fix some low-hanging warning fruitsMartin T. H. Sandsmark
2016-06-25add_definitions(-DQT_NO_URL_CAST_FROM_STRING) + fix compilationDavid Faure
This fixes some URLs built from local paths without scheme.
2016-06-16Fix DnD onto desktop:/ app desktop file.David Faure
We need to resolve from desktop:/ to file:/ so that DropJob can handle application .desktop files. CCBUG: 363991
2016-03-16[CLAZY] Fixed all level 1 and level 2 warnings with small exceptionsArtur Puzio
REVIEW: 126771
2015-09-03Merge branch 'Applications/15.08'Frank Reininghaus
2015-09-03Only store modified columns widths after the mouse button was releasedFrank Reininghaus
This prevents that the new widths are written to disk multiple times in quick succession, which can make column resizing quite slow. BUG: 351846 REVIEW: 351846 FIXED-IN: 15.08.1
2015-09-01Pedantic--Montel Laurent
2015-03-19Fix some EBN issuesYuri Chornoivan
2015-02-26Port away from KDELibs4Support (we only use KDELibs4Support when baloo isn't ↵Emmanuel Pescosta
present, because KFileMetaDataWidget is in KDELibs4Support) Reviewed-By: Vishesh Handa
2015-01-05Always connect the drop job result with DolphinView::slotPasteJobResultEmmanuel Pescosta
to receive the error message in case of an error also when the destUrl is not equal to the current url in the view. CCMAIL: [email protected]
2015-01-05Dolphin: port from KonqOperations::doDrop to the new KIO::DropJobDavid Faure
REVIEW: 121678
2014-12-14port away from deprecated KFileItem(mode_t mode, mode_t permissions, const ↵Emmanuel Pescosta
QUrl &url, bool delayedMimeTypes = false);
2014-11-10make use of initializer listsEmmanuel Pescosta
2014-11-02KonqOperations: KIO::pasteMimeData -> KIO::paste, update signal and simplify ↵David Faure
dolphin accordingly.
generated by cgit v1.3 (git 2.53.0) at 2026-04-20 02:07:12 +0000