┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views/dolphinview.cpp
AgeCommit message (Collapse)Author
2011-12-30Fix inconsistency in selection managerPeter Penz
When a selection has been done with non-linear ranges, it was possible that the anchor item pointed to an invalid index that resulted into an invalid selection. As part of this fix the sorting for DolphinView::selectedItems() has been disabled (if the caller assumes a sorted selection he must manually adjust it). BUG: 288908 FIXED-IN: 4.8.0
2011-12-20Show an error when dragging above a folder without write accessPeter Penz
Got OK from the translator team to add this new string.
2011-12-18Hide tooltips when dragging itemsPeter Penz
2011-12-17Hide tooltips when the view is scrolledPeter Penz
2011-12-16Assure that the general settings are refreshedPeter Penz
This fixes issues where Dolphin must get restarted after changing a general setting. BUG: 289131 FIXED-IN: 4.8.0
2011-12-11Remember sort settingsPeter Penz
If the user has changed the sort-role or sort-order by clicking on the view-header of the details-view, the settings have been adjusted to the model but not remembered in the directory settings.
2011-12-10Show error-message when dropping a folder into itselfPeter Penz
Thanks to Janardhan Reddy for the analysis of the issue! BUG: 283646 FIXED-IN: 4.8.0
2011-12-09Reloading is not necessary anymore on a settings changePeter Penz
The new view-engine can adjust the properties with the existing items.
2011-12-08Fix font settings issuePeter Penz
The font settings have been ignored currently because of the transition to the new view-engine. The patch is based on the work of Janardhan Reddy and has been extended by the helper class ViewModeSettings. BUG: 288395 FIXED-IN: 4.8.0
2011-12-08Fix "show hidden files" issuesPeter Penz
Use KFileItemModel instead of KDirLister for toggling the whether hidden files should be shown. This assures that the signal KFileItemModel::loadingCompleted() will be emitted. In the longterm Dolphin should only use the KFileItemModel, so that the KDirLister instance is used only internally as implementation detail in KFileItemModel. Although there are only a few cases left where KDirLister is used instead of KFileItemModel this cleanup will be postponed to after the 4.8 release... BUG: 287314 BUG: 288213 FIXED-IN: 4.8.0
2011-12-07Enable "menu key" functionalityPeter Penz
Bring back the functionality that a context-menu is opened if the "menu key" has been pressed. In opposite to Dolphin 1.7 the context-menu is shown above the selected item and not on the (probably unrelated) mouse position. A new method KItemListView::itemContextRect() has been introduced: The method is now also used as reference for tooltips which fixes the issue that tooltips had a wrong horizontal alignment in the details-view. BUG: 288366 FIXED-IN: 4.8.0
2011-12-06Selection and current item fixesPeter Penz
- Remember selection + current item when switching view-modes - Fix the current item indicator alignment for selections - Set the item as current item when the selection toggle has been clicked
2011-12-06Don't animate when switching view-modesPeter Penz
Currently when switching the view-modes an animation of the items is done, where the position and size is adjusted for the new view-mode. Although this might look nice initially I'd consider this as a kind of animation that is distracting and hence it has been turned off.
2011-12-06Folders Panel cleanupsPeter Penz
- Reactivate dropping of URLs - Remove unused/obsolete code - Simplify DragAndDropHelper interface
2011-12-04Fix crash #1 when filtering itemsPeter Penz
When filtering items it was possible that the current index got an invalid value which resulted in accessing the URL of a null-KFileItem. There is still one (general) open issue in KFileItemModelRolesUpdater (crash #2) where a KFileItem that is already null gets read. It is not really related to filtering but can be triggered quite easy when filtering huge directories with enabled previews. CCBUG: 287642
2011-11-30Reimplement name-filteringPeter Penz
The filtering of items has not been implemented yet in the KFileItemModel of the new view-engine. The patch brings back this functionality again, but some minor issues are open: - When filtering trees expanded directories should only get hidden if no child is visible - Regular expressions are not supported yet (they have not been supported in Dolphin 1.x but it is now quite simple to implement). - When filtering previews and removing the filter it might be possible that the preview is not shown (is most probably an an already existing bug in KFileItemModelRolesUpdater). BUG: 287642 FIXED-IN: 4.8.0
2011-11-29Reactivate the "Open folders during drag operations" featurePeter Penz
The feature got temporary lost due to the port to the new view engine.
2011-11-26Folders Panel fixesPeter Penz
The following functionality from Dolphin 1.x has been ported to the new view-engine: - Allow expanding/collapsing of items - Automatically select the current item - Context menu for items Related improvements to the view-engine: - Make the expanding/collapsing interface already accessible in the base classes KItemModelBase and KItemListView. If no expanding/collapsing is supported at all by derived models (which is usually the default case) simply not reimplementing those 3 methods is sufficient and it does not introduce an additional complexity like in QAbstractItemModel/QModelIndex. - Automatically handle the expanding/collapsing in KItemListController. This also includes the key-handling, which is quite special for expandable items. - Don't let KItemListView automatically scroll to the current item if the current item got changed. The automatic scrolling should only be done if the current item has been changed by the user. Hence this functionality has been moved to the KItemListController which currently only triggers the automatic scrolling if the current item has been changed by the keyboard (we might extend the usecases later if required).
2011-11-25Use KFileItem::text() instead of KFileItem::name().Sebastian Trueg
This way Nepomuk search results get their proper user readable names. BUG: 287472 REVIEW: 103237
2011-11-24Fix restoring expanded URLsFrank Reininghaus
When navigating back or forward in history, DolphinView tells the KFileItemModel about the expanded URLs which should be restored before the folder is entered. In this case, the algorithm in the new function KFileItemModel::setExpanded(const QSet<KUrl>&) does not work. To fix this, the old function KFileItemModel::restoreExpandedUrls(const QSet<KUrl>&) is restored. Unit test included.
2011-11-20Initial draft for bringing back the "Folders" panelPeter Penz
The folders panel has been adjusted to use the new view-engine. A lot of things don't work yet, but are mostly minor issues that should be fixable during the next 10 days.
2011-11-19Remove "Rename inline" optionPeter Penz
The new view-engine currently does not support inline-renaming and because of more important pending issues this cannot be implemented for the 4.8 release of KDE applications. The plan for 4.9 is to implement inline-renaming again and to make it "so good" (tm) that it is always turned on (-> there is no need anymore for an option to disable it ;-) CCBUG: 286893
2011-11-13Fix selection style issuesPeter Penz
Don't use a custom drawing code for showing the hover-indication or selection of the text. - The default style for items is used. - Merge icon-rectangle and text-rectangle if possible. - Fix background and minor focus-issues
2011-11-06Delete obsolete class DolphinSettingsPeter Penz
2011-11-04Don't use mixed units in size-column of details-viewPeter Penz
This makes it tricky to compare the filesizes without adjusting the sort-order, so now all sizes in the size-column are shown in KiB or KB (dependent on the KLocale setting). BUG: 219932 FIXED-IN: 4.8.0 Related fixes: - Stay consistent with the rounding when using the KiB/KB unit in the statusbar. - Fix sorting-by-size issue for folders - Show "Unknown" in the size-column when the number of items cannot be determined.
2011-10-23Improve group-header layoutPeter Penz
- Apply a dynamic width - Use a height that depends on the style - Cleanup some interfaces and replace xxxBoundingRect() by xxxRect()
2011-10-16Sort the items in DolphinView::selectedItems(), part 2Frank Reininghaus
I forgot this change in the last commit. CCBUG:283409
2011-10-16Sort the items in DolphinView::selectedItems()Frank Reininghaus
Before this commit, the order of the items in the list returned by DolphinView::selectedItems() was random. Now the items are sorted like they are sorted in the view. BUG: 283409
2011-10-15Interface cleanups to prepare the return of "grouped sorting"Peter Penz
- Rename setCategorizedSorting() to setGroupedSorting() - Change the model interface to allow enabling/disabling grouping without the need to declare a role (the sort role will be taken). - Add dummy group role implementation in KFileItemModel The grouping code itself requires some cleanups and might crash at the moment or lead to weird layouts.
2011-10-15Fix regression concerning Control+mouse wheel zoomingFrank Reininghaus
Commit 9311f4bc97ec7000be46b8eec242a8 accidentally removed DolphinView::wheelEvent(), which is responsible for the handling of Control+mouse wheel events. These should change the zoom level.
2011-10-14Activate the DolphinView if the KItemListContainer gets focusFrank Reininghaus
This is needed in the case that the view is split to make the DolphinMainWindow aware of the view which is currently active.
2011-10-08Remember the changed header-roles as part of the directoryPeter Penz
2011-10-08Context menu cleanupsPeter Penz
- Open the context menu on the mouse-press event, not on the mouse-release event. - Provide an explicit position-information and don't use QCursor::pos(). This fixes the issue that opening a context-menu by the keyboard opens below the cursor. - Provide different signals in the KItemListController for the different context-menu types (item vs. view vs. header). - Implement turning on/off roles by the header-context-menu.
2011-09-30Implement smooth-scrolling for horizontal and vertical scrollbarsPeter Penz
Currently only a smoothscrolling was provided into the scroll-direction, but not in case of the details-view where a horizontal scrollbar might be shown too. Some minor adjustments of the private KItemListSmoothScroller interface will be done later...
2011-09-25Fixed selection of directories with a trailing slash used with --selectChirag Anand
parameter. As QHash would not match a KUrl key with it's value if the key had a trailing slash, so it would return -1, hence the file won't get selected. Changed the UpdateViewState slot to remove the trailing slash before calling the index function for the selected URL. Also modified DolphinView to use KUrl list instead of KFileItemList to maintain simplicity.
2011-09-22Fixed bug for selecting files with --select parameter.Chirag Anand
Files selected via --select parameter did not get current item focus. And if files were deleted while being current item, updating the view would select the next item instead of the first item in the list. BUG: 257805 CCMAIL: [email protected] CCMAIL: [email protected]
2011-09-20Change signature of setVisibleRoles()Peter Penz
Simply use a QList<QByteArray> instead of QHash<QByteArray, int>.
2011-09-18Implement some missing sorting optionsFrank Reininghaus
Changing the sort order and enabling/disabling the "Sort Folders First" option works now.
2011-09-17Implement DolphinView::sorting()Frank Reininghaus
This fixes the problem that changing the sorting criterion from 'Name' to 'Date' and then back to 'Name' doesn't work.
2011-09-17Implement restoring expanded folders in Details ViewFrank Reininghaus
2011-09-10Provide KVersionControlPlugin version 2Peter Penz
Based on the work of Vishesh Yadav some extensions where required for the KVersionControlPlugin interface that have found there way now into KVersionControlPlugin2. Beside some interface cleanups it is now possible that a version control plugin may also provide context actions for directories or files that are not versioned yet. REVIEW: 102541
2011-09-09Version control: Show context menu entries of pluginsPeter Penz
2011-09-06First step to reactivate version control plugin functionalityPeter Penz
- Add a DolphinFileItemListWidget that provides icon-overlays and colored text for the version state (implementation is missing yet) - Allow KFileItemListWidget to have custom text colors - Update interface of VersionControlObserver to work with KFileItemModel instead of the old model-interface.
2011-09-04Improved drag and drop supportPeter Penz
2011-09-01Removed warning, minor coding style updatePeter Penz
2011-08-31Items are expandable in the Details View.Frank Reininghaus
2011-08-30Implement DolphinView::simplifiedSelectedUrls()Frank Reininghaus
Makes it possible to trash and delete items.
2011-08-30Made items a const.Tirtha Chatterjee
2011-08-30DolphinView zoom with CTRL+MouseWheel REVIEW: 102490Vishesh Yadav
2011-08-30Using selectedItems() method already present in DolphinView for ↵Tirtha Chatterjee
slotItemActivated()