| Age | Commit message (Collapse) | Author |
|---|
|
This reverts commit dc149ec5e52f52c514cf362603d05ba8eea506b8.
This prevents a crash. One issue identified is that the commit that
I am reverting here accesses a QDropEvent at a moment in time in
which it might have already been deleted. We cannot check if it
exists by that time because we do not control its lifetime and it
is not a QObject.
|
|
When dragging onto tabs/Places from a remote URL, we don't process
the QDropEvent immediately, but start a StatJob and process the
event when it finishes.
Also, the result of the StatJob is cached for 30 seconds, to avoid
starting duplicate jobs.
|
|
KFileItem::isDir() only works when it's created from listDir(),
or from a local QUrl. For a remote QUrl, isDir always returns
false, so we can't use that in supportsDropping().
As a workaround, now supportsDropping() always returns true in
remote dirs -- we don't check if a remote dir is writable when
dropping.
|
|
1. Places panel and tabbar update drag status in read-only dir
2. Don't create drop job in readonly directories
|
|
|
|
Accepts Ark's special dnd mime types so that archive contents can
be dragged onto a place to extract and/or (mount and) switch to the
hovered location.
|
|
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
|
|
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
|
|
Summary:
The check is called when the mouse is moved in a drag&drop operation.
Dragging all files in a directory with 3000 files under callgrind,
moving the mouse to the other panel and then canceling, doing it twice,
callgrind shows that the method urlListMatchesUrl is called around
200 times, spending around 9,30% of the cpu in those calls.
Applying the patch, callgrind tells it uses now 0.31% of the cpu in 1208 calls.
CCBUG: 342056
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: markg, anthonyfieroni, michaelh, elvisangelaccio, ngraham
Differential Revision: https://phabricator.kde.org/D10085
|
|
Summary:
This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself.
The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior.
BUG: 307747
Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen.
{F3787651}
Test Plan:
1. Drag a folder.
2. Drop it onto itself.
Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure
Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure
Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D6281
|
|
Commit 1e251d2f6a in kio broke drop menus when dropping on the URL
navigator (menus show up in the DolphinView rather than the URL bar).
This happens because in DolphinView::dropUrls() we set `this` as the
widget passed to KJobWidgets::setWindow() (in DragAndDropHelper::dropUrls()).
We need to replace `this` with the actual widget that received the QDropEvent
and that can mapToGlobal() the relative pos of the drop event.
Unfortunately this widget is not KUrlNavigator itself, but one of its
KUrlNavigatorButton children (private class, not exported). So
unfortunately we need a new API in KIO that exposes this child widget.
Differential Revision: https://phabricator.kde.org/D6684
|
|
the deprecated KVersionControlPlugin interface from konqlib
REVIEW: 122687
|
|
|
|
REVIEW: 121678
|
|
REVIEW: 120688
|
|
|
|
(because there exists items with it's names
Fixed the "same" buggy behavior when dropping files/folders
Select also putted files (PUT operation - SimpleJob) - e.g. Paste content from clipboard
BUG: 233335
REVIEW: 107351
|
|
The URL of the view should be used as destination target if a dropping is not
done above a directory or desktop-file.
BUG: 293511
FIXED-IN: 4.8.1
|
|
BUG: 292821
BUG: 292355
FIXED-IN: 4.8.1
|
|
Got OK from the translator team to add this new string.
|
|
- Reactivate dropping of URLs
- Remove unused/obsolete code
- Simplify DragAndDropHelper interface
|
|
|
|
|
|
- remove it
svn path=/trunk/KDE/kdebase/apps/; revision=1201101
|
|
svn path=/trunk/KDE/kdebase/apps/; revision=1154150
|
