| Age | Commit message (Collapse) | Author |
|
If each directory can have its own view properties, and loadting the
.directory file fails in a directory, we have to load the global view
properties. However, if we try to do this by changing the "global view
properties setting" and loading the view properties for the same
directory again, we might get an infinite recursion if changing the
setting fails.
We now force a loading of the global view properties by constructing a
new ViewProperties object with an empty URL.
Thanks to Kurt Hindenburg for helping to debug this issue (which was
only reproducible on MacOS).
BUG: 316209
FIXED-IN: 4.10.5
REVIEW: 111182
|
|
Normally, we only allow renaming multiple files if the new file name
contains a contiguous sequence of '#' placeholders, which are then
replaced by numbers.
However, if all extensions are different, we can also rename the files
without such a placeholder because the original extension is preserved
when renaming.
This had been possible some time ago already. That this "accidental
feature" was lost was a side effect of the fix for bug 318942.
BUG: 321234
FIXED-IN: 4.10.5
REVIEW: 111079
|
|
This is the real fix now - note that the last commit
4de9a233642a62ee96bac6031340d3eea21f14f9 was actually the fix for bug
320823. Somehow, I have messed up the local branches in my git
respository clone - sorry for the confusion!
BUG: 319912
FIXED-IN: 4.10.5
REVIEW: 110908
|
|
BUG: 255819
FIXED-IN: 4.10.4
REVIEW: 109966
|
|
The "Rename" button in the dialog should be enabled if and only if the
"new name" pattern is valid. This is the case if the pattern contains
exactly one sequence of '#', which will be replaced by digits.
This patch fixes the problem that
(a) A pattern that contains a single '#' is not considered valid, and
(b) A pattern without any '#' at all is not recognized as invalid.
BUG: 318942
FIXED-IN: 4.10.3
REVIEW: 110223
|
|
|
|
|
|
Showing this message in the KMessageWidget above the view, which means
that the view contents are moved down, can be extremely annoying
according to user feedback. Just showing the message in the status bar
is probably enough.
BUG: 313466
REVIEW: 108483
FIXED-IN: 4.10.0
|
|
|
|
UpdateItemStatesThread finishing and the finished() signal being
delivered.
In this case, a new thread was not created, because the old thread
still existed. However, pendingItemStatesUpdate was not set, because the
thread was not running. Instead, the old thread was restarted.
This meant that the finished() signal from the first run could be delivered
while the thread was running for a second time, causing the thread to be
deleted while still running and thus a crash.
Solution: set pendingItemStatesUpdate if the thread is non-null,
even if it is not running, knowing that slotThreadFinished has not yet run,
and will call updateItemStates itself.
BUG: 302264
FIXED-IN: 4.10
REVIEW: 107656
|
|
FIXED-IN: 4.10
BUG: 262464
REVIEW: 108336
|
|
BUG: 312812
BUG: 262464
FIXED-IN: 4.10
REVIEW: 108291
|
|
|
|
Use the KFileMetadataWidget if Nepomuk is not present.
REVIEW: 108236
|
|
Instead of the KFileMetadataWidget. The Nepomuk widget is just a copy of
the KFileMetadataWidget which utilizes Nepomuk2.
|
|
|
|
|
|
|
|
sort order
BUG: 287829
FIXED-IN: 4.9.5
REVIEW: 107718
|
|
multiple files are selected
BUG: 304299
REVIEW: 107305
|
|
The string was added in ecb2715ead30c2b9d483748074524322e5ecedcf.
According to the soft message freeze policy on techbase, it's OK to fix
previously untranslated strings. Translators, please tell me if I'm
wrong, then I'll remove the string and the surrounding code and re-add
it to master later for KDE 4.11. Sorry for the trouble.
Thanks to David Faure for pointing out this mistake!
CCMAIL: [email protected]
|
|
|
|
|
|
After 530c743a89bb5366ff9b6f8be1d7a37f23b46880, this fixes the other
places where the incorrect default value 'false' was used.
Thanks to Luc Menut for noticing this problem!
CCBUG: [email protected]
|
|
|
|
The problem was that we erased an iterator from the list and then
incremented it. This can lead to problems (namely, random crashes) if
the iterator pointed to the last list element.
Thanks to Sandro Mani for testing the patch!
BUG: 311246
FIXED-IN: 4.9.5
|
|
|
|
BUG: 310465
FIXED-IN: 4.9.4
REVIEW: 107458
|
|
|
|
This fixes a recent regression in the 4.9 branch caused by
b25059e803e7eed54f0593605a4066882d63bce2.
BUG: 310365
FIXED-IN: 4.9.4
REVIEW: 107389
|
|
The problem was that Qt tried to deliver an 'Enter' event to the
dangling pointer that once pointed to the tool tip.
Many thanks to G. Christ for finding a way to reproduce this crash!
BUG: 282257
BUG: 310579
FIXED-IN: 4.9.4
|
|
Conflicts:
konqueror/settings/kio/kcookiespolicies.cpp [master only changes]
konqueror/settings/kio/kcookiespolicies.h [ditto]
|
|
The 'make the new item the current one in all views' issue has been
around for quite some time, the unexpected selection was a recent
regression caused by commit b25059e803e7eed54f0593605a4066882d63bce2.
Thanks to Jaime Torres for finding the regression early and for testing
this patch!
BUG: 310219
FIXED-IN: 4.9.4
|
|
|
|
have been skipped
BUG: 217575
REVIEW: 107237
FIXED-IN: 4.9.4
|
|
|
|
BUG: 303742
FIXED-IN: 4.9.3
|
|
|
|
fish/sftp/ftp kioslave gets dolphin stuck on "Loading folder"
BUG: 153984
REVIEW: 107116
|
|
when listing directories is slow.
BUG: 302264
FIXED-IN: 4.9.3
|
|
when listing directories is slow.
BUG: 302264
FIXED-IN: 4.9.3
|
|
guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port
REVIEW: 106825
|
|
|
|
BUG: 307603
REVIEW: 106753
FIXED-IN: 4.9.3
|
|
|
|
This option, introduced in 99e4eb0f3a58c53277b099114a5fd8945937fb9a, did
not work any more since 2069c200211c93e401c3d19850f41eade09d64be.
CCBUG: 307522
|
|
Conflicts:
konq-plugins/dirfilter/dirfilterplugin.cpp
konq-plugins/dirfilter/dirfilterplugin.h
|
|
visible
BUG: 297355
FIXED-IN: 4.9.2
REVIEW: 106499
|
|
User feedback has shown that many users used the dialog for renaming
files. Since the dialog is still used when renaming multiple files, I
think there is no good reason not to use it for renaming single files
as well if the user wants.
Note that we cannot add an option in the settings dialog due to string
freeze issues. For the time being, you will have to add the line
"RenameInline=false" to the [General] section of
$KDEHOME/share/config/dolphinrc.
BUG: 304627
FIXED-IN: 4.9.2
|
|
It is not reproducible on every machine for me, but it seems that it can
happen that DolphinView's slot slotRoleEditingFinished() is invoked
after the items have already been removed from the model. In that case,
we have to return from the slot immediately to prevent a crash.
BUG: 306147
FIXED-IN: 4.9.2
|