┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views
AgeCommit message (Collapse)Author
2020-12-09operator+/- is disabled for QFlags in qt6Laurent Montel
2020-12-03DolphinView: set the parent of layout in the ctorAhmad Samir
This silences a runtime warning: QLayout: Attempting to add QLayout "" to DolphinView "", which already has a layout Remove redudant setLayout() calls, passing a parent widget to the Q*BoxLayout ctor sets that layout as the top-level layout for that widget.
2020-11-28Add placeholder text for empty viewsNate Graham
Throughout our QML-based software, we now display placeholder text for empty views so that the user knows that the view is actually empty, and it's not that the software is just broken. This commit introduces the same thing for Dolphin's main view. BUG: 429248 BUG: 426354 FIXED-IN: 21.04
2020-11-22Remove unneeded version checkAlexander Lohnau
2020-11-17Add missing kconfig_version.h includeElvis Angelaccio
This should have been part of edced8460b.
2020-11-17Correct indentation and whitespace in prior commitNate Graham
2020-11-17Allow folder creation on desktop via F10 shortcutDomenico Panella
2020-11-03Compute text width taking into account the zoom levelMéven Car
This makes the icon view less crowded.
2020-11-01Port away from deprecated QWheelEvent::delta()Elvis Angelaccio
QWheelEvent::angleDelta() returns a QPoint instead of int, so we need to use its y() value to get the number of steps.
2020-10-31Port from QStandardPaths::DataLocation to QStandardPaths::AppDataLocationDavid Faure
They are the same on Linux (but DataLocation is deprecated). On Windows this enables the use of the roaming path. NO_CHANGELOG
2020-10-23Compile with QT_NO_KEYWORDSAlexander Lohnau
2020-10-23Compile without foreachAlexander Lohnau
2020-10-17Remove not implmemented methodLaurent Montel
2020-10-15Port to non-deprecated QLabel::pixmap()Elvis Angelaccio
Quoting from: https://github.com/qt/qtbase/commit/714409b23ce5ec33e56adce5ba1966aad67c3b34 ``` The QLabel changes to the pixmap/picture getters provide the following migration path: QPixmap *ppix = l->pixmap(); // up to 5.15, warns in 5.15 QPixmap pval = l->pixmap(Qt::ReturnByValue); // new in 5.15, works in 6 QPixmap pixmap = l->pixmap(); // from Qt 6 on ``` Since we can't require 5.15 yet in dolphin, the port is done only when building with Qt >= 5.15
2020-10-15Port to non-deprecated QString::split() variantElvis Angelaccio
This requires Qt 5.14, which we now depend on.
2020-10-15Port away from QList::toSet()Elvis Angelaccio
The QSet range constructor requires Qt 5.14. In `DolphinView::slotHeaderContextMenuRequested()` the conversion from QList to QSet was pointless, so we just use a QList now.
2020-09-23SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-22Make "Show hidden files" action follow HIGNate Graham
The action is a toggle action, for which the HIG prescribes that the text should describe the action's checked state, and neither the text nor the icon should change when the action is checked. Other toggle actions in Dolphin follow these rules, but this one does not. This commit makes the action follow those rules.
2020-09-18Fix unused variable warningAyushmaan jangid
2020-09-14SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-13Improve Touch supportSteffen Hartleib
With this patch dolphin now supports the following touch gestures: * Tap gesture to interact/open with directories, files and so on * TapAndHold and release gesture for access to the context menu (main window, panel folder, places and information) * TapAndHold and moving gesture for drag and drop action (main windows, panel folder and places) * pinch gesture for zoom in main window * kinetic scrolling (QScroller) for main window, panel folder, panel places, panel information, setting preview and service * two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up * two finger tap gesture to toggle item selection, similar to Ctrl and left mouse click FEATURE: 385066 FIXED-IN: 20.11.80 You are currently rebasing branch 'touch' on '85241a924'.
2020-09-10SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-03SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-08-26Text style fixesNikita Churaev
2020-08-25Output of licensedigger + manual cleanup afterwards.Elvis Angelaccio
Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.
2020-06-29## SummaryYann Holme-Nielsen
* Adds a "Copy location" item, after the "Copy" Context item and Edit Menu, which will attempt to copy the path of the fist item into clipboard. ## Reasoning Most File Managers have this option through one or another way. Also using the default Copy option often results in different behaviour depending on the target software, Konsole will take the path. Other Programs will use the URI. Which ultimately could lead to non optimal User Experience. ## Notes * Should the target file **not** be on a local hard drive, this fallback to using the remote URL, feedback is wanted on that matter. FEATURE: 407004
2020-06-18SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-17SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-13SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-09Provide ability to configure size cut-off for local file previewsGastón Haro
Summary: FileWidgets read from kdeglobals the property "MaximumSize" under "PreviewSettings" to decide if a preview will be generated for that file. There is no current GUI to change that file size limit. On the other hand Dolphin ignores it. This patch aims to fix that by adding new configuration options to Dolphin. That is a new spinbox in Dolphin settings under General -> Previews tab. Test Plan: 1 - Set up a local folder with 2 jpg images of less and more than 1 MB respectively. 2 - Go to Dolphin Preferences. General -> Previews and check "JPEG Images" from the list. And set "Skip previews for files above:" to 1MB. 3 - Navigate to the afore mentioned folder. Only the image of size less than 1 MB should show a preview. BUG: 331240 Reviewers: ngraham, #dolphin, meven, elvisangelaccio Reviewed By: ngraham, #dolphin, meven, elvisangelaccio Subscribers: cfeck, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28402
2020-06-03Merge branch 'release/20.04'Nate Graham
2020-06-01Show progress when duplicating itemsNate Graham
For unknown reasons, when I implemented this feature, I turned off progress notifications. I don't think this makes any sense, and we just got a bug report about it. Accordingly, this patches turns on progress notifications. BUG: 422335 FIXED-IN: 20.04.2
2020-05-31Prevents warningsMéven Car
Warnings such as : kf5.kio.core: Invalid URL: QUrl("") It happened for instance with recentlyused:/ ioslave
2020-05-30Prevents showing StatJob Progress infoMéven Car
BUG: 422121 Was introduced in ac234a9c55aed509b385ef03835a6d0f563e6a22
2020-05-19DolphinView: rename new methods to copy/move urlsElvis Angelaccio
DolphinView doesn't know anything about split views and it shouldn't. Rename these new methods to what they actually do (just copy or move to a given QUrl).
2020-05-15Added VCS plugins signals connections for outOfVersionControl() actions.Nikolai Krasheninnikov
Summary: Plugins can now do out of version control actions (D29041), so we need them to inform of their state. This change connects every plugin signal to Dolphin on plugin instantiation. Test Plan: 1. Try SVN Update of inaccessible repository: see SVN error message shows up. 2. Try pull inaccessible git repository: see GIT error message shows up. 3. Try SVN Commit: see SVN message. Reviewers: #dolphin, meven, elvisangelaccio Reviewed By: #dolphin, meven Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29488
2020-05-14Allow to copy or move selection to the other split viewAntonio Prcela
Summary: FEATURE: 276167 Default keyboard shortcuts set to `SHIFT+F5` for `copy`, `SHIFT+F6` for `move` Reviewers: #dolphin, elvisangelaccio, ngraham, meven, dfaure Reviewed By: #dolphin, elvisangelaccio, ngraham, meven, dfaure Subscribers: yurchor, kde-doc-english, dfaure, meven, kfm-devel Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D29006
2020-05-11DolphinView: rename cutSelectedItems to cutSelectedItemsToClipboardElvis Angelaccio
For consistency with d1a70c0b629b.
2020-05-11DolphinView: rename copySelectedItems to copySelectedItemsToClipboardElvis Angelaccio
This makes it explicit that this is just a copy to clipboard, so that we can use the name for an actual KIO::copy().
2020-05-06Port QRegExp to QRegularExpressionAhmad Samir
Summary: Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern(). Port QRegExp::Wildcard with QRegularExpression::wildcardToRegularExpression(). Note that QRegularExpression::wildcardToRegularExpression() returns an anchored pattern. Test Plan: Using the filter bar in dolphin works as before. All unit tests pass, except: - kfileitemmodeltest (which is unrelated AFAICS); it fails on master too - placesitemmodeltest, which fails on master too Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26215
2020-05-04Replace the list with the simplified list, instead of concatenate.Antonio Prcela
Summary: Replace the list m_selectedUrls with a simplified list, instead of concatenating the simplified list to the current one. Reviewers: dfaure, meven Reviewed By: dfaure Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29399
2020-04-30For VCS-plugin interface added pure virtual function ↵Nikolai Krasheninnikov
outOfVersionControlActions() Summary: This commit changes VCS-plugin interface in order to provide actions for unversioned items (for example clone or checkout repository), updates to dolphin-plugins comes in the separate commit D29042. Reviewers: #dolphin, meven, elvisangelaccio Reviewed By: #dolphin, meven, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29041
2020-04-20Use new "Show/Hide Hidden Files" standard shortcutNate Graham
Summary: Note that we lose the F8 shortcut since the KStandardShortcut added in XXXX can only accommodate toew default shortcuts, and I thought Ctrl+H and Alt+. were the more important ones. Hopefully that's not too high a price to pay. Depends on D28802 Test Plan: - Apply D28802 to kconfig - Apply this patch to Dolphin, compile, and launch Dolphin - Hit Ctrl+H or Alt+. and see that hidden files are shown or hidden as approproiate Reviewers: #dolphin, dfaure, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28804
2020-04-18Allow statusbar and information panel to stat with KIO::StatRecursiveSizeMéven Car
Summary: Needed after D28901 to ensure we get the UDS_RECURSIVE_SIZE out of the stat calls. Test Plan: Trash size is visible in status bar and information panel again. Reviewers: ngraham, dfaure, #dolphin Reviewed By: dfaure Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28950
2020-04-14Allow to display UDS_RECURSIVE_SIZE in status barMéven Car
Summary: Useful for trash:/ in particular Test Plan: {F8233980} Reviewers: #dolphin, dfaure, elvisangelaccio, ngraham Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28794
2020-04-05Use same logic for "no extension" case with Duplicate featureNate Graham
Summary: In the "no extension" case, we weren't separating out the path and the original filename, breaking the feature for languages where the word "copy" would be at the beginning of the filename, not after it (e.g. "copia de foo" in Spanish, and similar in other romance languages). This patch fixes that by separating the original path and filename in the no extension case as is done for the other case, which should solve the issue. BUG: 419070 FIXED-IN: 20.04.0 Test Plan: No changes in English; should fix the issue in Spanish once new translations are done (see https://bugs.kde.org/show_bug.cgi?id=419070 for details) Reviewers: #dolphin, elvisangelaccio, arojas, meven, pino, #localization Reviewed By: #dolphin, elvisangelaccio Subscribers: aacid, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28227
2020-03-17Select new duplicated itemsElvis Angelaccio
Summary: This should have been part of commit 405dd624fb Test Plan: Duplicate item and make sure it gets selected. Reviewers: ngraham Reviewed By: ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28084
2020-03-15Add Duplicate featureNathaniel Graham
Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any. Test Plan: {F5201386} {F5201393} Test cases: - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out - Try to duplicate anything on a read-only local volume: **PASS**: menu item is grayed out - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected - Duplicate single local directory on R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected - Try to undo a successful duplication: **PASS**: operation is undone This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :) Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D8208
2020-03-01Merge branch 'release/19.12'Alexander Saoutkin
2020-03-01Fix files not being highlighted if directory of file is already openAlexander Saoutkin
Summary: In DolphinTabWidget::openFiles it assumes openDirectories will open new tabs, so it only marks the URL selection for the newly opened tabs. This assumption is incorrect as Dolphin might reuse tabs when the folder is already open. Even then, markUrlsAsSelected does nothing when the folder is already opened. The selection seems to only be used when the folder finishes loading, calls made after that only change a variable without updating the actual selection. A call to DolphinView::updateViewState() is required to restore the intended behaviour, so long as DolphinView::clearSelection() has been called on the relevant tab, otherwise updateViewState() is a no-op. BUG: 417230 FIXED-IN: 19.12.3 Test Plan: 1. In any application that has an "open containing folder" select that option 2. and then do the same for another file in the same folder Reviewers: broulik Reviewed By: broulik Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D27389