┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src/views
AgeCommit message (Collapse)Author
2013-12-03Fix Bug 328262 - rename bug if you cancel when folder already existsEmmanuel Pescosta
Only connect the renamingFailed signal if there is no item with the new name in the model yet. BUG: 328262 FIXED-IN: 4.11.5 REVIEW: 114228
2013-11-05Merge remote-tracking branch 'origin/KDE/4.11' into KDE/4.12Frank Reininghaus
2013-11-02Fix Bug 287983 - Dolphin truncates tooltip information for long file namesEmmanuel Pescosta
Use KStringHandler and QTextLayout to wrap the text (file name) into the maximum width of the label "name". Make use of QFontMetrics to calculate a font size aware tooltip size. BUG: 287983 FIXED-IN: 4.11.3 REVIEW: 113101
2013-10-30Store the selected items in a more efficient wayFrank Reininghaus
Since Dolphin 2.0, we have stored the selected items in a QSet<int>, which is neither space-efficient nor particularly fast when inserting many items which are in a consecutive range. This commit replaces the QSet<int> by a new class "KItemSet", which stores the items in a sorted list of ranges. For each range, we only store the first index and the length of the range, so we need a lot less memory for most common selection patterns, and we also save quite a few CPU cycles in many situations, because adding an item to the KItemSet will in many cases not need a memory allocation at all, and it's particularly easy when inserting sorted items into the KItemSet in a row. KItemSet contains a minimal subset of QSet's API which makes it suitable as a drop-in replacement for our needs. It also has iterators, such that the items can be iterated through easily, also with foreach. One advantage of KItemSet compared to QSet<int> is that the items are always iterated through in ascending order. REVIEW: 113488
2013-10-16Abort loading the current URL if the user presses EscapeFrank Reininghaus
BUG: 323181 FIXED-IN: 4.12.0 REVIEW: 113234
2013-10-01Merge remote-tracking branch 'origin/KDE/4.11'Frank Reininghaus
2013-09-29Show the right version states for expanded items.Emmanuel Pescosta
BUG: 267171 FIXED-IN: 4.11.3 REVIEW: 112980
2013-09-27SVN_SILENT made messages (.desktop file)l10n daemon script
2013-09-27SVN_SILENT made messages (.desktop file)l10n daemon script
2013-08-28Replaced all KNewFileMenu usages in DolphinPart by DolphinNewFileMenu.Emmanuel Pescosta
Removed all signal-slot-connections related to DolphinNewFileMenu->errorMessage(QString) in DolphinMainWindow and DolphinContextMenu and replaced it by a better solution. Now we make use of the already existing DolphinNewFileMenuObserver singleton class to achieve a better error handling, because every newly created DolphinContextMenu instance registers himself by DolphinNewFileMenuObserver and we use this to connect the errorMessage(QString) signal of every DolphinContextMenu instance to the errorMessage(QString) signal of the DolphinNewFileMenuObserver singleton class. So we need only one connection from DolphinNewFileMenuObserver to DolphinMainWindow (or to DolphinPart) to collect all error messages thrown by every DolphinNewFileMenu instance. REVIEW: 112178
2013-08-18dolphin: Show full file info in statusbar when only one file is selectedFabio D'Urso
The purpose of this change is to give the user a chance to see hover file information if it doesn't fit in the status bar, by allowing to click on the file and hover on the status bar. As it's now possible to have status bar texts starting with "<qt>", DolphinPart::updateStatusBar() must escape strings. Otherwise, filenames such as "<qt>Tes<font color=red>t" would be rendered as HTML data in konqueror's status bar when selected. BUG: 260717 FIXED-IN: 4.12.0 REVIEW: 111934
2013-07-31Do not enable the "Create New..." menu when a search is finishedFrank Reininghaus
BUG: 321577 FIXED-IN: 4.12.0 REVIEW: 111805
2013-07-29Merge remote-tracking branch 'origin/KDE/4.11'Frank Reininghaus
2013-07-29When pasting a folder and expanding it, do not select its childrenFrank Reininghaus
Thanks to Emmanuel for pointing out a problem with my first patch. BUG: 322965 FIXED-IN: 4.11.0 REVIEW: 111722
2013-07-26Don't open .desktop files with http:/https: urls in Dolphin,Emmanuel Pescosta
open these urls in the default browser instead. BUG: 283475 BUG: 318217 FIXED-IN: 4.11.0 REVIEW: 111674
2013-07-24Make sure that widgets are initialized when changing the view modeFrank Reininghaus
The problem was that DolphinItemListView overrides the virtual function onItemLayoutChanged() without calling the base class implementation. Therefore, KStandardItemListView::updateLayoutOfVisibleItems(), which calls initializeItemListWidget(), is never called. This patch refactors the "change item layout"/"supports item expanding" code a bit to make it more robust and fix the problem that the view looks "messed up" when switching from Details View without expandable folders to Icons View. I'm only pushing this patch to master (going to be KDE 4.12). The patch is a bit too intrusive for the KDE/4.11 branch for my taste at this point of the release cycle, and the bug is not a real showstopper. If it works well in master, one could consider backporting it to a 4.11.x bug fix release. Thanks to Emmanuel Pescosta for helping to analyze this issue. BUG: 302703 REVIEW: 111632 FIXED-IN: 4.12.0
2013-06-26Fix the "dropped files are not selected" regression that hasEmmanuel Pescosta
recently been brought up and that have been caused by review 107351 / commit fd65a97b0787b23246c9392fdc34173fb604c9ca CCBUG: 233335 FIXED-IN: 4.11.0 REVIEW: 111254
2013-06-24Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-23Prevent possible infinite recursion in ViewPropertiesFrank Reininghaus
If each directory can have its own view properties, and loadting the .directory file fails in a directory, we have to load the global view properties. However, if we try to do this by changing the "global view properties setting" and loading the view properties for the same directory again, we might get an infinite recursion if changing the setting fails. We now force a loading of the global view properties by constructing a new ViewProperties object with an empty URL. Thanks to Kurt Hindenburg for helping to debug this issue (which was only reproducible on MacOS). BUG: 316209 FIXED-IN: 4.10.5 REVIEW: 111182
2013-06-22Update the "Move to Trash" action's and the "Delete" action'sEmmanuel Pescosta
enabled state in the context menu for read only files/folders (also archives). BUG: 294013 FIXED-IN: 4.11 REVIEW: 111160
2013-06-22Make sure that changing the view mode does not failFrank Reininghaus
This commit ensures that changing the view mode works even if the .directory file in the user's KDE folder is not writable. BUG: 318534 FIXED-IN: 4.11.0 REVIEW: 111120
2013-06-22Enable KIO error reporting when renaming with the dialogFrank Reininghaus
The problem was that the KonqOperations object did not have the right parent. BUG: 299646 FIXED-IN: 4.11.0 REVIEW: 111111
2013-06-20Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-20Allow renaming multiple files without number if extensions are differentFrank Reininghaus
Normally, we only allow renaming multiple files if the new file name contains a contiguous sequence of '#' placeholders, which are then replaced by numbers. However, if all extensions are different, we can also rename the files without such a placeholder because the original extension is preserved when renaming. This had been possible some time ago already. That this "accidental feature" was lost was a side effect of the fix for bug 318942. BUG: 321234 FIXED-IN: 4.10.5 REVIEW: 111079
2013-06-13Fix "unused parameter" warningFrank Reininghaus
We don't need the parameter at all, so let's just remove it.
2013-06-10Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-10Do not rename files unexpectedly when changing the URLFrank Reininghaus
This is the real fix now - note that the last commit 4de9a233642a62ee96bac6031340d3eea21f14f9 was actually the fix for bug 320823. Somehow, I have messed up the local branches in my git respository clone - sorry for the confusion! BUG: 319912 FIXED-IN: 4.10.5 REVIEW: 110908
2013-06-10Fix Bug 319119 - Dolphin doesn't notice when renaming failedEmmanuel Pescosta
Change the data in the model before the real renaming is done by KonqOperations::rename(), but when the rename operation fails, revert the data changes in the model. BUG: 319119 REVIEW: 110922
2013-06-09Do not delete files when Shift-clicking "Trash"Frank Reininghaus
Thanks to Dawit Alemayehu for making this fix possible with commit 8e023ae9e5051cb7b81af86a178e37c1f2c5da94 ! BUG: 307254 FIXED-IN: 4.11.0
2013-06-05move focus to another view upon dropWeng Xuetian
When user drag and drop to another splitted view, the view will be activated, thus if user close the split view, the view will be closed, while this is usually the case when user copy file to remote/removable media. REVIEW: 110167 CCBUG: 312834
2013-06-04Bug 196035 - middle clicking on archive files in dolphin does not open them ↵Emmanuel Pescosta
in a new tab When 'browse through archives' is enabled, open archive files like folders on middle clicking, context menu -> new tab action and context menu -> new window action. BUG: 196035 REVIEW: 110487
2013-05-11Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
Conflicts: CMakeLists.txt
2013-05-10Don't try to change the icon of the "sort" action menu if it doesn't existDaniel Faust
BUG: 255819 FIXED-IN: 4.10.4 REVIEW: 109966
2013-05-02Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-05-02Rename multiple files: Determine correctly if the name pattern is validFrank Reininghaus
The "Rename" button in the dialog should be enabled if and only if the "new name" pattern is valid. This is the case if the pattern contains exactly one sequence of '#', which will be replaced by digits. This patch fixes the problem that (a) A pattern that contains a single '#' is not considered valid, and (b) A pattern without any '#' at all is not recognized as invalid. BUG: 318942 FIXED-IN: 4.10.3 REVIEW: 110223
2013-04-23Scroll to newly pasted files.Emmanuel Pescosta
If multiple files are pasted, scroll to the first pasted file. BUG: 315722 REVIEW: 109950 FIXED-IN: 4.11.0
2013-03-15SVN_SILENT made messages (.desktop file)Script Kiddy
2013-03-15SVN_SILENT made messages (.desktop file)Script Kiddy
2013-03-14SVN_SILENT made messages (.desktop file)Script Kiddy
2013-03-14SVN_SILENT made messages (.desktop file)Script Kiddy
2013-01-24Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-01-22Make the "A folder cannot be dropped into itself" message less intrusiveFrank Reininghaus
Showing this message in the KMessageWidget above the view, which means that the view contents are moved down, can be extremely annoying according to user feedback. Just showing the message in the status bar is probably enough. BUG: 313466 REVIEW: 108483 FIXED-IN: 4.10.0
2013-01-16Merge remote-tracking branch 'origin/KDE/4.10'Luca Beltrame
2013-01-16SVN_SILENT made messages (.desktop file)Script Kiddy
2013-01-15The locking around the plugin access in actions doesn't seem to beSimeon Bird
necessary, as actions is only called from the main thread. Also it wasn't checked consistently; if the lock could not be taken, the plugin was accessed anyway.
2013-01-15We don't need the mutex guarding m_itemStates in theSimeon Bird
UpdateItemStatesThread, because m_itemStates is only accessed by the when the thread is done, and set before the thread starts. Also combine the setData function with the constructor.
2013-01-15Merge branch 'KDE/4.10'Simeon Bird
2013-01-15A crash occurs if updateItemStates runs between theSimeon Bird
UpdateItemStatesThread finishing and the finished() signal being delivered. In this case, a new thread was not created, because the old thread still existed. However, pendingItemStatesUpdate was not set, because the thread was not running. Instead, the old thread was restarted. This meant that the finished() signal from the first run could be delivered while the thread was running for a second time, causing the thread to be deleted while still running and thus a crash. Solution: set pendingItemStatesUpdate if the thread is non-null, even if it is not running, knowing that slotThreadFinished has not yet run, and will call updateItemStates itself. BUG: 302264 FIXED-IN: 4.10 REVIEW: 107656
2013-01-12Merge remote-tracking branch 'origin/KDE/4.10'Luca Beltrame
2013-01-11Show the file name as plain text in the file-metadata-tooltipEmmanuel Pescosta
FIXED-IN: 4.10 BUG: 262464 REVIEW: 108336
generated by cgit v1.3 (git 2.53.0) at 2026-04-21 15:27:57 +0000