┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2012-12-17Fix Bug 287829 - inline rename multiple files does not honourEmmanuel Pescosta
sort order BUG: 287829 FIXED-IN: 4.9.5 REVIEW: 107718
2012-12-12Fix Bug 240820 - [Usability Bug] Handling Bad Filenames, dolphin gives ↵Emmanuel Pescosta
unclear error message Fix Bug 308597 - Regression: Renaming a file/folder to something that contains a "/" will result in several message boxes Uses the same solution as Dolphin-Rename-Dialog does. (KIO::encodeFileName) BUG: 240820 BUG: 308597 REVIEW: 107681 FIXED-IN: 4.9.5
2012-12-10SVN_SILENT made messages (.desktop file)Script Kiddy
2012-12-07Fix keyboard focus handling after renaming items inlineFrank Reininghaus
This reverts 951cb9c35d7a9ef814b3de5b359915968da9b881 and 3143acc084d54d43df469b54762bfa10a7050a9f, and fixes the crash caused by nested event loops by delaying the deletion of the KItemListRoleEditor until the next item is renamed inline. BUG: 311206 FIXED-IN: 4.9.5 REVIEW: 107606
2012-12-06Fix incorrect usage of list iteratorsFrank Reininghaus
The problem was that we erased an iterator from the list and then incremented it. This can lead to problems (namely, random crashes) if the iterator pointed to the last list element. Thanks to Sandro Mani for testing the patch! BUG: 311246 FIXED-IN: 4.9.5
2012-12-05Added curly brackets around DolphinApplication creation and execution, to ↵Hugo Pereira Da Costa
make sure it is deleted before "return 0;" is called. This might prevent random crashes due to the de-allocation chain in Qt at exit. CCBUG: 311092
2012-11-25Fix Bug 310465 - Can't switch view mode for non-writable pathsEmmanuel Pescosta
BUG: 310465 FIXED-IN: 4.9.4 REVIEW: 107458
2012-11-25Fix regression caused by 4120805872c2e9fac909a403b83221c09c9110a2Frank Reininghaus
Copied items should not be shown in gray. Thanks to Christoph Feck for testing and reporting this regression! CCBUG: 304615 CCMAIL: [email protected]
2012-11-24Clear the previous selection when selecting pasted or dropped itemsFrank Reininghaus
This fixes a recent regression in the 4.9 branch caused by b25059e803e7eed54f0593605a4066882d63bce2. BUG: 310365 FIXED-IN: 4.9.4 REVIEW: 107389
2012-11-24Update the 'isCut' state of items when cutting non-files, e.g., textFrank Reininghaus
BUG: 304615 FIXED-IN: 4.9.4 REVIEW: 107390
2012-11-24Delete FileMetaDataToolTip using deleteLater() to prevent crashesFrank Reininghaus
The problem was that Qt tried to deliver an 'Enter' event to the dangling pointer that once pointed to the tool tip. Many thanks to G. Christ for finding a way to reproduce this crash! BUG: 282257 BUG: 310579 FIXED-IN: 4.9.4
2012-11-18Only select a created item and make it 'current' in the active viewFrank Reininghaus
The 'make the new item the current one in all views' issue has been around for quite some time, the unexpected selection was a recent regression caused by commit b25059e803e7eed54f0593605a4066882d63bce2. Thanks to Jaime Torres for finding the regression early and for testing this patch! BUG: 310219 FIXED-IN: 4.9.4
2012-11-09Fix Bug 217575 - Auto select pasted files doesn't select all files if some ↵Emmanuel Pescosta
have been skipped BUG: 217575 REVIEW: 107237 FIXED-IN: 4.9.4
2012-11-09Fix Bug 309760 - Crash while inline-renaming a file and apply change with ↵Emmanuel Pescosta
return-key BUG: 309760 FIXED-IN: 4.9.4
2012-11-05Prevent crashes caused by nested event loops run when renaming inlineFrank Reininghaus
When renaming inline and starting a drag or invoking the context menu, a nested event loop will be run. If the role editor loses focus and emits roleEditingFinished(), we must prevent that deleteLater() is called because this would delete the role editor inside a nested event loop which is run from one of its own functions. We would get a crash when returning from that event loop otherwise. BUG: 308018 BUG: 309421 FIXED-IN: 4.9.4
2012-11-04Do not use a hardcoded size for the buttons in the Information panelFrank Reininghaus
Thanks to Kai Uwe Broulok and Jekyll Wu for the investigation! BUG: 309498 FIXED-IN: 4.9.4
2012-11-01Removed customm setText for mtp devices and check for kio_mtpAlex Fiestas
We are already checking if kio_mtp is installed when we build the predicate so we don't need to check if it is installed again. Also, the fix for "Showing the product as a name for some kind of massive storage" will have to be delayed to 4.9.4, so removing this.
2012-10-31Do not show an incorrect file name after a failed rename operationFrank Reininghaus
BUG: 303742 FIXED-IN: 4.9.3
2012-10-31Only store the HomeUrl in dolphinrc if it is not the user's home folderFrank Reininghaus
This fixes the problem that copying the dolphinrc from another user results in Dolphin starting up in a folder that might wither not be accessible or not exist at all. BUG: 308569 FIXED-IN: 4.9.3
2012-10-31Fix Bug 309338 - flood of error boxes while renaming a folder in the folder ↵Emmanuel Pescosta
panel BUG: 309338 FIXED-IN: 4.9.3 REVIEW: 107070
2012-10-30Fix Bug 279333 - Panels can be moved even if lockedEmmanuel Pescosta
BUG: 279333 FIXED-IN: 4.9.3 REVIEW: 107135
2012-10-27Workaround for failed comparison of items in KFileItemModelRolesUpdaterFrank Reininghaus
The real fix is in the KDE/4.10 branch of kdelibs (commit b8f64ca3f4b6311519c21046031d66d9d0a570c6). We work around the problem that the KFileItem that a preview has been requested for is different from the KFileItems in the sets m_pendingVisibleItems and m_pendingInvisibleItems by refreshing those sets when we detect that the bug has been triggered. BUG: 304986 FIXED-IN: 4.9.3
2012-10-26Fix color role of tree view arrowsChristoph Feck
BUG: 307734 FIXED-IN: 4.9.3 REVIEW: 107031
2012-10-24Show MTP devices in case support for it is installedAlex Fiestas
Basically adds a conditional that in case that mtp kioslave is installed devices with MTP are added to the predicated. REVIEW: 106651 (cherry picked from commit a09a23795050be4ad6e2c987614cb28096030cc8)
2012-10-19Fix race condition and deadlock in the version pluginSimeon Bird
when listing directories is slow. BUG: 302264 FIXED-IN: 4.9.3
2012-10-07Use not only Alt+Return, but also Alt+Enter as shortcut for "Properties"Amol Godbole
BUG: 307603 REVIEW: 106753 FIXED-IN: 4.9.3
2012-10-03Fix the hidden "EnlargeSmallPreviews" optionFrank Reininghaus
This option, introduced in 99e4eb0f3a58c53277b099114a5fd8945937fb9a, did not work any more since 2069c200211c93e401c3d19850f41eade09d64be. CCBUG: 307522
2012-09-29Find out the main window by calling the parent widget's window() memberFrank Reininghaus
KFileItemModel calls the dir lister's setMainWindow() method to make sure that the dir lister caches authentication data. However, the method used to determine the main window (qApp->activeWindow()) is not guaranteed to yield the DolphinMainWindow or the KonqMainWindow. In particular, if "Split View" is enabled in Dolphin's settings dialog, the active window is the dialog, and when it is closed, any later access to the stored pointer leads to a crash. A better method is to verify that the model's parent is a QWidget and then use this widget's window(). I had to make a small modification in DolphinMainWindow to make sure that it also works correctly when the view is split (the new view container had been created with a 0 parent previously). I tested it in Dolphin and Konqueror and verified that the "main window" passed to the dir lister is really the application's main window. BUG: 306459 FIXED-IN: 4.9.3
2012-09-28Redo the fix for CTRL+Tab not working when using Dolphin's filemanagement partDawit Alemayehu
in Konqueror. The original fix, commit 4f7ed2b, prevents drag and drop from working correctly. CCBUG: 302329 REVIEW: 106569
2012-09-28Dolphin Places: Only show file results in Nepomuk QueriesVishesh Handa
Dolphin is a file manager, and shouldn't be concerned with non-file resources like notes, contacts and other stuff. Use FileQuery instead of Query. This also results in a faster queries. With File Queries Nepomuk can perform some internal optimizations. BUG: 306029 REVIEW: 106274 Cherry-picked from 6892d39d292d4f64d808e64c58ef20fa081f0259
2012-09-27Add a new config option for the icon size in the Places PanelFrank Reininghaus
To change the icon size in the Places Panel to, e.g., 60 pixels, add the following lines to $KDEHOME/share/config/dolphinrc : [PlacesPanel] IconSize=60 A value of -1 means that the standard "Small" size should be used (which has been the default before this commit). It is planned to add an "Icon Size" submenu to the context menu of the Places Panel in KDE 4.10, but we cannot do this in the 4.9 branch because of the string freeze. FIXED-IN: 4.9.2 BUG: 301959
2012-09-26Fix a Bug in KFileItemModelRolesUpdate::setEnabledPlugins.Emmanuel Pescosta
Changes were never overtaken because of a wrong comparison. FIXED-IN: 4.9.2
2012-09-26Fixed CTRL+Tab not working when using Dolphin's filemanagement part in ↵Dawit Alemayehu
Konqueror. BUG: 302329 FIXED-IN: 4.9.2 REVIEW: 106569
2012-09-25Fixes Bug 305783 - dragging a file over a directory #c4Emmanuel Pescosta
does not expand the dir => Bug discovered: When you drag a item onto a folder-view-item and then move it away instantly before the autoactivation event is triggered (After 750ms), the folder will be opened anyway. BUG: 305783 REVIEW: 106381 FIXED-IN: 4.9.2 (cherry picked from commit 9ab8bcd6aa3ce5d96ee380d5f22d77c2f0a38881)
2012-09-24Fix crash when receiving Nepomuk info for a recently deleted file.Frank Reininghaus
BUG: 306036 FIXED-IN: 4.9.2
2012-09-20Fix Bug 297355 - Dolphin leaves file preview tooltips open even when is not ↵Emmanuel Pescosta
visible BUG: 297355 FIXED-IN: 4.9.2 REVIEW: 106499
2012-09-20Restore old behavior: Navigating by double-clicking in folder panel ↵Emmanuel Pescosta
(Double-Click - show folder content and expand folder) BUG: 295573 REVIEW: 106497 FIXED-IN: 4.9.2
2012-09-20Fixes Bug 304878 - Dolphin shows "ghost" folders in places after autofs ↵Emmanuel Pescosta
umount nfs shares BUG: 304878 REVIEW: 106456 FIXED-IN: 4.9.2
2012-09-19Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve originEmmanuel Pescosta
Patch 106381 Comment #3: When "Open folders during drag operations" is enabled, two things happen, both in the DolphinView and in the Folders Panel: 1) When hovering a folder that can be expanded (this is the case for folders with sub-folders in the Folders Panel and in the DolphinView if in Details View mode), toggle its "expanded" state. 2) When hovering a folder that can not be expanded (i.e., a folder without sub-folders or any folder in Icons or Compact View), open this folder in the DolphinView via the KItemListController's itemActivated(int) signal. The bug described in bug 293200 comment 3 is that 1) is always wanted, but 2) is not wanted for the Folders Panel. BUG: 293200 FIXED-IN: 4.9.2
2012-09-19Prevent unwanted URL changes when using the Terminal PanelFrank Reininghaus
The root cause of the problem was that TerminalPanel's member m_konsolePartCurrentDirectory, which is used to determine in TerminalPanel::sendCdToTerminal(QString& dir) if the Konsole part's directory is aleady 'dir', such that issuing the 'cd' command is not needed, was updated too late, namely when the part's currentDirectoryChanged(QString) signal was received, which may be up to one second after the 'cd' command. When changing the directory from "dir1" to "dir2" and going back to the "dir1" in less than one second (either by using the 'Back' action or by activating a tab which still had "dir1" open), the 'cd dir1' command was therefore suppressed because the Terminal Panel still thought that "dir1" was the current directory in the part. However, the directory of the part was actually "dir2", and when the currentDirectoryChanged(QString) signal was received from the part, the view's URL was set to "dir2" as well. BUG: 306349 BUG: 304838 FIXED-IN: 4.9.2
2012-09-15Corrected the compile fix commit, rev 965fc6b3.Dawit Alemayehu
2012-09-12Re-enable renaming items with the rename dialogFrank Reininghaus
User feedback has shown that many users used the dialog for renaming files. Since the dialog is still used when renaming multiple files, I think there is no good reason not to use it for renaming single files as well if the user wants. Note that we cannot add an option in the settings dialog due to string freeze issues. For the time being, you will have to add the line "RenameInline=false" to the [General] section of $KDEHOME/share/config/dolphinrc. BUG: 304627 FIXED-IN: 4.9.2
2012-09-11Fix compile against the minimum required kdelibs version (v4.7.97)Dawit Alemayehu
2012-09-11Mount unmounted devices, when a file is dropped upon it in places-panel.Emmanuel Pescosta
BUG: 176277 REVIEW: 106072 FIXED-IN: 4.9.2 (cherry picked from commit 824fa6a43734cf9ad2a690778c50bdaf76a1fb0e)
2012-09-11Fix possible crash when refreshing the view while renaming inlineFrank Reininghaus
It is not reproducible on every machine for me, but it seems that it can happen that DolphinView's slot slotRoleEditingFinished() is invoked after the items have already been removed from the model. In that case, we have to return from the slot immediately to prevent a crash. BUG: 306147 FIXED-IN: 4.9.2
2012-09-11Fix possible crash in KStandardItemListWidget::paint()Frank Reininghaus
According to the backtrace in the bug report, it is possible that KStandardItemListWidget::paint() is called if the hash m_textInfo has not been initialised. The widget's index must be -1 in this case, see KStandardItemListWidget::triggerCacheRefreshing(). It looks like this can only happen if the item is about to be removed from the view, see KItemListView::slotItemsRemoved(). I could not reproduce the crash, so I'm not sure why exactly this happens, but this commit should at least prevent the crash. BUG: 306167 FIXED-IN: 4.9.2
2012-09-11Use a better icon for recently accessed items, part 2Frank Reininghaus
I had missed one places where the incorrect icon was used in my previous commit d7e7ca53bb95c7555bbf107d92b47ac25eda1918. BUG: 304323 FIXED-IN: 4.9.2
2012-09-07Implemented the new KParts extension, KParts::ListingiNotificationExtension.Dawit Alemayehu
REVIEW: 106333
2012-09-06Do not show '-' for additional info which is not available for an itemFrank Reininghaus
I'm only backporting the removal of the '-', not the update for the line number calculation in Icons View, because this is the safest part of the patch and also the one that fixes the most annoying part of the bug. Thanks to Todd Jennings for the patch! BUG: 304752 REVIEW: 106304 (cherry picked from commit 20b0cb68bf5cc1099fd6e61982817d9e2ae0130c)
2012-09-05Implemented the new KParts' listing filter extension, ↵Dawit Alemayehu
KParts::ListingFilterExtension. REVIEW: 106289
generated by cgit v1.3.1 (git 2.54.0) at 2026-05-13 20:09:47 +0000