┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2012-10-19Fix race condition and deadlock in the version pluginSimeon Bird
when listing directories is slow. BUG: 302264 FIXED-IN: 4.9.3
2012-10-07Use not only Alt+Return, but also Alt+Enter as shortcut for "Properties"Amol Godbole
BUG: 307603 REVIEW: 106753 FIXED-IN: 4.9.3
2012-10-03Fix the hidden "EnlargeSmallPreviews" optionFrank Reininghaus
This option, introduced in 99e4eb0f3a58c53277b099114a5fd8945937fb9a, did not work any more since 2069c200211c93e401c3d19850f41eade09d64be. CCBUG: 307522
2012-09-29Find out the main window by calling the parent widget's window() memberFrank Reininghaus
KFileItemModel calls the dir lister's setMainWindow() method to make sure that the dir lister caches authentication data. However, the method used to determine the main window (qApp->activeWindow()) is not guaranteed to yield the DolphinMainWindow or the KonqMainWindow. In particular, if "Split View" is enabled in Dolphin's settings dialog, the active window is the dialog, and when it is closed, any later access to the stored pointer leads to a crash. A better method is to verify that the model's parent is a QWidget and then use this widget's window(). I had to make a small modification in DolphinMainWindow to make sure that it also works correctly when the view is split (the new view container had been created with a 0 parent previously). I tested it in Dolphin and Konqueror and verified that the "main window" passed to the dir lister is really the application's main window. BUG: 306459 FIXED-IN: 4.9.3
2012-09-28Redo the fix for CTRL+Tab not working when using Dolphin's filemanagement partDawit Alemayehu
in Konqueror. The original fix, commit 4f7ed2b, prevents drag and drop from working correctly. CCBUG: 302329 REVIEW: 106569
2012-09-28Dolphin Places: Only show file results in Nepomuk QueriesVishesh Handa
Dolphin is a file manager, and shouldn't be concerned with non-file resources like notes, contacts and other stuff. Use FileQuery instead of Query. This also results in a faster queries. With File Queries Nepomuk can perform some internal optimizations. BUG: 306029 REVIEW: 106274 Cherry-picked from 6892d39d292d4f64d808e64c58ef20fa081f0259
2012-09-27Add a new config option for the icon size in the Places PanelFrank Reininghaus
To change the icon size in the Places Panel to, e.g., 60 pixels, add the following lines to $KDEHOME/share/config/dolphinrc : [PlacesPanel] IconSize=60 A value of -1 means that the standard "Small" size should be used (which has been the default before this commit). It is planned to add an "Icon Size" submenu to the context menu of the Places Panel in KDE 4.10, but we cannot do this in the 4.9 branch because of the string freeze. FIXED-IN: 4.9.2 BUG: 301959
2012-09-26Fix a Bug in KFileItemModelRolesUpdate::setEnabledPlugins.Emmanuel Pescosta
Changes were never overtaken because of a wrong comparison. FIXED-IN: 4.9.2
2012-09-26Fixed CTRL+Tab not working when using Dolphin's filemanagement part in ↵Dawit Alemayehu
Konqueror. BUG: 302329 FIXED-IN: 4.9.2 REVIEW: 106569
2012-09-25Fixes Bug 305783 - dragging a file over a directory #c4Emmanuel Pescosta
does not expand the dir => Bug discovered: When you drag a item onto a folder-view-item and then move it away instantly before the autoactivation event is triggered (After 750ms), the folder will be opened anyway. BUG: 305783 REVIEW: 106381 FIXED-IN: 4.9.2 (cherry picked from commit 9ab8bcd6aa3ce5d96ee380d5f22d77c2f0a38881)
2012-09-24Fix crash when receiving Nepomuk info for a recently deleted file.Frank Reininghaus
BUG: 306036 FIXED-IN: 4.9.2
2012-09-20Fix Bug 297355 - Dolphin leaves file preview tooltips open even when is not ↵Emmanuel Pescosta
visible BUG: 297355 FIXED-IN: 4.9.2 REVIEW: 106499
2012-09-20Restore old behavior: Navigating by double-clicking in folder panel ↵Emmanuel Pescosta
(Double-Click - show folder content and expand folder) BUG: 295573 REVIEW: 106497 FIXED-IN: 4.9.2
2012-09-20Fixes Bug 304878 - Dolphin shows "ghost" folders in places after autofs ↵Emmanuel Pescosta
umount nfs shares BUG: 304878 REVIEW: 106456 FIXED-IN: 4.9.2
2012-09-19Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve originEmmanuel Pescosta
Patch 106381 Comment #3: When "Open folders during drag operations" is enabled, two things happen, both in the DolphinView and in the Folders Panel: 1) When hovering a folder that can be expanded (this is the case for folders with sub-folders in the Folders Panel and in the DolphinView if in Details View mode), toggle its "expanded" state. 2) When hovering a folder that can not be expanded (i.e., a folder without sub-folders or any folder in Icons or Compact View), open this folder in the DolphinView via the KItemListController's itemActivated(int) signal. The bug described in bug 293200 comment 3 is that 1) is always wanted, but 2) is not wanted for the Folders Panel. BUG: 293200 FIXED-IN: 4.9.2
2012-09-19Prevent unwanted URL changes when using the Terminal PanelFrank Reininghaus
The root cause of the problem was that TerminalPanel's member m_konsolePartCurrentDirectory, which is used to determine in TerminalPanel::sendCdToTerminal(QString& dir) if the Konsole part's directory is aleady 'dir', such that issuing the 'cd' command is not needed, was updated too late, namely when the part's currentDirectoryChanged(QString) signal was received, which may be up to one second after the 'cd' command. When changing the directory from "dir1" to "dir2" and going back to the "dir1" in less than one second (either by using the 'Back' action or by activating a tab which still had "dir1" open), the 'cd dir1' command was therefore suppressed because the Terminal Panel still thought that "dir1" was the current directory in the part. However, the directory of the part was actually "dir2", and when the currentDirectoryChanged(QString) signal was received from the part, the view's URL was set to "dir2" as well. BUG: 306349 BUG: 304838 FIXED-IN: 4.9.2
2012-09-15Corrected the compile fix commit, rev 965fc6b3.Dawit Alemayehu
2012-09-12Re-enable renaming items with the rename dialogFrank Reininghaus
User feedback has shown that many users used the dialog for renaming files. Since the dialog is still used when renaming multiple files, I think there is no good reason not to use it for renaming single files as well if the user wants. Note that we cannot add an option in the settings dialog due to string freeze issues. For the time being, you will have to add the line "RenameInline=false" to the [General] section of $KDEHOME/share/config/dolphinrc. BUG: 304627 FIXED-IN: 4.9.2
2012-09-11Fix compile against the minimum required kdelibs version (v4.7.97)Dawit Alemayehu
2012-09-11Mount unmounted devices, when a file is dropped upon it in places-panel.Emmanuel Pescosta
BUG: 176277 REVIEW: 106072 FIXED-IN: 4.9.2 (cherry picked from commit 824fa6a43734cf9ad2a690778c50bdaf76a1fb0e)
2012-09-11Fix possible crash when refreshing the view while renaming inlineFrank Reininghaus
It is not reproducible on every machine for me, but it seems that it can happen that DolphinView's slot slotRoleEditingFinished() is invoked after the items have already been removed from the model. In that case, we have to return from the slot immediately to prevent a crash. BUG: 306147 FIXED-IN: 4.9.2
2012-09-11Fix possible crash in KStandardItemListWidget::paint()Frank Reininghaus
According to the backtrace in the bug report, it is possible that KStandardItemListWidget::paint() is called if the hash m_textInfo has not been initialised. The widget's index must be -1 in this case, see KStandardItemListWidget::triggerCacheRefreshing(). It looks like this can only happen if the item is about to be removed from the view, see KItemListView::slotItemsRemoved(). I could not reproduce the crash, so I'm not sure why exactly this happens, but this commit should at least prevent the crash. BUG: 306167 FIXED-IN: 4.9.2
2012-09-11Use a better icon for recently accessed items, part 2Frank Reininghaus
I had missed one places where the incorrect icon was used in my previous commit d7e7ca53bb95c7555bbf107d92b47ac25eda1918. BUG: 304323 FIXED-IN: 4.9.2
2012-09-07Implemented the new KParts extension, KParts::ListingiNotificationExtension.Dawit Alemayehu
REVIEW: 106333
2012-09-06Do not show '-' for additional info which is not available for an itemFrank Reininghaus
I'm only backporting the removal of the '-', not the update for the line number calculation in Icons View, because this is the safest part of the patch and also the one that fixes the most annoying part of the bug. Thanks to Todd Jennings for the patch! BUG: 304752 REVIEW: 106304 (cherry picked from commit 20b0cb68bf5cc1099fd6e61982817d9e2ae0130c)
2012-09-05Implemented the new KParts' listing filter extension, ↵Dawit Alemayehu
KParts::ListingFilterExtension. REVIEW: 106289
2012-08-29fix missing enumWeng Xuetian
REVIEW: 106239
2012-08-27Make --select can automatically scroll to the selected file.Weng Xuetian
REVIEW: 106209
2012-08-26Adjust to Ark's drag'n'drop D-Bus interface changes.Raphael Kubo da Costa
Ark's drag'n'drop D-Bus interface needs to be changed: so far, the object path was always /DndExtract, but this does not work if Ark is being used as an embedded KPart (in Konqueror or Rekonq, for example), as all tabs will end up calling QDBusConnection::registerObject() with the same path. Only the first call will work, and the result is that dragging and dropping from any tab previewing an archive with Ark will extract from the first archive being previewed. To fix that, applications that accept the application/x-kde-dndextract mimetype should now be adjusted to check the application/x-kde-ark-dndextract-service and application/x-kde-ark-dndextract-path ones instead; the former contains the same service information that used to be passed, while the latter tells which object path should be talked to. This is the Dolphin part of the change, which also needs to be made to the folderview plasmoid. REVIEW: 106131 CCBUG: 304860
2012-08-24Merge branch 'KDE/4.9' of git://anongit.kde.org/kde-baseapps into KDE/4.9Emmanuel Pescosta
2012-08-24Fix wrong behaviour, when Dolphin is started with --split argument.Emmanuel Pescosta
Actual Results: dolphin starts without split view Expected Results: dolphin starts with split view New behaviour: * no url given - use default url for all two views * one url given - use given url for all two views * two urls given - open the first url in the left view and the second url in the right view BUG: 305538 REVIEW: 106171 FIXED-IN: 4.9.1
2012-08-24Do not crash when finishing inline renaming in unusual waysFrank Reininghaus
The crash was caused by a null pointer dereference when, e.g., minimizing Dolphin. The root cause was that KStandardItemListWidget::closeRoleEditor() was called twice: once when the role editor loses focus, and once again when the window is resized. After m_roleEditor was set to 0, the second call dereferenced this null pointer. I think the best solution is to disconnect from the role editor's signals when the editor is not needed any more by the KStandardItemListWidget. BUG: 304524 FIXED-IN: 4.9.1
2012-08-24Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menusFrank Reininghaus
For top-level roles like "Name" and "Size", the group translation is 0. In that case, the "group" member of the corresponding RoleInfo struct must be an empty string. This is expected by the code which generates Dolphin's menus, which group the top-level roles into a sub menu with the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c. Thanks to Christoph Feck for investigating this issue! CCBUG: 305228
2012-08-23Select the correct item in places-panel, when a directory is opened.Emmanuel Pescosta
BUG: 304541 REVIEW: 106074 FIXED-IN: 4.9.1 (cherry picked from commit 1ec8de2c619006e3fe997fbf6074035d65dea6c5)
2012-08-16Fix translations not showing in the Sort by and Additional Information submenusAlbert Astals Cid
Acked by Frank REVIEW: 106049 BUGS: 305228 FIXED-IN: 4.9.1
2012-08-15Fix wrong text color in Places Group Header. Use QPalette::Window for base ↵Emmanuel Pescosta
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient. BUG: 303133 FIXED-IN: 4.9.1 (cherry picked from commit b3c3da985159a9627c079ad615cd77fc5f7bb72a)
2012-08-13Fix wrong text color in places and in folders panel.Emmanuel Pescosta
FIXED-IN: 4.9.1 REVIEW: 105832 BUG: 303133
2012-08-13Show icon size as tooltip when adjusting icon sizeJekyll Wu
BUG:292700 FIXED-IN: 4.9.1 REVIEW: 105990 (cherry picked from commit 5e87cefd4c17467c3a650b133dc9bdadea22f9f7)
2012-08-10SVN_SILENT made messages (.desktop file)Script Kiddy
2012-08-09Follow-up to d7e7ca53bb95c7555bbf107d92b47ac25eda1918 - use correct iconFrank Reininghaus
I overlooked that "actions/" is not part of the icon name. Just rebuilding and re-running Dolphin did not reveal this issue, it seems that the old icon "package_utility_time" was still cached somewhere. I hope that it really works on all distros now. CCBUG: 304323
2012-08-09Use a better icon for recently accessed items in the Places PanelFrank Reininghaus
The problem with the icon "package_utility_time" that has been used before was that it is not available on all distros. The new icon "actions/chronometer" should be available on every KDE install. Thanks to Elias Probst for suggesting the new icon - I'm not that familiar with the icons provided by KDE myself. BUG: 304323 FIXED-IN: 4.9.1
2012-08-09Use a saner check for multimedia files in infopanel.Martin Sandsmark
Don't rely on the reported supported mimetypes from Phonon, Phonon supports more than just video and audio, but if it is video or audio there's a very good chance Phonon supports it. (If the mime type isn't in the list returned by Phonon there's still a good chance it supports it, because mime types are stupid.) BUG: 252539 FIXED-IN: 4.9.1 (cherry picked from commit 2fb4419de053c43a0a70ffb21920db687fa87b6e)
2012-08-07Fix the size of the rating stars in Icons ViewFrank Reininghaus
Moreover, make sure that the selection rectangle is large enough to include the stars. Patch by Emmanuel Pescosta. Thanks for the patch! BUG: 302624 FIXED-IN: 4.9.1 REVIEW: 105830
2012-08-06Stop preview jobs when closing DolphinFrank Reininghaus
Patch by Benni Hill. Thanks for the patch! BUG: 304467 FIXED-IN: 4.9.1
2012-08-02SVN_SILENT made messages (.desktop file)Script Kiddy
2012-07-30SVN_SILENT made messages (.desktop file)Script Kiddy
2012-07-29msvc needs to have the class definition for reference parameters in methodsPatrick Spendrin
2012-07-24SVN_SILENT made messages (.desktop file)Script Kiddy
2012-07-22Show the "Find File" and "Open Terminal" actions in the Tools for file URLs ↵Dawit Alemayehu
only. BUG: 279283 FIXED-IN: 4.9.0 REVIEW: 105607
2012-07-20Fix compiler warning, which spotted a real bug.David Faure
ItemLayout is an enum, not a flag, so == is even more correct than '&'.
generated by cgit v1.3 (git 2.53.0) at 2026-04-26 01:22:48 +0000