┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2018-10-10Update hidden state correctlyThomas Surrel
Summary: When renaming a file from '.hidden' to 'not_hidden', the file would still be displayed like a hidden file with a semi-transparent icon and a grey text. BUG: 399599 Reviewers: #dolphin, elvisangelaccio Reviewed By: elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16115
2018-10-10Add proper labels to Trash Emptied notificationKai Uwe Broulik
It is not shown by default but when the user enables it, it should show something sensible. Differential Revision: https://phabricator.kde.org/D15589
2018-10-09Added missing icons to panel places itemsAlex Debus
Summary: Screenshots of the changes: | {F6310217} |{F6310218} This contribution was motivated by a comment on [[ https://pointieststick.wordpress.com/2018/10/06/this-week-in-usability-productivity-part-39/comment-page-1/#comment-2108 | Nate's blog]]. Reviewers: #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, acrouthamel, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16019
2018-10-09Added missing QStringLiteral to Dolphin codeAlex Debus
Summary: Changed ``` QIcon::fromTheme("icon") ``` to ``` QIcon::fromTheme(QStringLiteral("edit-entry")) ``` as [[ https://phabricator.kde.org/D16019#339284 | discussed here ]]. Reviewers: ngraham, #dolphin, elvisangelaccio Reviewed By: ngraham, #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16050
2018-10-09Add "Create New" menu to "Control" buttonNathaniel Graham
Summary: Right now, the "Create New" menu's functionality is not visible with Dolphin's default layout that has a {nav Control} button instead of a menubar. This patch adds that functionality to the {nav Control} button's menu so that it's actually discoverable for regular users. Test Plan: {F6304893} All menu items work. Reviewers: #dolphin, broulik, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: acrouthamel, anthonyfieroni, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15609
2018-10-09[PlacesItemModelTest] Try harder to not hardcode indexesElvis Angelaccio
This test is still randomly failing on the CI (only on master though). Let's see if this fixes it for good.
2018-10-09[MountPointObserverCache] Update mounts less frequentlyKai Uwe Broulik
Even on fastest disks, filling up the disk in 10 seconds is unlikely. Moreover, Plasma's "low disk" warning only polls every minute as well and Dolphin doesn't warn you about the fact that it's full. Reduces needless wake ups of disks and network. CCBUG: 398612 Differential Revision: https://phabricator.kde.org/D15507
2018-10-07Fix implicit-fallthrough gcc warningElvis Angelaccio
GIT_SILENT
2018-10-07Drop noisy debug outputElvis Angelaccio
This qCDebug() call shows up at every change of directory and doesn't really add any value.
2018-10-07[DolphinMainWindowTest] Attempt to fix testOpenInNewTabTile() on the CIElvis Angelaccio
Both icon `name()`s are empty on the CI, which probably doesn't have icons or something. This should hopefully fix it.
2018-10-07[DolphinMainWindowTest] Add some debug outputElvis Angelaccio
testOpenInNewTabTitle() is currently failing on the CI, this should help investigate why.
2018-10-07Fix another stale commentElvis Angelaccio
PlacesItemModel::updateBookmarks() is gone since commit da6f8fe0862585287.
2018-10-07Merge branch 'Applications/18.08'Elvis Angelaccio
2018-10-07[PlacesItemModelTest] More index-related fixesElvis Angelaccio
Again, we cannot assume the Desktop and Downloads places are always around.
2018-10-07[PlacesItemModel] Fix testSystemItems()Elvis Angelaccio
2018-10-07[PlacesItemModelTest] Fix testHideItem()Elvis Angelaccio
2018-10-07[PlacesItemModelTest] Fix testTearDownDevice()Elvis Angelaccio
2018-10-07[PlacesItemModelTest] Fix testDeletePlace()Elvis Angelaccio
If the Desktop or Downloads folder is missing, using 5 as index would be wrong.
2018-10-07[PlacesItemModelTest] Fix testGroups() test caseElvis Angelaccio
The test was also assuming that the Desktop and Downloads folders are always available, which isn't the case.
2018-10-07Follow-up of commit 9760f9607dElvis Angelaccio
Also drop the hardcoded model count all over the place.
2018-10-07[PlacesItemModelTest] Check whether Desktop and Download folders existElvis Angelaccio
KFilePlacesModel creates the Desktop and Downloads bookmarks only if their folder exists. This should hopefully fix the failing test on the CI (actual count = 15, expected count = 17), since the CI runs in docker and probably doesn't have those two folders by default.
2018-10-07Fix disabling of DolphinNewFileMenuElvis Angelaccio
Summary: Commit e133c4557ecc37ed3f7e1b9 doesn't work because the actions in the KNewFileMenu are added only when we show the context menu for the first time. Fixes the failing test cases in D16005. Test Plan: Run `dolphinmainwindowtest` and open the context menu in different places (Home, Root, Trash, `bluetooth:/`, etc.) Reviewers: #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16006
2018-10-07Add test cases for enabled status of DolphinNewFileMenuElvis Angelaccio
Summary: Root and Trash test cases are currently failing because of commit e133c4557ecc37ed3f7e1b9418306aa8cc516865. Reviewers: #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16005
2018-10-07Add 'Mount' option to context menu of unmounted device in PlacesThomas Surrel
Summary: This is only a proposal but: 1/ it the sysmetric of the Unmount entry in the context menu of mounted devices 2/ I have to admit it took me a very long time to discover (by accident) that you can just (left-)click on a unmounted device to get it mounted automatically. I might not be the only feeling that you should be able to mount a device from the context menu ... Twin of D15988 in Kio while dolphin is not based on the kio code for Places. {F6306516} Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, elvisangelaccio Subscribers: ngraham, acrouthamel, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15974
2018-10-07Fix stale commentElvis Angelaccio
GIT_SILENT
2018-10-06Merge remote-tracking branch 'origin/Applications/18.08'Jaime Torres Amate
merge https://phabricator.kde.org/D15371
2018-10-06Don't assign twice the same key to the action New TabJaime Torres Amate
Second try: added Qt::CTRL + Qt::Key_T and Qt::CTRL + Qt::SHIFT + Qt::Key_N as QKeySequence::AddTab is only Qt::CTRL + Qt::SHIFT + Qt::Key_N under plasma.
2018-10-04[PlacesItemModel] Update apidoxElvis Angelaccio
Should have been part of da6f8fe0862585287153 (the grouping feature has been moved upstream to KIO).
2018-10-04[PlacesItemModel] Drop unused forward declarationElvis Angelaccio
No longer needed since da6f8fe0862585287153f0d90e. GIT_SILENT
2018-10-04[PlacesItemModel] Drop dead codeElvis Angelaccio
m_bookmarkedItems is long gone (since commit da6f8fe0862585287153). Porting `showModelState()` to the new KFilePlacesModel source model is not worth it, since this was just a debugging function and most of the logic has been moved upstream anyway (see T7040).
2018-10-04Change icon for the 'Edit...' context menu entry in Places panelThomas Surrel
Summary: The current icon is used for displaying the Properties context menu in other places in dolphin. Change to edit-entry. Test Plan: Right-click on a place in the Places panel. Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15938
2018-10-03Merge branch 'Applications/18.08'Andreas Krutzler
2018-10-03Fix that dragging a file can trigger inline rename.Andreas Krutzler
Summary: Inline renaming is aborted as soon as an item is dragged. Previously, ’m_dragging' was used to determine if an item was being dragged. However, inline renaming is triggered after a certain amount of time, during which time the user may have stopped dragging items. BUG: 398375 FIXED-IN: 18.08.2 Test Plan: When dragging an selected item, inline renaming should never be started, regardless of where you drag it (Places panel, other split-view window, out of the Dolphin window, ...). Reviewers: wbauer, elvisangelaccio, #dolphin, ngraham Reviewed By: wbauer, elvisangelaccio, #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15904
2018-09-27Track search mode in variableKai Uwe Broulik
Rather than relying on a widget being visible which might not be the case for e.g. non-active tabs Differential Revision: https://phabricator.kde.org/D15774
2018-09-27Fix window / tab caption in search modeKai Uwe Broulik
A search URL is never local, so this part of the code was never reached, resulting in raw baloosearch or filenamesearch URLs showing up as window and tab title Differential Revision: https://phabricator.kde.org/D15772
2018-09-24[Places Panel] Cleanup includesKai Uwe Broulik
Some leftovers from when Dolphin managed the places entirely on its own Differential Revision: https://phabricator.kde.org/D15636
2018-09-19Update disk space info on refreshKai Uwe Broulik
When explicitly refreshing the view (e.g. F5) also refresh disk space info. This would also allow us to raise the refresh interval somewhat. CCBUG: 398612 Differential Revision: https://phabricator.kde.org/D15508
2018-09-17[ViewProperties] Check part of home first before doing file system stuffKai Uwe Broulik
There's no point in creating a QFileInfo instance and checking for file properties if we're not going to do anything with it when not inside home. Differential Revision: https://phabricator.kde.org/D15237
2018-09-17Keep org.freedesktop.FileManager1 registered across processesDavid Edmundson
Summary: Currently if someone starts 2 dolphins, the second cannot register org.freedesktop.FileManager1 meaning and when the first dolphin quits, no-one has it registered. It doesn't cause a huge problem right now as we just dbus-activate a new one if needed, but it means the behaviour is a bit inconsistent and non-optimal. DBus has a system to queue names, meaning that as long as any dolphin is running this name is owned by one of the processes. Also this patch registers the service after the object which is technically safer. Test Plan: Ran d-feet Opened 2 dolphins, closed the first Service was still registered and the PID of the owning process changed. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15539
2018-09-11Revert "[KFileItemModelRolesUpdater] Avoid duplicate indexes to resolve"Kai Uwe Broulik
Sometimes causes the first thumbnail to not be loaded :/ This reverts commit 033eb6b3a35ca60ce78ce7ccfeeec26d70205aa8.
2018-09-11[KFileItemModelRolesUpdater] Avoid duplicate indexes to resolveKai Uwe Broulik
This avoids requesting a thumbnail twice for certain files, typically the first or last one in a folder. Differential Revision: https://phabricator.kde.org/D15404
2018-09-10Don't assign twice the same key to the action New TabJaime Torres Amate
Summary: QKeySequence::AddTab = Qt::CTRL + Qt::Key_T. Leaving only the first avoids the warning window "There are two actions (New Tab, New Tab) that want to use the same shortcut (Ctrl+T)" BUG: 398324 Test Plan: su - test unset KDE_FULL_SESSION dolphin After: No more the warning window. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15371
2018-09-10Merge branch 'Applications/18.08'Kai Uwe Broulik
2018-09-10Do use QIcon::Selected for non-icon viewKai Uwe Broulik
Fixes a regression introduced by not using the selected state. The views other than icon view actually do have a proper highlighted background. Differential Revision: https://phabricator.kde.org/D15387
2018-09-06Make thumbnail frame-and-shadow drawing criteria match those of the file dialogNathaniel Graham
Summary: KIO's file dialog already has logic to avoid drawing frames around images detected as likely to be icons, which is improved with D15071. Since Dolphin doesn't use KIO for any of this (boo) we have to pull it over here too; this patch brings the same feature to Dolphin, as well as the feature to disable frames and shadows for all thumbnails at very small sizes, which improves clarity. With this patch, Dolphin's frame drawing behavior becomes consistent with that of the file dialog (as of D15071). BUG: 295526 FIXED-IN: 18.12.0 Test Plan: Icons no longer have frames: {F6214279} Images without transparency still have frames: {F6214280} Nicer presentation for folders with mixed image types (images without transparency get frames; images without it don't): {F6214278} At small sizes, thumbnail clarity is improved by omitting the frame and shadow. Before: {F6214296} After: {F6214294} Reviewers: #dolphin, broulik, elvisangelaccio Reviewed By: #dolphin, broulik, elvisangelaccio Subscribers: markg, anthonyfieroni, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15069
2018-09-05[DolphinContextMenu] Use the view's already existing root KFileItemKai Uwe Broulik
Saves creating a new KFileItem from scratch which stats the file. Only when the root item isn't available (as can happen when you're currently looking at an non-existing directory) will it create a new KFileItem Differential Revision: https://phabricator.kde.org/D15266
2018-09-05Merge branch 'Applications/18.08'Kai Uwe Broulik
2018-09-05[KStandardItemListWidget] Round to icon size before applying scalingKai Uwe Broulik
Otherwise for 22px icons on high dpi we will request either the wrong icons or scale them needlessly. Dolphin requests a pixmap of 22px, this is then multiplied by dpr resulting in 44 which isn't a valid icon size (only 32 or 48 are). Moreover, we will also hit the path where it will scale the pixmap to a proper icon size resulting in blurry icons (and a performance penalty). Differential Revision: https://phabricator.kde.org/D15260
2018-09-04Merge branch 'Applications/18.08'David Edmundson
2018-09-04Correctly save behaviourOnLaunchDavid Edmundson
Summary: We only wrote out a checkbox value if the checkbox was checked. Unchecking it would not do anything. BUG: 398022 Test Plan: Read KRun's exepcted values Unchecked config option Reloaded dolphin Checkbox remained off Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15147
generated by cgit v1.3 (git 2.53.0) at 2026-04-21 06:35:10 +0000