┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2018-02-04Use qplatformdefs wrappersElvis Angelaccio
As recommended by krazy and as kio does.
2018-02-03Drop dead codeElvis Angelaccio
Spotted by clazy (-Wclazy-const-signal-or-slot). This was added in abf17941f7, but it became dead code after the KF5 port (possibly after c725848709).
2018-02-03Fix -Wunused-result warningsElvis Angelaccio
2018-02-03Fix all 'explicit constructor' krazy warningsElvis Angelaccio
2018-02-03Port QSignalSpy to new signal syntaxElvis Angelaccio
More compile-time safety. Tests still pass. This also fixes a krazy warning about "normalised signal/slot signatures".
2018-02-03Use new KStandardAction slot syntaxElvis Angelaccio
This was probably forgotten from commit 3bfdf0d2.
2018-02-03Fix typo spotted by krazyElvis Angelaccio
GIT_SILENT
2018-02-03Add newline at the end of kitemmodelbase.cppElvis Angelaccio
As recommended by krazy. GIT_SILENT
2018-01-30Merge branch 'Applications/17.12'Nathaniel Graham
2018-01-29Let the terminal panel sit on the left or right side of the windowNathaniel Graham
Summary: Just what it says: Let the terminal panel sit on the left or right side of the window. Test Plan: Tested in KDE Neon. Works great! Reviewers: #dolphin Differential Revision: https://phabricator.kde.org/D10189
2018-01-29base scrolling on the smallest itemMarco Martin
Summary: CCBUG: 386379 after recent highdpi patches on scrolling that delegated it completely to the scrollbar, based upon the scrollbar singleStep setted to the tallest of the items in the view. tough this makes scrolling way too fast, and on folders where just few filenames are longer than most we can get a single scrolling step almost double the number of lines configured in the mouse kcm. Using the shortest item instead of the tallest mitigates this problem making it a bit more usable Test Plan: tested on different folders in different view modes both with mouse and touchpad Reviewers: #dolphin, broulik, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D10102
2018-01-27Port away from deprecated QStyle::SH_Widget_AnimateElvis Angelaccio
Summary: Use the new QStyle::SH_Widget_Animation_Duration instead, which allows us to not manually hardcode the duration. We still use 1 if animations are disabled, otherwise the scroll would not work at all. See also D5883 for some background. Test Plan: Played with different values in the Animation tab of the Breeze config dialog. Reviewers: #dolphin, broulik Reviewed By: broulik Subscribers: broulik Differential Revision: https://phabricator.kde.org/D10005
2018-01-27Use BatchRenameJob to rename multiple files in DolphinChinmoy Ranjan Pradhan
Summary: Use KIO::BatchRenameJob in Dolphin::RenameDialog to rename multiple files. With this viewing progress of rename operation and undo is possible. See D9103 and D9107. Reviewers: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, ngraham, broulik Differential Revision: https://phabricator.kde.org/D9836
2018-01-26Fix place item edit after creationRenato Araujo Oliveira Filho
Summary: Make sure that the place can be edited after the creation. Depends on D9333 BUG: 389147 Test Plan: Create an item in dolphin places panel, make sure that you can rename it Reviewers: #dolphin, ngraham Reviewed By: ngraham Subscribers: michaelh, elvisangelaccio, lbeltrame, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9985
2018-01-26Make sure that old URLs do not appear duplicated in places modelRenato Araujo Oliveira Filho
Summary: BUG: 389401 KIO model now provides Baloo URLs; we need to remove the old ones created by Dolphin places model BUG: 387888 Depends on D9332 Test Plan: unit test Reviewers: mwolff, #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, broulik, ervin, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9333
2018-01-23Add option to sort for original dateJulian Schraner
Summary: Takes the original date a photo was taken out of the data provided by Baloo & makes it available to the user FEATURE: 303645 {F5671033} Test Plan: - Works with a batch of time-tagged photos - Can be hidden/shown/sorted like any other property Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham Differential Revision: https://phabricator.kde.org/D10059
2018-01-21Fix renamed file reclaims focusAndreas Krutzler
Summary: After renaming a file and then selecting another file immediately the just selected file stays selected. BUG: 388555 Test Plan: Steps to reproduce: $ mkdir /tmp/test $ cd /tmp/test $ touch a.tmp b.tmp $ dolphin /tmp/test In dolphin: * select a.tmp * <F2> * type aaa * select b.tmp immediately Expected result: * a.tmp renamed to aaa.tmp * b.tmp stays selected, aaa.tmp stays unselected Reviewers: ngraham, michaelh, #dolphin, elvisangelaccio Reviewed By: ngraham, michaelh, #dolphin, elvisangelaccio Subscribers: emateli, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D9711
2018-01-21Don't show 'Open Terminal' on WindowsElvis Angelaccio
We already disable the TerminalPanel on Windows, we should do the same with the 'Open Terminal' action for consistency.
2018-01-19Revert "Ignore baloo urls created from new KIO model"Luca Beltrame
This reverts commit 9d3a019445d7a7fdf3177bca9eeef4c44599e706. Causes breakage in Dolphin in master. The proper fix is in D9333. CCBUG: 389147
2018-01-18Exclude m_terminalPanel references when built on WindowsAdrián Chaves (Gallaecio)
Fixes an issue reported by elvisangelaccio at https://phabricator.kde.org/D9955
2018-01-18Set the focus to the active view, after leaving the terminal panelAdrián Chaves Fernández (Gallaecio)
Summary: BUG: 298467 Set the focus to the active view, after leaving the terminal panel. This is a fork of the patch at https://git.reviewboard.kde.org/r/116118/ by @emmanuelp which should fix the issue with the original patch reported by Frank Reininghaus. Test Plan: Works for me. Reviewers: #dolphin, emmanuelp, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, emmanuelp Differential Revision: https://phabricator.kde.org/D9955
2018-01-18Merge remote-tracking branch 'origin/Applications/17.12'Luca Beltrame
Conflicts: CMakeLists.txt [versions] src/panels/places/placesitemmodel.cpp
2018-01-18Folderspanel's context-menu option "Limit to Home Directory" is always visibleMichael Heidelbach
Summary: Applied suggested changes to [[ https://phabricator.kde.org/D9662 | D9662 ]] - Enum instead of bool - Use QStringLiteral Test Plan: Visual inspection Reviewers: ngraham, elvisangelaccio, #dolphin Reviewed By: ngraham, #dolphin Subscribers: #dolphin Tags: #dolphin, #kde_applications Differential Revision: https://phabricator.kde.org/D9911
2018-01-14folderspanel context-menu option "Limit to Home Directory" should be always ↵Michael Heidelbach
visible Summary: Only by chance I discovered that this option is visible but only when inside home. Before that I always edited dolphinrc to reenable it. I think it's less confusing to always show it but toggle its enabled state Test Plan: compile and run show folderspanel context-menu in different places Reviewers: #dolphin, emmanuelp, ngraham Reviewed By: #dolphin, ngraham Subscribers: elvisangelaccio Tags: #dolphin, #kde_applications Differential Revision: https://phabricator.kde.org/D9662
2018-01-11Explicitly pass iconNameForUrl when dropping places entryKai Uwe Broulik
Differential Revision: https://phabricator.kde.org/D9609
2018-01-11[KStandardItemListWidget] Don't paint overlay outside view for ↵Kai Uwe Broulik
devicePixelRatio > 1 Translate the position by devicePixelRatio REVIEW: 129084
2018-01-09SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-01-08Fix PlacesItemModel loading with hidden devicesRenato Araujo Oliveira Filho
Summary: Make sure that hidden devices loaded after module initialization does not appear in the view. Check for item visibility before add it on the model. Test Plan: Unit test created Reviewers: franckarrecot Reviewed By: franckarrecot Subscribers: cfeck, ervin, #dolphin Differential Revision: https://phabricator.kde.org/D9441
2018-01-06infopanel fully resizableMichael Heidelbach
Summary: Currently Infopanel does wrap its title when trying to narrow it. Initially: {F5619283} Expanded: {F5619284} Resizing fails, watch cursor: {F5619286} Patch applied: {F5619287} Maybe this behaviour it intentional. Personally, I prefer the patch. Test Plan: compile & run Resize infopanel with long title Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: renatoo, vhanda, nicolasfella, elvisangelaccio, ngraham Tags: #dolphin, #kde_applications Differential Revision: https://phabricator.kde.org/D9664
2018-01-03Revive folderpanel when outside $HOMEMichael Heidelbach
Summary: Currently the folderpanel is inert when browsing outside of home because urls end up as 'file:////a/b/c' and since Qt 5.10 this is an invalid URL: http://code.qt.io/cgit/qt/qtbase.git/commit/?id=f62768d046528636789f901ac79e2cfa1843a7b7 Premptive bug fix. Test Plan: Open dolphin Leave home directory Reviewers: #dolphin, elvisangelaccio Subscribers: dfaure, elvisangelaccio, ngraham, anthonyfieroni Tags: #dolphin Differential Revision: https://phabricator.kde.org/D9610
2018-01-02Ignore baloo urls created from new KIO modelRenato Araujo Oliveira Filho
Summary: For now ignore baloo urls that was created by new KIO::KFilePlacesModel, until we make use of new KIO API. BUG: 387888 Test Plan: Open any KIO file dialog using the new API. Runs dolphin v17.12.0 Make sure that baloo urls does not appear duplicated Reviewers: ngraham, elvisangelaccio Reviewed By: ngraham, elvisangelaccio Subscribers: cfeck, elvisangelaccio, ervin, mlaurent, #dolphin Differential Revision: https://phabricator.kde.org/D9347
2017-12-31GIT_SILENT made messages (after extraction)l10n daemon script
2017-12-31GIT_SILENT made messages (after extraction)l10n daemon script
2017-12-28SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-12-28SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-12-20SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-12-20SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-12-14Implemented support for hide/show groupsRenato Araujo Oliveira Filho
Summary: Added an option on PlacesPanel context menu to show or hide the entire group of places. Depends on D8855 Test Plan: Open Donlphin and use PlacesPanel context menu to hide and show groups Reviewers: franckarrecot, mlaurent, mwolff, elvisangelaccio Reviewed By: franckarrecot, mlaurent, mwolff, elvisangelaccio Subscribers: rkflx, mwolff, elvisangelaccio, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D9242
2017-12-14Use Kio::KPlacesModel as source model for PlacesItemModelRenato Araujo Oliveira Filho
Summary: Use Kio::KPlacesModel as source model for PlacesItemModel avoiding duplicated code. Depends on D8862 Depends on D8332 Depends on D8434 Depends on D8348 Depends on D8630 Test Plan: Unit test created Reviewers: elvisangelaccio, emmanuelp, mlaurent, mwolff Reviewed By: elvisangelaccio, mlaurent, mwolff Subscribers: mwolff, mlaurent, anthonyfieroni, nicolasfella, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8855
2017-12-13Change "Empty Search" to just "Search" to handle searches with no search textNathaniel Graham
Summary: BUG: 387854 The pre-defined searches (Documents, Videos, etc) all default to no search text. https://cgit.kde.org/dolphin.git/commit/?id=702429ac8e64a5aff4e110a56f526b96ecb795fd changed their window title from "baloosearch - /" to "Empty Search", but the search isn't really empty; it just lacks a search string. It's still looking for documents, or videos, or whatever. Test Plan: Is it too late to get this into 5.12? Tested in KDE Neon. Before: {F5545170} After: {F5545171} Reviewers: #dolphin, elvisangelaccio, broulik Reviewed By: broulik Differential Revision: https://phabricator.kde.org/D9305
2017-12-05Merge remote-tracking branch 'origin/Applications/17.12'Luigi Toscano
2017-12-05appdata: update doc URL, more httpsLuigi Toscano
- use the more generic URL for dolphin documentation; - use https for all links.
2017-12-03Change window title when searchingJulian Schraner
Summary: When you search for a file (e.g. "hello world") the window title of Dolphin will now change to "Search for [input]" instead of "baloosearch - /". BUG: 321575 Test Plan: - Disables it iself after search bar is hidden - Works with multiple word searches Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D8273
2017-12-03Remove duplicate definition of the function.Ben Cooksley
Looks like this is the result of a bad merge. CCMAIL: [email protected]
2017-12-02Merge remote-tracking branch 'origin/Applications/17.12'Heiko Becker
2017-11-27Created unit test for PlacesItemModelRenato Araujo Oliveira Filho
Summary: Make sure that PlacesItemModel is covered by unit test Reviewers: ervin, elvisangelaccio, mwolff Reviewed By: ervin, elvisangelaccio, mwolff Subscribers: mwolff, elvisangelaccio, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8630
2017-11-25Use kSqueezedTextLabel for the label text on the statusbarAhmad Samir
Summary: Following up from D8927; use kSqueezedTextLabel for the label text on the statusbar: - This simplifies the code in updateLabelText() - Remove the eventFilter as it's not needed any more since kSqueezedTextLabel has a resizeEvent function - Specify a stretch factor, 1, for m_label, m_zoomSlider and m_spaceInfo, this prevents the changing of the width of m_label when the label text is updated from changing the widths of the zoomSlider and the spaceInfo widgets as that is a bit too jumpy. (Thanks to the code of konversation statusbar for the hint about using the stretch factor in addWidget()). Reviewers: elvisangelaccio Subscribers: elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D8991
2017-11-21Elide the label text on the statusbar in the middleAhmad Samir
Summary: BUG: 387189 Currently the label text on the statusbar is elided in on the right, but that means that when the text gets elided the size of the file isn't shown. The label text on the statusbar shows the file name, the mime type and the size; the name is already shown in the main window and the mimetype can usually be guessed from the icon or from the extension, so it's usually the size that the user wants to see on the statusbar. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, anthonyfieroni Differential Revision: https://phabricator.kde.org/D8927
2017-11-21Revert some hunks from previous commitKevin Funk
Changes in folderspanel.cpp in 464b13f3828e5cdd03438d0881c3a62c7cda6333 were unintended.
2017-11-21Modernize: Use nullptr everywhereKevin Funk
generated by cgit v1.3 (git 2.53.0) at 2026-04-26 19:29:04 +0000