| Age | Commit message (Collapse) | Author |
|
|
|
Items location changes when scrollbar is moved in dolphin.
Accordingly calls to updateAccessibility should be made.
|
|
|
|
Added the calls to updateAccessibility, for DragDrop & Focus scenarios
|
|
|
|
Remove comparison of QAccessibleInterfaces - these are pointers that get
instantiated again and again, so they cannot be compared. Use the object()
function in QAI instead for comparison.
|
|
|
|
This leads to crashes since it implies that
casting to QAccessible2Interface is valid.
|
|
|
|
|
|
The base class implementations are actually good and without some problems.
Save one pointer's worth of memory by not having m_container.
rect was returning a relative rectangle always.
State was wrongly returning HasInvokeExtension which can lead to crashes.
|
|
And also bad use of "" instead of QString().
|
|
|
|
|
|
|
|
|
|
ItemLayout is an enum, not a flag, so == is even more correct than '&'.
|
|
Patch by Emmanuel Pescosta <[email protected]>
BUG: 303375
REVIEW: 105575
FIXED-IN: 4.9.0
|
|
FIXED-IN: 4.9.0
BUGS: 274655, 292822
|
|
FIXED-IN: 4.9.1
REVIEW: 105832
BUG: 303133
|
|
FIXED-IN: 4.9.1
REVIEW: 105832
BUG: 303133
|
|
BUG:292700
FIXED-IN: 4.9.1
REVIEW: 105990
(cherry picked from commit 5e87cefd4c17467c3a650b133dc9bdadea22f9f7)
|
|
That makes "Ctrl+L" less surprising to users who use it frequently in
web browsers
BUG: 183821
FIXED-IN: 4.10.0
REVIEW: 105994
|
|
BUG:292700
FIXED-IN: 4.10.0
REVIEW: 105990
|
|
|
|
|
|
The problem with the icon "package_utility_time" that has been used
before was that it is not available on all distros. The new icon
"chronometer" should be available on every KDE install.
Thanks to Elias Probst for suggesting the new icon - I'm not that
familiar with the icons provided by KDE myself.
CCBUG: 304323
(cherry picked from commit d7e7ca53bb95c7555bbf107d92b47ac25eda1918)
|
|
I overlooked that "actions/" is not part of the icon name. Just
rebuilding and re-running Dolphin did not reveal this issue, it seems
that the old icon "package_utility_time" was still cached somewhere.
I hope that it really works on all distros now.
CCBUG: 304323
|
|
The problem with the icon "package_utility_time" that has been used
before was that it is not available on all distros. The new icon
"actions/chronometer" should be available on every KDE install.
Thanks to Elias Probst for suggesting the new icon - I'm not that
familiar with the icons provided by KDE myself.
BUG: 304323
FIXED-IN: 4.9.1
|
|
Don't rely on the reported supported mimetypes from Phonon,
Phonon supports more than just video and audio, but if it is
video or audio there's a very good chance Phonon supports it.
(If the mime type isn't in the list returned by Phonon there's
still a good chance it supports it, because mime types are stupid.)
BUG: 252539
FIXED-IN: 4.9.1
(cherry picked from commit 2fb4419de053c43a0a70ffb21920db687fa87b6e)
|
|
Don't rely on the reported supported mimetypes from Phonon,
Phonon supports more than just video and audio, but if it is
video or audio there's a very good chance Phonon supports it.
(If the mime type isn't in the list returned by Phonon there's
still a good chance it supports it, because mime types are stupid.)
BUG: 252539
|
|
Moreover, make sure that the selection rectangle is large enough to
include the stars.
Patch by Emmanuel Pescosta. Thanks for the patch!
CCBUG: 302624
REVIEW: 105830
(cherry picked from commit 146c77eaa226915cd3cd01e112fcde42fd8c06c4)
|
|
Moreover, make sure that the selection rectangle is large enough to
include the stars.
Patch by Emmanuel Pescosta. Thanks for the patch!
BUG: 302624
FIXED-IN: 4.9.1
REVIEW: 105830
|
|
|
|
Patch by Benni Hill. Thanks for the patch!
CCBUG: 304467
(cherry picked from commit 4d39dbc9620cd30826bfab4a42cf31702aeac6d8)
|
|
Patch by Benni Hill. Thanks for the patch!
BUG: 304467
FIXED-IN: 4.9.1
|
|
|
|
|
|
|
|
|
|
|
|
only.
BUG: 279283
FIXED-IN: 4.9.0
REVIEW: 105607
(cherry picked from commit 9a622c16d969a39571b610304db759f941b5d4f3)
|
|
only.
BUG: 279283
FIXED-IN: 4.9.0
REVIEW: 105607
|
|
ItemLayout is an enum, not a flag, so == is even more correct than '&'.
|
|
Patch by Emmanuel Pescosta <[email protected]>
BUG: 303375
REVIEW: 105575
FIXED-IN: 4.9.0
|
|
FIXED-IN: 4.9.0
BUGS: 274655, 292822
|
|
Use QStyle icon sizes instead of hard coding 16 or 32 pixels.
Using styles that follow KDE settings (every KStyle, e.g.
Oxygen) the icon sizes can be configured by the user in
System Settings.
The size for the icon/details view can be later changed
by the user, overriding the defaults. The icon size for the
places panel is not (yet?) configurable separately.
(Not resolving the bug, see comment in review request)
CCBUG: 301959
REVIEW: 105548
(cherry picked from commit 79211f6e48d33b6be235811912061fda265fefb6)
|
|
Use QStyle icon sizes instead of hard coding 16 or 32 pixels.
Using styles that follow KDE settings (every KStyle, e.g.
Oxygen) the icon sizes can be configured by the user in
System Settings.
The size for the icon/details view can be later changed
by the user, overriding the defaults. The icon size for the
places panel is not (yet?) configurable separately.
(Not resolving the bug, see comment in review request)
CCBUG: 301959
REVIEW: 105548
|
|
This resolves a regression caused by the Places Panel rewrite. There is
a small glitch left when reordering items (dragging below the last or
above the first item only shows the drop indicator when first dragging
out of the item and then back), but I prefer not to fix this glitch
right now because this would require a more intrusive change, and I do
not want to risk regressions because is not much time left to fix them
before 4.9.0 is released.
Thanks to Peter Penz for providing some advice about this issue.
BUG: 302557
FIXED-IN: 4.9.0
(cherry picked from commit f4c960025167b7c7e04e1290ac9d9fee03a9b62d)
|
|
Without this patch, the name of the parent folder was used for the entry
in the Places Panel. Will backport to the KDE/4.9 branch when the RC2
freeze is over.
Thanks to Daniel Kreuter for the patch!
BUG: 303157
FIXED-IN: 4.9.0
(cherry picked from commit 9940244ddd68fabf2979b9c0832105e43d725619)
|