┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2012-02-14Details view: Siblings fixesPeter Penz
The siblings should only range within one group.
2012-02-14Details view: Fix indicator-branchesPeter Penz
Up to now no indicator-branches have been drawn when showing a tree. The patch fixes this so that that the style-dependent branches are drawn. The main part of the patch is the implementation of KItemListView::updateSiblingsInformation(). Most of the other changes are related due to an internal renaming of the expansionsLevel-role to expandedParentsCount and some related cleanups. BUG: 290276 FIXED-IN: 4.8.1
2012-02-13Test which items are activated when pressing Enter or ReturnFrank Reininghaus
The ViewState struct gets a new bool member to indicate if the selected items should have been activated after the last event or not. One could argue that adding a bool parameter to the constructor is not optimal, but I think adding an enum is not really worth the effort because the struct is not used outside this unit test. Moreover, I could not think of a good name for the enum type and its values. (cherry picked from commit 307cca7b31b998fb7e8af0478a8e97e53bdc059c)
2012-02-13Fix regression in KItemListControllerTestFrank Reininghaus
Since commit 66ce4db4879cd80b2dcb6d65a0c74599c5e5f0ba, enabling or disabling groupling may change the number of columns in the view. Therefore, the test should first change the "grouping" setting and then change the view geometry to make sure that the column count is correct. (cherry picked from commit 61390b201acae2d8eea94fefc947977a8799af85)
2012-02-11Group header layout fixesPeter Penz
- Don't use a margin for the first group header - Provide margins between the groups - Use a more subtle coloring - Prevent animation glitches when resizing a window
2012-02-09Icon-rectangle and selection-toggle optimizationsPeter Penz
- No padding should be applied to the icon-rectangle - Base the selection-toggle size on the icon-size of the style not the actual pixmap content, as this might lead to smaller selection-toggles when having pixmap-previews with a small height.
2012-02-08Layout optimizationsPeter Penz
- Differ internally between margins and paddings - Add a small padding in the icons-view and the compact-views - Optimize the width of the icons-view if previews are shown
2012-02-08Drag and drop: Adjust destination if the item is no directory or desktop-filePeter Penz
The URL of the view should be used as destination target if a dropping is not done above a directory or desktop-file. BUG: 293511 FIXED-IN: 4.8.1
2012-02-07Compact view: Don't hide items at the bottom when grouping is turned onPeter Penz
When grouping has been turned on, it was possible that items aligned at the bottom have been hidden. BUG: 291640 FIXED-IN: 4.8.1
2012-02-06Group header improvementsPeter Penz
- Use a simpler background and colors as suggested by Martin Zilz. This is just an early draft, I need to post some comparison screenshots to Martin for review. - Fixes of some layout issues that have been revealed because of adjusting the group header heights. - More clever animation/no-animation detection when doing listview-property changes in parallel.
2012-02-05Fix potential endless loop in layoutPeter Penz
Usecase: - No scrollbar is shown - Window size will be decreased so that a scrollbar gets necessary The decreased window size minus the space required for the scrollbar results in a relayout of the items. In 99 % of all cases a decreased window size won't result in showing more items in parallel in comparison to a larger window size. However in the remaining 1 % this can happen (e.g. see bug 293318 for a sample). This results in an endless loop as now no scrollbar is required anymore, the layout changes again, the scrollbar is required again, ... BUG: 293318 FIXED-IN: 4.8.1
2012-02-05Replace setExpanded(const QSet<KUrl>&) by expandParentItems(const KUrl&)Frank Reininghaus
The use case of this function (Folders Panel) requires the expansion of the parent items of a single URL, so it's not needed to handle a full set of URLs in this function. Moreover, the issue that not only the parents, but also the URLs themselves were expanded is fixed by this commit. (cherry picked from commit 89082ca391807abdc26d8985efe6b4c27183a9b1)
2012-02-04Icons view: Layout optimizationsPeter Penz
- Assure that landscape-previews use the whole available width of the icon-area instead of only using the square width. This waste of space occured if the text-width was larger than the icon-width. - Only use one margin instead of two between the icons and the text to improve the visual appearance (thanks to Martin Zilz for the hint) BUG: 293268 FIXED-IN: 4.8.1 CCMAIL: [email protected]
2012-02-04Simplify KItemListControllerTest::testKeyboardNavigation_data()Frank Reininghaus
Function-static variables do not help much in a function which is called exactly once. (cherry picked from commit 847c8ebfd3259a6f090db7451dd3350c6e01e0d2)
2012-02-03Show the value "Unknown" for the item-count only after it has been verifiedPeter Penz
During determining the item-count for directories just show an empty string until either the item-count has been calculated or if the item-count is unknown. Thanks to Nikita Skovoroda for the initial proof-of-concept patch. BUG: 291823 FIXED-IN: 4.8.1
2012-02-03Show file size when hovering an itemPeter Penz
BUG: 292687 FIXED-IN: 4.8.1
2012-02-03FoldersPanel: Rename setHiddenFilesShown() to setShowHiddenFiles()Peter Penz
This is consistent with the naming scheme in KFileItemModel and KDirLister.
2012-02-03Simplify FoldersPanel::setHiddenFilesShown()Peter Penz
Thanks to Frank Reininghaus for the hint.
2012-02-03The autoscroll timer should be only a single-shot timerPeter Penz
2012-02-03Folders Panel: Show expansion toggles for directories on ISO-imagesPeter Penz
When counting the number of sub-directories consider unknown file types as potential directories. In the "worst case" an expansion toggle will be shown although the directory contains only files, however from a performance point of view this seems to be an acceptable compromise. BUG: 292642 FIXED-IN: 4.8.1
2012-02-02Fix sorting issue when sorting by "size"Peter Penz
Root cause of the issue was an overflow in: result = a - b; where result is 'int' and a and b are 'KIO::filesize_t'. BUG: 293086 FIXED-IN: 4.8.1
2012-02-02Fix crash when opening a tab during a tooltip is shownPeter Penz
Thanks a lot to Mathias Tillman for finding a 100 % reliable way how to reproduce the issue and for the initial patch! BUG: 278302 FIXED-IN: 4.8.1
2012-02-02Fix pending zooming animationPeter Penz
If doLayout() is invoked with the 'NoAnimation' hint, it must be assured that any ongoing animations are stopped.
2012-02-01First version of a unit test for KItemListControllerFrank Reininghaus
At the moment, only key press events are tested, and the current item and selection after the event are verified. Moreover, this commit makes sure that KItemListController::keyPressEvent() really does not select anything if the selection mode is NoSelection. (cherry picked from commit 7457f4868cf0bc83e8a90ce5693292378f3d07c4)
2012-02-01KFileItemModelRolesUpdater: Optimize updatesPeter Penz
The asynchronous resolving to bypass performance bottlenecks is not necessary anymore as multiple ranges can be inserted in one step now. This solves the issue that e.g. opening a tree resulted in temporary unknown icons for a short period of time.
2012-02-01Don't animate items if the number of grid elements has been changedPeter Penz
Having animated items is useful when e.g. deleting or inserting one item or when the size or position slightly changes by increasing the zoom level or the window size. However if the number of rows or columns change, the animation gets obtrusive and in this case lets just apply the final layout.
2012-01-31Fix keyboard navigation issue when Home or End are pressedFrank Reininghaus
The problem was that m_keyboardAnchorIndex and m_keyboardAnchorPos were not updated when Home or End are pressed. This causes the following unexpected behavior in Icons View: Press Home, then Right, then Down, then Home, finally Down. One would expect that the first item in the second row is the current item then, but before this commit, it was the second one because the controller still remembered that the second column was active before Home was pressed. (cherry picked from commit 999234a94ae41cfb4f2167d2779b562ebf8127ce)
2012-01-31Animation optimizationsPeter Penz
Prevent that the moving-animation crosses other items when zooming or changing the window size.
2012-01-31Fix sorting issuesPeter Penz
For some roles the sorting has not been implemented. BUG: 292941 FIXED-IN: 4.8.1
2012-01-31Adjust zoom-slider in the statusbar if settings have been changedPeter Penz
This fixes the issue that changing the zoom-level in the settings does not update the zoom-slider in the statusbar.
2012-01-31Apply changed home-URL to the URL navigatorPeter Penz
BUG: 291043 FIXED-IN: 4.8.1
2012-01-31SVN_SILENT made messages (.desktop file)Script Kiddy
2012-01-30Only move the items if at least one direction is within the item sizePeter Penz
2012-01-30Synchronize view-mode settings before the settings dialog gets openedPeter Penz
BUG: 292698 FIXED-IN: 4.8.1
2012-01-30Further animation optimizationsPeter Penz
- Assure a proper minimim width in the compact mode. - Don't calculate the old position of hidden items to animate the moving. Just show them directly.
2012-01-30Fix drag & drop issues with non-local URLsPeter Penz
BUG: 292821 BUG: 292355 FIXED-IN: 4.8.1
2012-01-30Fix crash in Compact View if view height is smaller then item heightFrank Reininghaus
CCBUG: 292816 FIXED-IN: 4.8.1 (cherry picked from commit f5ecaee9c40c940fe8e1bf4a7d50fe0b18e1932b)
2012-01-29Make moving animations less obtrusivePeter Penz
Only animate the moving of items if the new position is within the same row or the same column. Otherwise just fade in the icon on the new position. This makes the the animations when resizing the window or changing the zoom-level a lot more pleasant. CCBUG: 289238
2012-01-29SVN_SILENT made messages (.desktop file)Script Kiddy
2012-01-28Fix regression: Respect "natural sorting" settingPeter Penz
BUG: 292270 FIXED-IN: 4.8.1
2012-01-28Assure to mark an item as unhovered on a drag-leave eventPeter Penz
BUG: 292501 FIXED-IN: 4.8.1
2012-01-28--warningPeter Penz
2012-01-28--warningPeter Penz
2012-01-27Fix regression: Allow dragging items on a tabPeter Penz
BUG: 292505 FIXED-IN: 4.8.1
2012-01-27Don't crash when opening a tab with enabled split viewPeter Penz
BUG: 292470 FIXED-IN: 4.8.1
2012-01-25Handle folder names containing spaces correctly in the Folders PanelFrank Reininghaus
The problem was that KFileItemModel::setExpanded() used KUrl::url() to determine the names of the subfolders. This method encodes special characters, such that comparing the folder names with the unencoded URLs stored in the model fails. Using KUrl::path(), which does not encode special characters, fixes the problem. CCBUG: 291781 FIXED-IN: 4.8.1 (cherry picked from commit 80d9bfec580bf01b0ee584fc4bb46e3d59a0ba7c)
2012-01-25Terminal: only consider process IDs > 0Peter Penz
Thanks to Jekyll Wu for the analyses. CCBUG: 286367
2012-01-23Make sure that Control+click toggles the selection stateFrank Reininghaus
This commit fixes a regression caused by the recent commit 9f711b5f2e1d1fd856cd6b033e6adb96f9b46d8a. CCBUG: 292250 (cherry picked from commit 84a9cc4bf6e9decc4c102102c4b04162369eb0fe)
2012-01-19Do not make items invisible when turning off previewsFrank Reininghaus
This commit fixes a problem in KItemListView::doLayout(): This function assumed that firstVisibleIndex is a constant. However, if the view is scrolled to the bottom with previews enabled, and then previews are disabled (and the icon size is much smaller without previews), this function changes the scroll offset, which also changes the the first visible index. Using the unchanged variable causes trouble later on (i.e., it makes items which are actually inside the view area invisible). lastVisibleIndex is not needed before the scroll offset change and is const after that, so its calculation is moved a few lines down. CCBUG: 291841 FIXED-IN: 4.8.1 (cherry picked from commit cc8f5b4939062df44ce0bd314ac4ae04973b9830)
2012-01-18When populating the "Show Remote Encoding" menu, put the check mark besidesDawit Alemayehu
the correct saved remote encoding charset. BUG: 186289 FIXED-IN: 4.8.0 REVIEW: 103730 (cherry picked from commit 8f231bd08134f7b1870a9c1747429c1b05174d62)
generated by cgit v1.3 (git 2.53.0) at 2026-04-23 07:18:30 +0000