┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2011-12-16Update the roles if items have been changedPeter Penz
The code "// TODO..." in slotItemsChanged() obviously was not sufficient ;-) BUG: 288691 BUG: 288824 BUG: 288921 FIXED-IN: 4.8.0
2011-12-16Assure that the general settings are refreshedPeter Penz
This fixes issues where Dolphin must get restarted after changing a general setting. BUG: 289131 FIXED-IN: 4.8.0
2011-12-15RenameDialog: Don't disable the OK-button if nothing has been changedPeter Penz
This prevents using the RETURN-key when accidently opening the renaming dialog. Thanks to Thomas Murach for pointing this out and providing the patch! REVIEW: 103414
2011-12-15SVN_SILENT made messages (.desktop file)Script Kiddy
2011-12-15Start an anchored selection when clicking a selection markerFrank Reininghaus
BUG:200782 FIXED-IN:4.8.0
2011-12-15Fix descending sort order issuePeter Penz
If the sort order is descending and directories and files are shown on the same hierarchy level, the sorting was partly wrong.
2011-12-15Don't show an expansion toggle for locked expansionsPeter Penz
2011-12-14Fix expansion levels for search resultsPeter Penz
Force an expansion level of 0 for search results to prevent showing tabbed child items without parent items.
2011-12-14Fix filtering issue in combination with expanded itemsPeter Penz
When items have been expanded they should never get filtered, as each child item must have a parent item.
2011-12-14Improve private method KFileItemModel::expansionLevelsCompare()Peter Penz
Get rid of the hack to access the m_itemData member for getting the parent of an item during sorting. ItemData has been extended by a parent-member which allows a fast and save way to do this. Sadly this makes the unit-test for expansionLevelsCompare() more complex and it has been temporary deactivated. I'll take care to fix this during the next week.
2011-12-14Fix commentPeter Penz
2011-12-13Fix several sort-issuesPeter Penz
- Treeview: When sorting descending assure that the parent item is still ordered before the child items and not afterwards. - Treeview: When sorting by other roles than names expansionsLevelCompare() had been buggy and resulted in ordering child items below wrong parent items. - General: When sorting by another role than names and the role of two items had been equal a case sensitive sorting of the names had been done. This has been fixed by using the default name sorting as fallback. BUG: 286726 FIXED-IN: 4.8.0
2011-12-13dolphin: DLLEXPORT is not valid for template classMichael Drueing
MSVC tries to import the specialized class from the library, which fails because only the generic version can be exported. GCC probably silently ignores the export.
2011-12-13SVN_SILENT made messages (.desktop file)Script Kiddy
2011-12-12Respect style's viewport scrollbar layout policyChristoph Feck
REVIEW: 103381
2011-12-11Remember sort settingsPeter Penz
If the user has changed the sort-role or sort-order by clicking on the view-header of the details-view, the settings have been adjusted to the model but not remembered in the directory settings.
2011-12-11Fix KItemListView::scrollToItem()Peter Penz
Don't let the item be invisible if the header is shown.
2011-12-11Scroll the view when the current item has been changedPeter Penz
We need now explicitly to scroll to the item when the current item has been changed, as this is not done automatically in the scope of KItemListView. BUG: 288745 FIXED-IN: 4.8.0
2011-12-11SVN_SILENT made messages (.desktop file)Script Kiddy
2011-12-10Fix issue that icon overlay is missing for linksPeter Penz
BUG: 288609 FIXED-IN: 4.8.0
2011-12-10Show error-message when dropping a folder into itselfPeter Penz
Thanks to Janardhan Reddy for the analysis of the issue! BUG: 283646 FIXED-IN: 4.8.0
2011-12-10Minor fix in copyright headerPeter Penz
This class is not based on the ItemViews-NG project.
2011-12-10Support wildcards for the filterPeter Penz
Thanks to Janardhan Reddy for the patch! BUG: 155986 FIXED-IN: 4.8.0
2011-12-10Resort items when they have been changedPeter Penz
This assures that when renaming an item the sort-position will be adjusted. Thanks to Frank Reininghaus and Janardhan Reddy for the patch and the tests. BUG: 288311
2011-12-09Fix issue with duplicate items in details viewPeter Penz
When expanding an item, collapsing it and expanding it again before the items for the first expanding could be loaded, it was possible that items have been inserted twice into the model. BUG: 288521 FIXED-IN: 4.8.0
2011-12-09Reloading is not necessary anymore on a settings changePeter Penz
The new view-engine can adjust the properties with the existing items.
2011-12-08Fix font settings issuePeter Penz
The font settings have been ignored currently because of the transition to the new view-engine. The patch is based on the work of Janardhan Reddy and has been extended by the helper class ViewModeSettings. BUG: 288395 FIXED-IN: 4.8.0
2011-12-08Fix "show hidden files" issuesPeter Penz
Use KFileItemModel instead of KDirLister for toggling the whether hidden files should be shown. This assures that the signal KFileItemModel::loadingCompleted() will be emitted. In the longterm Dolphin should only use the KFileItemModel, so that the KDirLister instance is used only internally as implementation detail in KFileItemModel. Although there are only a few cases left where KDirLister is used instead of KFileItemModel this cleanup will be postponed to after the 4.8 release... BUG: 287314 BUG: 288213 FIXED-IN: 4.8.0
2011-12-08SVN_SILENT made messages (.desktop file)Script Kiddy
2011-12-07Prevent unwanted item animations (#2)Peter Penz
Use a cleaner approach to prevent item animations when showing a hidden tab the first time. For Dolphin > 2.0 the tab-code should be refactored from DolphinMainWindow and encapsulated into an own module (but well, this is on my TODO-list since KDE SC 4.4...)
2011-12-07Enable "menu key" functionalityPeter Penz
Bring back the functionality that a context-menu is opened if the "menu key" has been pressed. In opposite to Dolphin 1.7 the context-menu is shown above the selected item and not on the (probably unrelated) mouse position. A new method KItemListView::itemContextRect() has been introduced: The method is now also used as reference for tooltips which fixes the issue that tooltips had a wrong horizontal alignment in the details-view. BUG: 288366 FIXED-IN: 4.8.0
2011-12-07Prevent unwanted item animationsPeter Penz
When splitting the view or opening a new tab there should not be any animation of the items due to a wrong initial viewport size.
2011-12-07Fix issue of unknown icon-typesPeter Penz
If the split-view is used and/or the Folders Panel is activated it might happen that the "unknown"-icon of an item is shown instead of the correct icon. The root-cause is that one model might already have been resolved the MIME-type of a KFileItem while the other model has not updated the icon yet. As KFileItems are shared the check whether the MIME-type has been resolved is wrong. As at that stage it is assured anyhow that the MIME-type is known just applying the icon-name in any case won't slow down the performance.
2011-12-07Fix icon boundaries issuePeter Penz
The size of the icon boundaries should be as minimal as possible. The patch for fixing the zooming-issues with the selection resulted into a minor regression where the icon boundaries might be too large. This patch remembers the original size of the pixmap to be able to scale m_iconRect.
2011-12-07SVN_SILENT made messages (.desktop file)Script Kiddy
2011-12-06Use scaled size for KFileItemListWidget::iconRect()Peter Penz
This prevents temporary selection rectangle issues when zooming the icon sizes. BUG: 287542 FIXED-IN: 4.8.0
2011-12-06Version control: Don't tint unversioned filesPeter Penz
BUG: 287742 FIXED-IN: 4.8.0
2011-12-06Selection and current item fixesPeter Penz
- Remember selection + current item when switching view-modes - Fix the current item indicator alignment for selections - Set the item as current item when the selection toggle has been clicked
2011-12-06Don't animate when switching view-modesPeter Penz
Currently when switching the view-modes an animation of the items is done, where the position and size is adjusted for the new view-mode. Although this might look nice initially I'd consider this as a kind of animation that is distracting and hence it has been turned off.
2011-12-06Fix possible crash in SearchPanel::urlChanged()Peter Penz
m_lastSetUrlStatJob gets a dangling pointer if we don't have a Nepomuk URL. Thanks to Frank Reininghaus for the analysis and the hint! BUG: 287075 FIXED-IN: 4.8.0
2011-12-06Folders Panel cleanupsPeter Penz
- Reactivate dropping of URLs - Remove unused/obsolete code - Simplify DragAndDropHelper interface
2011-12-06Fix selection issue for Information PanelPeter Penz
When the selection changes during the Information Panel is invisible, it still should get applied so that when making the Information Panel visible again a valid selection is shown. Thanks to A. Janardhan Reddy for the patch! (Additionally the obsolete check for an empty selection has been removed, as this cannot happen anymore with the new view engine) BUG: 281452 FIXED-IN: 4.8.0
2011-12-06Reactivate drop-above-places-panel functionalityPeter Penz
Dropping items into the Places panel has been temporary deactivated because of switching to the new view-engine -> reactivate it again BUG: 204359 FIXED-IN: 4.8.0
2011-12-05Fix calculation of maximum scroll offsetPeter Penz
The maximum scroll offset must be the maximum y-range of the last row, not only the maximum of the last item. Thanks to Frank Reininghaus for analysing the root-cause and for providing the initial patch! BUG: 287211 FIXED-IN: 4.8.0
2011-12-04Update the view if an item is renamedFrank Reininghaus
2011-12-04Fix crash #2 when filtering itemsPeter Penz
When KFileItems get removed from the model it is temporary possible that the pending items are still part of the KFileItemModelRolesUpdater while they have already been removed from the model (this happens in the context during the signal itemsRemoved() gets emitted). BUG: 287642
2011-12-04Fix crash #1 when filtering itemsPeter Penz
When filtering items it was possible that the current index got an invalid value which resulted in accessing the URL of a null-KFileItem. There is still one (general) open issue in KFileItemModelRolesUpdater (crash #2) where a KFileItem that is already null gets read. It is not really related to filtering but can be triggered quite easy when filtering huge directories with enabled previews. CCBUG: 287642
2011-12-04Make sure that enabling previews triggers the generation of previewsFrank Reininghaus
Before this commit, no previews were generated if the icon size was the same with and without previews.
2011-12-04Update the zoom slider if the previews setting is changedFrank Reininghaus
This is important if the zoom levels are different with previews enabled/disabled.
2011-12-04Clear the selection in MousePressEvent() rather than MouseReleaseEvent()Frank Reininghaus
This fixes the problem that clicking an unselected item in order to drag it would result in dragging all previously selected items as well. With this commit, previously selected items are unselected when a new item is clicked. The reason why clearing the selection was moved to MouseReleaseEvent() in commit b583dd6d4d3a03e3af2ec8d370132b84935ff871 was that clicking one of several selected items should not result in unselecting the other items (to make sure that dragging multiple items is possible). However, this can also be assured by just checking in MousePressEvent() if the clicked item has been selected already and not clearing the previous selection in that case. This applies equally to the case that a context menu is requested when several items are selected.