┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-07-02Make it clear that the Trash/Delete confirmations apply to all KDE appsFrank Reininghaus
FIXED-IN: 4.11.0 REVIEW: 111324
2013-07-02Prevent some unnecessary layoutings when the view size is changedFrank Reininghaus
In Icons/Details (Compact) View, no layouting is necessary if the view height (width) changes. REVIEW: 111322
2013-06-30Replace QList by QVector if the elements are larger than a pointerFrank Reininghaus
If the elements are larger than a pointer, QList does not store the elements themselves, but pointers to them in a contiguous block of memory. This wastes quite a bit of memory. This can be prevented easily by using QVector instead. REVIEW: 111304
2013-06-29Dolphin: Use the Nepomuk2::FileMetaDatConfigWidgetVishesh Handa
Instead of the KFileMetaDataConfigurationWidget REVIEW: 111294
2013-06-28Fix memory leak in KFileItemModelFrank Reininghaus
Since m_pendingItemsToInsert is a list of pointers now (and not a list of KFileItems, as in the 4.10 branch), we have to delete all pointers when clearing or destroying the model. I think that no review request is necessary for this small and obvious change. CCMAIL: [email protected]
2013-06-26Remove the space (1 pixel) between the file name and the fileEmmanuel Pescosta
icon in Compact View and Details View mode. BUG: 320899 FIXED-IN: 4.11.0 REVIEW: 111244
2013-06-26Re-enable expandable folders for network top level folders (remote:/)Emmanuel Pescosta
Added a hash table for target url to url mapping. So when the dir lister sends us the target url as directory url, we can use the url mapping table to get the right "Dolphin internal" directory url, which is the non-target url. BUG: 306219 FIXED-IN: 4.11.0 REVIEW: 111252
2013-06-26Fix the "dropped files are not selected" regression that hasEmmanuel Pescosta
recently been brought up and that have been caused by review 107351 / commit fd65a97b0787b23246c9392fdc34173fb604c9ca CCBUG: 233335 FIXED-IN: 4.11.0 REVIEW: 111254
2013-06-26Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-26Use the KDE SC version also as the Dolphin versionsFrank Reininghaus
This has some advantages: (a) The version actually changes for every bug fix release, making it easier to find out which version a bug reporter has used. (b) No changes in Dolphin's source code are required to keep the version always up to date. (c) It is more transparent for users because there are not two different versions any more.
2013-06-26Fix performance regression when loading folders in Details ViewFrank Reininghaus
When using Details View, only insert all pending items immediately if new items are inserted which might be children of a pending item. Fixes the problem that inserting the items in multiple bunches slows down the folder loading. Note that the cause of the slowness when inserting in multiple bunches is that KItemListSizeHintResolver needs O(N^2) time in the worst case for inserting N items into a model with N existing ones. REVIEW: 111226
2013-06-26Improve filterbar lock button.Kai Uwe Broulik
Use object-(un)locked icon and make it flat. REVIEW: 111233
2013-06-26Dolphin Search Date: Set the proper dateVishesh Handa
QDate's api is not that intuitive and the addDays functions return a QDate with those amount of days. They do not modify the original QDate. BUG: 321198
2013-06-24Do not show "Move To Trash" action in context menu for remote URLs.Dawit Alemayehu
BUG: 261762 REVIEW: 111206 FIXED-IN: 4.11
2013-06-24Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-24Use the target url of a item when creating the QMimeData in ↵Emmanuel Pescosta
KFileItemModel::createMimeData. BUG: 307336 FIXED-IN: 4.10.5 REVIEW: 111209
2013-06-23Prevent possible infinite recursion in ViewPropertiesFrank Reininghaus
If each directory can have its own view properties, and loadting the .directory file fails in a directory, we have to load the global view properties. However, if we try to do this by changing the "global view properties setting" and loading the view properties for the same directory again, we might get an infinite recursion if changing the setting fails. We now force a loading of the global view properties by constructing a new ViewProperties object with an empty URL. Thanks to Kurt Hindenburg for helping to debug this issue (which was only reproducible on MacOS). BUG: 316209 FIXED-IN: 4.10.5 REVIEW: 111182
2013-06-22Dolphin Nepomuk Roles: Handle values which are resource listsVishesh Handa
It is common for music files to have more than one artist BUG: 321359
2013-06-22Remove knepomukdatamanagement_export.hVishesh Handa
It is no longer required. In fact it hasn't been required since nepomuk-core was introdcued.
2013-06-22Update the "Move to Trash" action's and the "Delete" action'sEmmanuel Pescosta
enabled state in the context menu for read only files/folders (also archives). BUG: 294013 FIXED-IN: 4.11 REVIEW: 111160
2013-06-22Make sure that changing the view mode does not failFrank Reininghaus
This commit ensures that changing the view mode works even if the .directory file in the user's KDE folder is not writable. BUG: 318534 FIXED-IN: 4.11.0 REVIEW: 111120
2013-06-22Enable KIO error reporting when renaming with the dialogFrank Reininghaus
The problem was that the KonqOperations object did not have the right parent. BUG: 299646 FIXED-IN: 4.11.0 REVIEW: 111111
2013-06-22Dolphin: Do not try to connect to Nepomuk if it is not runningVishesh Handa
Each time one uses any of the Nepomuk classes, an attempt is made to connect to the database. This slows down the application since connecting to Nepomuk is not so cheap. BUG: 321299
2013-06-21Revert "Hide context menu plugins unless enabled by default or by the user"Sune Vuorela
This reverts commit b1aebb44d6863951841d857b84253a782d4138dc. As agreed with Frank on k-c-d.
2013-06-20Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-20Allow renaming multiple files without number if extensions are differentFrank Reininghaus
Normally, we only allow renaming multiple files if the new file name contains a contiguous sequence of '#' placeholders, which are then replaced by numbers. However, if all extensions are different, we can also rename the files without such a placeholder because the original extension is preserved when renaming. This had been possible some time ago already. That this "accidental feature" was lost was a side effect of the fix for bug 318942. BUG: 321234 FIXED-IN: 4.10.5 REVIEW: 111079
2013-06-20Make it possible to select files like "a_b" using keyboard searchFrank Reininghaus
The problem was that pressing the Shift key would reset the keyboard search. BUG: 321286 FIXED-IN: 4.11.0 REVIEW: 111102
2013-06-20Hide the "drop" indicator when an item is not hovered any moreFrank Reininghaus
This fixes the problem that the drop indicator might still be shown after the drag&drop operation in the Places Panel is finished. REVIEW: 111037
2013-06-20Some simplifications in KFileItemModelRolesUpdaterFrank Reininghaus
This removes some things that are obsolete after the recent commits: (a) resolveNextPendingRoles() is not called any more when the preview job is running. (b) In applyResolvedRoles(), we always load the icon if it isn't known yet. This ensures that every item has an icon. REVIEW: 111012
2013-06-20Try to do at least a "fast" icon loading for all itemsFrank Reininghaus
If all icons for the visible items could be loaded in 200 ms, we continue loading icons without mime type determination for all items until the 200 ms are over. This reduces the risk that the user ever sees "unknown" icons. REVIEW: 111011
2013-06-20Avoid a unnecessary resorting when items are changed, only resort the items ↵Emmanuel Pescosta
when the sorting role value is changed. BUG: 299565 FIXED-IN: 4.11 REVIEW: 111146
2013-06-20Make sure that all visible items have an iconFrank Reininghaus
We try to determine "final" icons, i.e., icons with known mime type, for 200 ms. If this does not succeed, we at least load "fast" icons, i.e., load the icons without determining the mime type. REVIEW: 111009
2013-06-20Prevent the selection rectangle from being reduced to 0pxEmmanuel Pescosta
width or 0px height, so the selected items can not be accidently unselected when the rectangle width/height becomes 0px. BUG: 320897 REVIEW: 111144 FIXED-IN: 4.10.5
2013-06-20Simplify handling of preview jobsFrank Reininghaus
This patch changes two things about the way we handle the preview jobs: (a) Rather than passing a KFileItemList to startPreviewJob(), remembering the leftovers in the member variable m_pendingPreviewItems and then starting a new preview job for these, we append items that need a preview to this member, and let startPreviewJob() take its input from there. This simplifies the code greatly. (b) To prevent that we start preview jobs with just one item and also that the GUI is frozen too long by startPreviewJob(), we take the following approach: * If the mime type of the first pending item is known, the function has probably been called by startUpdating(), which has determined mime types for the visible items already. startUpdating() has also blocked the GUI, so we just take all items at the beginning of the list with known mime type, and do not do any expensive mime type determination in startPreviewJob(). * If the mime type of the first pending item is unknown, the function has probably been called by slotPreviewJobFinished(). In that case, we can afford to block the GUI for a short while, so we determine mime types for 200 ms. REVIEW: 111008
2013-06-20Merge remote-tracking branch 'origin/KDE/4.10'Dawit Alemayehu
2013-06-18Do not use fixed widths for the widgets in the status barFrank Reininghaus
This fixes the problem that the Dolphin window has a rather large minimum size. A side effect of this was that splitting the view could resize the window (because twice the minimum status bar width was needed then). BUG: 319373 REVIEW: 110966 FIXED-IN: 4.10.5
2013-06-18Ensure that the "Sort by Type" setting is respectedFrank Reininghaus
Before this commit, switching from, e.g., "Sort by Name" to "Sort by Type" sometimes had no effect until the view was refreshed. The problem was that the re-sorting was triggered before the type information was actually added to the model. BUG: 310705 BUG: 312014 FIXED-IN: 4.10.5 REVIEW: 111004
2013-06-13Remove trailing white spaceFrank Reininghaus
2013-06-13Fix "unused parameter" warningFrank Reininghaus
We don't need the parameter at all, so let's just remove it.
2013-06-10Merge remote-tracking branch 'origin/KDE/4.10'Frank Reininghaus
2013-06-10Do not rename files unexpectedly when changing the URLFrank Reininghaus
This is the real fix now - note that the last commit 4de9a233642a62ee96bac6031340d3eea21f14f9 was actually the fix for bug 320823. Somehow, I have messed up the local branches in my git respository clone - sorry for the confusion! BUG: 319912 FIXED-IN: 4.10.5 REVIEW: 110908
2013-06-10Do not rename files unexpectedly when changing the URLFrank Reininghaus
If the role editor loses focus, it considers the current renaming operation finished, and tells DolphinView to rename the file. This is a problem when changing the directory, because the URL change happens before DolphinView receives the signal, which results in a file in the new directory being renamed unexpectedly. The solution is to establish the connection to the slotRoleEditingFinished signal only when the "rename inline" editor is opened, and disconnect it when renaming is finished or canceled or the URL changes. BUG: 319912 FIXED-IN: 4.10.5 REVIEW: 110908
2013-06-10Fix Bug 319119 - Dolphin doesn't notice when renaming failedEmmanuel Pescosta
Change the data in the model before the real renaming is done by KonqOperations::rename(), but when the rename operation fails, revert the data changes in the model. BUG: 319119 REVIEW: 110922
2013-06-09Do not delete files when Shift-clicking "Trash"Frank Reininghaus
Thanks to Dawit Alemayehu for making this fix possible with commit 8e023ae9e5051cb7b81af86a178e37c1f2c5da94 ! BUG: 307254 FIXED-IN: 4.11.0
2013-06-07Remove unused argumentFrank Reininghaus
I saw a runtime warning from QMetaObject::invokeMethod() that KJob* is not a registered type. Since we don't use that argument in slotPreviewJobFinished(KJob*) anyway, it's best to remove it.
2013-06-06Ignore a changed item if it cannot be found in the modelFrank Reininghaus
This prevents repeated attempts to reload the data for the non-existing item. This was the root cause of bug 320791. Thanks to Hrvoje Senjan and Jekyll Wu for testing the new code and finding this bug! BUG: 320791
2013-06-06Make calls to resolveNextPendingRoles and resolveNextSortRole delayedFrank Reininghaus
This prevents that functions that call these indirectly call themselves recursively and cause trouble. BUG: 320791
2013-06-06startPreviewJob: if items is empty, delay call to slotPreviewJobFinshedFrank Reininghaus
This should prevent that other functions, which start preview jobs, eventually call themselves and thus cause trouble. CCBUG: 320791
2013-06-05KFileItemModelRolesUpdater: waste less ressources and fix some bugsFrank Reininghaus
The main change in this commit is that we do not determine expensive roles (like previews, mime types, etc) for all items, but only for the visible ones and those close to the visible area or on the first and the last page of the view. This prevents that the CPU and hard drive are kept busy for quite some time after entering a folder while all items are handled asynchronously. There is one known problem at the moment: when sorting by "Type" or another role that can be resolved by KFileItemModelRolesUpdater, the icons of the visible items are sometimes not loaded while the sorting is still in progress. I will try to fix this issue during the next few days. REVIEW: 110839
2013-06-05Reduce KFileItemModel memory usage by making use of implicit sharingFrank Reininghaus
The idea is based on http://milianw.de/blog/katekdevelop-sprint-vienna-2012-take-1 REVIEW: 110686
generated by cgit v1.3 (git 2.53.0) at 2026-04-21 23:45:41 +0000