| Age | Commit message (Collapse) | Author |
|---|
|
User feedback has shown that many users used the dialog for renaming
files. Since the dialog is still used when renaming multiple files, I
think there is no good reason not to use it for renaming single files
as well if the user wants.
Note that we cannot add an option in the settings dialog due to string
freeze issues. For the time being, you will have to add the line
"RenameInline=false" to the [General] section of
$KDEHOME/share/config/dolphinrc.
BUG: 304627
FIXED-IN: 4.9.2
|
|
does not expand the dir => Bug discovered: When you drag a
item onto a folder-view-item and then move it away
instantly before the autoactivation event is triggered
(After 750ms), the folder will be opened anyway.
BUG: 305783
REVIEW: 106381
|
|
(cherry picked from commit f0d5e062bf0452258d337d7dcb2edd2eefa1c37b)
|
|
|
|
BUG: 176277
REVIEW: 106072
FIXED-IN: 4.9.2
(cherry picked from commit 824fa6a43734cf9ad2a690778c50bdaf76a1fb0e)
|
|
BUG: 176277
REVIEW: 106072
|
|
different partition using "Places Panel"
BUG: 242007
REVIEW: 106380
|
|
It is not reproducible on every machine for me, but it seems that it can
happen that DolphinView's slot slotRoleEditingFinished() is invoked
after the items have already been removed from the model. In that case,
we have to return from the slot immediately to prevent a crash.
BUG: 306147
FIXED-IN: 4.9.2
|
|
According to the backtrace in the bug report, it is possible that
KStandardItemListWidget::paint() is called if the hash m_textInfo has
not been initialised. The widget's index must be -1 in this case, see
KStandardItemListWidget::triggerCacheRefreshing(). It looks like this
can only happen if the item is about to be removed from the view, see
KItemListView::slotItemsRemoved().
I could not reproduce the crash, so I'm not sure why exactly this
happens, but this commit should at least prevent the crash.
BUG: 306167
FIXED-IN: 4.9.2
|
|
I had missed one places where the incorrect icon was used in my
previous commit d7e7ca53bb95c7555bbf107d92b47ac25eda1918.
BUG: 304323
FIXED-IN: 4.9.2
|
|
Thanks to André Wöbbeking for noticing that this was unnecessarily
complex!
|
|
REVIEW: 106333
(cherry picked from commit acef4b1c287a315b42550c27fc18ac4b9f49746c)
|
|
REVIEW: 106333
|
|
This is achieved by adding some descriptive text and by using a more
appropriate icon.
Thanks to Panos Kanavos for the patch!
BUG: 300248
FIXED-IN: 4.10.0
REVIEW: 106325
|
|
I'm only backporting the removal of the '-', not the update for the
line number calculation in Icons View, because this is the safest part
of the patch and also the one that fixes the most annoying part of the
bug.
Thanks to Todd Jennings for the patch!
BUG: 304752
REVIEW: 106304
(cherry picked from commit 20b0cb68bf5cc1099fd6e61982817d9e2ae0130c)
|
|
Thanks to Todd Jennings for the patch!
CCBUG: 304752
REVIEW: 106304
|
|
KParts::ListingFilterExtension.
REVIEW: 106289
(cherry picked from commit cb79ee6a881e2b4418bccc22480e3e269e5b0af9)
|
|
KParts::ListingFilterExtension.
REVIEW: 106289
|
|
Dolphin is a file manager, and shouldn't be concerned with non-file
resources like notes, contacts and other stuff.
Use FileQuery instead of Query.
This also results in a faster queries. With File Queries Nepomuk can
perform some internal optimizations.
BUG: 306029
REVIEW: 106274
|
|
REVIEW: 106239
|
|
REVIEW: 106239
|
|
REVIEW: 106209
|
|
REVIEW: 106209
|
|
`git merge -s recursive --log --edit KDE/4.9' was run first, and it looked
like the only conflicts were in some docbooks. I then aborted the merge and
ran `git merge' with `-Xours' to use this branch's version of the
conflicting files.
Even though a lot of changes are listed below, all but the last two are
already present in master because they were cherry-picked from one branch to
another.
Hopefully this sets a trend and people start using git as it was intended to
be used.
* KDE/4.9: (50 commits)
Adjust to Ark's drag'n'drop D-Bus interface changes.
Adjust to Ark's drag'n'drop D-Bus interface changes.
Fix wrong behaviour, when Dolphin is started with --split argument.
Do not crash when finishing inline renaming in unusual ways
Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menus
Select the correct item in places-panel, when a directory is opened.
SVN_SILENT made messages (.desktop file)
avoid duplicate entries in konqueror address completion list
Fix translations not showing in the Sort by and Additional Information submenus
Fix wrong text color in Places Group Header. Use QPalette::Window for base color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
Fix wrong text color in places and in folders panel.
Show icon size as tooltip when adjusting icon size
Fix a long standing security issue with the hiding of Konqueror's location (address) bar through javascript.
Fixed the display of the security sheild icon for SSL sites.
SVN_SILENT made messages (.desktop file)
Follow-up to d7e7ca53bb95c7555bbf107d92b47ac25eda1918 - use correct icon
Use a better icon for recently accessed items in the Places Panel
Use a saner check for multimedia files in infopanel.
Fix the size of the rating stars in Icons View
Stop preview jobs when closing Dolphin
...
|
|
Ark's drag'n'drop D-Bus interface needs to be changed: so far, the object
path was always /DndExtract, but this does not work if Ark is being used as
an embedded KPart (in Konqueror or Rekonq, for example), as all tabs will
end up calling QDBusConnection::registerObject() with the same path. Only
the first call will work, and the result is that dragging and dropping from
any tab previewing an archive with Ark will extract from the first archive
being previewed.
To fix that, applications that accept the application/x-kde-dndextract
mimetype should now be adjusted to check the
application/x-kde-ark-dndextract-service and
application/x-kde-ark-dndextract-path ones instead; the former contains the
same service information that used to be passed, while the latter tells
which object path should be talked to.
This is the Dolphin part of the change, which also needs to be made to
the folderview plasmoid.
REVIEW: 106131
CCBUG: 304860
|
|
Actual Results:
dolphin starts without split view
Expected Results:
dolphin starts with split view
New behaviour:
* no url given - use default url for all two views
* one url given - use given url for all two views
* two urls given - open the first url in the left view and the second url in the right view
BUG: 305538
REVIEW: 106171
(cherry picked from commit d430a1c3b3c7485149f5486e38f4188074d09c0d)
|
|
|
|
Actual Results:
dolphin starts without split view
Expected Results:
dolphin starts with split view
New behaviour:
* no url given - use default url for all two views
* one url given - use given url for all two views
* two urls given - open the first url in the left view and the second url in the right view
BUG: 305538
REVIEW: 106171
FIXED-IN: 4.9.1
|
|
The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.
CCBUG: 304524
(cherry picked from commit a9c2bdc3b53955693e716bbab58c318fe25bdc9b)
|
|
The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.
BUG: 304524
FIXED-IN: 4.9.1
|
|
For top-level roles like "Name" and "Size", the group translation is 0.
In that case, the "group" member of the corresponding RoleInfo struct
must be an empty string. This is expected by the code which generates
Dolphin's menus, which group the top-level roles into a sub menu with
the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression
caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c.
Thanks to Christoph Feck for investigating this issue!
CCBUG: 305228
(cherry picked from commit 168d0511c754008cc679589566d961beb9f6cc10)
|
|
For top-level roles like "Name" and "Size", the group translation is 0.
In that case, the "group" member of the corresponding RoleInfo struct
must be an empty string. This is expected by the code which generates
Dolphin's menus, which group the top-level roles into a sub menu with
the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression
caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c.
Thanks to Christoph Feck for investigating this issue!
CCBUG: 305228
|
|
|
|
BUG: 304541
REVIEW: 106074
FIXED-IN: 4.9.1
(cherry picked from commit 1ec8de2c619006e3fe997fbf6074035d65dea6c5)
|
|
BUG: 304541
REVIEW: 106074
|
|
folders-dockwidget. Now it opens the folders in a new background tab (General behaviour of Dolphin)
BUG: 196263
REVIEW: 106069
|
|
|
|
Acked by Frank
REVIEW: 106049
BUGS: 305228
FIXED-IN: 4.9.1
(cherry picked from commit 199fabbaa8d8a12fb49e4c9922c38ec8b033923c)
|
|
Acked by Frank
REVIEW: 106049
BUGS: 305228
FIXED-IN: 4.9.1
|
|
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
BUG: 303133
FIXED-IN: 4.9.1
(cherry picked from commit b3c3da985159a9627c079ad615cd77fc5f7bb72a)
|
|
|
|
REVIEW:105973
|
|
|
|
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
BUG: 303133
|
|
|
|
ItemLayout is an enum, not a flag, so == is even more correct than '&'.
|
|
Patch by Emmanuel Pescosta <[email protected]>
BUG: 303375
REVIEW: 105575
FIXED-IN: 4.9.0
|
|
FIXED-IN: 4.9.0
BUGS: 274655, 292822
|
|
|
|
|
