┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2019-09-15Fix wrong window titlesNazar Kalinowski
Summary: BUG: 389135 FIXED-IN: 19.11.80 Currently dolphin shows a folder's name instead of a "place" name if the current path has trailing slash and place's name doesn't, or vice versa. This patch fixes this behavior, so that dolphin always shows a "place" name. The QUrl::FullyEncoded string conversion is required because that's how the places model stores the places URLs in the XML bookmarks file. Test Plan: Test configuration: https://imgur.com/a/U4zBp8c Before (wrong window titles are in red): https://imgur.com/a/dB4xRwo After (all window titles are correct): https://imgur.com/a/W7virBn Reviewers: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23706
2019-09-15Introduce test for window titlesElvis Angelaccio
2019-09-15Clean up hamburger menu and viewport and single-folder context menusNate Graham
Summary: Dolphin's hamburger and context menus have grown organically over time, becoming a bit messy and somewhat visually overwhelming. This makes them harder to parse and more intimidating to use. This patch cleans up the hamburger menu and viewport and single-folder context menus to group items more logically, and remove items that aren't actually relevant to the context. The hamburger menu part of the patch is fairly significant, and draws from the principle of only showing actions with a global scope that are not already accessible from another visible method (e.g. via the default toolbar). In the end, it manages to be shorter than the current hamburger menu with expose actions that are more relevant. A visible method to display context-specific actions should be explored separately (see https://bugs.kde.org/show_bug.cgi?id=411500). Depends on D23945 Test Plan: Before, hamburger menu: {F7334178} After, hamburger menu: {F7350958} Before, viewport: {F7324802} After, viewport: {F7330109} Before, one folder selected: {F7324798} After, one folder selected: {F7341163} No change for the context menus shown when selecting a single item, multiple items, or multiple folders Reviewers: #vdg, #dolphin, meven, elvisangelaccio, GB_2 Reviewed By: #vdg, #dolphin, meven, elvisangelaccio, GB_2 Subscribers: GB_2, mmustac, elvisangelaccio, meven, ndavis, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23757
2019-09-15Bring back placesitemmodeltestMéven Car
KIO_VERSION is not defined, KF5_VERSION is.
2019-09-14Improve icons and text for some actionsNate Graham
Summary: Split out from D23757 Reviewers: #dolphin, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23945
2019-09-14Fix unused variable warningElvis Angelaccio
Should have been removed by 60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7 GIT_SILENT
2019-09-14This is not unusedIsmael Asensio
GIT_SILENT
2019-09-14DolphinTabWidget: cleanup index-by-URL API usageElvis Angelaccio
Summary: Follow-up of D23655 where we didn't have time to polish the code: - add a couple of variables to make the code more clear. - remove the `get` prefix which we usually don't use in Qt code. - make the function private since it's very tied to implementation. - add a new isUrlOpen public method as wrapper. Reviewers: feverfew Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23860
2019-09-14Use directly "isEmpty()"Laurent Montel
2019-09-10Add Reset Zoom Level action inside View menuNate Graham
Summary: FEATURE: 409591 FIXED-IN: 19.12.0 Test Plan: {F7096397} Reviewers: elvisangelaccio, shubham, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: broulik, cfeck, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D22444
2019-09-09Merge branch 'Applications/19.08'Nate Graham
2019-09-09Fix ascending/descending choosers getting unchecked when re-selecting the ↵Nate Graham
same sort order Summary: When you select the same sort order that's already selected, the currently-checked sort order description (the human-readable ascending/descending items) gets unchecked in `slotSortTriggered()` yet the ascending/descending items items only get checked in `slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets checked again. This patch fixes the problem by not unchecking them in the first place. BUG: 411223 FIXED-IN: 19.08.2 Test Plan: 1. Right-click > Sort By > Click the currently-selected sort order 2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: broulik, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23412
2019-09-08GIT_SILENT: minor qstring optimizationLaurent Montel
2019-09-06Use large colorful category icons in Dolphin settingsBjörn Feber
Summary: {F7324074} Ref task T10165 Depends on D23749 Test Plan: Open the Dolphin settings dialog. Reviewers: #dolphin, #vdg, ndavis, ngraham Reviewed By: #dolphin, #vdg, ndavis, ngraham Subscribers: ngraham, ndavis, kfm-devel, #vdg, #dolphin Tags: #dolphin Maniphest Tasks: T10165 Differential Revision: https://phabricator.kde.org/D23750
2019-09-05Change terminal panel icon to dialog-scriptsNoah Davis
Summary: The old icon was a color icon, which does not match the style of other toolbar/menu buttons Test Plan: {F7321334, size=full}{F7321319} Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23740
2019-09-04Use better-named visible and hidden iconsNate Graham
2019-09-04Unbreak context menu showing when right clicking on an empty areaLuca Beltrame
In D22149, a request was made to remove a variable assignment ("action", on line 389 in src/dolphincontextmenu.cpp. However the change went too far, and it actually removed the exec() call, not just the assignment which should have stayed. This resulted in the context menu not being shown at all. Adding back exec(m_pos) at least allows for the context menu to show. CCMAIL: [email protected]
2019-09-02Merge branch 'Applications/19.08'Elvis Angelaccio
2019-09-02Fixing bugs in new folders in tabs featureAlexander Saoutkin
Summary: Fixing bug where urls in secondary view containers would not be considered for the open new folders in tabs feature. Test Plan: Manual testing. Testing for no regressions. Testing that URL is found if in secondary view container Reviewers: elvisangelaccio Reviewed By: elvisangelaccio Subscribers: kfm-devel, ngraham Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23655
2019-09-02Making sure that DBus objects are all created before the serviceAlexander Saoutkin
Summary: Currently the DBus service is created before the MainWindow DBus object is created. This can cause hangs if another service makes calls to a a method in an object that's not been initialised, when the service is already published. This patch defers the creation of the service until all DBus objects are created. Test Plan: Tested in KDevelop. Have "open new folders in tabs" feature enabled. Open several folders with Dolphin at once. Before this patch there would be noticeable hanging. With this patch all tabs instantly open with no hanging. Reviewers: elvisangelaccio, ngraham Reviewed By: elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23672
2019-09-02Fix places text when the URL has a trailing slashElvis Angelaccio
Summary: QUrl::fileName() returns an empty string if the URL ends with a slash. Test Plan: 1. Run `dolphin /tmp` from command line 2. Right-click from viewport and click 'Add to Places' Reviewers: ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23654
2019-09-02[Tab Bar] Resolve tab icon only if visibleKai Uwe Broulik
Calling KIO::iconNameForUrl will determine mime type of the file potentially blocking. Don't needless do it when the tab bar isn't visible. Differential Revision: https://phabricator.kde.org/D23295
2019-09-02Merge branch 'Applications/19.08'Kai Uwe Broulik
2019-09-02Reset progress bar text when directory loading startsKai Uwe Broulik
Dolphin shows a different text for whether it is loading the directory or currently sorting its contents. However, when entering a folder that causes sort criteria to change (e.g. because of different view properties in that folder), the status bar text is changed to "Sorting..." while it is still actually loading the folder. When loading a directory starts, reset any status bar text to ensure "Loading..." is displayed in this case. Differential Revision: >https://phabricator.kde.org/D23459
2019-09-02Replace the stop button of the media preview by a pause buttonMéven Car
Summary: Stop is not as useful as paused plus it makes the button coherent with the click to play/pause feature. CCBUG: 364957 Test Plan: {F7305382} Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23648
2019-09-02Add missing spaceYuri Chornoivan
2019-09-01Add "Add to Places" action to file menuNate Graham
Summary: It's recommended that actions available in context menus be available in the main menu as well for discoverability's sake. This patch does so for the "Add to Places" action. The action is moved over to the main window, and accessed in the context menu via the actionCollection it lives in. BUG: 390757 FIXED-IN: 19.08.0 Test Plan: - Action still works - Action still appears in context menu when relevant - Action in the File menu only becomes enabled when only a single directory is selected or nothing is selected {F7143876} {F7143877} {F7143878} {F7143879} Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22149
2019-09-01[dolphin] Add an action to toggle the searchbarIsmael Asensio
Summary: Make search action toggle the searchbar instead of just launching it. The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar. This behavior in inconsistent with other dolphin actions which toggle panels or tools. BEFORE: {F7256652} AFTER: {F7256862} BUG: 344617 FIXED-IN: 19.12.0 Closes T8473 Depends on D23075 Test Plan: - Enable the search mode: the searchbar appears and the toolbar button gets checked - Press the search button again, and it goes back to normal mode. - The search button state is coherent with the searchbox - Coherence is kept when changing to a split view or different tab - Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it. Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio Reviewed By: ngraham, #vdg Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel Tags: #dolphin Maniphest Tasks: T8473 Differential Revision: https://phabricator.kde.org/D23232
2019-09-01Make non-empty textual columns come first in sortingNazar Kalinowski
Summary: Current behavior of dolphin in sorting of files with textual columns (e.g. tags) is to show files without this particular textual column (e.g. without tags) first. This patch changes this behavior so that dolphin shows the files with some value before the files without any value for chosen sorting method. BUG: 410538 Test Plan: Sorting by name (isn't affected by the patch): https://i.imgur.com/eqbYwyZ.png Sorting by textual column ("tags" in this particular example), old version (non-tagged files and folders come first): https://i.imgur.com/5KLLujU.png patched version (tagged files and folders come first): https://i.imgur.com/oUAeZ2z.png Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23482
2019-09-01Add click to play/pause feature on previews for audio/videoMéven Car
Test Plan: In dolphin, click on a video or audio preview in the information panel. The video or audio preview starts Reviewers: elvisangelaccio, #dolphin, ngraham Reviewed By: elvisangelaccio, #dolphin, ngraham Subscribers: alexde, anthonyfieroni, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22183
2019-08-28Don't store view properties on network sharesKai Uwe Broulik
Entering a folder will have Dolphin determine whether it can store the view properties in a .directory file within the folder or in a generic config location. It does so by checking for permissions on the file and parent dir causing various stat calls that potentially block on a slow mount. Also, the config reading thereafter can be very slow. Moreover, network shares are typically shared between users, so one user's view properties shouldn't affect or be overwritten by this Dolphin instance. It doesn't resolve symlinks but is surely an improvement over the status quo. Differential Revision: https://phabricator.kde.org/D23458
2019-08-27Always periodically dispatch pending itemsKai Uwe Broulik
"Local" URLs can also be slow. This might jeopardize loading large local directories where a resorting could take place but imho it's better than leaving the user wondering when files will finally show up. However, it takes some time for KDirLister to initially signal items having been added, and only then our 2 second timer starts. Also, stop the timer when loading has completed. Differential Revision: https://phabricator.kde.org/D23460
2019-08-25Merge branch 'Applications/19.08'Nate Graham
2019-08-25Fixing bug where split view opens with no URLsAlexander Saoutkin
Summary: BUG: 411193 FIXED-IN: 19.08.1 Test Plan: Reproduce steps as given in bug report. Observe the exected result. Used qdbusviewer and ShowFolders method to observe that no regressions occured in the "open new folders in tabs" feature. Reviewers: elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23445
2019-08-25Change default Dolphin toolbar layoutSimon Krull
Summary: {F7205836} Use a default toolbar layout that looks better and makes more sense for new users. Test Plan: Open Dolphin (with the default toolbar) Reviewers: #dolphin, #vdg, ngraham, GB_2, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, GB_2 Subscribers: iasensio, filipf, meven, elvisangelaccio, felixernst, GB_2, ndavis, ngraham, kfm-devel, #vdg, #dolphin Tags: #dolphin, #vdg Differential Revision: https://phabricator.kde.org/D23075
2019-08-24Middle-elide file/folder labels so the extension is always visibleNate Graham
Summary: This ensures that the filename extension is always visible, and also is just a nicer way to elide file and folder names in general. BUG: 404955 FIXED-IN: 19.12.0 Test Plan: Details view: {F6648784} Icons view with limited label height: {F6648785} Reviewers: #dolphin, #vdg, elvisangelaccio, GB_2 Reviewed By: #dolphin, #vdg, elvisangelaccio, GB_2 Subscribers: GB_2, ndavis, rooty, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19471
2019-08-24Correct "New Window" tooltipNate Graham
BUG: 411215 FIXED-IN: 19.12.0
2019-08-19Fix a typoNazar Kalinowski
Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23264
2019-08-14Correct translation context for zoom out action's what's this textNate Graham
2019-08-13Remove redundant codeAntonio Prcela
Summary: Remove redundant negation and the AND check. OR is enough. Reviewers: meven, elvisangelaccio Reviewed By: meven, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23129
2019-08-11Match style of if() condition used aboveElvis Angelaccio
To be consistent with aeba47648d8b4b43ad0f8e237cfc95b8a4bd60ac.
2019-08-11Merge branch 'Applications/19.08'Elvis Angelaccio
2019-08-11Fix an issue with focus lost after closing terminal panelAndrey Yashkin
Summary: After leaving terminal with Ctrl-D or exit commands the input focus isn't set back to the folder view. The problem appears, because `TerminalPanel::isHiddenInVisibleWindow` returns not what it supposed to return, since when the terminal process exits, `m_terminal` is set to nullptr. I moved unwanted checks from it inside `TerminalPanel::dockVisibilityChanged` This change also exposes a crash in `DolphinMainWindow::slotTerminalPanelVisibilityChanged()`, which was previously working only by luck. Now we check whether `m_activeViewContainer` is not null before using it. BUG: 407979 FIXED-IN: 19.11.80 Test Plan: 1. Open Dolphin 2. Press F4 to open the terminal panel 3. Type exit<Enter> or press Ctrl-D 4. Check current focus widget Reviewers: #dolphin Subscribers: ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22420
2019-08-11Move variables closer to their usageElvis Angelaccio
GIT_SILENT
2019-08-11Coding style fixesElvis Angelaccio
GIT_SILENT
2019-08-11Do not match daemonized dolphin instances: part 2Elvis Angelaccio
Summary: `dolphin --daemon` does not have the `/dolphin/Dolphin_1` dbus path, because it doesn't have any DolphinMainWindow. Checking if the QDBusInterface is valid is not enough, we also need to look for dbus errors. This should have been part of commit 7df5fc8edb54153f. Not sure how I missed it. BUG: 408244 FIXED-IN: 19.08.0 Test Plan: 1. Make sure the new "Open new folders in tabs" setting is enabled. 2. Run `dolphin --deamon` and make sure is the only dolphin process around. 3. Call the `org.freedesktop.FileManager1.ShowFolders` method from QDbusViewer. Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23087
2019-08-03[Dolphin] Hide tooltip instantly on key pressPiotr Henryk Dabrowski
Summary: Instantly hide tooltip shown over an element when a key is pressed. Currently, when pressing an alphanum key to select a different file, the tooltip continues to cover much of the window - often hiding that newly selected file from view. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: broulik, elvisangelaccio, kfm-devel, pdabrowski Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22512
2019-07-31SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-07-31GIT_SILENT made messages (after extraction)l10n daemon script
2019-07-31SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
generated by cgit v1.3 (git 2.53.0) at 2026-04-27 19:00:35 +0000