┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2018-05-18Make target_link_libraries for kdeinit_dolphin PRIVATEAlexander Miller
Summary: There is no need to add all of kdeinit_dolphin's dependencies (including the static archive) when linking dolphin; kdemain is the only needed symbol. Mark the link libraries PRIVATE to simplify the link command for dolphin. Reviewers: #dolphin, elvisangelaccio Reviewed By: elvisangelaccio Subscribers: asturmlechner, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12931
2018-05-18Remove main.cpp from dolphinstatic_SRCSAlexander Miller
Summary: The file main.cpp is already in dolphin_SRCS and doesn't belong in dolphinstatic_SRCS. Normally the duplicate object is simply ignored, but with link time optimization (LTO), linking dolphin can fail. Apparently, the compiler tries to inline inline kdemain() in this case. That is undesirable anyway and it ultimately fails because the DBusInterface definition is not available: .../ccHEv6cl.ltrans0.ltrans.o: In function `DBusInterface::~DBusInterface()': <artificial>:(.text+0x2583): undefined reference to `vtable for DBusInterface' .../ccHEv6cl.ltrans0.ltrans.o: In function `DBusInterface::~DBusInterface()': <artificial>:(.text+0x5aa3): undefined reference to `vtable for DBusInterface' .../ccHEv6cl.ltrans0.ltrans.o: In function `kdemain': <artificial>:(.text+0x7686): undefined reference to `DBusInterface::DBusInterface()' <artificial>:(.text+0x7b64): undefined reference to `vtable for DBusInterface' collect2: error: ld returned 1 exit status See also <https://bugs.gentoo.org/655710>. Reviewers: #dolphin, elvisangelaccio Reviewed By: elvisangelaccio Subscribers: elvisangelaccio, asturmlechner, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12929
2018-05-14Re-add "Open With" items to context menu for files in search viewNathaniel Graham
2018-05-14Remove duplicated entryAntonio Larrosa
Summary: This gave a warning when running the script, and the value was overwritten a few lines below, so just remove the unused value. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D12845
2018-05-13Merge branch 'Applications/18.04'Elvis Angelaccio
2018-05-13Add missing i18n callMelanie Genz
The string was already part of dolphin but was not exposed for translation. BUG: 394194
2018-05-12Fix broken build without baloo-widgets masterElvis Angelaccio
D11245 introduced a dependency on baloo-widgets master, but baloo-widgets is only an optional dependency.
2018-05-11GIT_SILENT made messages (after extraction)l10n daemon script
2018-05-11GIT_SILENT made messages (after extraction)l10n daemon script
2018-05-07Disable all the 'create new' items when in the TrashNathaniel Graham
Summary: Disable all the items in the 'create new' menu when the active view is in the trash, because they're not useful and don't even work. We don't disable the entire menu because it's useful to be able to see what specific things are disabled. This can be reverted once T8234 is implemented. BUG: 332463 FIXED-IN: 18.08.0 Test Plan: - Enter the trash with and without a split view; the 'create new' menu items are all disabled - Be looking at something other than the trash with and without a split view; the 'create new' menu items are all enabled - Toggle between split views (one in the trash, one elsewhere); menu is correct for both cases Out of the trash: {F5837042} In the trash: {F5837043} Reviewers: #dolphin, broulik, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio Differential Revision: https://phabricator.kde.org/D12731
2018-04-30SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-04-30GIT_SILENT made messages (after extraction)l10n daemon script
2018-04-30SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-04-30GIT_SILENT made messages (after extraction)l10n daemon script
2018-04-29Merge branch 'Applications/18.04'Antonio Rojas
2018-04-29Don't filter out duplicated entries from places panelAntonio Rojas
This can lead to crashes and is inconsistent with the KIO file picker dialog, which shows duplicated entries. BUG: 393528 Differential Revision: https://phabricator.kde.org/D12558
2018-04-29Use QGuiApplication::applicationDisplayName()Elvis Angelaccio
Same result with less code.
2018-04-29Bundle dolphinui.rc also in dolphinmainwindowtestElvis Angelaccio
Otherwise the test executable will not be able to find the .rc file while creating a DolphinMainWindow instance. We also need to force the component name to `dolphin`, otherwise kxmlgui will default to the name of the binary (which in this case would be dolphinmainwindowtest rather than dolphin).
2018-04-25DolphinTabPage: deactivate secondary view after closing split viewElvis Angelaccio
We deactivate the previously active view container whenever we change the active split view, but we never do the same when we close the split view. Long term we should probably even delete the secondary view after closing the split view, because it will never be used again and the pointer will be overwritten the next time the user opens the split view.
2018-04-25Merge branch 'Applications/18.04'Elvis Angelaccio
2018-04-25Update window title after closing split viewRobert Jennings
Summary: In dolphintabpage.cpp: Through the connections set up in createViewContainer(), m_primaryViewContainer->setActive(true), at line 98, ends up triggering slotViewActivated(). Because m_primaryViewActive is true, oldActiveView is not set to the view needed in this particular situation. Both oldActiveView and newActiveView end up pointing to the same view and the connections are not set up. BUG: 385111 FIXED-IN: 18.04.1 Test Plan: 1. Open split view 2. Make left panel active 3. Close split view 4. Navigate to various directories Window title now updates to show current directory Also tried with multiple tabs/combinations Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: elvisangelaccio, ngraham Differential Revision: https://phabricator.kde.org/D12446
2018-04-25Add failing test case for bug #385111Elvis Angelaccio
Will be fixed by D12446. CCBUG: 385111
2018-04-22Move "Open" actions to the top of the context menu for filesNathaniel Graham
Summary: This patch moves the "Open", "Open With", and "Open in" items to the top of the context menu to reap the following benefits: - Move the "Open" and "Open With" items closer to the top since they're commonly used items, and right now they're buried in the middle of the menu - Group related functionality - Consistency with other common platforms (macOS Finder and Windows Explorer both have these items at the top of the context menu) For folders, the "Open With" entries are moved higher, but not all the way to the top, since the "open in New tab/folder" entries are more useful. Test Plan: Tested all menu items in the context menu for files, folders, and links; all still work. Context menu for single file: {F5806809} Context menu for multiple files: {F5806810} Context menu for single folder: {F5806811} Context menu for multiple folders: {F5806812} Context menu for symlink to folder: {F5806815} Reviewers: #dolphin, #vdg, elvisangelaccio, abetts Reviewed By: #dolphin, #vdg, elvisangelaccio, abetts Subscribers: markg, abetts, elvisangelaccio Differential Revision: https://phabricator.kde.org/D11884
2018-04-19Merge branch 'Applications/18.04'Nathaniel Graham
2018-04-19Fix inconsistent preview spacing and icon wiggly-ness when toggling previews ↵Nathaniel Graham
in Icon mode Summary: Dolphin had some code to change the grid spacing when previews were toggled, in an attempt to optimize the view for 3:2 landscape photos. This was problematic for many reasons: - Conceptually, it was a bad idea to optimize the view for one specific use case. Previews are useful for more than just landscape photos, and this optimization would be inapplicable to any other set of files. - Folders entirely full of images commonly have some portrait-orientation images included too, so even if the goal were appropriate, it was a bad idea to optimize for only having landscape images. - For small sizes and medium icons (< 96px), the preview grid size was virtually identical to the non-preview grid size, so it had essentially no effect, and only made the icons wiggle strangely when previews were toggled. - For large large sizes (>= 96px), all it did was unnecessarily increase the horizontal grid spacing, actually //reducing// usability for browsing through folders of images. Therefore, let's just remove this code. BUG: 393306 FIXED-IN: 18.04.1 Test Plan: - Go to {nav Settings > View Modes > Icons} and make the icon size and preview size identical for 64px - Toggle previews on and off - Change both sizes to 112x - Toggle previews on and off In both cases, the grid spacing does not change and the icons do not wiggle strangely. The only visual change is that previews turn on or off. Dolphin still works fine for viewing 3:2 landscape photos. 80px icons: {F5813467} 192px icons: {F5813465} In fact, it's vastly //improved// for the >=96px use case since the grid spacing is no longer excessively wide Reviewers: #dolphin, hein Reviewed By: hein Subscribers: broulik Differential Revision: https://phabricator.kde.org/D12362
2018-04-13Convert hard coded shortcuts to standard keysRoman Inflianskas
Test Plan: Check all changed shortcuts on all platforms. Reviewers: #dolphin, rizzitello, elvisangelaccio Reviewed By: #dolphin, rizzitello, elvisangelaccio Subscribers: anthonyfieroni, ngraham, elvisangelaccio, rizzitello, #dolphin Differential Revision: https://phabricator.kde.org/D11048
2018-04-12Merge branch 'Applications/18.04'Antonio Rojas
2018-04-12Fix untranslated places panel entriesAntonio Rojas
Load the places panel entries strings from the kio5 catalog, where they live now BUG: 392822 Differential Revision: https://phabricator.kde.org/D12119
2018-04-11infopanel: Add choice of date display formatsMichael Heidelbach
Summary: Let user choose date display format via checkbox in context menu [[ https://phabricator.kde.org/file/info/PHID-FILE-5xjr7tvypj3jaczjtzrz | Example ]] Depends on D11242 FEATURE: 392352 Test Plan: visual inspection Reviewers: #dolphin, markg, ngraham Reviewed By: markg, ngraham Subscribers: broulik, markg, ngraham Tags: #dolphin, #kde_applications Differential Revision: https://phabricator.kde.org/D11245
2018-04-09Select and scroll to the file for "Open path" and "Open Path in New Window" ↵Nathaniel Graham
operations Summary: After performing a search and using the "Open path" or "Open Path in New Window" present in the context menu, make sure the file is selected and visible in the resulting view. Cannot implement the same fix for "Open Path in New Tab" because of a limitation in how the contents of inactive tabs are rendered; will need to fix that separately in another patch. BUG: 377510 Test Plan: Search for an item, and choose {nav Open Path} or {nav Open path in new window} Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, broulik Differential Revision: https://phabricator.kde.org/D11703
2018-04-09Add more tab access functionsNathaniel Graham
Summary: These new functions to access the next and previous tabs are not used by anything yet, but it is envisioned that they would be useful for a variety of purposes--such as the "open path in new tab" feature from D11703 Test Plan: Dolphin still compiled and runs; new code is not actually used anywhere Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Differential Revision: https://phabricator.kde.org/D12039
2018-04-08use the same bound check as setCurrentItem when setting m_currentItem manuallyFabian Kosmale
Summary: This patch basically adds the check that would normally be done to the itemInserted method, which seems to be good idea in general. However, the fact that this is needed there might be an indicator of a logic bug in the function – though, as I'm not familiar with the code base I cannot judge this. Test Plan: Without this patch, dolphin when started from a terminal prints the following warning (number can be different): qt.accessibility.core: Cannot create accessible child interface for object: PlacesView(0x563e863e35c0) index: 10 After applying the patch, the warning doesn't appear anymore. Dolphin still works still as it did before. Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D11990
2018-04-05Merge branch 'Applications/18.04'Elvis Angelaccio
2018-04-05Improve QDialogButtonBox::Yes override textElvis Angelaccio
Summary: We are asking the users whether they are sure they want to quit. But the "Quit" button can be ambiguous (am I quitting dolphin or just this dialog?). If we use a "Quit Dolphin" button instead, that clearly shows what will happen after triggering the action. Test Plan: Close dolphin while multiple tabs are open. Reviewers: #dolphin Differential Revision: https://phabricator.kde.org/D11892
2018-04-05[RenameDialog] Fix crash when renaming single itemsElvis Angelaccio
Summary: `m_spinBox` is initialized only when renaming multiple items. This commit restores the single-item rename logic which was wrongly removed by commit c5eb4e31161ccf422. BUG: 392743 FIXED-IN: 18.03.90 Test Plan: Disable inline renaming and try to rename single or multiple items (and also to undo the jobs). Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D11972
2018-04-03Show folder previews for items that have a Places Panel entryNathaniel Graham
Summary: informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug. BUG: 392621 FIXED-IN: 18.08.0 Test Plan: Before: {F5782793} After: {F5782794} Detailed test procedure: - Open the Information Panel - Turn on previews - Put some pictures in ~/Pictures - Hover over it and see that the Information Panel shows a preview of its contents - Add ~/Pictures to the Places panel - Hover over it again and see that previews are no longer displayed - Apply the patch and restart Dolphin - Hover over it once more and see that there are now previews, yay! Reviewers: #dolphin, markg, elvisangelaccio Reviewed By: markg, elvisangelaccio Subscribers: markg, broulik Differential Revision: https://phabricator.kde.org/D11894
2018-04-03Merge branch 'Applications/18.04'Antonio Rojas
2018-04-03Initialize m_konsolePartMissingMessageAntonio Rojas
Otherwise it just crashes when trying to open the terminal panel BUG: 392660 Differential Revision: https://phabricator.kde.org/D11904
2018-04-03SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-04-03SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-04-01Split Image Size into Width/HeightJulian Schraner
Summary: This patch splits the single property "Image Size" into "Width" and "Height", providing more fine-tuned control for power users. FEATURE: 374559 Test Plan: - Sorting works correctly - No real change, only exposed differently Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, elvisangelaccio Differential Revision: https://phabricator.kde.org/D11816
2018-04-01Fix detachingElvis Angelaccio
2018-04-01Use QHash rather than QMapElvis Angelaccio
As recommended by the clazy qmap-with-pointer-key check.
2018-04-01Use rightRef() instead of right()Elvis Angelaccio
As recommended by the clazy qstring-ref check.
2018-03-29Fix alignment of icons in Places panel and Compact view modeScott Harvey
Summary: Adjust calculation of icon pixmap Y value; now based off center of text label bounding rectangle. Previously, icons appeared top-aligned when text size was larger than icon size. Centering is done by obtaining the center point of the text frame (`m_textRect.center().y()`) and setting the top `Y` point of the icon to one-half of the scaled icon height (`m_scaled_PixmapSize.height()`) Division is done by `2.0`, to ensure calculations are done with floating-point math, in keeping with `QPointF`, which returns floating-point values. Also includes an adjustment named `midlineShift` (contributed by @zzag), which takes into account the font's midline in respect to the center of the text frame. Certain fonts (i.e. Noto Sans) can have a slightly offset midline, resulting in imperfect alignment of the icon. This small adjustment resolves that potential issue. See before and after screenshots. {F5764918} Before, showing misalignment (with and without debugging wireframes) {F5764920} After, showing correction BUG: 390771 Test Plan: -- Compile Dolphin with patch -- Increase system font size by several points (i.e. 15pt) -- Check that Places panel icons remain centered with the text label -- Select Compact View mode -- Adjust icon size slider to minimum -- Ensure that icons also remain centered in file listing -- Check several combinations of icon size & font size to ensure centering is consistent Reviewers: #dolphin, ngraham, cfeck, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: zzag, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D11650
2018-03-29Merge branch 'Applications/18.04'Elvis Angelaccio
2018-03-29Fix enum-compare-switch clang warningsElvis Angelaccio
We were comparing a value of type `KStandardItemListView::ItemLayout` with values of type `KStandardItemListWidget::Layout`.
2018-03-29[KItemListView] Check if KItemListStyleOption actually changed before ↵Kai Uwe Broulik
emitting a change This avoids work being done when it doesn't need to be. For instance, the preview generator waits for everything to have settled using a 200ms timer before generating a preview. This timer fired also in response to onStyleOptionChanged and needlessly delayed preview generation when navigating between folders despite the style option (e.g. icon size, view mode) not having changed. Differential Revision: https://phabricator.kde.org/D11481
2018-03-24[DolphinContextMenu] Fix excluding ourself from Open With menuKai Uwe Broulik
The desktop file name changed to org.kde.dolphin a long time ago. To avoid this breaking again, just use qApp->desktopFileName() BUG: 391997 Differential Revision: https://phabricator.kde.org/D11540
2018-03-22Merge branch 'Applications/18.04'Nathaniel Graham
generated by cgit v1.3 (git 2.53.0) at 2026-04-22 03:04:15 +0000