┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2014-06-19Remove confusing warning messageFrank Reininghaus
The message "TODO: Emitting itemsChanged() with no information what has changed!" is not helpful for the user. The implementation of the TODO will be done in master, see https://git.reviewboard.kde.org/r/118815/ CCBUG: 336174
2014-06-04Fix possible crash if a kioslave adds multiple items with the same URLFrank Reininghaus
When opening the URL "man:", there are multiple items with the same name (for example, _exit is shown twice here). When opening a new tab, the kioslave reports some items as deleted (I have not quite understood why). The problem is that it reports some of the duplicate items twice in the list of deleted items. This confused KFileItemModel and corrupted the internal data structures, and finally, caused a crash. The fix is to remove all duplicates from KItemRangeList::fromSortedContainer(const Container& container). New unit tests included. BUG: 335672 REVIEW: 118507 FIXED-IN: 4.13.2
2014-05-29Fix Bug 334696 - File/directory icons/names move to the right when ↵Emmanuel Pescosta
opening/refreshing contents of Dolphin Take the scrollbar spacing into account. BUG: 334696 REVIEW: 118319 FIXED-IN: 4.13.2
2014-05-29Use "selectionToggleRect().contains(pos)" insteadEmmanuel Pescosta
of "m_selectionToggle->contains(pos)" in KItemListWidget::setHoverPosition(const QPointF& pos). This wrong check was accidentally introduced by commit 24326d447358f0dbfc18963743207d4a3d4f1c9e BUG: 299328 REVIEW: 118320 FIXED-IN: 4.13.2
2014-05-20Remove debug outputFrank Reininghaus
This debug output was pushed accidentally in commit c52ba9446b05e6bc7f890daac406659a9c37c562
2014-05-20Do not lose translation of Places items if a Dolphin window is closedFrank Reininghaus
If the "Places" are updated outside the current Dolphin process, PlacesItemModel::updateBookmarks() is called, which invokes PlacesItem::setBookmark(const KBookmark& bookmark) for each item. This commit ensures that the correct translation is used for system bookmarks like "Root", "Network", etc. Without this patch, all Places entries in the remaining Dolphin windows would switch to US English if one of multiple windows is closed. See http://lists.kde.org/?t=139660468400004&r=1&w=2 for details. BUG: 334999 REVIEW: 118207 FIXED-IN: 4.13.2
2014-05-13Stop listing children of collapsed foldersFrank Reininghaus
Before this patch, KDirLister would continue listing any children of collapsed folders, even though the children themselves were removed from the model. This could lead to new items being inserted as top-level items at some later point, because no parent could be found for them. This inconsistent model state could lead to a crash later on. Many thanks to Martin Koller for helping to debug this problem! BUG: 332102 REVIEW: 118055 FIXED-IN: 4.13.2
2014-05-13Ensure that all children of a collapsed folder are removedFrank Reininghaus
Before this patch, any (direct or indirect) children that might have been in m_pendingItemsToInsert, i.e., that were not inserted into the model yet because KDirLister had not finished listing the directory yet, would be added to the model later without a proper parent. This could cause a crash later on. CCBUG: 332102 FIXED-IN: 4.13.2
2014-05-13Allow the widget in the "Additional Information" dialog to resizeUzair Shamim
BUG: 334355 REVIEW: 118088 FIXED-IN: 4.13.2
2014-04-30Update the "Paste" action only if it is necessaryFrank Reininghaus
Updating this action is only required if the clipboard contents change, or if the "is writable" state of the current location changes. In all other cases, an update of this action should be prevented because it can be very expensive if many files are in the clipboard. In particular, the update when the selection changes could make changing the current item in the view very slow. BUG: 333903 REVIEW: 117782 FIXED-IN: 4.13.1
2014-04-26Merge branch 'KDE/4.13' of git://anongit.kde.org/kde-baseapps into KDE/4.13Emmanuel Pescosta
2014-04-26Mount partitions when you open them in a new tab.Emmanuel Pescosta
Instead of just emitting the slotItemMiddleClicked signal in PlacesPanel::slotItemContextMenuRequested we now use triggerItem with Qt::MiddleButton, which does set up the storage first and emit the slotItemMiddleClicked signal afterwards. BUG: 311226 FIXED-IN: 4.13.1 REVIEW: 117755
2014-04-26Do not change the selection when re-sorting the viewFrank Reininghaus
If a range of items has been selected by Shift-clicking or by pressing Shift+Arrow, then each of them is added individually to the selection before the items are re-sorted. Before this commit, the first and the last item in the range were moved, and all items between them were selected, even though these were not necessarily the items which had been selected before the re-sorting. BUG: 333457 REVIEW: 117603 FIXED-IN: 4.13.1
2014-04-26Enable the previous and next tab toolbar buttonsRenato Atilio
when multiple tabs are opened. Disable them again when there is only one remaining tab. Additionally set the default state to disabled. BUG: 332628 FIXED-IN: 4.13.1 REVIEW: 117778
2014-04-25Fix memory leak with Dropbox version control plugin.Emmanuel Pescosta
In the current version we only call endRetrieval when beginRetrieval was successfully in UpdateItemStatesThread::run(). This causes some problems with version control plugins (like Dropbox plugin), which have to do cleanups in endRetrieval. Now we always call endRetrieval after beginRetrieval when updating the version states. FIXED-IN: 4.13.1 REVIEW: 117753
2014-04-24Scroll to the right position when going back and show hidden files is enabled.Emmanuel Pescosta
Instead of emitting the directoryLoadingCompleted signal (via slotCompleted) in KFileItemModel::setShowHiddenFiles directly, we now call dispatchPendingItemsToInsert instead. @Frank: Thanks for your help! FIXED-IN: 4.13.1 BUG: 332159 REVIEW: 117021
2014-04-14Merge branch 'KDE/4.12' into KDE/4.13Frank Reininghaus
2014-04-14Update the "is cut" state of items if necessaryFrank Reininghaus
The icons of items which are "cut" are shown faded in the view. The "is cut" state of the widget representing an item is updated if the clipboard contents change. Before this commit, if the sort order was changed however, then each widget kept the "is cut" state of the item which had been shown previously at its position. The solution is to update the "is cut" state also if any of the widget's data change. BUG: 332792 REVIEW: 117451 FIXED-IN: 4.12.5
2014-04-03KDirectoryContentsCounter: do not delete currently active worker objectsFrank Reininghaus
Before this patch, the destructor of KDirectoryContentsCounter might delete the worker object, which lives in another thread, while one of its methods was still being executed. This could cause a crash. Only if the destroyed KDirectoryContentsCounter was the last one, the worker thread was stopped, and the destructor waited until all workers are done. BUG: 332767 FIXED-IN: 4.13.0 REVIEW: 117209
2014-03-31Make this thing compileAlbert Astals Cid
CCMAIL: [email protected]
2014-03-28When you open a new tab while the search mode is enabled, theEmmanuel Pescosta
newly opened tab also starts the same search (Because new tab is opened with the current view url), but the search box is in read-only mode. So you cannot close the search bar nor edit the search text. This patch fixes this by parsing the search url. The value of the "search" parameter is used as search text and the value of the "url" parameter is used for the search path ("root" folder for the search when "Search from here" mode is enabled). In case of Baloo search urls, we use Baloo::Query::fromSearchUrl. Removed everything related to read only mode in DolphinSearchBox, not needed anymore. REVIEW: 111968 BUG: 311950 FIXED-IN: 4.13.0
2014-03-25Set m_anyType as checked by default.Emmanuel Pescosta
CCMAIL: [email protected]
2014-03-24Dolphin Facet Widget: Convert type selection into radio buttonsVishesh Handa
They were previously checkboxes. Most files cannot have more than 1 type considering that the exposed types were "Document", "Image", "Video" and "Audio". Also, it is not very simple in baloo to search through ORs for types. Not through the exposed API anyway. REVIEW: 117015
2014-03-24DolphinSearchBox: Only search through filename is search text is not emptyVishesh Handa
2014-03-19Dolphin Facet Widgets: Implement date based filteringVishesh Handa
This required changes in Baloo which require reindexing. Since the storage location has changed for Beta 3 everyone should be re-indexing everything, so it won't be a problem.
2014-03-17Add the Baloo::Term to the Baloo:Query in ↵Emmanuel Pescosta
DolphinSearchBox::balooUrlForSearching(). REVIEW: 116837 FIXED-IN: 4.13.0
2014-03-16Merge branch 'KDE/4.12' into KDE/4.13Frank Reininghaus
2014-03-16Use MIME type inheritance to find out if a file contains textFrank Reininghaus
Before this commit, filenamesearch checked if a file's MIME type begins with "text/" to determine if its content can be searched. This prevented that text inside shell scripts is found. BUG: 332143 REVIEW: 116805 FIXED-IN: 4.12.4
2014-03-11Use QMutableHashIterator for deleting items from a QHashFrank Reininghaus
KItemListViewAnimation::slotFinished() used a QHashIterator to iterate over a QHash, and then removes an item from the hash using QHash::remove() inside the loop. This is quite unusual - the recommended way is to use a QMutableHashIterator (or std-style iterators and then QHash::erase(it)). This might be related to the cause of a crash in this function. BUG: 331876 REVIEW: 116666 FIXED-IN: 4.13.0
2014-03-05Fix Bug 326210 - Dolphin unnecessarily truncates names of soft links in ↵Emmanuel Pescosta
compact mode FIXED-IN: 4.13.0 BUG: 326210 BUG: 310592 REVIEW: 116121
2014-03-04SVN_SILENT made messages (.desktop file)l10n daemon script
2014-03-03Add a hover effect for the selection toggle.Emmanuel Pescosta
FIXED-IN: 4.13.0 REVIEW: 116028 BUG: 299328
2014-03-01Always go back/forward in history when pressing the respective buttonsFrank Reininghaus
Before this patch, pressing one of these buttons while an item is hovered selected this item. The motivation for this behavior was to provide a fast way to select items. However, this was counter-intuitive and confusing for many users. BUG: 310288 FIXED-IN: 4.13.0 REVIEW: 116469
2014-02-27Scroll to newly dropped files.Emmanuel Pescosta
If multiple files are dropped, scroll to the first dropped file. BUG: 315722 FIXED-IN: 4.13 REVIEW: 116020
2014-02-27Merge remote-tracking branch 'origin/KDE/4.12' into KDE/4.13Frank Reininghaus
2014-02-25Show the correct icon size in the zoom slider tooltip.Emmanuel Pescosta
BUG: 305694 FIXED-IN: 4.12.3 REVIEW: 111197
2014-02-25Fix Bug 330605 - Dropbox plugin prevents git plugin from workingEmmanuel Pescosta
Use scoring to find the best matching plugin for the given directory. Thanks to Phil Schaf for testing this patch! BUG: 330605 FIXED-IN: 4.12.3 REVIEW: 116019
2014-02-24Make the handling of the "maximum text lines" setting more robustFrank Reininghaus
If the user sets a maximum number of text lines in the settings, this number was translated into a maximum height in pixels using QFontMetrics::lineSpacing() before this commit. In KStandardItemListWidgetInformant::itemSizeHint(), this maximum height limited the size that is reserved for the item. However, in KStandardItemListWidget::updateIconsLayoutTextCache(), the maximum height was translated back into a maximum number of lines, which limits the number of lines that are created using the QTextLayout. This approach could lead to problems if the real height of the layouted text is 1 pixel more or less than QFontMetrics::lineSpacing() times "number of lines". Now we do not store a "maximum height" inside the "maximum size" explicitly, but store a maximum number of lines and a maximum with (for Compact View) separately, and then use the number of lines also to calculate the required size in KStandardItemListWidgetInformant::itemSizeHint(). This should make sure that the correct height is reserved for each item. Thanks to Christoph Feck and Emmanuel Pescosta for helping to debug this problem and testing the patch. BUG: 323841 FIXED-IN: 4.13 REVIEW: 113871
2014-02-24Handle font and palette changes in Dolphin list views.Emmanuel Pescosta
Also update the font of the meta data widget in InformationPanelContent (smallest readable font). BUG: 329186 BUG: 315061 FIXED-IN: 4.13 REVIEW: 115958
2014-02-11Remove some unused functions.Emmanuel Pescosta
void KFileItemModel::slotClear(const KUrl& url) bool UpdateItemsThread::lockPlugin() <- Done with QMutexLocker void UpdateItemsThread::unlockPlugin() REVIEW: 115627
2014-02-11Ensure that KItemListViewLayouter always has a size hint resolverFrank Reininghaus
KItemListViewLayouter uses a KItemListSizeHintResolver to find out how much space the items will need in the view. Before this commit, the size hint resolver object could be changed at runtime, and it could also be null. However, we never made use of these possibilities, so all the code that checks if m_sizeHintResolver is null is actually not needed at all.
2014-02-07Fix includesChristophe Giboudeaux
2014-02-07Merge remote-tracking branch 'origin/KDE/4.12'Frank Reininghaus
2014-02-07Only initialize the hash m_items in KFileItemModel if it is neededFrank Reininghaus
Moreover, clear the entire hash if items are added or removed. This saves time and memory when loading a directory, and it fixes problems that might occur if the model is in an inconsistent state, such as crashes that can happen when we try to remove individual items from m_items. BUG: 329494 FIXED-IN: 4.13.0 REVIEW: 115432
2014-02-07Fix build if Baloo is not installedFrank Reininghaus
2014-02-06Port Dolphin to BalooVishesh Handa
Nepomuk is being replaced with Baloo
2014-02-06Set the Details View colummns width to the preferred column width, by ↵Emmanuel Pescosta
double-clicking the header grips. BUG: 293315 FIXED-IN: 4.13 REVIEW: 115503
2014-02-02Restore the URLs of both views correctly when restoring a sessionFrank Reininghaus
The problem was that we restored the URL of the right view while the left one is still active. When we received the signal urlChanged(KUrl& url) from the right URL navigator, we then set the URL of the active (i.e., left) view to 'url', such that both views showed the same URL. BUG: 330047 FIXED-IN: 4.12.3 REVIEW: 115406
2014-01-31Don't store the index of the file item in the ↵Emmanuel Pescosta
VersionControlObserver::ItemState, get the index of the file item on demand instead. Fixes some "old"-index problems, esp. when you copy/move around files while the version control thread is still running. FIXED-IN: 4.13 REVIEW: 115410
2014-01-30Always enable the "Create New..." menu if the URL is writableFrank Reininghaus
This commit works around the problem that KDirLister may not provide a "rootItem" for some kioslaves by setting up a KFileItem with the view URL and using this to find out if the URL is writable. BUG: 330001 CCBUG: 330015 REVIEW: 115405 FIXED-IN: 4.12.2
generated by cgit v1.3 (git 2.53.0) at 2026-04-30 17:36:53 +0000