┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-06-23Prevent possible infinite recursion in ViewPropertiesFrank Reininghaus
If each directory can have its own view properties, and loadting the .directory file fails in a directory, we have to load the global view properties. However, if we try to do this by changing the "global view properties setting" and loading the view properties for the same directory again, we might get an infinite recursion if changing the setting fails. We now force a loading of the global view properties by constructing a new ViewProperties object with an empty URL. Thanks to Kurt Hindenburg for helping to debug this issue (which was only reproducible on MacOS). BUG: 316209 FIXED-IN: 4.10.5 REVIEW: 111182
2013-06-20Allow renaming multiple files without number if extensions are differentFrank Reininghaus
Normally, we only allow renaming multiple files if the new file name contains a contiguous sequence of '#' placeholders, which are then replaced by numbers. However, if all extensions are different, we can also rename the files without such a placeholder because the original extension is preserved when renaming. This had been possible some time ago already. That this "accidental feature" was lost was a side effect of the fix for bug 318942. BUG: 321234 FIXED-IN: 4.10.5 REVIEW: 111079
2013-06-20Prevent the selection rectangle from being reduced to 0pxEmmanuel Pescosta
width or 0px height, so the selected items can not be accidently unselected when the rectangle width/height becomes 0px. BUG: 320897 REVIEW: 111144 FIXED-IN: 4.10.5
2013-06-18Ensure that the "Sort by Type" setting is respectedFrank Reininghaus
Before this commit, switching from, e.g., "Sort by Name" to "Sort by Type" sometimes had no effect until the view was refreshed. The problem was that the re-sorting was triggered before the type information was actually added to the model. BUG: 310705 BUG: 312014 FIXED-IN: 4.10.5 REVIEW: 111004
2013-06-10Do not rename files unexpectedly when changing the URLFrank Reininghaus
This is the real fix now - note that the last commit 4de9a233642a62ee96bac6031340d3eea21f14f9 was actually the fix for bug 320823. Somehow, I have messed up the local branches in my git respository clone - sorry for the confusion! BUG: 319912 FIXED-IN: 4.10.5 REVIEW: 110908
2013-06-10Do not rename files unexpectedly when changing the URLFrank Reininghaus
If the role editor loses focus, it considers the current renaming operation finished, and tells DolphinView to rename the file. This is a problem when changing the directory, because the URL change happens before DolphinView receives the signal, which results in a file in the new directory being renamed unexpectedly. The solution is to establish the connection to the slotRoleEditingFinished signal only when the "rename inline" editor is opened, and disconnect it when renaming is finished or canceled or the URL changes. BUG: 319912 FIXED-IN: 4.10.5 REVIEW: 110908
2013-05-22Do not reset the 'isExpanded' state when an expanded folder is refreshedFrank Reininghaus
If an item is moved out of an expanded folder, the model receives the dir lister's refreshItems signal for the folder. The method retrieveData() then updates the folder's properties. This commit makes sure that the 'isExpanded' state is not touched by retrieveData(). A side-effect is that the 'isExpanded' role is not initialized to 'false', but this does not matter because trying to read a non-existing role from the QHash<QByteArray, QVariant> yields a default-constructed QVariant, which evaluates to 'false'. BUG: 299675 FIXED-IN: 4.10.4 REVIEW: 110401
2013-05-22KFileItemModelRolesUpdater: only update the size for changed foldersFrank Reininghaus
When using inotify, we also receive signals for modified files, even if we only ask KDirWatch to watch the directory containing them. In that case, we must not set the size to -1 (which means "unknown number of items" for folders) temporarily, or we end up with an apparent file size of 2^64 - 1 bytes. BUG: 309740 FIXED-IN: 4.10.4 REVIEW: 110428
2013-05-13DolphinSearchBox setReadOnly: Update if either of the parameters changeVishesh Handa
This way when another read only query is added, the internal state is changed and the search label gets updated. REVIEW: 110324 BUG: 315796 FIXED-IN: 4.10.4
2013-05-12Fix unit test failureFrank Reininghaus
The recent commit 022b564831e2295ee3bb6e53ece53191b40d894a, which added a few source files to kitemlistcontrollertest, caused a crash in that test - an assert was hit because now a different virtual method was called in one place (KStandardItemListView::initializeItemListWidget()), and qobject_cast could not cast the 'item', which is of type KFileItemListWidget, to its base class KStandardItemListWidget. Adding the source file kfileitemlistwidget.cpp fixes this. CCMAIL: [email protected]
2013-05-10fix building tests under windowsPatrick Spendrin
2013-05-10Don't try to change the icon of the "sort" action menu if it doesn't existDaniel Faust
BUG: 255819 FIXED-IN: 4.10.4 REVIEW: 109966
2013-05-07Dolphin Places: React to Nepomuk system changesVishesh Handa
Reload the places panel when Nepomuk starts up and shutsdown. This way the user does not need to restart Dolphin to see the custom searches and places after Nepomuk switches on. BUG: 304918 REVIEW: 110323
2013-05-02Do not change the view URL if it is a symlink to the current directoryFrank Reininghaus
BUG: 302037 FIXED-IN: 4.10.3 REVIEW: 110233
2013-05-02Use the same text color for selected hidden and non-hidden itemsFrank Reininghaus
This fixes the problem that the names of selected hidden items are unreadable with some color schemes. BUG: 305734 FIXED-IN: 4.10.3 REVIEW: 110164
2013-05-02Rename multiple files: Determine correctly if the name pattern is validFrank Reininghaus
The "Rename" button in the dialog should be enabled if and only if the "new name" pattern is valid. This is the case if the pattern contains exactly one sequence of '#', which will be replaced by digits. This patch fixes the problem that (a) A pattern that contains a single '#' is not considered valid, and (b) A pattern without any '#' at all is not recognized as invalid. BUG: 318942 FIXED-IN: 4.10.3 REVIEW: 110223
2013-04-23Disable Find/Replace in the "rename inline" line editFrank Reininghaus
These actions do not work correctly because renaming is considered finished as soon as the line edit loses focus, which happens when the "Replace" dialog pops up. BUG: 317772 FIXED-IN: 4.10.3
2013-04-23Do not dereference null pointer in KItemListViewAccessibleFrank Reininghaus
BUG: 316285 FIXED-IN: 4.10.3
2013-04-22Comment out assertion to fix a crash when filtering in Icons/Compat ViewFrank Reininghaus
I'm not sure yet if there is a problem somewhere else in the code. For the time being, I think it's better to replace the assert by a TODO comment to prevent that users find out the hard way that there is something that we're not quite sure about. BUG: 317827 FIXED-IN: 4.10.3
2013-04-22Always determine icons for the visible items firstFrank Reininghaus
When entering a folder, KFileItemModelRolesUpdater has not yet been informed about the visible index range by the view when it tries to determine icons synchronously. This resulted in the problem that it tried to determine icons for all items in random order, and some visible icons were somtimes still unknown after the "synchronous icon loading" timeout of 200 ms. This commit tries to improve the situation by loading icons starting with the first item in increasing order. This should make it less likely that some visible items still have unknown icons after 200 ms. BUG: 316129 FIXED-IN: 4.10.3 REVIEW: 109843
2013-04-19SVN_SILENT made messages (.desktop file)Script Kiddy
2013-04-12Fix moving image while transitioning to hover pixmapAurélien Gâteau
See: http://youtu.be/OMYO0U0kSL0 REVIEW: 109960 FIXED-IN: 4.10.3
2013-03-27Update icon if it couldn't be determined upfront (.desktop file on slow mount)David Faure
This requires an up-to-date kdelibs >= 4.10. CCBUG: 290666
2013-03-26Improve grouping by name for non-ASCII file namesFrank Reininghaus
This commit prevents that all non-ASCII letters which are not umlauts are grouped in a single group "Others", and that the joint group of an ASCII letter and the associated umlaut in some locales is called "Others" if there is only the umlaut in the group. BUG: 315569 REVIEW: 109457 FIXED-IN: 4.10.2
2013-03-21Fix transition between m_pixmap and m_hoverPixmapAurélien Gâteau
The default SourceOver composition mode of QPainter cannot be used to interpolate between two images, we must use intermediate buffers to perform the interpolation and blend the result on the widget. More details are available in the review request. REVIEW: 109614 FIXED-IN: 4.10.2
2013-03-17Refresh all expanded directories too, when reloading a directory.Emmanuel Pescosta
BUG: 295300 FIXED-IN: 4.10.2 REVIEW: 109488
2013-03-16use plain text for information panelWeng Xuetian
REVIEW: 109129 BUG: 315693 CCBUG: 262464
2013-03-15SVN_SILENT made messages (.desktop file)Script Kiddy
2013-03-15Prevent accidental deletion of home directory in Terminal PanelFrank Reininghaus
The protection against unwanted execution of "rm -rf" when changing the directory while entering the command did not work if there was never any automatic "cd" command sent to the terminal before. This patch ensures that Terminal Panel's member m_clearTerminal is false after the initialization of the panel, such that the protection is effective after that. BUG: 316300 FIXED-IN: 4.10.2 REVIEW: 109431
2013-03-14SVN_SILENT made messages (.desktop file)Script Kiddy
2013-03-11Do not skip rows in when clicking the empty area of the scroll barFrank Reininghaus
The height of the header widget must be subtracted from the view's height in Details View to determine the "pageStep" for the scroll bar. BUG: 315619 FIXED-IN: 4.10.2 REVIEW: 109210
2013-03-10Remove filtered children if the parent folder is collapsedFrank Reininghaus
This is analogous to commit e053ecdcd57cc39fdcbc314fc8dd22c8b9dbdd4f, which fixes the same problem for the case that the parent folder is deleted. BUG: 316335 FIXED-IN: 4.10.2 REVIEW: 109343
2013-02-22SVN_SILENT made messages (.desktop file)Script Kiddy
2013-02-18Fix crash when clicking an action in context menu for a removed deviceFrank Reininghaus
Devices can be added and removed while the context menu is open. Sfter an action has clicked that needs to access a device, we therefore have to check if its position in the model has changed, and more importantly, if it is still there at all in order to prevent a crash. BUG: 315298 FIXED-IN: 4.10.1 REVIEW: 108989
2013-02-18Remove items from m_filteredItems if their parent is deletedFrank Reininghaus
Fixes the problem that filtered children of expanded deleted folders reappear if the filter is cleared. BUG: 315210 FIXED-IN: 4.10.1 REVIEW: 108976
2013-02-17Another fix for KItemListControllerTest::testMouseClickActivation()Frank Reininghaus
One one machine, I see that changing the global "single click" setting fails. I don't know why that is the case, but I think we should better just skip the test in that case and not hang forever.
2013-02-17Prevent repeated re-layouting of all items while previews are generatedFrank Reininghaus
There was some code in KStandardItemListView::itemSizeHintUpdateRequired already that was supposed to prevent an expensive re-layouting of all items when a preview is received. However, it didn't quite work as intended because also the "iconOverlays" role changed. The new approach is to only re-layout if text of a visible role changes, because this is the only way how the space needed by an item might change (see KStandardItemListWidgetInformant::itemSizeHint()). BUG: 315315 FIXED-IN: 4.10.1 REVIEW: 108984
2013-02-13Improve the recently added test testMouseClickActivationFrank Reininghaus
The method to make sure that the first item is visible turned out to be less reliable than I thought. This could make the test hang forever. Moreover, this commit removes some trailing whitespace that had been added accidentally.
2013-02-11Fix blinking when moving the mouse over an hidden itemAurélien Gâteau
The opacity of the unhovered pixmap must be gradually reduced while animating otherwise the alpha channel saturates. REVIEW: 108858 BUG: 299371 FIXED-IN: 4.10.1
2013-02-05Add unit test for bug 313342Frank Reininghaus
2013-02-05Apply changes of the KGlobalSettings::singleClick() setting immediatelyAniket Anvit
Fixes a regression introduced by commit 7a364cbf489af25e123d18713523151a3a53f814. Patch reviewed and pushed by Frank Reininghaus. BUG: 313342 FIXED-IN: 4.10.1
2013-01-30Add unit test for bug 314046Frank Reininghaus
The regression happened in the master branch only, but I think it doesn't hurt to add the test to the stable branch. CCBUG: 314046
2013-01-29Update Dolphin version to 2.2 for KDE 4.10.0Frank Reininghaus
2013-01-27escape the existing text instead of set to plain textWeng Xuetian
@info indicates it's rich text and will be added <html> tag by kdelibs, so just escape the text that will be set to label for KDE/4.10 REVIEW: 108584 BUG: 313992
2013-01-27Add a unit test for a recently fixed crashFrank Reininghaus
Before commit 90c7fd400c34e6d4d583c54c04631856c387d359, adding a KFileItem with an empty path caused a crash in KFileItemModel::expandedParentsCountCompare().
2013-01-24KFileItemModelRolesUpdater: Avoid multiple updates for Nepomuk dataVishesh Handa
The Nepomuk ResourceWatcher emits 3 signals - propertyChanged, propertyAdded and propertyRemoved. We should only listen to either the propertyChanged signal or the propertyAdded + Removed signals. There is no point in listening to all 3 signals. That will just result in unnecessary updates. Additionally, we do not need to listen to the resourceCreated signal. That is only emitted when we are watching for a specific types, which we are not. REVIEW: 108543
2013-01-22Make the "A folder cannot be dropped into itself" message less intrusiveFrank Reininghaus
Showing this message in the KMessageWidget above the view, which means that the view contents are moved down, can be extremely annoying according to user feedback. Just showing the message in the status bar is probably enough. BUG: 313466 REVIEW: 108483 FIXED-IN: 4.10.0
2013-01-17SVN_SILENT made messages (.desktop file)Script Kiddy
2013-01-16Allow Timeline-URLs as homepageAndrea Scarpino
FEATURE: 313151 REVIEW: 108428
2013-01-16Use proper IconSize for PlacesItemEditDialog's KIconButtonKai Uwe Broulik
REVIEW: 108443
generated by cgit v1.3 (git 2.53.0) at 2026-04-30 05:06:18 +0000