┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2020-05-29Port away from deprecated QFontMetrics::width()Elvis Angelaccio
While the documention says to port to QFontMetrics::horizontalAdvance(), what we actually need is not the horizontal advance, but the width of the text. So we need to port to QFontMetrics::boundingRect().width(). Quoting from https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/: "Since it was not clear from the confusingly named function QFontMetrics::width() that it actually returned the horizontal advance, instead of the bounding width, this method is now obsolete. You must port to either QFontMetrics::horizontalAdvance() or QFontMetrics::boundingRect().width(). Please make sure you are aware of the difference, and do not port blindly. I am pretty sure that in most cases QFontMetrics::boundingRect() is what you want, unless you are writing custom text shaping/layouting code. Using the wrong function can cause clipped text or text that suddenly wraps to the next line despite calculating the width that it needs."
2020-05-28Non-functional change: consistent indentationAdriaan de Groot
Use 4-space indents consistently, rather than a mix of 2- and 4-.
2020-05-28Make ruby, and Gem:test-unit, optionalAdriaan de Groot
While this reduces test-coverage in cases where the user doesn't have Ruby or the testing gem installed, it at least allows us to get through configure and build without disabling **all** testing.
2020-05-28Port to non-deprecated variant of QPixmapCache::find()Elvis Angelaccio
We need to pass the pixmap by address, not by reference.
2020-05-28Add some missing const qualifiersElvis Angelaccio
2020-05-28Drop incorrect emit keyworkElvis Angelaccio
This is not a signal.
2020-05-28Fix clazy-range-loop warningElvis Angelaccio
2020-05-28Port away from deprecated qrand()Elvis Angelaccio
2020-05-25KDirectoryContentsCounter: scan first path not in cacheMéven Car
Use a secondary QLinkedList to store the priority path.
2020-05-24Merge branch 'release/20.04'Nate Graham
2020-05-24use KSycoca for updating OpenPreferredSearchTool actionPiotr Henryk Dabrowski
Summary: Remove all random updates of OpenPreferredSearchTool action, and use KSycoca for updating it as discussed in https://phabricator.kde.org/D22594#663847 Enhancement for D29441 for bug #420911 caused by D22594. The bug was fixed by D29442. CCBUG: 420911 Test Plan: ``` $ cd ${KDE_INSTALL_DIR}/usr/share/applications $ sudo mv org.kde.kfind.desktop org.kde.kfind.desktop_ $ kbuildsycoca5 $ sudo mv org.kde.kfind.desktop_ org.kde.kfind.desktop $ kbuildsycoca5 ``` Reviewers: broulik, elvisangelaccio, ngraham, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: anthonyfieroni, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29568
2020-05-20KDirectoryContentsCounter: don't schedule scanning a folder already in the QueueMéven Car
Use a QLinkedList to check for presence in the queue. merge request !2
2020-05-19DolphinView: rename new methods to copy/move urlsElvis Angelaccio
DolphinView doesn't know anything about split views and it shouldn't. Rename these new methods to what they actually do (just copy or move to a given QUrl).
2020-05-18Move search and filter bar close buttons to the rightNate Graham
Summary: Close buttons for windows, tabs, and pretty much everything else in KDE are on the right, not the left. This patch makes Dolphin's search and filter bars follow that. BUG: 421372 FIXED-IN: 20.08.0 Test Plan: {F8314176} Reviewers: abetts, #dolphin, #vdg, elvisangelaccio, GB_2 Reviewed By: #dolphin, #vdg, elvisangelaccio, GB_2 Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29693
2020-05-18Merge branch 'release/20.04'Méven Car
2020-05-18Left-elide file/folders while keeping their extension visibleMéven Car
Summary: Tweak behavior introduced in D19471. BUG: 404955 Test Plan: Before: {F8325282} After: {F8325283} {F8325284} Reviewers: ngraham, #dolphin, elvisangelaccio, #vdg Reviewed By: ngraham, #dolphin, elvisangelaccio, #vdg Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29794
2020-05-15Added VCS plugins signals connections for outOfVersionControl() actions.Nikolai Krasheninnikov
Summary: Plugins can now do out of version control actions (D29041), so we need them to inform of their state. This change connects every plugin signal to Dolphin on plugin instantiation. Test Plan: 1. Try SVN Update of inaccessible repository: see SVN error message shows up. 2. Try pull inaccessible git repository: see GIT error message shows up. 3. Try SVN Commit: see SVN message. Reviewers: #dolphin, meven, elvisangelaccio Reviewed By: #dolphin, meven Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29488
2020-05-14Allow to copy or move selection to the other split viewAntonio Prcela
Summary: FEATURE: 276167 Default keyboard shortcuts set to `SHIFT+F5` for `copy`, `SHIFT+F6` for `move` Reviewers: #dolphin, elvisangelaccio, ngraham, meven, dfaure Reviewed By: #dolphin, elvisangelaccio, ngraham, meven, dfaure Subscribers: yurchor, kde-doc-english, dfaure, meven, kfm-devel Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D29006
2020-05-13GIT_SILENT made messages (after extraction)l10n daemon script
2020-05-13GIT_SILENT made messages (after extraction)l10n daemon script
2020-05-11GIT_SILENT Update Appstream for new releaseChristoph Feck
2020-05-11DolphinView: rename cutSelectedItems to cutSelectedItemsToClipboardElvis Angelaccio
For consistency with d1a70c0b629b.
2020-05-11Dolphin: Cleanup service settings pageAlexander Lohnau
Summary: Just some little things :-) - Refactor foreach - Fix minor formatting issues - Use auto keyword where appropiate Test Plan: Compiles Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29560
2020-05-11DolphinView: rename copySelectedItems to copySelectedItemsToClipboardElvis Angelaccio
This makes it explicit that this is just a copy to clipboard, so that we can use the name for an actual KIO::copy().
2020-05-10GIT_SILENT made messages (after extraction)l10n daemon script
2020-05-10GIT_SILENT made messages (after extraction)l10n daemon script
2020-05-10is use -> is usedAlbert Astals Cid
CCMAIL: [email protected]
2020-05-08Prevent crash in WindowsMéven Car
Summary: https://phabricator.kde.org/D25335#664304 Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29470
2020-05-06Port QRegExp to QRegularExpressionAhmad Samir
Summary: Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern(). Port QRegExp::Wildcard with QRegularExpression::wildcardToRegularExpression(). Note that QRegularExpression::wildcardToRegularExpression() returns an anchored pattern. Test Plan: Using the filter bar in dolphin works as before. All unit tests pass, except: - kfileitemmodeltest (which is unrelated AFAICS); it fails on master too - placesitemmodeltest, which fails on master too Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26215
2020-05-06Merge branch 'release/20.04'Kai Uwe Broulik
2020-05-06Don't update preferred search action on window activationKai Uwe Broulik
I don't see why this is necessary and causes a blocking(!) StatJob every single time the window is focussed, worse, ends up in an infinite loop when the window loses focus on an auth prompt. CCBUG: 420911 Differential Revision: https://phabricator.kde.org/D29441
2020-05-06Keep name readable on drag to matching backgroundChristian Christiansen
Summary: Previously, when a single item was selected and dragged, the name would become unreadable when the text colour matched the background colour it was dragged onto. This is now fixed by not deselecting the item (and hence keeping the highlighting around the text) before creating the pixmap for dragging. BUG: 405266 Test Plan: Tested with Breeze and Breeze Dark. Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: #dolphin, elvisangelaccio, meven Subscribers: meven, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29378
2020-05-05Dolphin: Implement package kit for deb/rpm/pacman service packagesAlexander Lohnau
Summary: The deb/rpm/pacman packages are now installed/uninstalled using packagekit. Test Plan: Try to install deb package from kde store (search for `jetbrains`). Then uninstall it. Reviewers: #dolphin, ngraham, elvisangelaccio, meven Reviewed By: #dolphin, ngraham, elvisangelaccio, meven Subscribers: cblack, anthonyfieroni, asturmlechner, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29119
2020-05-05Merge branch 'release/20.04'Kai Uwe Broulik
2020-05-05Don't use local URL for KMoreToolKai Uwe Broulik
This method is called a billion times and spawns a blocking(!) StatJob. KFind can search local URLs, too, so I don't see why this is necessary. Either way, I'd rather have a non-KDE search tool broken than the app. Ideally, I'd like this entire thing redone to use an async StatJob, if any. Fwiw the KMoreTools in the free space bar doesn't use a local URL either. BUG: 420911 FIXED-IN: 20.04.1 Differential Revision: https://phabricator.kde.org/D29442
2020-05-05Sort by file size according to DetailsModeSettings::directorySizeCountMéven Car
Test Plan: Sort by file size in details view. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29424
2020-05-05Fix Windows BuildMéven Car
Summary: Due to D25335 Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29425
2020-05-04Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is ↵Nikolai Krasheninnikov
installed. Summary: Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel". This fix is pretty straight forward. Steps to reproduce: 1. Run Dolphin without Konsole available. 2. Press F4 to open console window. 3. Click in service menu "Focus Terminal Panel". 4. Click in service menu "Defocus Terminal Panel". Observe the crash. Test Plan: 1. Run Dolphin without Konsole available. 2. Press F4 to open console window. 3. Click in service menu "Focus Teminal Panel". 4. Click in service menu "Defocus Terminal Panel". 5. Click in service menu "Focus Terminal Panel". 6. Press F4 to close console window. Reviewers: #dolphin, meven, elvisangelaccio, ngraham Reviewed By: #dolphin, meven, elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29345
2020-05-04Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is ↵Nikolai Krasheninnikov
installed. Summary: Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel". This fix is pretty straight forward. Steps to reproduce: 1. Run Dolphin without Konsole available. 2. Press F4 to open console window. 3. Click in service menu "Focus Terminal Panel". 4. Click in service menu "Defocus Terminal Panel". Observe the crash. Test Plan: 1. Run Dolphin without Konsole available. 2. Press F4 to open console window. 3. Click in service menu "Focus Teminal Panel". 4. Click in service menu "Defocus Terminal Panel". 5. Click in service menu "Focus Terminal Panel". 6. Press F4 to close console window. Reviewers: #dolphin, meven, elvisangelaccio, ngraham Reviewed By: #dolphin, meven, elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29345
2020-05-04Dolphin: Cleanup kcmsAlexander Lohnau
Summary: Refactor forearch, adjust formatting, remove unnecessary version checks. Test Plan: Compiles Reviewers: #dolphin, ngraham, elvisangelaccio, meven Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29377
2020-05-04Replace the list with the simplified list, instead of concatenate.Antonio Prcela
Summary: Replace the list m_selectedUrls with a simplified list, instead of concatenating the simplified list to the current one. Reviewers: dfaure, meven Reviewed By: dfaure Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29399
2020-05-04[Details mode] Allow to fill the column size of directories with actual sizeMéven Car
Summary: Allow to compute the recursive size of directories to fill the details view size column. A setting allow to set a limit to the recursive level, allowing the user to have some power over the setting. When sorting by size and the feature is on, we get progressive ordering as the directory size are gathered. KDirectoryContentsCounter uses a cache internally to keep results so that it can display directory size faster, but counts the dir size of directories each time it is asked to count the size a directory nevertheless and when the size has changed, it is updated. KDirectoryContentsCounter uses one worker per instance only, meaning one process per view makes the disk spin. FIXED-IN: 20.08 BUG: 190580 BUG: 158090 Test Plan: With some recursion allowed: {F8267580} Without any recursion allowed (default): {F8267581} Reviewers: elvisangelaccio, ngraham, #dolphin Reviewed By: elvisangelaccio, ngraham, #dolphin Subscribers: feverfew, anthonyfieroni, iasensio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25335
2020-05-03Dolphin Service Menu Installer: Launch certain scripts in KonsoleAlexander Lohnau
Summary: In general the issue with installers/uninstallers for the dolphin plugin is that a lot of the scripts are intended to be run manually in a terminal. For instance if a script uses `sudo make install` the user can't type in the password. With this patch scripts that are executed without arg variants are executed in konsole (if available). Test Plan: Tests still pass. Try to install the "Jetbrains Dolphin Plugin" tar.gz file from the kde store. If you have the required dependencies etc. the konsole window should close. If the install script fails (type in wrong admin password a couple of times) you should have a shell opened. Reviewers: #dolphin, ngraham, nicolasfella, elvisangelaccio, meven Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29089
2020-05-03ServicesSettingsPage: add missing connection receiverElvis Angelaccio
2020-05-03Dolphin Services: Add search boxAlexander Lohnau
Summary: You can now filter the list of installed services. This is especially useful if you install additional service menus from the kde store, because one instalaton can add a lot of services. For instance the ReImage plugin. Test Plan: Compiles, search for a service menu. Only services matching the query will show up. Reviewers: ngraham, elvisangelaccio, meven Reviewed By: meven Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29375
2020-05-03filenamesearch:/ define a title for the queryMéven Car
Summary: CCBUG: 420354 Reviewers: ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio Reviewed By: elvisangelaccio, #dolphin, iasensio Subscribers: iasensio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29198
2020-05-01Information Panel: show early icons for foldersMéven Car
Summary: Folders previews can be long to generate. This can be noticeable by the user. This diff displays folder icons after a 100ms timer. BUG: 420340 FIXED-IN: 20.08 Test Plan: rm -r ~/.cache/thumbnails/ In dolphin open trash Click on download (or any directory with a long to generate preview). Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29204
2020-04-30For VCS-plugin interface added pure virtual function ↵Nikolai Krasheninnikov
outOfVersionControlActions() Summary: This commit changes VCS-plugin interface in order to provide actions for unversioned items (for example clone or checkout repository), updates to dolphin-plugins comes in the separate commit D29042. Reviewers: #dolphin, meven, elvisangelaccio Reviewed By: #dolphin, meven, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29041
2020-04-27prevent a QFileInfo warningRené Bertin
DolphinSearchBox::init() can generate a terminal warning depending on the user's search history: QFileInfo::absolutePath: Constructed with empty filename The warning can seem to appear randomly if you don't use the search feature often, because of its dependency on previous search activity. Prevent this warning by adding a simple check if the current m_searchPath is valid or not. This check has no effect on the value returned by DolphinSearchBox::isIndexingEnabled() and is in line with the fact that m_searchPath == QUrl() indicates that no search path has been set. Differential Revision: https://phabricator.kde.org/D29194
2020-04-26Add an option to show tabs from last time when Dolphin startsNate Graham
Summary: All modern web browsers offer a function to show tabs from last time when a browser starts, and many apps today restore their prior state when they're launched. This patch implements thatfunctionality as an option and turns it on by default. The settings window is accordingly adjusted to be clear about what applies when: {F7681752} FEATURE: 413564 FIXED-IN: 20.08.0 Depends on D25106 Depends on D25219 Test Plan: With the new setting turned off: - No behavioral changes at all With the new setting turned on: - When launched from the GUI or CLI without any URLs, dolphin restores session - When rebooting with Dolphin open, it restores session normally after the system comes back (i.e. no behavioral change here) - When launched with URLs, Dolphin window is opened showing those URLs instead of restoring session - When Dolphin is already running and a new window is opened, that new window shows a single tab with the same URL as was visible in the previously-open Dolphin instance (i.e. no behavioral change here) - "Open Containing folder" functionality in other apps works regardless of whether or not Dolphin is running Reviewers: #dolphin, #vdg, feverfew, meven, elvisangelaccio, ndavis Reviewed By: #dolphin, #vdg, feverfew, elvisangelaccio, ndavis Subscribers: davidedmundson, ndavis, intika, feverfew, kfm-devel, ngraham, broulik, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D11382
generated by cgit v1.3 (git 2.53.0) at 2026-04-23 12:03:26 +0000