┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2020-01-06Use newly-upstreamed rename dialog from KIONate Graham
Summary: With the rename dialog upstreamed in D17595, we can use it from there. This will require the KF5 dep to be bumped to 5.67, which should be feasible given that we're at the very beginning of a new Applications cycle. Depends on D17595 Test Plan: 1. Dolphin Settings > uncheck "rename inline" 2. Rename one or more files. Observe that it still works Tests still pass. Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: elvisangelaccio, meven Subscribers: meven, broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17597
2020-01-06(search) Keep menu open when selecting tagsIsmael Asensio
Summary: Keeps the `Tags` menu open while selecting and deselecting tags in the search panel, saving many mouse clicks for multiple tags. It cannot be done natively on `QMenu` (https://bugreports.qt.io/browse/QTBUG-6635) but it is a one-liner and I haven't seen any bad behavior so far. Test Plan: {F7853717} - `Tags` menu does not close when selecting/deselecting tags - Tag search is consistent - Clicking anywhere else will close the menu Reviewers: #dolphin, elvisangelaccio, ngraham, #vdg Reviewed By: #dolphin, elvisangelaccio, #vdg Subscribers: #vdg, broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26343
2020-01-06Don't use nullptr for flag. Just use default argument hereLaurent Montel
2019-12-29Clean-up DolphinFacetsWidgetIsmael Asensio
Summary: Small refactor patch to clean-up some logic on setter and getter: - Search terms are previously splitted and set separately, so no need for extra splitting and `foreach` loop - Return search terms on a `QStringList` rather than join first Depends on: D26029 Test Plan: No behavior changes Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26150
2019-12-26Rename methods on DolphinFacetsWidgetIsmael Asensio
Summary: Small refactor patch to rename method names, from `ratingTerm` to `searchTerm`, since its scope has grown bigger. Test Plan: No behavior changes Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26029
2019-12-26Port from deprecated KIconLoader::IconSize()Ismael Asensio
Summary: `IconSize()` method is deprecated from Frameworks 5.66 Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T11637 Differential Revision: https://phabricator.kde.org/D26237
2019-12-26Don't use nullptr/0 as flags (deprecated in qt5.15)Laurent Montel
2019-12-24Rename variables to improve readability of Dolphin::attachToExistingInstanceElvis Angelaccio
Services and interfaces are not the same thing. Also clarify the name of dbus replies.
2019-12-23[DolphinContextMenu] Use contains check for scheme againKai Uwe Broulik
Regression introduced in 8b0c12a59ccb23fdb6393f640693d21afaeb02a1 There's "filenamesearch" and "baloosearch". Differential Revision: https://phabricator.kde.org/D26169
2019-12-21Use KParts::ReadOnlyPart::localFilePath() in DolphinPart::slotOpenTerminal()Piotr Henryk Dabrowski
Reviewers: ngraham, elvisangelaccio, #dolphin Reviewed By: ngraham, elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26140
2019-12-21Merge branch 'release/19.12'Nate Graham
2019-12-21Improve scroll wheel speed by basing it on label height, not icon heightNate Graham
Summary: Dolphin currently scrolls by the height of three items at a time per "step" when using a scroll wheel. Because item height is highly variable, this leads to scroll speed being inconsistent between views, and generally far too fast when using icon view with icons larger than 22px size. This patch makes the size of the scroll step based on the text label rather than the icon size just like D25683, ensuring that the scroll speed does not vary and become super fast when using large icons in particular. It also reverts 90beb4a5e37b887caad1e767046a42dad0af1ab3, which is no longer needed. BUG: 386379 FIXED-IN: 19.12.1 Test Plan: Use a mouse with a scroll wheel and scroll in Dolphin item views with list view, details view, icon view, etc, using different item sizes. Speed should be consistent in all views now, and also feel consistent with other KDE apps. Also try with multiple scale factors to make sure the behavior does not change. No change with high-resolution two-finger touchpad scrolling. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ahiemstra, lots0logs, anthonyfieroni, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19190
2019-12-21fix(search): Correctly parse filename and/or content searchIsmael Asensio
Summary: Currently, the search url parsing does not detect if the search is based on Content or Filename, and it just keeps the last selection which can be inconsistent with the actual search. This patch add such detection, and since an advanced user can combine filename and content search (using the keyword `filename:`), now the parsing detects both items and handles the four possible cases: | Content | Filename | Search text | Search type | |---|---|------------------------|------------------| | T | T | abc filename:"xyz" | Content | | T | F | abc | Content | | F | T | xyz | Filename | | F | F | | do not set | Depends on: D25260 Test Plan: `bin/dolphinquerytest`: Added new test cases for searches with content text and/or filename Reviewers: elvisangelaccio, bruns, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25416
2019-12-20GIT_SILENT made messages (after extraction)l10n daemon script
2019-12-19GIT_SILENT: Port deprecated QSet::toList methodLaurent Montel
2019-12-16SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-12-15[dolphin/search] Search by (multiple) tagsIsmael Asensio
Summary: Adds a tag selector in the extended filters of the search box. Selected tag or tags are added to the search query along with the other filters (type, date, rating). FEATURE: 412564 CCBUG: 356062 Test Plan: - Menu shows the user tags - Picking any tag/s filters the search to that specific tag/s {F7727909} Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg Reviewed By: elvisangelaccio, ngraham, #dolphin, #vdg Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T9094 Differential Revision: https://phabricator.kde.org/D25130
2019-12-15Don't overload the word "Properties" to mean multiple thingsNate Graham
Summary: Generally "Properties" refers to information about a selected file. However Dolphin also uses the word "Properties" in the phrase "View Properties", which refers to the display style of the view. Since "properties" is a fairly esoteric and technical term to most users, it would probably be wise to avoid using it in multiple contexts. Accordingly, this patch changes "view properties" to "view display style". Test Plan: Look at the settings window, hamburger menu, view menu, and docbook Reviewers: #vdg, #dolphin, ndavis, elvisangelaccio Reviewed By: #vdg, #dolphin, ndavis, elvisangelaccio Subscribers: ndavis, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D25987
2019-12-09Merge branch 'release/19.12'Antonio Rojas
2019-12-09Merge branch 'release/19.12' of git://anongit.kde.org/dolphin into release/19.12Antonio Rojas
2019-12-09Fix build with Qt 5.14 RCAntonio Rojas
Add needed Qt includes that are no longer pulled transitively. BUG: 414492 Differential Revision: https://phabricator.kde.org/D25783
2019-12-06Merge branch 'release/19.12'Nate Graham
2019-12-06Correct invalid homepage URLNate Graham
BUG: 414901 FIXED-IN: 19.12.1
2019-12-06Make it compile against last kf5 version without deprecated methodsLaurent Montel
2019-12-05Add action for focusing Terminal PanelNate Graham
Summary: Add an action for focusing and de-focusing the Terminal Panel. FEATURE: 185096 FIXED-IN 20.04.0 Test Plan: - Hit {key Ctrl Shift F4} or click {nav Tools > Focus Terminal Panel} or {nav Control > Tools > Focus Terminal Panel} - If the Terminal Panel was closed, it opens and gains focus - If the Terminal Panel was open but unfocused, it gains focus - If the Terminal Panel was open and focused, focus returns to the view {F6630289, size=full} Reviewers: #dolphin, elvisangelaccio, rominf Reviewed By: #dolphin, elvisangelaccio, rominf Subscribers: kfm-devel, elvisangelaccio, rkflx, ngraham, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D10959
2019-12-05Update Appstream for new releaseChristoph Feck
2019-12-02Refactoring to reduce size of openItemContextMenu and add the ContextType ↵Méven Car
TimelineOrSearchContext Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25615
2019-12-02GIT_SILENT remove unused includeDavid Faure
2019-11-28Merge branch 'release/19.12'Elvis Angelaccio
2019-11-28fix(search): Fix baloo searchString parsingIsmael Asensio
Summary: Fix the parsing of Baloo query `searchString` to represent its parameters properly in the search box: # Baloo terms (`rating`, `modified`) are added to the user search text: {F7575590} # Extra quotes are added to the search text: https://bugs.kde.org/show_bug.cgi?id=412952 This revision supersedes D24422, by making the fixes on the new dolphin query model, instead of directly on the UI. BUG: 412952 FIXED IN: 19.11.90 Test Plan: - `bin/dolphinquerytest` passes without `XFAIL`s - Dolphin search box is not garbled by search terms or quotes Reviewers: elvisangelaccio, bruns, ngraham, #dolphin Reviewed By: elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25260
2019-11-28Force dbus introspection on the Dolphin_1 objectElvis Angelaccio
Summary: QtDBus caches known interfaces when passing a non-empty interface name to the QDbusInterface constructor. This is an issue when calling the FileManager1 methods more than once, because `preferred` could be a valid interface from the cache, but it would later fail to call the `openFiles`/`openDirectories` methods on the main window. By passing an empty interface name, we prevent QtDBus from using the cache so that we always get an invalid interface when calling the FileManager1 methods on a daemonized dolphin process (that doesn't have the Dolphin_1 dbus object). BUG: 414402 FIXED-IN: 19.12.0 Test Plan: 1. dolphin --daemon 2. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" "" 3. Close the dolphin window that was just opened. 4. Start a normal dolphin process 5. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" "" 6. Close again the dolphin window 7. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" "" Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25510
2019-11-25Remove dead codeNicolas Fella
Summary: The code appears to do nothing. Test Plan: builds, bookmarkmenu still works Reviewers: #dolphin, meven, elvisangelaccio Reviewed By: #dolphin, meven, elvisangelaccio Subscribers: meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25347
2019-11-24Fix accessibility regression on the Dolphin Control buttonElvis Angelaccio
9cd042a86c removed the text from the Control button without setting an accessibleName property, which is a regression for screen-reader users. This breaks the 19.12 string freeze, but since it's the same string we were translating before 9cd042a86c, hopefully it's not going to be too much of a burden for translators. CCBUG: 414271 CCMAIL: [email protected]
2019-11-23Merge remote-tracking branch 'origin/release/19.12'David Faure
2019-11-23GIT_SILENT remove unused includeDavid Faure
2019-11-19Change default completion mode to CompletionPopupAutoNoah Davis
Summary: This makes Dolphin use the "Dropdown List & Automatic" completion mode by default when editing the URL bar. Given the context of someone typing file paths, I can't see why one wouldn't want to use this feature, unless they don't like how it looks. Reviewers: #vdg, #dolphin, ngraham, elvisangelaccio Reviewed By: #vdg, #dolphin, ngraham, elvisangelaccio Subscribers: ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25391
2019-11-19Port deprecated methodsLaurent Montel
2019-11-17Merge branch 'release/19.12'Elvis Angelaccio
2019-11-17Fix dolphin homepage in the appstream metadataElvis Angelaccio
2019-11-17[Dolphin] Open Preferred Search Tool actionPiotr Henryk Dabrowski
Summary: Added "Open Preferred Search Tool" action to Tools menu. It runs preferred (topmost) external search tool as configured in the "More Search Tools" menu. By default Ctrl+Shift+F shortcut is assigned to this action. FEATURE: 384798 FIXED-IN: 20.03.80 {F7134238} {F7134240} {F7134242} Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham Subscribers: pkloc, kfm-devel, kde-doc-english Tags: #dolphin, #documentation Differential Revision: https://phabricator.kde.org/D22594
2019-11-16Use URLs with transport encryptionYuri Chornoivan
2019-11-14test(search): Add test case for baloo parsing modelIsmael Asensio
Summary: Adds a new test unit for the model which parses baloo search URLs 14/19 tests are set to `XFAIL` on current implementation, as they will be fixed in a final revision. Supersedes D25135. Depends on: D25257 Test Plan: `bin/dolphinquerytest` Reviewers: elvisangelaccio, bruns, #dolphin Reviewed By: elvisangelaccio, bruns, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25258
2019-11-13fix(search): Allow to set empty typeIsmael Asensio
Summary: This small patch allows to set and empty `type` to the extended options, which will set the `Any Type` option (index 0). It doesn't make any change in current code, since this case is not called, but it helps simplifying follow-up patches. Test Plan: No behavior changes with current code. Calling `setFacetsType(QString())` actually sets the first option (`Any Type`) Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25255
2019-11-13DolphinQuery: drop DOLPHIN_EXPORTElvis Angelaccio
DOLPHIN_EXPORT is only used by classes in the `dolphinprivate` target, while DolphinQuery is part of `dolphinstatic`. This should fix the failing Windows build on the CI.
2019-11-13refactor(search): De-couple baloo URL parsing logic from UIIsmael Asensio
Summary: Extracts the logic that parses `baloosearch:` urls into a new model class. The parser logic itself is kept as is. The search box UI is later updated using the model fields. This refactor has been proposed by @bruns in the review of D24422, as it largely simplifies the unit tests and further expansion/improvements. Test Plan: No behavior changes. Test case is added in the follow-up revision: D25258 Reviewers: #dolphin, elvisangelaccio, bruns Reviewed By: #dolphin, elvisangelaccio, bruns Subscribers: ngraham, bruns, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25257
2019-11-12make link with LLVMRené Bertin
This patch fixes a link failure when building with the LLVM toolchain which does not discover the dependency on or pull in the private dolphin library when linking dolphin itself. BUG: 410237 Differential Revision: https://phabricator.kde.org/D22802
2019-11-12Allow dolphin to format DateTime at later stage than KBalooRolesProviderMéven Car
Summary: KFileItemListWidgetInformant::roleText expected imageDateTime value to be a QDateTime but KBalooRolesProvider formatted it to QString previously, preventing KFileItemListWidgetInformant::roleText to format properly the imageDateTime BUG: 411173 Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25242
2019-11-12[Information Panel] Allows to refresh icon and metadata for urls such as trash:/Méven Car
Summary: CCBUG: 392882 Test Plan: 1. Create a file 2. Remove it, so that it goes to the trash 3. Open trash 4. Empty trash Before: Information panel icon is still user-trash-full After: Information panel icon is changed to user-trash Reviewers: ngraham, #dolphin, elvisangelaccio Reviewed By: ngraham, #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23668
2019-11-11SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-11SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
generated by cgit v1.3 (git 2.53.0) at 2026-04-28 18:29:01 +0000