┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2019-02-17Word-wrap KMessageWidget textNate Graham
Summary: Word-wrap KMessageWidget text to prevent the window from being widened when the text is very long. CCBUG: 404232 Only `CCBUG: ` because word wrap only works where QLabel detects a word boundary; it will not wrap a string with no spaces or other word boundaries (e.g. "aaaaaaaaaaaaaaaaaaaa...") Test Plan: - Create a new text file with a 300-character name that has spaces in it - In the KMessageWidget's error message, the file name is wrapped at the word boundaries Reviewers: #dolphin, #frameworks, cfeck, elvisangelaccio Reviewed By: #dolphin, cfeck, elvisangelaccio Subscribers: elvisangelaccio, cfeck, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D18968
2019-02-13GIT_SILENT made messages (after extraction)l10n daemon script
2019-02-08[DolphinView] Use correct color groupKai Uwe Broulik
Use the inactive color group when the window is inactive and update when window state changes. CCBUG: 404053 Differential Revision: https://phabricator.kde.org/D18811
2019-02-06Sort preview plugins case-insensitivelyKai Uwe Broulik
"eBook thumbnails" would show up all the way at the bottom otherwise Test Plan: 18.12 branch It now shows where it should Differential Revision: https://phabricator.kde.org/D18787
2019-02-02Fix member initializationAnthony Fieroni
Signed-off-by: Anthony Fieroni <[email protected]>
2019-02-02[versioncontrolobserver] Update working directory on tab activationAnthony Fieroni
Differential Revision: https://phabricator.kde.org/D18605 Signed-off-by: Anthony Fieroni <[email protected]>
2019-01-30GIT_SILENT made messages (after extraction)l10n daemon script
2019-01-29[versioncontrolobserver] Do not use static plugin objectsAnthony Fieroni
Differential Revision: https://phabricator.kde.org/D17640 Signed-off-by: Anthony Fieroni <[email protected]>
2019-01-28SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-01-07fix display of image orientationAlexander Stippich
Summary: The name of the orientation property for baloo/kfilemetadata was false, leading to an always empty image orientation field. Test Plan: Look at an image in Dolphin details view which has the exiv orientation tag set. Orientation column is not empty. Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D18008
2019-01-06SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-01-05Fix title update when changing active split viewElvis Angelaccio
Summary: The DolphinTabPage::activeViewUrlChanged signal triggers the title update in DolphinMainWindow, which sets the new title from the `m_activeViewContainer` instance. This means we need to notify the main window that the active view changed before telling it that the current url changed. BUG: 402641 FIXED-IN: 18.12.1 Reviewers: #dolphin, rizzitello, ngraham Reviewed By: #dolphin, rizzitello, ngraham Subscribers: rizzitello, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17881
2019-01-04Use https over http for homepage urlFriedrich W. H. Kossebau
2018-12-31Add failing test case for bug #402641Elvis Angelaccio
CCBUG: 402641
2018-12-23GIT_SILENT made messages (after extraction)l10n daemon script
2018-12-18Use correct icon for the "New Window" menu itemNate Graham
2018-12-12GIT_SILENT made messages (after extraction)l10n daemon script
2018-12-03KItemListWidget: Use initStyleOptionAnton Kreuzkamp
Instead of using QStyleOption::initFrom, let's use QGraphicsWidget::initStyleOption, which is made for exactly the purpose of KItemListWidget. This is especially important since, according to the docs of QGraphicsItem::paint "The widget argument is optional. [...] For cached painting, widget is always 0.". Even though currently no code in dolphin does cached painting, for the sake of modularity one should not rely on widget to be non-null. Using QStyleOption::initFrom does assume that, though. In fact, GammaRay asks the items to do cached painting when attaching it to the application, causing it to crash.
2018-12-01Fix selection when navigating back, with size sorting.Thomas Surrel
Summary: KItemListSelectionManager::itemsMoved (called when sorting by size) was re-activating anchor selection regardless if we actually were doing an anchored selection. This was leading to an incorrect selection when navigating back. BUG: 352296 Test Plan: In any folder, sort by size then move to a subfolder. Navigate back to the parent folder: only the parent folder should be selected. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17042
2018-11-29GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-21GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-20GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-17Do not disconnect all StorageAccess signals when unmountingThomas Surrel
Summary: The problem is caused by the fact device interfaces returned by Solid (e.g. item->device().as<Solid::StorageAccess>()) are not full objects, but only references/pointers to a per-device-object, i.e. requesting the same interface for a device will return the same address every time. If the interface is used used in multiple places, calling disconnect on the interface address disconnects the signals for all users. BUG: 400992 Test Plan: In Dolphin, mount a local partition (e.g. a Windows partition) then unmount it (right click on it in Places, then Unmount). Try to access it again by clicking on it in Places, we should get access to it correctly. Reviewers: #dolphin, #frameworks, bruns, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16857
2018-11-17Improve Ux for the places panel's hidden itemsChris Rizzitello
Summary: BUG: 400860 FIXED-IN: 18.12.0 Clean up the context menu for the places panel. - Change Text "Show All Entries" -> "Show Hidden Places" - Use State dependent icon (like hidden files) - Disable instead of hide if not places are hidden. - Toggle to unchecked if last item of group is unhidden. Create a copy of this "Show Hidden Places" entry in the main dolphin menu View->Places. Test Plan: With Hidden Places {F6398756} {F6398759} Context Menu: {F6398762} {F6398761} Without Hidden Places. {F6414694} {F6414696} Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham Reviewed By: #dolphin, #vdg, elvisangelaccio, ngraham Subscribers: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel Tags: #dolphin Maniphest Tasks: T8349 Differential Revision: https://phabricator.kde.org/D16767
2018-11-17move kcrash link to dolphin app (which is the effective user)Harald Sitter
Summary: to successfully use kcrash when linking with as-needed (which is a default flag on many linux distros) one also needs to call KCrash::initialize. this call happens in the app's main.cpp. as such the kcrash link target on the dolphinprivate library doesn't do anything for dolphinprivate but only kicks into action for dolphin itself. to avoid confusion and make it clear that kcrash is only initialized in the application scope the KF5::Crash link target is now on the application target, not the library target. (this makes no difference in the output, kcrash was still correctly linked via dolphinprivate; but only for kdeinit_dolphin, dolphinprivate did not get linked to it with as-needed) Test Plan: builds; links as expected Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16896
2018-11-16GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-11Update copyright year in KAboutDataElvis Angelaccio
GIT_SILENT
2018-11-08Warn user before renaming the file/folder to start with a ' . 'Shubham Jangra
Summary: For normal "casual" linux users, renaming the file/folder starting with dot may get irritating, they will be wondering their file is deleted. Test Plan: 1. Make new file/folder. 2. Rename it to .foo 3. Question dialog appears. Reviewers: elvisangelaccio, ngraham, pino Reviewed By: elvisangelaccio, ngraham Subscribers: cfeck, emateli, elvisangelaccio, pino, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15980
2018-11-08Add donation url to appdataAlbert Astals Cid
2018-11-05GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-04Update maintainership in KAboutDataElvis Angelaccio
As discussed on kfm-devel and agreed upon with Emmanuel.
2018-11-04GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-02Autogenerate debug file + install debug categories fileLaurent Montel
2018-11-01GIT_SILENT made messages (after extraction)l10n daemon script
2018-10-28GIT_SILENT made messages (after extraction)l10n daemon script
2018-10-27Merge branch 'Applications/18.08'Elvis Angelaccio
2018-10-27Don't enable two-clicks renaming in single-click modeElvis Angelaccio
Summary: This was supposed to be part of commit 5454283008f2, but apparently we didn't notice it was missing. Test Plan: - Enable single-click mode from system settings - Select a file in dolphin - Long-click the selected file and make sure inline renaming doesn't start Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16460
2018-10-27Adjust label in the settings page for changed preview behaviourFabian Vogt
Summary: Requested by https://phabricator.kde.org/D15138#318904 Test Plan: Opened the preview settings, label text changed. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ngraham, markg, broulik, kfm-devel, elvisangelaccio Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15216
2018-10-27Close Dolphin if last tab closedAlexander Saoutkin
Summary: Allows closing of last tab via shortcut or menubar (File->Close Tab), which then results in closing dolphin. FEATURE: 397101 Test Plan: [Manual] Check closing tab closes dolphin via shortcut and menubar. Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio Reviewed By: #dolphin, ngraham, #vdg, elvisangelaccio Subscribers: thsurrel, svenmauch, abetts, elvisangelaccio, ngraham, #dolphin, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15278
2018-10-27GIT_SILENT made messages (after extraction)l10n daemon script
2018-10-25Add caption to the screenshotYuri Chornoivan
2018-10-25Fix minor typosYuri Chornoivan
2018-10-24[DolphinViewActionHandler] Rename createDirectory signalElvis Angelaccio
Signals should be named after an event that happened.
2018-10-24Merge branch 'Applications/18.08'Kai Uwe Broulik
2018-10-24[KStandardItemListWidget] Pass icon state to overlay painterKai Uwe Broulik
Ensures the overlay is painted in the same icon state, especially the selected one so dark overlays turn white. Differential Revision: https://phabricator.kde.org/D16307
2018-10-18Use QLatin1Char instead of QLatin1StringShubham Jangra
2018-10-18GIT_SILENT made messages (after extraction)l10n daemon script
2018-10-14Add a 'Properties' entry in the Places panel context menuThomas Surrel
Summary: BUG: 181880 Test Plan: Right-click on a place or on a device in the Places panel now show a Properties entry. Clicking on it will open its folder property. Reviewers: #dolphin, #plasma, #vdg, ngraham, elvisangelaccio Reviewed By: #dolphin, #vdg, ngraham, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, cfeck, ngraham, abetts, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15929
2018-10-13Revert "[PlacesItemModelTest] Make test fail on purpose"Elvis Angelaccio
This reverts commit dd8fce5594e9f55ce4c159d46ec59b08313982bb. Got what I was looking for, from the CI logs.
2018-10-13[PlacesItemModelTest] Make test fail on purposeElvis Angelaccio
Needed to check whether on the CI KDirWatch emits the `created` signal when we refresh the places model. Will be reverted soon. GIT_SILENT