| Age | Commit message (Collapse) | Author |
|
The use case of this function (Folders Panel) requires the expansion of
the parent items of a single URL, so it's not needed to handle a full
set of URLs in this function. Moreover, the issue that not only the
parents, but also the URLs themselves were expanded is fixed by this
commit.
(cherry picked from commit 89082ca391807abdc26d8985efe6b4c27183a9b1)
|
|
- Assure that landscape-previews use the whole available width of the icon-area
instead of only using the square width. This waste of space occured if the
text-width was larger than the icon-width.
- Only use one margin instead of two between the icons and the text to improve the
visual appearance (thanks to Martin Zilz for the hint)
BUG: 293268
FIXED-IN: 4.8.1
CCMAIL: [email protected]
|
|
Function-static variables do not help much in a function which is
called exactly once.
(cherry picked from commit 847c8ebfd3259a6f090db7451dd3350c6e01e0d2)
|
|
During determining the item-count for directories just show an empty string
until either the item-count has been calculated or if the item-count is unknown.
Thanks to Nikita Skovoroda for the initial proof-of-concept patch.
BUG: 291823
FIXED-IN: 4.8.1
|
|
BUG: 292687
FIXED-IN: 4.8.1
|
|
This is consistent with the naming scheme in KFileItemModel and KDirLister.
|
|
Thanks to Frank Reininghaus for the hint.
|
|
|
|
When counting the number of sub-directories consider unknown file types
as potential directories. In the "worst case" an expansion toggle will be
shown although the directory contains only files, however from a performance
point of view this seems to be an acceptable compromise.
BUG: 292642
FIXED-IN: 4.8.1
|
|
Root cause of the issue was an overflow in:
result = a - b;
where result is 'int' and a and b are 'KIO::filesize_t'.
BUG: 293086
FIXED-IN: 4.8.1
|
|
Thanks a lot to Mathias Tillman for finding a 100 % reliable way
how to reproduce the issue and for the initial patch!
BUG: 278302
FIXED-IN: 4.8.1
|
|
If doLayout() is invoked with the 'NoAnimation' hint, it must be assured
that any ongoing animations are stopped.
|
|
At the moment, only key press events are tested, and the current item
and selection after the event are verified.
Moreover, this commit makes sure that
KItemListController::keyPressEvent() really does not select anything
if the selection mode is NoSelection.
(cherry picked from commit 7457f4868cf0bc83e8a90ce5693292378f3d07c4)
|
|
The asynchronous resolving to bypass performance bottlenecks is not necessary
anymore as multiple ranges can be inserted in one step now. This solves the issue
that e.g. opening a tree resulted in temporary unknown icons for a short period
of time.
|
|
Having animated items is useful when e.g. deleting or inserting one
item or when the size or position slightly changes by increasing the
zoom level or the window size. However if the number of rows or columns
change, the animation gets obtrusive and in this case lets just apply
the final layout.
|
|
The problem was that m_keyboardAnchorIndex and m_keyboardAnchorPos were
not updated when Home or End are pressed. This causes the following
unexpected behavior in Icons View: Press Home, then Right, then Down,
then Home, finally Down. One would expect that the first item in the
second row is the current item then, but before this commit, it was the
second one because the controller still remembered that the second
column was active before Home was pressed.
(cherry picked from commit 999234a94ae41cfb4f2167d2779b562ebf8127ce)
|
|
Prevent that the moving-animation crosses other items when zooming or
changing the window size.
|
|
For some roles the sorting has not been implemented.
BUG: 292941
FIXED-IN: 4.8.1
|
|
This fixes the issue that changing the zoom-level in the settings
does not update the zoom-slider in the statusbar.
|
|
BUG: 291043
FIXED-IN: 4.8.1
|
|
|
|
|
|
BUG: 292698
FIXED-IN: 4.8.1
|
|
- Assure a proper minimim width in the compact mode.
- Don't calculate the old position of hidden items to animate the
moving. Just show them directly.
|
|
BUG: 292821
BUG: 292355
FIXED-IN: 4.8.1
|
|
CCBUG: 292816
FIXED-IN: 4.8.1
(cherry picked from commit f5ecaee9c40c940fe8e1bf4a7d50fe0b18e1932b)
|
|
Only animate the moving of items if the new position is within the same
row or the same column. Otherwise just fade in the icon on the new position.
This makes the the animations when resizing the window or changing the zoom-level
a lot more pleasant.
CCBUG: 289238
|
|
|
|
BUG: 292270
FIXED-IN: 4.8.1
|
|
BUG: 292501
FIXED-IN: 4.8.1
|
|
|
|
|
|
BUG: 292505
FIXED-IN: 4.8.1
|
|
BUG: 292470
FIXED-IN: 4.8.1
|
|
The problem was that KFileItemModel::setExpanded() used KUrl::url()
to determine the names of the subfolders. This method encodes special
characters, such that comparing the folder names with the unencoded URLs
stored in the model fails.
Using KUrl::path(), which does not encode special characters, fixes the
problem.
CCBUG: 291781
FIXED-IN: 4.8.1
(cherry picked from commit 80d9bfec580bf01b0ee584fc4bb46e3d59a0ba7c)
|
|
Thanks to Jekyll Wu for the analyses.
CCBUG: 286367
|
|
This commit fixes a regression caused by the recent commit
9f711b5f2e1d1fd856cd6b033e6adb96f9b46d8a.
CCBUG: 292250
(cherry picked from commit 84a9cc4bf6e9decc4c102102c4b04162369eb0fe)
|
|
This commit fixes a problem in KItemListView::doLayout(): This function
assumed that firstVisibleIndex is a constant.
However, if the view is scrolled to the bottom with previews enabled,
and then previews are disabled (and the icon size is much smaller
without previews), this function changes the scroll offset, which also
changes the the first visible index. Using the unchanged variable causes
trouble later on (i.e., it makes items which are actually inside the
view area invisible).
lastVisibleIndex is not needed before the scroll offset change and is
const after that, so its calculation is moved a few lines down.
CCBUG: 291841
FIXED-IN: 4.8.1
(cherry picked from commit cc8f5b4939062df44ce0bd314ac4ae04973b9830)
|
|
the correct saved remote encoding charset.
BUG: 186289
FIXED-IN: 4.8.0
REVIEW: 103730
(cherry picked from commit 8f231bd08134f7b1870a9c1747429c1b05174d62)
|
|
BUG: 288748
FIXED-IN: 4.8.0
REVIEW: 103721
(cherry picked from commit e56a363aa6106477fa1577cb0b1bc2a6389910c8)
|
|
(cherry picked from commit dbf0bfffa72c190ed1c8b406c65c9e67b6f65d4f)
|
|
Thanks to Nikita Skovoroda for the initial patch and the analyses.
BUG: 290947
FIXED-IN: 4.8.0
|
|
Thanks to Nikita Skovoroda for the patch!
CCMAIL: [email protected]
|
|
This prevents a delayed update when resizing the window e.g. in the details
view. As no animated item position changes can happen for dynamic item sizes
the synchronous relayout is fine from a performance point of view.
BUG: 290953
FIXED-IN: 4.8.0
|
|
If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance
-> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled.
Additionally the duration for the smooth-scrolling has been decreased from 200 ms
to 100 ms to reduce the lag.
A wrong calculation of the end-value has been fixed that might trigger
a wrong position of the content.
BUG: 291740
BUG: 291607
FIXED-IN: 4.8.0
|
|
Note that the clearing is not done on mouse press, but on mouse release.
The reason is that there are situations when multiple items are selected
and pressing the mouse on one of them should not clear the selection
(e.g., drag and drop of multiple items).
BUG: 290854
REVIEW: 103703
FIXED-IN: 4.8.0
(cherry picked from commit 9f711b5f2e1d1fd856cd6b033e6adb96f9b46d8a)
|
|
This allows adding the "Show in groups" action to the toolbar with
a nice icon.
CCBUG: 290632
|
|
|
|
|
|
subdirectories
BUG: 290745
FIXED-IN: 4.8.0
|