| Age | Commit message (Collapse) | Author |
|
The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.
BUG: 304524
FIXED-IN: 4.9.1
|
|
For top-level roles like "Name" and "Size", the group translation is 0.
In that case, the "group" member of the corresponding RoleInfo struct
must be an empty string. This is expected by the code which generates
Dolphin's menus, which group the top-level roles into a sub menu with
the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression
caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c.
Thanks to Christoph Feck for investigating this issue!
CCBUG: 305228
(cherry picked from commit 168d0511c754008cc679589566d961beb9f6cc10)
|
|
For top-level roles like "Name" and "Size", the group translation is 0.
In that case, the "group" member of the corresponding RoleInfo struct
must be an empty string. This is expected by the code which generates
Dolphin's menus, which group the top-level roles into a sub menu with
the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression
caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c.
Thanks to Christoph Feck for investigating this issue!
CCBUG: 305228
|
|
|
|
BUG: 304541
REVIEW: 106074
FIXED-IN: 4.9.1
(cherry picked from commit 1ec8de2c619006e3fe997fbf6074035d65dea6c5)
|
|
BUG: 304541
REVIEW: 106074
|
|
folders-dockwidget. Now it opens the folders in a new background tab (General behaviour of Dolphin)
BUG: 196263
REVIEW: 106069
|
|
|
|
Acked by Frank
REVIEW: 106049
BUGS: 305228
FIXED-IN: 4.9.1
(cherry picked from commit 199fabbaa8d8a12fb49e4c9922c38ec8b033923c)
|
|
Acked by Frank
REVIEW: 106049
BUGS: 305228
FIXED-IN: 4.9.1
|
|
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
BUG: 303133
FIXED-IN: 4.9.1
(cherry picked from commit b3c3da985159a9627c079ad615cd77fc5f7bb72a)
|
|
|
|
REVIEW:105973
|
|
|
|
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
BUG: 303133
|
|
|
|
ItemLayout is an enum, not a flag, so == is even more correct than '&'.
|
|
Patch by Emmanuel Pescosta <[email protected]>
BUG: 303375
REVIEW: 105575
FIXED-IN: 4.9.0
|
|
FIXED-IN: 4.9.0
BUGS: 274655, 292822
|
|
|
|
|
|
|
|
Items location changes when scrollbar is moved in dolphin.
Accordingly calls to updateAccessibility should be made.
|
|
|
|
Added the calls to updateAccessibility, for DragDrop & Focus scenarios
|
|
|
|
Remove comparison of QAccessibleInterfaces - these are pointers that get
instantiated again and again, so they cannot be compared. Use the object()
function in QAI instead for comparison.
|
|
|
|
This leads to crashes since it implies that
casting to QAccessible2Interface is valid.
|
|
|
|
|
|
The base class implementations are actually good and without some problems.
Save one pointer's worth of memory by not having m_container.
rect was returning a relative rectangle always.
State was wrongly returning HasInvokeExtension which can lead to crashes.
|
|
And also bad use of "" instead of QString().
|
|
|
|
|
|
|
|
|
|
ItemLayout is an enum, not a flag, so == is even more correct than '&'.
|
|
Patch by Emmanuel Pescosta <[email protected]>
BUG: 303375
REVIEW: 105575
FIXED-IN: 4.9.0
|
|
FIXED-IN: 4.9.0
BUGS: 274655, 292822
|
|
FIXED-IN: 4.9.1
REVIEW: 105832
BUG: 303133
|
|
FIXED-IN: 4.9.1
REVIEW: 105832
BUG: 303133
|
|
BUG:292700
FIXED-IN: 4.9.1
REVIEW: 105990
(cherry picked from commit 5e87cefd4c17467c3a650b133dc9bdadea22f9f7)
|
|
That makes "Ctrl+L" less surprising to users who use it frequently in
web browsers
BUG: 183821
FIXED-IN: 4.10.0
REVIEW: 105994
|
|
BUG:292700
FIXED-IN: 4.10.0
REVIEW: 105990
|
|
|
|
|
|
The problem with the icon "package_utility_time" that has been used
before was that it is not available on all distros. The new icon
"chronometer" should be available on every KDE install.
Thanks to Elias Probst for suggesting the new icon - I'm not that
familiar with the icons provided by KDE myself.
CCBUG: 304323
(cherry picked from commit d7e7ca53bb95c7555bbf107d92b47ac25eda1918)
|
|
I overlooked that "actions/" is not part of the icon name. Just
rebuilding and re-running Dolphin did not reveal this issue, it seems
that the old icon "package_utility_time" was still cached somewhere.
I hope that it really works on all distros now.
CCBUG: 304323
|
|
The problem with the icon "package_utility_time" that has been used
before was that it is not available on all distros. The new icon
"actions/chronometer" should be available on every KDE install.
Thanks to Elias Probst for suggesting the new icon - I'm not that
familiar with the icons provided by KDE myself.
BUG: 304323
FIXED-IN: 4.9.1
|