┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2012-08-24Do not crash when finishing inline renaming in unusual waysFrank Reininghaus
The crash was caused by a null pointer dereference when, e.g., minimizing Dolphin. The root cause was that KStandardItemListWidget::closeRoleEditor() was called twice: once when the role editor loses focus, and once again when the window is resized. After m_roleEditor was set to 0, the second call dereferenced this null pointer. I think the best solution is to disconnect from the role editor's signals when the editor is not needed any more by the KStandardItemListWidget. BUG: 304524 FIXED-IN: 4.9.1
2012-08-24Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menusFrank Reininghaus
For top-level roles like "Name" and "Size", the group translation is 0. In that case, the "group" member of the corresponding RoleInfo struct must be an empty string. This is expected by the code which generates Dolphin's menus, which group the top-level roles into a sub menu with the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c. Thanks to Christoph Feck for investigating this issue! CCBUG: 305228 (cherry picked from commit 168d0511c754008cc679589566d961beb9f6cc10)
2012-08-24Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menusFrank Reininghaus
For top-level roles like "Name" and "Size", the group translation is 0. In that case, the "group" member of the corresponding RoleInfo struct must be an empty string. This is expected by the code which generates Dolphin's menus, which group the top-level roles into a sub menu with the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c. Thanks to Christoph Feck for investigating this issue! CCBUG: 305228
2012-08-24Fix includesChristophe Giboudeaux
2012-08-23Select the correct item in places-panel, when a directory is opened.Emmanuel Pescosta
BUG: 304541 REVIEW: 106074 FIXED-IN: 4.9.1 (cherry picked from commit 1ec8de2c619006e3fe997fbf6074035d65dea6c5)
2012-08-23Select the correct item in places-panel, when a directory is opened.Emmanuel Pescosta
BUG: 304541 REVIEW: 106074
2012-08-23Changed the behaviour when middle clicking folders in places- and ↵Emmanuel Pescosta
folders-dockwidget. Now it opens the folders in a new background tab (General behaviour of Dolphin) BUG: 196263 REVIEW: 106069
2012-08-17Remove one unneeded #includeJekyll Wu
2012-08-16Fix translations not showing in the Sort by and Additional Information submenusAlbert Astals Cid
Acked by Frank REVIEW: 106049 BUGS: 305228 FIXED-IN: 4.9.1 (cherry picked from commit 199fabbaa8d8a12fb49e4c9922c38ec8b033923c)
2012-08-16Fix translations not showing in the Sort by and Additional Information submenusAlbert Astals Cid
Acked by Frank REVIEW: 106049 BUGS: 305228 FIXED-IN: 4.9.1
2012-08-15Fix wrong text color in Places Group Header. Use QPalette::Window for base ↵Emmanuel Pescosta
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient. BUG: 303133 FIXED-IN: 4.9.1 (cherry picked from commit b3c3da985159a9627c079ad615cd77fc5f7bb72a)
2012-08-15Merge branch 'master' of git://anongit.kde.org/kde-baseappsEmmanuel Pescosta
2012-08-15Merge branch 'ivan/dolphin-activities'Ivan Čukić
REVIEW:105973
2012-08-15Dolphin reporting opened locations to activity managerIvan Čukić
2012-08-14Fix wrong text color in Places Group Header. Use QPalette::Window for base ↵Emmanuel Pescosta
color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient. BUG: 303133
2012-08-14Correcting code according to KDE PolicyAmandeep Singh
2012-08-14Fix compiler warning, which spotted a real bug.David Faure
ItemLayout is an enum, not a flag, so == is even more correct than '&'.
2012-08-14Fix bug 303375 - Dots in directory names treated as file extension.David Faure
Patch by Emmanuel Pescosta <[email protected]> BUG: 303375 REVIEW: 105575 FIXED-IN: 4.9.0
2012-08-14Fix open-in-new-window to work with remote URLsDavid Faure
FIXED-IN: 4.9.0 BUGS: 274655, 292822
2012-08-14Reverting KListSelectionManager, removing unneccessary a11y factoriesAmandeep Singh
2012-08-14Remove unneccessary dependency and polish the Accessibility InterfacesAmandeep Singh
2012-08-14Enclose accessibility code within QT_NO_ACCESSIBILITYAmandeep Singh
2012-08-14Adding calls to updateAccessibilityAmandeep Singh
Items location changes when scrollbar is moved in dolphin. Accordingly calls to updateAccessibility should be made.
2012-08-14Minor fixes to accessible interfacesAmandeep Singh
2012-08-14Focus-tracking for widgets in Dolphin View now works.Amandeep Singh
Added the calls to updateAccessibility, for DragDrop & Focus scenarios
2012-08-14Improving Accessibility implementationAmandeep Singh
2012-08-14Accessibility: Implement rect for cells and view.Frederik Gladhorn
Remove comparison of QAccessibleInterfaces - these are pointers that get instantiated again and again, so they cannot be compared. Use the object() function in QAI instead for comparison.
2012-08-14Renaming the a11y classes and adding implementationAmandeep Singh
2012-08-14Do not claim HasInvokeExtension.Frederik Gladhorn
This leads to crashes since it implies that casting to QAccessible2Interface is valid.
2012-08-14Remove some dubious code for now (crash less)Frederik Gladhorn
2012-08-14Add some fixmes, comment out broken rect()Frederik Gladhorn
2012-08-14Remove reimplementation of functions.Frederik Gladhorn
The base class implementations are actually good and without some problems. Save one pointer's worth of memory by not having m_container. rect was returning a relative rectangle always. State was wrongly returning HasInvokeExtension which can lead to crashes.
2012-08-14Remove unused function.Frederik Gladhorn
And also bad use of "" instead of QString().
2012-08-14Use KDebug in favor of qdebug.Frederik Gladhorn
2012-08-14Fix parent navigation for KItemListContainerAccessible.Frederik Gladhorn
2012-08-14Instantiate KItemListContainerAccessible when needed.Frederik Gladhorn
2012-08-14Adding the Accessibility classesAmandeep Singh
2012-08-13Fix compiler warning, which spotted a real bug.David Faure
ItemLayout is an enum, not a flag, so == is even more correct than '&'.
2012-08-13Fix bug 303375 - Dots in directory names treated as file extension.David Faure
Patch by Emmanuel Pescosta <[email protected]> BUG: 303375 REVIEW: 105575 FIXED-IN: 4.9.0
2012-08-13Fix open-in-new-window to work with remote URLsDavid Faure
FIXED-IN: 4.9.0 BUGS: 274655, 292822
2012-08-13Fix wrong text color in places and in folders panel.Emmanuel Pescosta
FIXED-IN: 4.9.1 REVIEW: 105832 BUG: 303133
2012-08-13Fix wrong text color in places and in folders panel.Emmanuel Pescosta
FIXED-IN: 4.9.1 REVIEW: 105832 BUG: 303133
2012-08-13Show icon size as tooltip when adjusting icon sizeJekyll Wu
BUG:292700 FIXED-IN: 4.9.1 REVIEW: 105990 (cherry picked from commit 5e87cefd4c17467c3a650b133dc9bdadea22f9f7)
2012-08-13Swap shortcuts of "editable_location" and "replace_location" actionsJekyll Wu
That makes "Ctrl+L" less surprising to users who use it frequently in web browsers BUG: 183821 FIXED-IN: 4.10.0 REVIEW: 105994
2012-08-13Show icon size as tooltip when adjusting icon sizeJekyll Wu
BUG:292700 FIXED-IN: 4.10.0 REVIEW: 105990
2012-08-10SVN_SILENT made messages (.desktop file)Script Kiddy
2012-08-10SVN_SILENT made messages (.desktop file)Script Kiddy
2012-08-09Use a better icon for recently accessed items in the Places PanelFrank Reininghaus
The problem with the icon "package_utility_time" that has been used before was that it is not available on all distros. The new icon "chronometer" should be available on every KDE install. Thanks to Elias Probst for suggesting the new icon - I'm not that familiar with the icons provided by KDE myself. CCBUG: 304323 (cherry picked from commit d7e7ca53bb95c7555bbf107d92b47ac25eda1918)
2012-08-09Follow-up to d7e7ca53bb95c7555bbf107d92b47ac25eda1918 - use correct iconFrank Reininghaus
I overlooked that "actions/" is not part of the icon name. Just rebuilding and re-running Dolphin did not reveal this issue, it seems that the old icon "package_utility_time" was still cached somewhere. I hope that it really works on all distros now. CCBUG: 304323
2012-08-09Use a better icon for recently accessed items in the Places PanelFrank Reininghaus
The problem with the icon "package_utility_time" that has been used before was that it is not available on all distros. The new icon "actions/chronometer" should be available on every KDE install. Thanks to Elias Probst for suggesting the new icon - I'm not that familiar with the icons provided by KDE myself. BUG: 304323 FIXED-IN: 4.9.1