| Age | Commit message (Collapse) | Author |
|
Ensure proper font synchronization between KItemListStyleOption and the base font system. Previously, when switching from a view mode with custom font to one with system font, the style option would retain the custom font setting, causing font settings to persist incorrectly between view modes after application restart.
The changes:
- Unify the font setting logic for both system and custom fonts
- Ensure style option font is synchronized with actual font in system mode
BUG: 511604
|
|
aba0de7301b060c40d543adbaa8d53cf69a9d7ee re-introduced the usage of QFontMetrics::boundingRect(QString) for calculating the size of the last line of a filename. ..Unfortunately, that function uses a different code path from QTextLayout, and arrives at a shorter width for a line of text.
Meanwhile, QFontMetrics::size(QString) internally uses QFontMetric::boundingRect(QRect, int, QString, ..), which has been documented as "The bounding rectangle returned by this function is somewhat larger than that calculated by the simpler boundingRect() function. This function uses the maximum left and right font bearings as is necessary for multi-line text to align correctly."
I have empirically confirmed that QFontMetricsF::size and QTextLine::naturalTextWidth return the same floating-point value given the same input, and QFontMetrics::size does internally use QTextLine::naturalTextWidth through qt_format_text.
BUG: 432530
|
|
with list
Added the feature to open the selected file with the third application from the associated applications list on shift and middle-click. Generalized the middle-click slot to open the file with the app on a specified index, since the behavior should be almost the same for those two actions.
Similar to: d27ee07de7558470ef7b497fbe3d3504ce7cad07
BUG: 510237
|
|
This reverts merge request !1035 65bb95f5
This simply made an unexpected behavior change, opposite to most users expectations.
https://discuss.kde.org/t/slightly-strange-behaviour-in-dolphin/40209/33
Disregarding https://en.wikipedia.org/wiki/Principle_of_least_astonishment (Occam's razor)
Having different behavior when there a folder selected + shortcut, and a folder selected + context menu should be considered different use case.
One has a strong context established, the other has no context from the user perspective.
BUG: 510757
CCBUG: 508196
It re-introduces 508196
|
|
GIT_SILENT
|
|
This commit changes version number for save/restore tab state,
because format has changed - m_splitterLastPosition is now also saved/restored
BUG: 430705
|
|
(cherry picked from commit be2728c5f1b8a0d44d977f9439b73b54e8f142df)
|
|
Replace the wording "Open archives as folder" to the wording "Browse archives as folders".
BUG: 499782
|
|
Instead of ViewModeSettings default mode.
The original resetZoomLevel() implementation used settings.useDefaults(true) to force reading the system's hardcoded default icon size (typically 16px), ignoring the user's custom default size configured in Dolphin's View settings. This caused Ctrl+0 to reset icons to the minimum size instead of the user's preferred default.
This patch removes the useDefaults(true) call, allowing ViewModeSettings::iconSize() to directly retrieve the user-configured default icon size. Ctrl+0 now correctly resets to the size the user set in Dolphin's settings, aligning with expected behavior.
BUG: 482322
|
|
When last viewed tab was in split mode, closing current tab did not activate it properly. In that case focus was lost and there was no possibility to get it again even on mouse click.
|
|
of the splitter.
So the previous size of a pontential leftover closed state does not
apply initially.
BUG: 510915
|
|
|
|
This reverts commit 4b7d49dfca757e28a659bd01614b8f3ee3a03fc0.
|
|
And no hostname set cases.
For other invalid cases (invalid host, host unreachable), we get the Canceled Loading status.
BUG: 509253
|
|
|
|
So users can identify them and distinguish them when two plugins provide
the same mimetype support or help figure out devs where the plugins are
loaded from.
|
|
The information panel does a scaling animation when switching between files. It does not completely make sense because the pixmap passes immediately to the new one, it just animates the scale between the two which just looks glitchy. the effect is particularly visible when switching between a normal folder and one that has thumbnails overlayed on top: the two folder icons appear the same size, but still a weird animation occurs when going from one to another.
Also, the rest of the text of the information panel does change immediately. ideally perhaps some sort of fading animation could make sense, but only if everything in that panel faded together, only the icon fading with the text that is already the "new" one doesn't make much sense
BUG:503036
|
|
Between all dolphinprivate library users.
So that the KConfigSkeleton singleton have unique instances accross
libraries bounds.
To fully fix the bug, make sure to save the modified file to disk.
BUG: 368121
|
|
ResizeAnimation and IconResizeAnimation are not
used anymore anywhere so remove them from KItemListViewAnimation
|
|
The zoom animation in all 3 views looks very glitchy,
because icons that were already in view animate, those that weren't
don't animate giving weird effect.
In the list view mode, the tree view branches don't animate either,
showing weird holes between the branches
Also, while zooming in and out very quickly, is possible to
have the selection rectangle somehow unsynced with the items sizes
leading to visual glitches.
Without an animation, zooming the view feels much faster and robust
giving immediate feedback when zooming via ctrl+scroll or by dragging
the slider around
BUG:510426
|
|
|
|
In editedRoleChanged.
This can happen if updateTextsCache has not yet be called before
editedRoleChanged in tests notably.
|
|
|
|
Since the Menu will then be used in the chain of focused elements.
|
|
|
|
|
|
as file url to open, as does `slotItemActivated`.
Allows to open files using the middle click, with protocols using `UDS_TARGET_URL` such as
recentlyused://.
|
|
Layouts are parented to their containing layout by default, and layouts
can't share a same parent.
This prevent a runtime warning regarding QLayout.
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Initialize the action state based on current trash contents and keep it in sync with Trash::emptinessChanged to avoid incorrect disabling on startup.
BUG: 501091
|
|
Initialize the action state based on current trash contents and keep it in sync with Trash::emptinessChanged to avoid incorrect disabling on startup.
BUG: 501091
|
|
pipeline for some reason
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
renaming a folder
In a split-view tab, the child folder is opened in the left view and other tabs, while the parent folder is opened in the right view. After renaming the child folder from the right view:
- The activated view should not switch to the left view.
- All tab titles should be updated.
CCBUG: 496414
|
|
renaming folder
Issue:
In a split-view tab, if a folder is opened in the left view and its parent folder is opened in the right view, renaming the folder from the right view activates the left view.
Reason:
When renaming the folder, the emitted `DolphinView::urlChanged` will invoke `KUrlNavigator::setLocationUrl()`, which finally calls `DolphinViewContainer::setActive()` and activates the left view.
Change:
- Temporarily disconnect the `DolphinUrlNavigator::activated` signal to avoid activation of `DolphinViewContainer`.
- Force inactivate `DolphinUrlNavigator`.
|
|
Issue:
When opening an MTP device via the sidebar, Dolphin shows one "Internal shared storage" folder. However, clicking the entry again results in a duplicate folder being displayed.
This regression was introduced by !865 (commit 6c7c047).
Reason:
The URL of an MTP device in the sidebar is `mtp:udi=/org/kde/solid/udev/sys/devices/...`. When clicking to open the MTP device, it is redirected to `mtp:/...`.
- On the first click (no cache), `KCoreDirListerCache::slotUpdateResult()` calls `KCoreDirListerPrivate::emitItems()`.
- On the second click (with cache), `KCoreDirListerCache::slotRedirection()` first calls `KCoreDirListerPrivate::emitItems()`. Besides, `DolphinTabPage::slotViewUrlRedirection()` calls `KCoreDirLister::openUrl()`, which triggers `CachedItemsJob::start()`, and eventually calls `KCoreDirListerPrivate::emitItems()` again. As a result, two `KCoreDirLister::itemsAdded` signals are emitted, causing `m_pendingItemsToInsert` to be appended twice.
---
BUG 496414:
Need to rename folder twice to make it reflect in the tab title.
Reason:
`m_url` is updated after emitting the `DolphinView::redirection` signal. It triggers `DolphinTabWidget::tabUrlChanged()`, which still uses the old URL and thus resets the tab title incorrectly.
---
Change:
- Revert the change in `DolphinTabPage::slotViewUrlRedirection()`.
- Update `m_url` before `DolphinView::redirection` to fix BUG 496414.
- Emit `DolphinView::urlChanged` signal to refresh the navigator of the inactive view.
BUG: 506634
CCBUG: 497313
CCBUG: 496414
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
(cherry picked from commit d8831f3d6ccc46058cdc00f32c2f07b96f259cb8)
|
|
When switching files quickly in the Information Panel, the preview pixmap could appear progressively brighter/whiter. This happened because markOutdatedPreview() was applying KIconEffect::toDisabled() multiple times on the same pixmap while a preview job was still pending.
This patch fixes the issue by:
- Tracking the URL that was last disabled, and only applying the disabled effect once per URL.
- Clearing the disabled state whenever a new preview job starts or when a new pixmap is shown.
With this change, the "disabled preview" effect is preserved (still useful for slow HDD or network filesystems), but the progressive white-out artifact no longer occurs when navigating rapidly.
BUG: 507844
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
So that when those actions appear in toolbars or shortcut configuration,
users can know what they correspond to.
|
|
Move instantiation, setModel, and some connections to constructor and remove showEvent.
This was being done in an erroneous lazy order which led to the places panel's sizeHint not being called properly.
Also removes the double loading workaround in setUrl, which is no longer needed either.
BUG: 449070
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Summary:
This patch introduces context menu actions that allow users to hide or unhide selected files by editing the .hidden file in their parent directories.
What this patch does:
- Implemented HideFileItemAction plugin based on KAbstractFileItemActionPlugin
- Plugin is disabled by default unless explicitly enabled in kservicemenurc via the hidefileitemaction key
- "Hide" action adds selected file names to the .hidden file, avoiding duplicates
- "Unhide" action removes selected file names from the .hidden file
- Action visibility logic:
- If only visible or only hidden files are selected, only the relevant action is shown
- If both are selected, both "Hide" and "Unhide" actions are shown
- Write permission checks ensure actions are disabled if the .hidden file cannot be modified
- Optimized redundant path computations by calculating parent directory and .hidden file paths once and reusing them
|
|
Previously, the code could misposition the selection after removal if
the last file in the view was removed and several files were selected.
And since it didn't clear the selection, the previous selection
influence the selection.
Instead clear the selection and position only the focus, either on the
next item after the last index, or the last item still in the view if the last
item was removed.
BUG: 504490
|