| Age | Commit message (Collapse) | Author |
|---|
|
When a file is deleted using the Delete key, the next item gains focus but loses its selection, which breaks further keyboard deletion.
This patch ensures the next item is explicitly selected after clearing the previous selection.
BUG: 513371
|
|
(cherry picked from commit 31fa6509c29f730a8a1d4fe1c8dbf50a1f1fcf9c)
|
|
|
|
If we have return early because dynamic view is not enabled
or we have Icon View already, then do not try to load view
properties to get 'dynamicViewPassed' property.
Otherwise, for example, it infinitely calls
the ViewProperties::save() method for the /tmp folder,
which generates a bunch of temporary files
(on new user, if dynamic view is not enabled
and Icon View applied by default)
BUG: 508402
|
|
BUG: 513345
|
|
Commit 8d44699f introduced a new session file format, without providing a migration path for the old file format, which led to users losing their session.
Besides adding the migration path, the condition check for future updates is necessary, since we don't provide guarantees for backwards-compatible format changes. In case users downgrade their Dolphin version/immutable distro or they share the Dolphin config file across multiple systems, Dolphin at least won't crash when reading a session file with a newer format.
BUG: 513466
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Using plural here better conveys that every new window will have split view mode enabeled. The original string was introduced in !1103
CCBUG:464696
CCBUG:186185
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Fix the issue where enabling icon rating always showed five white stars. Retrieve the correct rating from KFileMetaData::UserMetaData for local files and insert it into the item data. This ensures both files and folders display the updated rating correctly.
BUG: 512940
|
|
(cherry picked from commit 74285708c697b7a05f22da3ce4d1032d6dfa539c)
|
|
|
|
There is one bool setting in Dolphin Interface->Folders&Tabs->Split_view
which determines which panel is closed on "Close split view" button
click (currently focused or unfocused one).
This commit replaces this setting with (enum-based) 3-state combo box.
Since now we can set "When closing a split view" action to:
- Close the active pane
- Close the inactive pane
- Close the right pane
BUG: 464696
BUG: 186185
|
|
Use loop index 'i' instead of function parameter 'index' for setTabToolTip.
Previously all tooltips would be set on the newly inserted tab instead of
their respective tabs.
|
|
Calling createRolePixmap() while roleIndex is < 0 (which is the case for
the header side padding) would cause access to a negative index of a
vector, so exit the function before so and do nothing.
BUG: 511057
|
|
This commit uses KUrlNavigator focus indicator to show sufficiently which panel (left or right) is currently active in split mode.
This MR is based on KIO changes in https://invent.kde.org/frameworks/kio/-/merge_requests/2054
See discussion in MR: !1076 (comment 1334290), see https://invent.kde.org/frameworks/kio/-/merge_requests/2058
@teams/vdg
{width=849 height=313}
{width=849 height=313}
{width=849 height=313}
{width=849 height=313}
@teams/vdg
BUG: 150718
BUG: 428440
|
|
If you are in ~
And create at once ~/1/2
Select the 1 folder afterwards
|
|
Use current view url as fallback.
Don't update the selection after a directory is created, except if there
was no selection.
CCBUG: 508196
BUG: 512020
|
|
Similarly to Microsoft explorer.
FEATURE: 512383
|
|
certain glyphs
In the Details view the name (text) column could appear vertically off-center for file names containing certain Unicode glyphs (for example "』"). The issue is caused by a mismatch between the generic font metrics ascent and the actual ascent of the rendered QTextLine for that glyph, which shifts the baseline and thus the visual vertical centering.
This change computes the QTextLine ascent for the (single) layouted line and adjusts the vertical position by the difference between the font metrics ascent and the line ascent. The adjustment is applied only for the name (text) role so other columns are unaffected.
BUG: 512152
|
|
media file is selected
To reproduce the crash:
- Open Dolphin, disable information panel and close Dolphin
- Re-open Dolphin
- Select a video file
- Enable information panel
- Crash
Problem is that some elements of the MediaWidget panel are created when the widget is shown, in `showEvent` (`m_seekSlider` and `m_topLayout`), and these elements are called before being created.
This MR fixes 2 different crashes:
- Crash creating panel when a video file is selected (call to `m_seekSlider` before its creation)
- Crash creating panel when a video file is selected and autoplay enabled (call to `m_topLayout` before its creation)
|
|
"Sort By field" could be understood as an extra field that contains a "Sort By" value
|
|
Checks if the second action in the submenu is actually an app and not a
separator, and add hint "Shift + Middle Click".
|
|
When Dolphin config was set to start in split mode by default
AND simply open the given folder in both panels
(Settings -> Folders&Tabs -> Show on startup -> selected folder [NOT "...state from last time"])
no view was initially active making weird side-effects described in both bugs.
This commit solves that by calling mainWindow->openDirectories
on start when both of the above conditions are met.
BUG: 503576
BUG: 508554
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
This reverts commit 122fee5625f0285ec4ebda79162c72390989eb2a.
This behavior change was well-intentioned, but has significant usability
and speed drawbacks that have not been addressed:
- Keyboard-driven folder manipulation became slower
- Unexpected behavioral differences when opening files with the pointer
compared to when opening them with the keyboard introduced
inconsistency and cognitive load
- Unexpected opening of selection mode during fast operation introduced
the potential for confusion and additional errors
- Dolphin's behavior became inconsistent with that of other file
managers users may be accustomed to
The bug tracker, discuss.kde.org, and Reddit are full of complaints
about this change. It's been a year now; I think it's clear that many
Dolphin users have not gotten used to and accepted it. I have to count
myself as one of them, I'm afraid. I've tried to get used to it for a
year, but I just have not been able to.
I don't believe the benefits of this change outweigh the drawbacks, so
let's revert it.
24d859cf19e90fa22ed687b36a68231625c1bd80 was explicitly mentioned as a
thing that should also be reverted in this case, but it's already been
done.
BUG: 494125
BUG: 511966
CCBUG: 424723
CCBUG: 492404
FIXED-IN: 25.12.0
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Rather than its description, which for an empty charset is:
"Other encoding ()", that can't be empty and will always enter the
branch.
|
|
The original keyboard search implementation had a limitation when dealing with files containing repeated characters like 44.txt. When typing 44, it would trigger rapid navigation to the next item starting with 4 instead of matching the full string 44.
This patch introduces a smarter search strategy:
1. First attempt full string matching for exact file names
2. If full match fails and user is typing repeating characters, fall back to rapid navigation using either:
- Last successful search string (for extended searches like 444 -> 4444)
- First character only (original rapid navigation behavior)
The changes include:
- Modified changeCurrentItem signal to include a found parameter for search result feedback
- Added m_lastSuccessfulSearch to track successful searches for better fallback behavior
- Used Qt::DirectConnection to ensure synchronous execution for immediate result feedback
This provides better user experience when searching for files with repeated characters while maintaining the rapid navigation feature for quick browsing.
BUG: 501851
|
|
The original implementation prioritized mouse hover over keyboard selection,
preventing panel updates when navigating with arrow keys while the mouse
was over another item.
This patch adds explicit state tracking to ensure keyboard selections
always update the panel, regardless of mouse position.
BUG: 474507
|
|
Ensure proper font synchronization between KItemListStyleOption and the base font system. Previously, when switching from a view mode with custom font to one with system font, the style option would retain the custom font setting, causing font settings to persist incorrectly between view modes after application restart.
The changes:
- Unify the font setting logic for both system and custom fonts
- Ensure style option font is synchronized with actual font in system mode
BUG: 511604
|
|
aba0de7301b060c40d543adbaa8d53cf69a9d7ee re-introduced the usage of QFontMetrics::boundingRect(QString) for calculating the size of the last line of a filename. ..Unfortunately, that function uses a different code path from QTextLayout, and arrives at a shorter width for a line of text.
Meanwhile, QFontMetrics::size(QString) internally uses QFontMetric::boundingRect(QRect, int, QString, ..), which has been documented as "The bounding rectangle returned by this function is somewhat larger than that calculated by the simpler boundingRect() function. This function uses the maximum left and right font bearings as is necessary for multi-line text to align correctly."
I have empirically confirmed that QFontMetricsF::size and QTextLine::naturalTextWidth return the same floating-point value given the same input, and QFontMetrics::size does internally use QTextLine::naturalTextWidth through qt_format_text.
BUG: 432530
|
|
with list
Added the feature to open the selected file with the third application from the associated applications list on shift and middle-click. Generalized the middle-click slot to open the file with the app on a specified index, since the behavior should be almost the same for those two actions.
Similar to: d27ee07de7558470ef7b497fbe3d3504ce7cad07
BUG: 510237
|
|
This reverts merge request !1035 65bb95f5
This simply made an unexpected behavior change, opposite to most users expectations.
https://discuss.kde.org/t/slightly-strange-behaviour-in-dolphin/40209/33
Disregarding https://en.wikipedia.org/wiki/Principle_of_least_astonishment (Occam's razor)
Having different behavior when there a folder selected + shortcut, and a folder selected + context menu should be considered different use case.
One has a strong context established, the other has no context from the user perspective.
BUG: 510757
CCBUG: 508196
It re-introduces 508196
|
|
GIT_SILENT
|
|
This commit changes version number for save/restore tab state,
because format has changed - m_splitterLastPosition is now also saved/restored
BUG: 430705
|
|
(cherry picked from commit be2728c5f1b8a0d44d977f9439b73b54e8f142df)
|
|
Replace the wording "Open archives as folder" to the wording "Browse archives as folders".
BUG: 499782
|
|
Instead of ViewModeSettings default mode.
The original resetZoomLevel() implementation used settings.useDefaults(true) to force reading the system's hardcoded default icon size (typically 16px), ignoring the user's custom default size configured in Dolphin's View settings. This caused Ctrl+0 to reset icons to the minimum size instead of the user's preferred default.
This patch removes the useDefaults(true) call, allowing ViewModeSettings::iconSize() to directly retrieve the user-configured default icon size. Ctrl+0 now correctly resets to the size the user set in Dolphin's settings, aligning with expected behavior.
BUG: 482322
|
|
When last viewed tab was in split mode, closing current tab did not activate it properly. In that case focus was lost and there was no possibility to get it again even on mouse click.
|
|
of the splitter.
So the previous size of a pontential leftover closed state does not
apply initially.
BUG: 510915
|
|
|
|
This reverts commit 4b7d49dfca757e28a659bd01614b8f3ee3a03fc0.
|
|
And no hostname set cases.
For other invalid cases (invalid host, host unreachable), we get the Canceled Loading status.
BUG: 509253
|
|
|
|
So users can identify them and distinguish them when two plugins provide
the same mimetype support or help figure out devs where the plugins are
loaded from.
|
|
The information panel does a scaling animation when switching between files. It does not completely make sense because the pixmap passes immediately to the new one, it just animates the scale between the two which just looks glitchy. the effect is particularly visible when switching between a normal folder and one that has thumbnails overlayed on top: the two folder icons appear the same size, but still a weird animation occurs when going from one to another.
Also, the rest of the text of the information panel does change immediately. ideally perhaps some sort of fading animation could make sense, but only if everything in that panel faded together, only the icon fading with the text that is already the "new" one doesn't make much sense
BUG:503036
|
|
Between all dolphinprivate library users.
So that the KConfigSkeleton singleton have unique instances accross
libraries bounds.
To fully fix the bug, make sure to save the modified file to disk.
BUG: 368121
|
