┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-02-17Prevent repeated re-layouting of all items while previews are generatedFrank Reininghaus
There was some code in KStandardItemListView::itemSizeHintUpdateRequired already that was supposed to prevent an expensive re-layouting of all items when a preview is received. However, it didn't quite work as intended because also the "iconOverlays" role changed. The new approach is to only re-layout if text of a visible role changes, because this is the only way how the space needed by an item might change (see KStandardItemListWidgetInformant::itemSizeHint()). BUG: 315315 FIXED-IN: 4.10.1 REVIEW: 108984
2013-02-13Improve the recently added test testMouseClickActivationFrank Reininghaus
The method to make sure that the first item is visible turned out to be less reliable than I thought. This could make the test hang forever. Moreover, this commit removes some trailing whitespace that had been added accidentally.
2013-02-11Fix blinking when moving the mouse over an hidden itemAurélien Gâteau
The opacity of the unhovered pixmap must be gradually reduced while animating otherwise the alpha channel saturates. REVIEW: 108858 BUG: 299371 FIXED-IN: 4.10.1
2013-02-05Add unit test for bug 313342Frank Reininghaus
2013-02-05Apply changes of the KGlobalSettings::singleClick() setting immediatelyAniket Anvit
Fixes a regression introduced by commit 7a364cbf489af25e123d18713523151a3a53f814. Patch reviewed and pushed by Frank Reininghaus. BUG: 313342 FIXED-IN: 4.10.1
2013-01-30Add unit test for bug 314046Frank Reininghaus
The regression happened in the master branch only, but I think it doesn't hurt to add the test to the stable branch. CCBUG: 314046
2013-01-29Update Dolphin version to 2.2 for KDE 4.10.0Frank Reininghaus
2013-01-27escape the existing text instead of set to plain textWeng Xuetian
@info indicates it's rich text and will be added <html> tag by kdelibs, so just escape the text that will be set to label for KDE/4.10 REVIEW: 108584 BUG: 313992
2013-01-27Add a unit test for a recently fixed crashFrank Reininghaus
Before commit 90c7fd400c34e6d4d583c54c04631856c387d359, adding a KFileItem with an empty path caused a crash in KFileItemModel::expandedParentsCountCompare().
2013-01-24KFileItemModelRolesUpdater: Avoid multiple updates for Nepomuk dataVishesh Handa
The Nepomuk ResourceWatcher emits 3 signals - propertyChanged, propertyAdded and propertyRemoved. We should only listen to either the propertyChanged signal or the propertyAdded + Removed signals. There is no point in listening to all 3 signals. That will just result in unnecessary updates. Additionally, we do not need to listen to the resourceCreated signal. That is only emitted when we are watching for a specific types, which we are not. REVIEW: 108543
2013-01-22Make the "A folder cannot be dropped into itself" message less intrusiveFrank Reininghaus
Showing this message in the KMessageWidget above the view, which means that the view contents are moved down, can be extremely annoying according to user feedback. Just showing the message in the status bar is probably enough. BUG: 313466 REVIEW: 108483 FIXED-IN: 4.10.0
2013-01-17SVN_SILENT made messages (.desktop file)Script Kiddy
2013-01-16Allow Timeline-URLs as homepageAndrea Scarpino
FEATURE: 313151 REVIEW: 108428
2013-01-16Use proper IconSize for PlacesItemEditDialog's KIconButtonKai Uwe Broulik
REVIEW: 108443
2013-01-16SVN_SILENT made messages (.desktop file)Script Kiddy
2013-01-15Update Dolphin version to 2.1.98 for KDE 4.10 RC 3Frank Reininghaus
2013-01-15A crash occurs if updateItemStates runs between theSimeon Bird
UpdateItemStatesThread finishing and the finished() signal being delivered. In this case, a new thread was not created, because the old thread still existed. However, pendingItemStatesUpdate was not set, because the thread was not running. Instead, the old thread was restarted. This meant that the finished() signal from the first run could be delivered while the thread was running for a second time, causing the thread to be deleted while still running and thus a crash. Solution: set pendingItemStatesUpdate if the thread is non-null, even if it is not running, knowing that slotThreadFinished has not yet run, and will call updateItemStates itself. BUG: 302264 FIXED-IN: 4.10 REVIEW: 107656
2013-01-14Select right item as current item (first item after the deletion) after ↵Emmanuel Pescosta
deleting files BUG: 290736 REVIEW: 108356 FIXED-IN: 4.10
2013-01-14Don't delay popup menus of "Create New" and "Recently Closed Tabs" toolbar ↵Kai Uwe Broulik
buttons REVIEW: 108397
2013-01-11Show the file name as plain text in the file-metadata-tooltipEmmanuel Pescosta
FIXED-IN: 4.10 BUG: 262464 REVIEW: 108336
2013-01-11Slightly reduce the tinting for selected icons and previewsFrank Reininghaus
The intention of the tinting was to make it more obvious in icons view which icons are selected. However, some icons and previews look quite ugly with the current tinting value of 1.0 (i.e., the value passed to KIconEffect::colorize). A slight reduction of this value to 0.8 makes this a little less ugly. However, the real fix is to remove the tinting altogether and find something better to indicate which items are selected. CCBUG: 309722
2013-01-11Only use parallel sorting when sorting by nameFrank Reininghaus
The reentrant natural comparison of strings is the only really expensive operation. Other comparison functions are much cheaper and might not be reentrant at all. Therefore, we disable parallel sorting when not sorting by name to prevent crashes and other unpleasant behaviour. BUG: 312679 FIXED-IN: 4.10 REVIEW: 108309
2013-01-09Fix information panel interpreting html tagsKai Uwe Broulik
Only fixes the most obvious file name, the other entries in the table probably have to be fixed in the FileMetaDataWidget. REVIEW: 108307 BUG: 262464 (cherry picked from commit 3d7d900d2830c71255ff8c02f5f7439224cd4122)
2013-01-09Show the real audio file duration in additional informationsEmmanuel Pescosta
Big Thanks to Frank Reininghaus and Vishesh Handa! BUG: 311794 REVIEW: 108281 FIXED-IN: 4.10
2013-01-09Show the file name as plain text in the rename dialogEmmanuel Pescosta
BUG: 312812 BUG: 262464 FIXED-IN: 4.10 REVIEW: 108291
2013-01-08SVN_SILENT made messages (.desktop file)Script Kiddy
2013-01-07Fix build if one of the missing Nepomuk dependencies is missingChristophe Giboudeaux
2013-01-07Dolphin: Make Nepomuk Support OptionalVishesh Handa
Use the KFileMetadataWidget if Nepomuk is not present. REVIEW: 108236
2013-01-04SVN_SILENT made messages (.desktop file)Script Kiddy
2013-01-03Fix crash when browsing bluetooth device.Michael Jansen
When trying to browse a N900 it crashed here because pathA was empty. Which lead to index = maxIndex beeing -1 and pathA.at(index) crashing. Reorder the while condition to prevent that courtesy of tsdgeos. (cherry picked from commit f0c90a47de3f59e4a98932ae6f0499921d9aa899)
2013-01-02Dolphin Information Panel: Use Nepomuk2::FileMetadataWidgetVishesh Handa
Instead of the KFileMetadataWidget. The Nepomuk widget is just a copy of the KFileMetadataWidget which utilizes Nepomuk2.
2012-12-27Increase Dolphin version to 2.1.97 for the 2nd release candidateFrank Reininghaus
2012-12-27Merge remote-tracking branch 'origin/KDE/4.9' into KDE/4.10Frank Reininghaus
2012-12-24SVN_SILENT made messages (.desktop file)Script Kiddy
2012-12-23SVN_SILENT made messages (.desktop file)Script Kiddy
2012-12-22SVN_SILENT made messages (.desktop file)Script Kiddy
2012-12-22SVN_SILENT made messages (.desktop file)Script Kiddy
2012-12-19Fix Bug 311782 - Directory loading has been cancelled sometimes falsly ↵Emmanuel Pescosta
triggered which was introduced by commit 9dbc24fd647e0457d50ec901d33100c33967be68 BUG: 311782 REVIEW: 107787 FIXED-IN: 4.10
2012-12-17Fix Bug 287829 - inline rename multiple files does not honourEmmanuel Pescosta
sort order BUG: 287829 FIXED-IN: 4.9.5 REVIEW: 107718
2012-12-13Fix Bug 304299 - Dolphin launches multiple instances of a program when ↵Emmanuel Pescosta
multiple files are selected BUG: 304299 REVIEW: 107305
2012-12-13Merge remote-tracking branch 'origin/KDE/4.9'Frank Reininghaus
2012-12-13Add i18 call to untranslated stringFrank Reininghaus
The string was added in ecb2715ead30c2b9d483748074524322e5ecedcf. According to the soft message freeze policy on techbase, it's OK to fix previously untranslated strings. Translators, please tell me if I'm wrong, then I'll remove the string and the surrounding code and re-add it to master later for KDE 4.11. Sorry for the trouble. Thanks to David Faure for pointing out this mistake! CCMAIL: [email protected]
2012-12-12Fix Bug 240820 - [Usability Bug] Handling Bad Filenames, dolphin gives ↵Emmanuel Pescosta
unclear error message Fix Bug 308597 - Regression: Renaming a file/folder to something that contains a "/" will result in several message boxes Uses the same solution as Dolphin-Rename-Dialog does. (KIO::encodeFileName) BUG: 240820 BUG: 308597 REVIEW: 107681 FIXED-IN: 4.9.5
2012-12-10SVN_SILENT made messages (.desktop file)Script Kiddy
2012-12-10SVN_SILENT made messages (.desktop file)Script Kiddy
2012-12-07Correct value for autostart setting of Service-nepomukfileindexer, part2Frank Reininghaus
After 530c743a89bb5366ff9b6f8be1d7a37f23b46880, this fixes the other places where the incorrect default value 'false' was used. Thanks to Luc Menut for noticing this problem! CCBUG: [email protected]
2012-12-07Merge remote-tracking branch 'origin/KDE/4.9'Frank Reininghaus
2012-12-07Update Dolphin version to 2.1.95 for KDE 4.10 RC 1Frank Reininghaus
2012-12-07Fix keyboard focus handling after renaming items inlineFrank Reininghaus
This reverts 951cb9c35d7a9ef814b3de5b359915968da9b881 and 3143acc084d54d43df469b54762bfa10a7050a9f, and fixes the crash caused by nested event loops by delaying the deletion of the KItemListRoleEditor until the next item is renamed inline. BUG: 311206 FIXED-IN: 4.9.5 REVIEW: 107606
2012-12-06Fix incorrect usage of list iteratorsFrank Reininghaus
The problem was that we erased an iterator from the list and then incremented it. This can lead to problems (namely, random crashes) if the iterator pointed to the last list element. Thanks to Sandro Mani for testing the patch! BUG: 311246 FIXED-IN: 4.9.5