┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2019-04-18Fix adding "Create New..." menu to toolbarNate Graham
Summary: Access the object by its existing name rather than renaming it. BUG: 405780 FIXED-IN: 19.04.1 Test Plan: - Add {nav Create New} item to toolbar; it now works - Verify that {nav Create New} menu and toolbar items are disabled when in the trash - All tests still pass Reviewers: elvisangelaccio, broulik, #dolphin, cfeck Reviewed By: cfeck Subscribers: cfeck, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20664
2019-04-18Fix missing update of file name label in information panel without previewStefan Brüns
Summary: The file name label was only updated when the preview was shown, after the function was moved into a conditional section. This is a regression caused by commit 405aa4878f75 ("[InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled"). Test Plan: Hide the preview in dolphin's information panel Hover different files, the name label reflects the hovered file again Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: meven Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20660
2019-04-14Remove last traces of KFileMetaDataWidget from information panelStefan Brüns
Summary: The whole information panel is not included when Baloo is not found, so there is no need for the HAVE_BALOO guards. KFileMetaDataWidget and KFileMetaDataConfigurationWidget were never part of KF5, see https://git.reviewboard.kde.org/r/113153/ Test Plan: ctest Reviewers: #frameworks, apol, ngraham, #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20513
2019-04-14[Information Panel] Remove nullptr checks for MetaDataWidget memberStefan Brüns
Summary: The widget has the same livetime as the containing widget, no need to do any extra checks. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20514
2019-04-12GIT_SILENT made messages (after extraction)l10n daemon script
2019-04-12Scroll to item if it's not visible on keyPressTranter Madi
Summary: Always scroll to item if it's not visible on keyPress, even if it's the current index. Test Plan: Select the last item, scroll up to make it not visible > press the `End` key > Dolphin now scrolls to that item. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20152
2019-04-12GIT_SILENT made messages (after extraction)l10n daemon script
2019-04-09Merge branch 'Applications/19.04'Nate Graham
2019-04-09Don't show "Open With" menu items for empty directoriesNate Graham
Summary: Any app that registers itself as able to open directories generally can't do anything useful with an empty directory. So, don't show the {nav Open With} menu items for them. Test Plan: Before: {F6759793} After: {F6759794} The {nav Open With} items still appear for non-empty directories. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: trmdi, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20396
2019-04-09Make buttons in seach bar nicer (icon, tooltip, autoselect)Stefan Brüns
Summary: The "Everywhere" button actually selects the home directory, so use an appropriate label ("Your files") and add a "user-home" icon. Pre-select the right button when entering search, depending on the location where the "Find ..." action was triggered. Add tooltips for both buttons, stating where to look for files. Most importantly, this includes the full path for "From here". Canonicalize the path correctly (always strip trailing slash), otherwise QUrl::fileName() will be an empty string, resulting in "From Here (/)" Do not hide the buttons in case the url is non-local, as it is confusing: 1. The state depends on the previous search. When the user hits "Find" when browsing e.g an SMB share, the search was probably in the home dir. 2. The current search location was hidden 3. The user may want to do a local search, give the option to do so. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: loh.tar, meven, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20357
2019-04-07Merge branch 'Applications/19.04'Elvis Angelaccio
2019-04-07[DolphinMainWindowTest] Fix testNewFileMenuEnabledElvis Angelaccio
The newFileMenu enabled status is updated whenever the KDirLister emits the `completed` signal: use QTRY_COMPARE so that we can wait for it.
2019-04-07[KFileItemModelTest] Port to fastInsert()Elvis Angelaccio
We already depend on KF5 > 5.47, so we are ready to switch to the non-deprecated fastInsert() method.
2019-04-06Re-implement Meta-E global launch shortcut using KGlobalAccelNate Graham
Summary: FEATURE: 405302 FIXED-IN: 19.08.0 Test Plan: 1. Apply patch 2. Reboot (didn't work until I rebooted or logged out and back in again) 3. Hit {key Meta E} 4. Dolphin Launches Reviewers: #dolphin, elvisangelaccio, davidedmundson Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20229
2019-03-30[KFileItemModel] Fix alignment of rolesInfoMapElvis Angelaccio
GIT_SILENT
2019-03-27Add "Aspect Ratio" and "Frame Rate" to additional video information columnsKochih Wu
Summary: Add options to show aspect ratio and frame rate. BUG: 366524 FIXED-IN: 19.08.0 Test Plan: Under Control -> Additional Info -> Video, there should be options for aspect ratio and frame rate. Reviewers: #dolphin, #kde_applications, ngraham Reviewed By: #dolphin, #kde_applications, ngraham Subscribers: astippich, ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20074
2019-03-27Fix typo in dolphinsettingsdialog.cppYi-Jyun Pan
Summary: Just remove the useless "have". Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20080
2019-03-26Prompt user to save/discard changes upon closing config dialogAmish Naidu
Summary: When the configuration dialog is closed with unsaved changes, a message box is prompted to save/discard them or cancel the event. BUG: 391206 Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19904
2019-03-24Merge branch 'Applications/19.04'Nate Graham
2019-03-24[InformationPanel] Hide the video when the preview is disabled, avoid ↵Méven Car
computing the preview when it is disabled Summary: Bug symptom : {F6698879} Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled. Test Plan: # In dolphin with an information panel with preview on # launch the video preview # Disable the preview ->bug 1: the video player control is still visible (this bug fix this) # re-enable preview -> bug 2: the video stays visible and the preview is displayed above (this bug fix this) Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19844
2019-03-24Move Safely Remove down in places context menuTigran Gabrielyan
Summary: BUG: 405620 Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19950
2019-03-24When hovering over a file on the not-focus view panel, the information panel ↵Méven Car
gets updated Test Plan: - In Dolphin with two views (split view) and with the information panels - Hover over a file on the not selected view - > the information panel show information about this file No other changes in behavior Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19936
2019-03-24[InformationPanel] Hide the video when the preview is disabled, avoid ↵Méven Car
computing the preview when it is disabled Summary: Bug symptom : {F6698879} Fix the bugs and allow to avoid launching a PreviewJob with all files even when the preview is disabled. Test Plan: # In dolphin with an information panel with preview on # launch the video preview # Disable the preview ->bug 1: the video player control is still visible (this bug fix this) # re-enable preview -> bug 2: the video stays visible and the preview is displayed above (this bug fix this) Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19844
2019-03-24[PhononWidget] Fix layout warningElvis Angelaccio
`controlsLayout` should not be a direct child of the widget, since it already has `m_topLayout` as layout. This fixes the following warning: QLayout: Attempting to add QLayout "" to PhononWidget "", which already has a layout
2019-03-23Merge branch 'Applications/19.04'Elvis Angelaccio
2019-03-22Convert foreach to for loopsMéven Car
Test Plan: Compile Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19911
2019-03-21find ruby gems & make coverage conditional on BUILD_COVERAGEHarald Sitter
Summary: new finding tech: - find_gem function configures gem-specific FindFoo files and wraps around find_package - FindFoo files look for ruby and then attempt to require the gem name i.e. it checks if the gem can be successfully loaded by the interpreter - since this is based on find_package it may be influenced in all the regular ways (e.g. forced found or disabled from finding altogether via CMAKE_DISABLE_FIND_PACKAGE_$PKGNAME) various notes for the future: - technically this isn't 100% correct because the require name of a gem and the gem name may not be the same. e.g. the gem `docker-api` has the require name `docker`. for all currently used gems the names are however the same and so simply requiring the gem name is expected to work - the implementation doesn't care about versions, again because we don't need it to - test-unit is a bundled gem, some distributions (e.g. Arch) do split it out without making suitable dependency arrangements on a package level though the tech is heavily inspired by Aleix Pol's tech for finding QML modules as seen in extra-cmake-modules Test Plan: - ruby not found: none of the modules found - test-unit not present: error - simplecov not prseent: never errors - having a module installed or not is reported in the cmake output Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19856
2019-03-20Fix PlacesItemModelTest::testDefaultViewProperties()Elvis Angelaccio
The test was assuming that global view properties are off by default, which is no longer true after d6c086ad04.
2019-03-20Merge branch 'Applications/19.04'Nate Graham
2019-03-20Fix rearranging items in places panel with hidden itemsTigran Gabrielyan
Summary: `m_sourceModel->movePlace` is called using index from the view model. This becomes an issue when there are hidden places items. This change calls `m_sourceModel->movePlace` using the corresponding mapped source index. BUG: 399430 FIXED-IN: 19.04.0 Test Plan: # Create at least 4 Places items # Hide first item # Drag the now first visible item between second and third item Actual: The item does not move Expected: The first visible item should now be second visible item in the list Reviewers: #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19901
2019-03-18Merge remote-tracking branch 'origin/Applications/19.04'Christoph Feck
2019-03-18Bring back KActivities supportElvis Angelaccio
Summary: This code has been unused since the KF5 port. Reviewers: #dolphin, #plasma Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D18273
2019-03-18fix coverage generation when run through ctestHarald Sitter
path construction is a bit disappointing and doesn't actually work all that well for out-of-tree PWDs. in lieu of an upstream fix let's try our best to get the correct coverage directory set. without this hack no results get recorded unfortunately.
2019-03-18redo service menu ruby helpers from ground up more or lessHarald Sitter
Summary: - apply ruby community style guidelines - full rewrite fixing, among other things: - inefficient/unreadable String#end_with reimplementation - inefficient use of Kernel.system (forked shell to fork a shell) - inefficient/unreadable Dir.glob reimplementation - inefficient File initialization for single chmod - invocation conditions are now actually readable - invocation conditions now also force +x on argless scripts, not just scripts that need arguments - repetitive conditions are now expressed as loops on argument arrays - mime detection now uses xdg-mime instead of file (xdg-mime internally may fall back to mime but will prefer higher level tools such as kmimetypefinder5; giving better results overall) - return values of "backtick forks" are now checked and will produce suitable errors on stderr - fail now takes a log_msg argument which is printed to stderr. this is in addition to the error raised as notification for the user, as that is unfortunately not so useful for diagnostics - overall error handling and logging of problem causes is much improved - add license headers. the original code was actually fairly exhaustive, so this really should have had a header to begin with. the code was originally introduced in svn r1045663 on Nov 6 14:56:35 2009 UTC - add blackbox tests. in the interest of keeping the scripts actually simple scripts (as opposed to a bunch of classes used by even simpler scirpts) they are now also covered by test rigging which runs them as scripts (again, as opposed to individual unit testing of distinct units) - the tests optionally can use simplecov to gather coverage metrics - also wired up to ctest so it actually gets run structurally there is actually a fair amount of overlap between the two scripts, but again, in the interest of keeping things simple I think it's better to live with that instead of refactoring a shared library out of it and then use heavy-duty meta-programming Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19334
2019-03-17When the previewed video stops playing (because of the user or because the ↵Méven Car
media playback has ended), show the regular preview only if the preview setting is on. Summary: Bug result after test plan : {F6698812} Test Plan: In dolphin with the information panel Select a video Play the video Disable the preview through the context menu (the video stays playing and visible and this will get fixed in a subsequent review) Stop the video -> the video preview reappears when it should not Reviewers: elvisangelaccio Reviewed By: elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19843
2019-03-17Fix a todo: InformationPanelContent::configureSettings code is moved to ↵Méven Car
InformationPanel::contextMenuEvent Summary: Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent Adding necessary accessors and changing visibility of one slot. Test Plan: 1 compile 2 in dolphin right on the information panel 3 toggle preview 4 from the same context menu, click configure, metadadata settings appears 5 toggle "condensed date" if available Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19832
2019-03-17Fix "Add Network Folder" tooltip icon does not show on Breeze, shows ↵David Hallas
correctly on Breeze Dark Summary: Fix "Add Network Folder" tooltip icon does not show on Breeze, shows correctly on Breeze Dark. The fix is taken from D19596. Test Plan: Open Dolphin with the Breeze theme Hover the mouse over the "Add Network Folder" The icon is black on black BUG: 404858 Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio, ngraham Subscribers: broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19738
2019-03-17Fix crash at shutdown after showing a tooltipDavid Hallas
Summary: Fix crash at shutdown after showing a tooltip. The commit 94d7e1471e0a81b72285795ad91c4f6196157ae4 introduced a crash that occurs when closing Dolphin after Dolphin has showed a tooltip. This happens because the ToolTipManager::showToolTip function calls the KToopTipWidget::showBelow function passing in the pointer to the DolphinFileMetaDataWidget. But this also passes the ownership of the pointer to the KToopTipWidget as long as a new tooltip is not shown. The problem is that at shutdown, the KToopTipWidget instance will be destoyed first and therefore also destroy the DolphinFileMetaDataWidget instance (which the ToolTipManager still owns through the QScopedPointer) causing it to be deleted twice. The fix for this is simply to swap the order of these two members so that the DolphinFileMetaDataWidget is destroyed first by the QScopedPointer thereby removing it from the KToopTipWidget if it has been set as it's parent. Test Plan: Open Dolphin Show a Tool Tip Close Dolphin Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19737
2019-03-17Make global view properties the default settingElvis Angelaccio
Summary: Automatic creation of .directory files is one of the most complained about things in dolphin. These days applications are supposed to store application-specific data within $XDG_DATA_HOME. Long-term that's the proper solution for this issue, but for now we can at least flip the default so that we no longer create .directory files out of the box. A tooltip is also added as a kind of warning for the users who want to change the setting. Ideally a proper warning should be shown using a KMessageWidget or KMessageBox, but neither play too well with the setting dialog workflow used by dolphin. CCBUG: 322922 Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19661
2019-03-12Correctly position context menu of the information panel under wayland with ↵Méven Car
a secondary screen Summary: According to my testing this bug occurs because Qcursor::pos() does not work as expected under wayland on a secondary screen, then it returns inaccurate data. This could hide bugs elsewhere. BUG: 404799 FIXED-IN: 19.04.0 Test Plan: Under Wayland test the context menu on both screens. Do the same under Xorg. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, ngraham, nicolasfella, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19535
2019-03-10Fixes leak of DolphinFileMetaDataWidget in ToolTipManagerDavid Hallas
Summary: Fixes leak of DolphinFileMetaDataWidget in ToolTipManager. The destructor of ToolTipManager failed to delete the m_fileMetaDataWidget member. This is seen at shutdown but also when you close a tab that has displayed a tooltip. Test Plan: Compile Dolphin with address sanitizer Open Dolphin Show a tooltip Close Dolphin Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19485
2019-03-10[FoldersPanel] Stop ignoring positions from the controllerElvis Angelaccio
This fixes the position of Folder panel's context menus on multi-screens on Wayland, because `QCursor::pos()` is not reliable on those setups.
2019-03-10[FoldersPanel] Don't show 'Limit to Home Directory' in the view context menuElvis Angelaccio
The `viewContextMenuRequested` signal is emitted without a valid KFileItem, so `m_fileItem` will always be null in `TreeViewContextMenu::open()`.
2019-03-10Fix clazy-fully-qualified-moc-types warningElvis Angelaccio
Slot arguments should be fully-qualified.
2019-03-10port to std::stable_sortLaurent Montel
2019-03-09Fix context for QDateTime::toString() translationsElvis Angelaccio
Summary: The documentation of QDateTime::toString() says that: Any sequence of characters that are enclosed in single quotes will be treated as text and not be used as an expression. This means that translators cannot replace single quotes with other characters such as «...». This is now described in the context of the affected strings. We also check that the translated string contains exactly 2 single quotes, and we use the untraslated string otherwise. BUG: 401382 Reviewers: lueck, aacid, cfeck Subscribers: ltoscano, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D18769
2019-03-09New tab placed after current tab when middle-clickingDavid Hallas
Summary: New tabs should be placed after the currently active tab when using middle click. Test Plan: Open new tab from the places panel using middle click, verify that the Open new tab from the folders panel using middle click, verify that the tab is opened after the current tab Open new tab by middle clicking on the Back button, verify that the tab is opened after the current tab Open new tab by middle clicking on the Forward button, verify that the tab is opened after the current tab FEATURE: 403690 Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19201
2019-03-06Improve wording of split view/pane settingsSimon Depiets
Summary: I found these strings very hard to understand then translate without looking into the code because the use of "view" refers to both "the split view" and "the left pane and the right pane of the split view". This patch attempts to explicitly mention panes when needed. Reviewers: #dolphin, angeloevertonjr, ngraham Reviewed By: #dolphin, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19579
2019-03-01Use new display string function from KFileMetaDataAlexander Stippich
Summary: Delete all the custom formatting functions and use the ones provided from KFileMetaData. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: bcooksley, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19105
2019-02-27remove deprecated methodsLaurent Montel
generated by cgit v1.3 (git 2.53.0) at 2026-04-23 14:14:20 +0000