┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2018-12-12GIT_SILENT made messages (after extraction)l10n daemon script
2018-12-10Add an icon for "restore" actionShubham Jangra
Summary: Before: {F6469103} After: {F6469104} Test Plan: 1. Go to Trash 2. Right click any item. Reviewers: ngraham Reviewed By: ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17490
2018-12-10Revert backShubham Jangra
2018-12-10Add an icon for "restore" actionShubham Jangra
Summary: Before: {F6469103} After: {F6469104} Test Plan: 1. Go to Trash 2. Right click any item. Reviewers: ngraham Reviewed By: ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17490
2018-12-07Remove unused parameter warningShubham Jangra
2018-12-06[context menu] Restore separator above 'Properties' that went missingNate Graham
2018-12-04Merge branch 'Applications/18.12'Elvis Angelaccio
2018-12-03KItemListWidget: Use initStyleOptionAnton Kreuzkamp
Instead of using QStyleOption::initFrom, let's use QGraphicsWidget::initStyleOption, which is made for exactly the purpose of KItemListWidget. This is especially important since, according to the docs of QGraphicsItem::paint "The widget argument is optional. [...] For cached painting, widget is always 0.". Even though currently no code in dolphin does cached painting, for the sake of modularity one should not rely on widget to be non-null. Using QStyleOption::initFrom does assume that, though. In fact, GammaRay asks the items to do cached painting when attaching it to the application, causing it to crash.
2018-12-02[PlacesPanel] Fix unused variable warningElvis Angelaccio
2018-12-02[KItemListController] Make event-handling functions privateElvis Angelaccio
There is no reason why these event-handling custom functions should be public, so make them private instead.
2018-12-02[KItemListController] Drop virtual keywordsElvis Angelaccio
We are never overriding these functions, so there is no reason to declare them virtual.
2018-12-02[KItemListController] Drop unused functionsElvis Angelaccio
2018-12-01Merge remote-tracking branch 'origin/Applications/18.12'Thomas Surrel
2018-12-01Fix selection when navigating back, with size sorting.Thomas Surrel
Summary: KItemListSelectionManager::itemsMoved (called when sorting by size) was re-activating anchor selection regardless if we actually were doing an anchored selection. This was leading to an incorrect selection when navigating back. BUG: 352296 Test Plan: In any folder, sort by size then move to a subfolder. Navigate back to the parent folder: only the parent folder should be selected. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17042
2018-12-01Do not sort twice when changing role and order at the same timeThomas Surrel
Summary: When using the list header to change the role and order, if one changes the order to descending and then changes role, dolphin also changes the order back to ascending. This results in sorting the list of files twice in a row. This patch removes the first (useless) sort. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17111
2018-11-30Use isEmpty here tooLaurent Montel
2018-11-30Use isEmpty() hereLaurent Montel
2018-11-29GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-29GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-24[PlacesPanel] Port to KFilePlaceEditDialogElvis Angelaccio
Summary: This patch ports away from the old PlacesItemEditDialog copy, which doesn't honour the "applicationLocal" checkbox. KFilePlaceEditDialog was not exported by KIO, but it will be starting from 5.53 BUG: 376619 FIXED-IN: 19.03.80 Test Plan: * Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox * Edit an existing (global) place and check the "only show in dolphin" checkbox Reviewers: #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16824
2018-11-21Avoid warning when translatedtext is nullLaurent Montel
2018-11-21GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-21GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-20GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-20GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-19Show the Delete context menu entry even when disabledThomas Surrel
Summary: This is consistent with the HIG, and the 'Rename' entry in the context menu already behaves like that. Test Plan: Right click on /home. The context menu should contained the 'Delete' entry, but it should be disabled. Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: ngraham, romangg, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17012
2018-11-17Merge remote-tracking branch 'origin/Applications/18.12'Thomas Surrel
2018-11-17Do not disconnect all StorageAccess signals when unmountingThomas Surrel
Summary: The problem is caused by the fact device interfaces returned by Solid (e.g. item->device().as<Solid::StorageAccess>()) are not full objects, but only references/pointers to a per-device-object, i.e. requesting the same interface for a device will return the same address every time. If the interface is used used in multiple places, calling disconnect on the interface address disconnects the signals for all users. BUG: 400992 Test Plan: In Dolphin, mount a local partition (e.g. a Windows partition) then unmount it (right click on it in Places, then Unmount). Try to access it again by clicking on it in Places, we should get access to it correctly. Reviewers: #dolphin, #frameworks, bruns, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16857
2018-11-17Merge remote-tracking branch 'origin/Applications/18.12'Chris Rizzitello
2018-11-17Improve Ux for the places panel's hidden itemsChris Rizzitello
Summary: BUG: 400860 FIXED-IN: 18.12.0 Clean up the context menu for the places panel. - Change Text "Show All Entries" -> "Show Hidden Places" - Use State dependent icon (like hidden files) - Disable instead of hide if not places are hidden. - Toggle to unchecked if last item of group is unhidden. Create a copy of this "Show Hidden Places" entry in the main dolphin menu View->Places. Test Plan: With Hidden Places {F6398756} {F6398759} Context Menu: {F6398762} {F6398761} Without Hidden Places. {F6414694} {F6414696} Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham Reviewed By: #dolphin, #vdg, elvisangelaccio, ngraham Subscribers: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel Tags: #dolphin Maniphest Tasks: T8349 Differential Revision: https://phabricator.kde.org/D16767
2018-11-17Merge branch 'Applications/18.12'Harald Sitter
2018-11-17move kcrash link to dolphin app (which is the effective user)Harald Sitter
Summary: to successfully use kcrash when linking with as-needed (which is a default flag on many linux distros) one also needs to call KCrash::initialize. this call happens in the app's main.cpp. as such the kcrash link target on the dolphinprivate library doesn't do anything for dolphinprivate but only kicks into action for dolphin itself. to avoid confusion and make it clear that kcrash is only initialized in the application scope the KF5::Crash link target is now on the application target, not the library target. (this makes no difference in the output, kcrash was still correctly linked via dolphinprivate; but only for kdeinit_dolphin, dolphinprivate did not get linked to it with as-needed) Test Plan: builds; links as expected Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16896
2018-11-16GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-16GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-14GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-13GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-11[PlacesItem] Add support for OnlyInApp metadata for bookmarksElvis Angelaccio
This will allow to edit an existing place to make it application-local or visible from all applications. CCBUG: 376619
2018-11-11[PlacesItemModel] Match KFilePlacesModel addPlaces() APIElvis Angelaccio
This will allow to create a place visible only from Dolphin, by passing an `appName` to the KFilePlacesModel. CCBUG: 376619
2018-11-11Update copyright year in KAboutDataElvis Angelaccio
GIT_SILENT
2018-11-08Warn user before renaming the file/folder to start with a ' . 'Shubham Jangra
Summary: For normal "casual" linux users, renaming the file/folder starting with dot may get irritating, they will be wondering their file is deleted. Test Plan: 1. Make new file/folder. 2. Rename it to .foo 3. Question dialog appears. Reviewers: elvisangelaccio, ngraham, pino Reviewed By: elvisangelaccio, ngraham Subscribers: cfeck, emateli, elvisangelaccio, pino, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15980
2018-11-08Add donation url to appdataAlbert Astals Cid
2018-11-05GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-04Update maintainership in KAboutDataElvis Angelaccio
As discussed on kfm-devel and agreed upon with Emmanuel.
2018-11-04GIT_SILENT made messages (after extraction)l10n daemon script
2018-11-02Autogenerate debug file + install debug categories fileLaurent Montel
2018-11-01GIT_SILENT made messages (after extraction)l10n daemon script
2018-10-28GIT_SILENT made messages (after extraction)l10n daemon script
2018-10-27Merge branch 'Applications/18.08'Elvis Angelaccio
2018-10-27Don't enable two-clicks renaming in single-click modeElvis Angelaccio
Summary: This was supposed to be part of commit 5454283008f2, but apparently we didn't notice it was missing. Test Plan: - Enable single-click mode from system settings - Select a file in dolphin - Long-click the selected file and make sure inline renaming doesn't start Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16460
2018-10-27Adjust label in the settings page for changed preview behaviourFabian Vogt
Summary: Requested by https://phabricator.kde.org/D15138#318904 Test Plan: Opened the preview settings, label text changed. Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: ngraham, markg, broulik, kfm-devel, elvisangelaccio Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15216