| Age | Commit message (Collapse) | Author |
|---|
|
Same result with less code.
|
|
Otherwise the test executable will not be able to find the .rc file
while creating a DolphinMainWindow instance.
We also need to force the component name to `dolphin`, otherwise kxmlgui
will default to the name of the binary (which in this case would be
dolphinmainwindowtest rather than dolphin).
|
|
We deactivate the previously active view container whenever we change the active
split view, but we never do the same when we close the split view.
Long term we should probably even delete the secondary view after
closing the split view, because it will never be used again and the
pointer will be overwritten the next time the user opens the split view.
|
|
|
|
Summary:
In dolphintabpage.cpp:
Through the connections set up in createViewContainer(), m_primaryViewContainer->setActive(true), at line 98,
ends up triggering slotViewActivated().
Because m_primaryViewActive is true, oldActiveView is not set to the view needed in this particular situation.
Both oldActiveView and newActiveView end up pointing to the same view and the connections are not set up.
BUG: 385111
FIXED-IN: 18.04.1
Test Plan:
1. Open split view
2. Make left panel active
3. Close split view
4. Navigate to various directories
Window title now updates to show current directory
Also tried with multiple tabs/combinations
Reviewers: #dolphin, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: elvisangelaccio, ngraham
Differential Revision: https://phabricator.kde.org/D12446
|
|
Will be fixed by D12446.
CCBUG: 385111
|
|
Summary:
This patch moves the "Open", "Open With", and "Open in" items to the top of the context menu to reap the following benefits:
- Move the "Open" and "Open With" items closer to the top since they're commonly used items, and right now they're buried in the middle of the menu
- Group related functionality
- Consistency with other common platforms (macOS Finder and Windows Explorer both have these items at the top of the context menu)
For folders, the "Open With" entries are moved higher, but not all the way to the top, since the "open in New tab/folder" entries are more useful.
Test Plan:
Tested all menu items in the context menu for files, folders, and links; all still work.
Context menu for single file:
{F5806809}
Context menu for multiple files:
{F5806810}
Context menu for single folder:
{F5806811}
Context menu for multiple folders:
{F5806812}
Context menu for symlink to folder:
{F5806815}
Reviewers: #dolphin, #vdg, elvisangelaccio, abetts
Reviewed By: #dolphin, #vdg, elvisangelaccio, abetts
Subscribers: markg, abetts, elvisangelaccio
Differential Revision: https://phabricator.kde.org/D11884
|
|
|
|
in Icon mode
Summary:
Dolphin had some code to change the grid spacing when previews were toggled, in an attempt to optimize the view for 3:2 landscape photos. This was problematic for many reasons:
- Conceptually, it was a bad idea to optimize the view for one specific use case. Previews are useful for more than just landscape photos, and this optimization would be inapplicable to any other set of files.
- Folders entirely full of images commonly have some portrait-orientation images included too, so even if the goal were appropriate, it was a bad idea to optimize for only having landscape images.
- For small sizes and medium icons (< 96px), the preview grid size was virtually identical to the non-preview grid size, so it had essentially no effect, and only made the icons wiggle strangely when previews were toggled.
- For large large sizes (>= 96px), all it did was unnecessarily increase the horizontal grid spacing, actually //reducing// usability for browsing through folders of images.
Therefore, let's just remove this code.
BUG: 393306
FIXED-IN: 18.04.1
Test Plan:
- Go to {nav Settings > View Modes > Icons} and make the icon size and preview size identical for 64px
- Toggle previews on and off
- Change both sizes to 112x
- Toggle previews on and off
In both cases, the grid spacing does not change and the icons do not wiggle strangely. The only visual change is that previews turn on or off.
Dolphin still works fine for viewing 3:2 landscape photos. 80px icons:
{F5813467}
192px icons:
{F5813465}
In fact, it's vastly //improved// for the >=96px use case since the grid spacing is no longer excessively wide
Reviewers: #dolphin, hein
Reviewed By: hein
Subscribers: broulik
Differential Revision: https://phabricator.kde.org/D12362
|
|
Test Plan: Check all changed shortcuts on all platforms.
Reviewers: #dolphin, rizzitello, elvisangelaccio
Reviewed By: #dolphin, rizzitello, elvisangelaccio
Subscribers: anthonyfieroni, ngraham, elvisangelaccio, rizzitello, #dolphin
Differential Revision: https://phabricator.kde.org/D11048
|
|
|
|
Load the places panel entries strings from the kio5 catalog, where they live now
BUG: 392822
Differential Revision: https://phabricator.kde.org/D12119
|
|
Summary:
Let user choose date display format via checkbox in context menu
[[ https://phabricator.kde.org/file/info/PHID-FILE-5xjr7tvypj3jaczjtzrz | Example ]]
Depends on D11242
FEATURE: 392352
Test Plan: visual inspection
Reviewers: #dolphin, markg, ngraham
Reviewed By: markg, ngraham
Subscribers: broulik, markg, ngraham
Tags: #dolphin, #kde_applications
Differential Revision: https://phabricator.kde.org/D11245
|
|
operations
Summary:
After performing a search and using the "Open path" or "Open Path in New Window" present in the context menu, make sure the file is selected and visible in the resulting view.
Cannot implement the same fix for "Open Path in New Tab" because of a limitation in how the contents of inactive tabs are rendered; will need to fix that separately in another patch.
BUG: 377510
Test Plan: Search for an item, and choose {nav Open Path} or {nav Open path in new window}
Reviewers: #dolphin, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: elvisangelaccio, broulik
Differential Revision: https://phabricator.kde.org/D11703
|
|
Summary: These new functions to access the next and previous tabs are not used by anything yet, but it is envisioned that they would be useful for a variety of purposes--such as the "open path in new tab" feature from D11703
Test Plan: Dolphin still compiled and runs; new code is not actually used anywhere
Reviewers: #dolphin, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Differential Revision: https://phabricator.kde.org/D12039
|
|
Summary:
This patch basically adds the check that would normally be done to the
itemInserted method, which seems to be good idea in general.
However, the fact that this is needed there might be an indicator of a logic bug
in the function – though, as I'm not familiar with the code base I cannot judge
this.
Test Plan:
Without this patch, dolphin when started from a terminal prints the following
warning (number can be different):
qt.accessibility.core: Cannot create accessible child interface for object: PlacesView(0x563e863e35c0) index: 10
After applying the patch, the warning doesn't appear anymore. Dolphin still
works still as it did before.
Reviewers: elvisangelaccio, #dolphin
Reviewed By: elvisangelaccio
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D11990
|
|
|
|
Summary:
We are asking the users whether they are sure they want to quit.
But the "Quit" button can be ambiguous (am I quitting dolphin or just
this dialog?). If we use a "Quit Dolphin" button instead, that clearly
shows what will happen after triggering the action.
Test Plan: Close dolphin while multiple tabs are open.
Reviewers: #dolphin
Differential Revision: https://phabricator.kde.org/D11892
|
|
Summary:
`m_spinBox` is initialized only when renaming multiple items.
This commit restores the single-item rename logic which was wrongly
removed by commit c5eb4e31161ccf422.
BUG: 392743
FIXED-IN: 18.03.90
Test Plan: Disable inline renaming and try to rename single or multiple items (and also to undo the jobs).
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D11972
|
|
Summary:
informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug.
BUG: 392621
FIXED-IN: 18.08.0
Test Plan:
Before:
{F5782793}
After:
{F5782794}
Detailed test procedure:
- Open the Information Panel
- Turn on previews
- Put some pictures in ~/Pictures
- Hover over it and see that the Information Panel shows a preview of its contents
- Add ~/Pictures to the Places panel
- Hover over it again and see that previews are no longer displayed
- Apply the patch and restart Dolphin
- Hover over it once more and see that there are now previews, yay!
Reviewers: #dolphin, markg, elvisangelaccio
Reviewed By: markg, elvisangelaccio
Subscribers: markg, broulik
Differential Revision: https://phabricator.kde.org/D11894
|
|
|
|
Otherwise it just crashes when trying to open the terminal panel
BUG: 392660
Differential Revision: https://phabricator.kde.org/D11904
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Summary:
This patch splits the single property "Image Size" into "Width" and "Height", providing more fine-tuned control for power users.
FEATURE: 374559
Test Plan:
- Sorting works correctly
- No real change, only exposed differently
Reviewers: #dolphin, elvisangelaccio, ngraham
Reviewed By: #dolphin, elvisangelaccio, ngraham
Subscribers: ngraham, elvisangelaccio
Differential Revision: https://phabricator.kde.org/D11816
|
|
|
|
As recommended by the clazy qmap-with-pointer-key check.
|
|
As recommended by the clazy qstring-ref check.
|
|
Summary:
Adjust calculation of icon pixmap Y value; now based off center of text label bounding rectangle. Previously, icons appeared top-aligned when text size was larger than icon size.
Centering is done by obtaining the center point of the text frame (`m_textRect.center().y()`) and setting the top `Y` point of the icon to one-half of the scaled icon height (`m_scaled_PixmapSize.height()`) Division is done by `2.0`, to ensure calculations are done with floating-point math, in keeping with `QPointF`, which returns floating-point values.
Also includes an adjustment named `midlineShift` (contributed by @zzag), which takes into account the font's midline in respect to the center of the text frame. Certain fonts (i.e. Noto Sans) can have a slightly offset midline, resulting in imperfect alignment of the icon. This small adjustment resolves that potential issue.
See before and after screenshots.
{F5764918}
Before, showing misalignment (with and without debugging wireframes)
{F5764920}
After, showing correction
BUG: 390771
Test Plan:
-- Compile Dolphin with patch
-- Increase system font size by several points (i.e. 15pt)
-- Check that Places panel icons remain centered with the text label
-- Select Compact View mode
-- Adjust icon size slider to minimum
-- Ensure that icons also remain centered in file listing
-- Check several combinations of icon size & font size to ensure centering is consistent
Reviewers: #dolphin, ngraham, cfeck, elvisangelaccio
Reviewed By: #dolphin, ngraham, elvisangelaccio
Subscribers: zzag, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D11650
|
|
|
|
We were comparing a value of type `KStandardItemListView::ItemLayout`
with values of type `KStandardItemListWidget::Layout`.
|
|
emitting a change
This avoids work being done when it doesn't need to be.
For instance, the preview generator waits for everything to have settled using a 200ms timer before generating a preview.
This timer fired also in response to onStyleOptionChanged and needlessly delayed preview generation when navigating between folders
despite the style option (e.g. icon size, view mode) not having changed.
Differential Revision: https://phabricator.kde.org/D11481
|
|
The desktop file name changed to org.kde.dolphin a long time ago. To avoid this breaking again, just use qApp->desktopFileName()
BUG: 391997
Differential Revision: https://phabricator.kde.org/D11540
|
|
|
|
Summary: https://cgit.kde.org/dolphin.git/commit/?id=86f4fcb8cd574f6d886627fc5e01c9edfc84e977 introduced a regression: the context menu for links no longer shows various items that were gated behind being a directory. However, a link can be both a link and a directory, from KIO's perspective. This patch resolves the issue.
Test Plan:
- Context menus for files, folders, and file links are unchanged.
- The missing context menu items for folder links have returned: {F5761809}
I should have tested that patch better, and for that I apologize and offer to fix this regression here. I will endeavor to up my reviewing game.
Reviewers: rominf, michaelh, #dolphin, rkflx
Reviewed By: rominf, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D11562
|
|
The desktop file name changed to org.kde.dolphin a long time ago. To avoid this breaking again, just use qApp->desktopFileName()
BUG: 391997
Differential Revision: https://phabricator.kde.org/D11540
|
|
|
|
There are various places where Dolphin created a new KFilePlacesModel which would then query all storage devices and do other expensive work.
Differential Revision: https://phabricator.kde.org/D11283
|
|
Summary:
Add "Show Target" into symlink context menu and file menu
FEATURE: 215069
Reviewers: ngraham, elvisangelaccio
Reviewed By: ngraham, elvisangelaccio
Subscribers: rkflx, ngraham, elvisangelaccio, markg, #dolphin
Differential Revision: https://phabricator.kde.org/D10990
|
|
Summary:
Show "Empty Trash" button inside trash directory.
FEATURE: 163306
Test Plan: {F5734949}
Reviewers: ngraham, rkflx, markg, elvisangelaccio
Reviewed By: ngraham, markg, elvisangelaccio
Subscribers: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D10804
|
|
Summary:
This is not complete. I'm wondering about "Open symlink destination folder in new tab/window".
Feature wants also "Copy symlink destination". I dislike this, because then it's good to have "Cut symlink destination" and that's too much.
FEATURE: 215069
Reviewers: #dolphin, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: rkflx, ngraham, elvisangelaccio, markg, #dolphin
Differential Revision: https://phabricator.kde.org/D10990
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Summary:
Show a message if Konsole part is not installed
BUG: 371822
FIXED-IN: 18.04.0
{F5749731}
Reviewers: ngraham, progwolff, elvisangelaccio
Reviewed By: ngraham, progwolff, elvisangelaccio
Subscribers: rkflx, ngraham, elvisangelaccio, broulik, progwolff, #dolphin
Differential Revision: https://phabricator.kde.org/D11118
|
|
Summary:
After restoring all the files from the trash, the trash icon remain 'full'. This patch fixes this.
BUG: 252483
Reviewers: elvisangelaccio
Reviewed By: elvisangelaccio
Subscribers: elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D11216
|
|
|
|
Forgot to mention it while reviewing D11012.
|
|
Summary: Add `Trash` class to handle all trash operations.
Reviewers: elvisangelaccio, markg, ngraham
Reviewed By: elvisangelaccio, markg, ngraham
Subscribers: ngraham, markg, rkflx, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D11012
|
|
Reviewers: markg, elvisangelaccio
Reviewed By: markg, elvisangelaccio
Subscribers: chehrlic, rkflx, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10995
|
|
That include IS used
|
|
This reverts commit 533f050855a50212bba7be57a1590f9ce743e26d.
D10995 has not been approved.
|
