┌   ┐
54
└   ┘

summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2017-09-11Add "Open in New Window to Dolphin's places context menuNathaniel Graham
Summary: BUG: 384352 Add an "Open in New Window" menu item to the context menu for Dolphin's places items. Test Plan: Tested in up-to-date KDE Neon. Works as expected: {F3898707} Reviewers: #dolphin, #kde_applications, dfaure, aacid, elvisangelaccio, emmanuelp, broulik Reviewed By: #dolphin, emmanuelp, broulik Subscribers: alexeymin, emmanuelp, broulik, sefaeyeoglu, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D7690
2017-09-12Qt 5 Porting: Q_WS_WIN -> Q_OS_WINBen Cooksley
2017-09-07Fix DolphinRemoveAction Shift toggling on WaylandElvis Angelaccio
QGuiApplication::queryKeyboardModifiers() does not work on Wayland [1]. We don't need it in the first place, since we already know (thanks to the key events) whether Shift has been pressed or released. So we can just pass this information to DolphinRemoveAction::update(). BUG: 354301 [1]: https://bugreports.qt.io/browse/QTBUG-62786 Differential Revision: https://phabricator.kde.org/D7519
2017-09-01Limit folder panel to home directory if inside homeRobert Hoffmann
Summary: Added the option to limit the displayed folders in the folder panel (F7) to the tree below the user's home directory if the current URL is inside the home directory. This can be configured in the preferences General/Behaviour tab by checking the corresponding check box. Reviewers: #dolphin, elvisangelaccio, emmanuelp Reviewed By: #dolphin, elvisangelaccio, emmanuelp Subscribers: emmanuelp, elvisangelaccio, #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D7477
2017-08-29Prefer place name over actual name in title barKai Uwe Broulik
When inside a place, the address bar already gives it precedence over the actual folder name. By doing this in the title bar also, we make it consistent and can mask ugly technical terminology like "trash:/" and instead show the nice localized "Trash" place name as well as "Home" instead of lowercase internal user name. BUG: 211959 Differential Revision: https://phabricator.kde.org/D4826
2017-08-27Add Genre to additional information for audio files. Fixes T5599Francisco Navarro Morales
Summary: I have just imitated the code that made this funcionality for artist and album additional information for audio files. Reviewed By: #dolphin, emmanuelp CCBUG: 374558 Differential Revision: https://phabricator.kde.org/D7215
2017-08-25[AdditionalInfoDialog] Prevent hiding "text" roleKai Uwe Broulik
You cannot do this from the menu but the option was there (but ignored) in the "View Properties" dialog. BUG: 302622 Differential Revision: https://phabricator.kde.org/D7386
2017-08-24Port to new KStandardAction slot syntaxElvis Angelaccio
For more compile-time safety.
2017-08-24Support middle clicking of Back/Forward/Up/Home toolbar buttonsKai Uwe Broulik
This opens the resulting page in a new tab. BUG: 358649 Differential Revision: https://phabricator.kde.org/D7390
2017-08-23Fix typo in udi stringChristoph Feck
Spotted by Chris Holland. BUG: 383182
2017-08-10GIT_SILENT made messages (after extraction)l10n daemon script
2017-08-09Drop duplicate i18n stringsElvis Angelaccio
This comment (introduced in commit 39f89141b06c) no longer seems to apply, so drop the duplicate translations and just use the default strings from kconfigwidgets. Differential Revision: https://phabricator.kde.org/D6779
2017-08-09Port to KStandardAction::RenameFileElvis Angelaccio
It was introduced in kconfig(widgets) 5.25. Using the standard action results in less code and no need to hardcode the F2 shortcut. Differential Revision: https://phabricator.kde.org/D6777
2017-08-03Port to KHelpMenuElvis Angelaccio
Less code and KHelpMenu respects KIOSK restrictions. Differential Revision: https://phabricator.kde.org/D7095
2017-07-28Merge branch 'Applications/17.08'Elvis Angelaccio
2017-07-28Fix loading of dolphinui.rcElvis Angelaccio
dolphin.qrc is compiled into a static library, which means we need to force its loading with the Q_INIT_RESOURCE macro. See http://doc.qt.io/qt-5/resources.html#using-resources-in-a-library BUG: 382848 FIXED-IN: 17.07.90 Differential Revision: https://phabricator.kde.org/D6958
2017-07-28Merge branch 'Applications/17.08'David Edmundson
2017-07-28Use https for knsrc providersDavid Edmundson
CCBUG: 382820
2017-07-27Port to KStandardAction::MoveToTrashElvis Angelaccio
It was introduced in kconfig(widgets) 5.25. Using the standard action results in less code and no need to hardcode the Del shortcut. Test Plan: - Change shortcut in System Settings -> Shortcuts -> Standard Shortcuts - Make sure the new shortcut is used by dolphin. Differential Revision: https://phabricator.kde.org/D6778
2017-07-27Merge branch 'Applications/17.08'Elvis Angelaccio
2017-07-27Fix drop menu position with urlnavigator dropsElvis Angelaccio
Commit 1e251d2f6a in kio broke drop menus when dropping on the URL navigator (menus show up in the DolphinView rather than the URL bar). This happens because in DolphinView::dropUrls() we set `this` as the widget passed to KJobWidgets::setWindow() (in DragAndDropHelper::dropUrls()). We need to replace `this` with the actual widget that received the QDropEvent and that can mapToGlobal() the relative pos of the drop event. Unfortunately this widget is not KUrlNavigator itself, but one of its KUrlNavigatorButton children (private class, not exported). So unfortunately we need a new API in KIO that exposes this child widget. Differential Revision: https://phabricator.kde.org/D6684
2017-07-25Bundle the XMLGUI files into qrc resources.David Faure
This is a step towards being able to run applications uninstalled, and it simplifies deployment on non-linux.
2017-07-21Don't add null widget to layoutElvis Angelaccio
m_expandableFolders is created only in DetailsMode. This fixes a QLayout runtime warning.
2017-07-21Fix layout warningElvis Angelaccio
This fixes the following warning: QLayout: Attempting to add QLayout "" to PreviewsSettingsPage "", which already has a layout `topLayout->addLayout(fileSizeBoxLayout)` takes ownership of `fileSizeBoxLayout`, so there is no reason to use `this` as parent.
2017-07-18Add role for file creation time.Tobias C. Berner
Summary: At least on FreeBSD UFS and ZFS support birthtimes of files. Reviewers: #freebsd, #dolphin Subscribers: #konqueror Differential Revision: https://phabricator.kde.org/D6243 (cherry picked from commit d8061b4d9e04ec940ee33feae5f60f26bffc97b1)
2017-07-18Add role for file creation time.Tobias C. Berner
Summary: At least on FreeBSD UFS and ZFS support birthtimes of files. Reviewers: #freebsd, #dolphin Subscribers: #konqueror Differential Revision: https://phabricator.kde.org/D6243
2017-07-13Fix knewstuff popup menu position on waylandElvis Angelaccio
On Wayland we need to pass a parent to popup menus. See https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Popup_Menus So we use the new setParentWidget() method from KNewStuff (introduced in Frameworks 5.37).
2017-07-13Add missing emit keywordsElvis Angelaccio
GIT_SILENT
2017-06-27[Places Panel] Disallow editing devicesKai Uwe Broulik
I introduced this bug when I changed the layout of the menu. While it would be nice if one could edit devices, it is currently not possible and would require significant re-engineering effort in Solid. While the "Edit" menu works just fine, changes are not persisted. Reviewed-By: emmanuelp Differential Revision: https://phabricator.kde.org/D6294
2017-06-20Support "Deletion Time" role in TrashKai Uwe Broulik
This allows to sort by and show (both as additional data in icon view and column in column view) deletion date of files in Trash. CHANGELOG: It is now possible to view and sort by "Deletion Time" in Trash BUG: 153492 FIXED-IN: 17.08.0 Differential Revision: https://phabricator.kde.org/D6269
2017-06-11Merge branch 'Applications/17.04'Elvis Angelaccio
* Applications/17.04: Change in "Open in new tab" feature in Dolphin Ignore drops-onto-items from invalid places items Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"
2017-06-11Change in "Open in new tab" feature in DolphinEmirald Mateli
Summary: This patch proposes a change to the "open in new tab" feature. The "open in new tab" feature will try to open selected items (files or folders) in a new tab, however, if there are no valid items to be opened in a new tab then nothing will happen, making it look like a bug. This patch adds the functionality that when there are no valid items(files or folders) to be opened in a new tab the current folder will be opened. Test Plan: 1. Select a file(pdf, text, image etc) in Dolphin 2. Click on the "Open in new tab" toolbar button Expected: since the file is not a valid target to open in a new tab, the current directory should be opened (as is the case where selection is empty) Actual: Nothing happens after the button is pressed Reviewed By: #dolphin, elvisangelaccio Differential Revision: https://phabricator.kde.org/D6182
2017-06-11Ignore drops-onto-items from invalid places itemsElvis Angelaccio
If the QMimeData object created by PlacesItemModel doesn't have any url set (e.g. when dragging unmounted devices), it is detected by the resulting DropJob as "drop raw data" because the mimeData has one format set (the internalMimeType() used for dragging between places items). This results in a crash because the DropJob schedules a PasteJob, but in the meantime the QDrag from Dolphin ends and deletes the mimeData object that was passed to the paste job. The fix is to prevent the DropJob in the first place. We can introduce a new internal mimetype that we use to blacklist drops-onto-items (while still allowing drops-between-items). This way PlacesItemModel can set the blacklist flag if the mimeData is being created without urls. BUG: 373005 FIXED-IN: 17.04.3 Test Plan: Drag and drop an unmounted device to another place item or the DolphinView, doesn't crash anymore. Dropping the unmounted device between two places item still works. Differential Revision: https://phabricator.kde.org/D5535
2017-06-06Drop unnecessary methodElvis Angelaccio
2017-05-31Revert "Increase smooth scrolling animation duration from 100 to 300 ms and ↵Elvis Angelaccio
set easing curve to InOutQuart" This reverts commit 58c5eae1953bbdcf6d4150b21cb7ffdad07a5257. Reasons against this change: 1. Scroll is now too fast with devices such as touchpads or trackpoints. 2. Scroll behavior is now inconsistent between Dolphin and other applications (e.g. the Plasma file dialog). Breeze's default animation duration is 100 ms. 3. Many people complained and this feature is currently not configurable. We should introduce a QStyle::SH_Widget_Animation_Duration hint that would allow us to not hardcode durations in Dolphin (i.e. respect whatever duration the users set in their QStyle). Proposal in https://codereview.qt-project.org/#/c/195712/ Reviewers: #vdg, #plasma, emmanuelp, davidedmundson Reviewed By: #plasma, davidedmundson Differential Revision: https://phabricator.kde.org/D5883
2017-05-27Introduce DolphinMainWindowTestElvis Angelaccio
For now it contains a test case for the crash in bug #379135 CCBUG: 379135 Reviewers: emmanuelp, dfaure Differential Revision: https://phabricator.kde.org/D5936
2017-05-27Move non-exported code to a static libraryElvis Angelaccio
This allows us to speed up the compilation because we don't need to build twice the source files we use in the unit tests. Test Plan: Builds, dolphin works and tests pass. Reviewers: emmanuelp, dfaure Differential Revision: https://phabricator.kde.org/D5935
2017-05-25SVN_SILENT made messages (.desktop file) - always resolve oursl10n daemon script
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-05-22Merge branch 'Applications/17.04'Luca Beltrame
2017-05-22Correct searchbox, split view transitions between tabsAnthony Fieroni
Differential Revision: https://phabricator.kde.org/D5864 BUG: 379135 BUG: 380032 FIXED-IN: 17.04.2 Signed-off-by: Anthony Fieroni <[email protected]>
2017-05-12add few more Q_DECL_OVERRIDEPino Toscano
2017-05-11Port tests from ecm_mark_as_test to ecm_add_testHannah von Reth
Summary: This enables us to run the tests on Windows. Reviewers: elvisangelaccio, kfunk, dfaure Reviewed By: elvisangelaccio Subscribers: #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D5810
2017-05-11Fix kfileitemmodeltestElvis Angelaccio
Commit 6dcbb8127c introduced the isHidden role, update the test accordingly.
2017-05-11Remove define to disable exportsHannah von Reth
As the tests are now correctly linked to dolphinprivate we need the actual export macro.
2017-05-08Merge branch 'Applications/17.04'Elvis Angelaccio
2017-05-08Don't ignore tag clicks in the tooltipsElvis Angelaccio
Summary: Now that we can use the metadata widgets in the tooltips, we can also open the tags:// url if the user clicks some tag in a tooltip. The behavior is now consistent with the metadata widget in the information panel. Test Plan: Click a tag when the metadata tooltip shows up. Reviewers: emmanuelp Subscribers: #konqueror, #dolphin Differential Revision: https://phabricator.kde.org/D5658
2017-04-29Sort the tag-values alphabetically in the "Tags" columnAthanasios Kanellopoulos
Up until now tag-values have appeared unsorted in the Tags column when the selected View Mode is "Details". In older versions of Dolphin (in KDE4) the tags-values were alphabetically sorted in the Tags column, which means that back then this was the desired behavior. This commit restores this functionality. BUG: 377589 FIXED-IN: 17.04.1 REVIEW: 130068
2017-04-07Fix some compiler warningsKevin Funk
2017-03-29Update name of the delete action in the .rc filesElvis Angelaccio
Summary: Small regression in commit 68bb0ec22a. We need to use the new (standard) name for the delete action, otherwise it won't be properly enabled/disabled. BUG: 378154 FIXED-IN: 17.03.90 Reviewers: emmanuelp Differential Revision: https://phabricator.kde.org/D5248
2017-03-28behavior change -> New Window opens with same URLDon Nguyen
This patch will cause a "New Window" command to open a new window with the URL from the active view. Opening a new instance via launcher will still open a new window with the URL specified in Startup settings. This is the behavior in Windows 10 file explorer. The advantage is this gives the user a way to open a new window with the current URL(New Window) as well as a new window with URL specified in Startup settings(new instance) whereas currently, there isn't an easy way to open a new window with the current URL. You'd have to either open a new window and copy and paste the URL, or open a new tab(which opens with the same URL) and detach it. I'd much rather have the new window open with the current URL and if what I wanted was the Startup URL I could easily get there as it's already bookmarked. REVIEW: 129973
generated by cgit v1.3 (git 2.53.0) at 2026-04-24 17:29:28 +0000